104164 2012-12-05 13:24:51 -0800 [Qt][Mac] Fix libxslt and libxml2 config tests 2012-12-06 06:03:28 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abecsi abecsi hausmann vestbo oldest_to_newest 784059 0 abecsi 2012-12-05 13:24:51 -0800 [Qt][Mac] Fix libxslt and libxml2 config tests 784064 1 177820 abecsi 2012-12-05 13:27:40 -0800 Created attachment 177820 Patch 784873 2 177820 hausmann 2012-12-06 05:27:28 -0800 Comment on attachment 177820 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177820&action=review r=me with a small change before landing :) > Tools/qmake/config.tests/libxslt/libxslt.pro:3 > +LIBS += -lxslt I think the LIBS line should go into the mac scope, no? At least if we're using pkg-config we should not be doing LIBS += but solely rely on what pkg-config gives us. Same in libxml2.pro 784890 3 abecsi 2012-12-06 06:03:28 -0800 Committed r136837: <http://trac.webkit.org/changeset/136837> 177820 2012-12-05 13:27:40 -0800 2012-12-06 05:27:27 -0800 Patch bug-104164-20121205222504.patch text/plain 3680 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGQ2OWQ2ODIzNjk0OWZi N2EwY2QxYzlmOGFmYjVhNTg2Yjg5MTNlOS4uNDJhODBhY2NmYTU4YmY3NzQ5ZTk2MDQ0ZTlmNzMx MzhkOGMzZDJlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEyLTEyLTA1ICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAZGlnaWEuY29tPgorCisgICAgICAgIFtRdF1bTWFjXSBG aXggbGlieHNsdCBhbmQgbGlieG1sMiBjb25maWcgdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDE2NAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNpbmNlIGxpYnhtbDIgaXMgYSBkZXBlbmRlbmN5 IGZvciBsaWJ4c2x0IGFuZCBpcyBub3QgdXNlZAorICAgICAgICBzdGFuZGFsb25lIHRoZSBjb25m aWd1cmF0aW9ucyBmb3IgaXQgc2hvdWxkIGFsc28gZGVwZW5kIG9uCisgICAgICAgIHdoZXRoZXIg WFNMVCBpcyBlbmFibGVkLgorICAgICAgICBBbHNvIGF2b2lkIHVzaW5nIHBrZy1jb25maWcgb24g TWFjLCBpbnN0ZWFkIHVzZSBkaXJlY3QKKyAgICAgICAgaW5jbHVkZSBwYXRocyBhbmQgYWRkIG5l ZWRlZCBsaWJyYXJpZXMgdG8gdGhlIGxpbmtlci4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVl ZGVkLgorCisgICAgICAgICogV2ViQ29yZS5wcmk6CisKIDIwMTItMTItMDUgIE1hcmsgUGlsZ3Jp bSAgPHBpbGdyaW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV1bV2luXSBSZW1v dmUgdGhlbWUtcmVsYXRlZCBmdW5jdGlvbnMgZnJvbSBQbGF0Zm9ybVN1cHBvcnQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL1dlYkNvcmUucHJpIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5w cmkKaW5kZXggNjdlMTJjMDY2ZTJmM2Y3ZWFmYjY0NTUyYzM1NzYyMDAxZGY2MDlhOC4uOTRmNmU2 NWVmMjAzZDAzZmNhNzNjMjIxNDkxZmFhMDkyNmE2YmNjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvV2ViQ29yZS5wcmkKKysrIGIvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5wcmkKQEAgLTEw NywyMCArMTA3LDE2IEBAIElOQ0xVREVQQVRIICs9ICQkV0VCQ09SRV9HRU5FUkFURURfU09VUkNF U19ESVIKIGVuYWJsZT8oWFNMVCkgewogICAgIHVzZT8oTElCWE1MMikgewogICAgICAgICBtYWMg ewotICAgICAgICAgICAgSU5DTFVERVBBVEggKz0gL3Vzci9pbmNsdWRlL2xpYnhtbDIKKyAgICAg ICAgICAgIElOQ0xVREVQQVRIICs9IC91c3IvaW5jbHVkZS9saWJ4c2x0IC91c3IvaW5jbHVkZS9s aWJ4bWwyCiAgICAgICAgICAgICBMSUJTICs9IC1seG1sMiAtbHhzbHQKICAgICAgICAgfSBlbHNl IHsKLSAgICAgICAgICAgIFBLR0NPTkZJRyArPSBsaWJ4c2x0CisgICAgICAgICAgICBQS0dDT05G SUcgKz0gbGlieHNsdCBsaWJ4bWwtMi4wCiAgICAgICAgIH0KICAgICB9IGVsc2UgewogICAgICAg ICBRVCAqPSB4bWxwYXR0ZXJucwogICAgIH0KIH0KIAotdXNlPyhMSUJYTUwyKSB7Ci0gICAgUEtH Q09ORklHICs9IGxpYnhtbC0yLjAKLX0KLQogdXNlPyhaTElCKSB7CiAgICAgTElCUyArPSAtbHoK IH0KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBi OGEyMjcxY2E1ZjA3NjMwZmExN2M4NzRmZGQ2NGYyZjZmYjY5YmZjLi45NjgzMGQ4NDE1M2U1NzVi YjdhODUwYjUwYTk0MWU3MTc1NWY2ZjY5IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysr IGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTItMTItMDUgIEFuZHJhcyBC ZWNzaSAgPGFuZHJhcy5iZWNzaUBkaWdpYS5jb20+CisKKyAgICAgICAgW1F0XVtNYWNdIEZpeCBs aWJ4c2x0IGFuZCBsaWJ4bWwyIGNvbmZpZyB0ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgV2Ugc2hvdWxkIG5vdCB1c2UgcGtnLWNvbmZpZyBvbiBN YWMgaW5zdGVhZCB1c2UgZGlyZWN0IGluY2x1ZGUKKyAgICAgICAgcGF0aHMgYW5kIGFkZCBuZWVk ZWQgbGlicmFyaWVzIHRvIHRoZSBsaW5rZXIgb3B0aW9ucyB0byBkZXRlY3QKKyAgICAgICAgbGli eHNsdCBhbmQgbGlieG1sMiBwcm92aWRlZCBieSB0aGUgc3lzdGVtLgorICAgICAgICBQcmV2aW91 c2x5IHdlIHdvdWxkIGFsd2F5cyBmYWxsIGJhY2sgdG8gcXR4bWxwYXR0ZXJucy4KKworICAgICAg ICAqIHFtYWtlL2NvbmZpZy50ZXN0cy9saWJ4bWwyL2xpYnhtbDIucHJvOgorICAgICAgICAqIHFt YWtlL2NvbmZpZy50ZXN0cy9saWJ4c2x0L2xpYnhzbHQucHJvOgorCiAyMDEyLTEyLTA1ICBEaXJr IFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIG5yd3Q6IHNpbXBsaWZ5 IHRoZSBmaW5kaW5nIG9mIHRlc3RzIHRvIHJldHJ5CmRpZmYgLS1naXQgYS9Ub29scy9xbWFrZS9j b25maWcudGVzdHMvbGlieG1sMi9saWJ4bWwyLnBybyBiL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0 cy9saWJ4bWwyL2xpYnhtbDIucHJvCmluZGV4IGQ1YWRkOGYxNzQ1NDAwMGM3NDA3NjA0MzQxZjZk MTgzNDViZWQ0NWEuLjkyNWEwOWZmOTNjZDVmYmJhNzA1OGM4MDYxYTFkYTBkODQwMmM0ZTIgMTAw NjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9saWJ4bWwyL2xpYnhtbDIucHJvCisr KyBiL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9saWJ4bWwyL2xpYnhtbDIucHJvCkBAIC0xLDQg KzEsOCBAQAogQ09ORklHIC09IHF0CiBTT1VSQ0VTID0gbGlieG1sMi5jcHAKLUNPTkZJRyArPSBs aW5rX3BrZ2NvbmZpZwotUEtHQ09ORklHICs9IGxpYnhtbC0yLjAKK0xJQlMgKz0gLWx4bWwyCitt YWM6SU5DTFVERVBBVEggKz0gL3Vzci9pbmNsdWRlL2xpYnhtbDIKK2Vsc2UgeworICAgIFBLR0NP TkZJRyArPSBsaWJ4bWwtMi4wCisgICAgQ09ORklHICs9IGxpbmtfcGtnY29uZmlnCit9CmRpZmYg LS1naXQgYS9Ub29scy9xbWFrZS9jb25maWcudGVzdHMvbGlieHNsdC9saWJ4c2x0LnBybyBiL1Rv b2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9saWJ4c2x0L2xpYnhzbHQucHJvCmluZGV4IDYzNTlkZTNj NjRhOTc2YjJjYjc5MjI1NzE1YjI0MWY4YmVjN2Q5OGMuLmFiZDA5ZGI3NWFjZTMzZTU0ZDNkNzY0 NGVmNzNkZjFkNTg2OGEyZjEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9s aWJ4c2x0L2xpYnhzbHQucHJvCisrKyBiL1Rvb2xzL3FtYWtlL2NvbmZpZy50ZXN0cy9saWJ4c2x0 L2xpYnhzbHQucHJvCkBAIC0xLDQgKzEsOCBAQAogQ09ORklHIC09IHF0CiBTT1VSQ0VTID0gbGli eHNsdC5jcHAKLUNPTkZJRyArPSBsaW5rX3BrZ2NvbmZpZwotUEtHQ09ORklHICs9IGxpYnhzbHQK K0xJQlMgKz0gLWx4c2x0CittYWM6IElOQ0xVREVQQVRIICs9IC91c3IvaW5jbHVkZS9saWJ4c2x0 IC91c3IvaW5jbHVkZS9saWJ4bWwyCitlbHNlIHsKKyAgICBQS0dDT05GSUcgKz0gbGlieHNsdAor ICAgIENPTkZJRyArPSBsaW5rX3BrZ2NvbmZpZworfQo=