104162 2012-12-05 13:23:57 -0800 [BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order 2012-12-05 14:47:54 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 784056 0 otcheung 2012-12-05 13:23:57 -0800 We need to notify all geolisteners when a onPermission comes in, so it doesn't matter which infobar the user responds to, given multiple permission requests from the same origin. 784065 1 177821 otcheung 2012-12-05 13:29:25 -0800 Created attachment 177821 Patch 784090 2 177821 yong.li.webkit 2012-12-05 13:59:24 -0800 Comment on attachment 177821 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177821&action=review > Source/WebKit/blackberry/WebCoreSupport/GeolocationClientBlackBerry.cpp:165 > + if (m_geolocationRequestMap.isEmpty()) > + BlackBerry::Platform::GeolocationHandler::instance()->unregisterFromPermissionTracking(this); let's also do this in the dtor. 784098 3 177826 otcheung 2012-12-05 14:06:47 -0800 Created attachment 177826 Patch 784136 4 177826 webkit.review.bot 2012-12-05 14:47:50 -0800 Comment on attachment 177826 Patch Clearing flags on attachment: 177826 Committed r136764: <http://trac.webkit.org/changeset/136764> 784137 5 webkit.review.bot 2012-12-05 14:47:54 -0800 All reviewed patches have been landed. Closing bug. 177821 2012-12-05 13:29:25 -0800 2012-12-05 14:06:44 -0800 Patch bug-104162-20121205162650.patch text/plain 3137 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5YWQ2MGFjMmI0Y2I2N2ZlZTMxYzZlZWM4OGI4OWUyNTc1OTdmNDBkLi43MjcxMTIwMzE3 MjViMzQzZTUwNTQ5MjY1ZjkyYjQzMjIzNGQ4MTA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0xMi0wNSAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBHZW9sb2NhdGlvbiBwcm9t cHRzIHdvbid0IHJlc3BvbmQgdG8gdGhlIGNvcnJlY3QgZ2VvbG9jYXRpb24gb2JqZWN0IGlmIHRo ZSB1c2VyIG9wZW5zIHR3byBwYWdlcyBhbmQgcmVzcG9uZCBpbiB0aGUgcmV2ZXJzZWQgb3JkZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDE2Mgor CisgICAgICAgIFBSIDI1NzUwNQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkgd2lsbCByZWdpc3RlciBpdHNl bGYgdG8gR2VvbG9jYXRpb25IYW5kbGVyIHdoZW4gaXQgaGFzCisgICAgICAgIGEgcGVuZGluZyBy ZXF1ZXN0LiBXaGVuIGJyb3dzZXIgcmVzcG9uZHMgd2l0aCBXZWJQYWdlQ2xpZW50SW1wbDo6c2V0 QWxsb3dHZW9sb2NhdGlvbiwKKyAgICAgICAgd2UgZ28gdGhyb3VnaCB0aGUgbGlzdCBhbmQgbGV0 IGFsbCB0aGUgcGVuZGluZyBHZW9sb2NhdGlvbkxpc3RlbmVycyBrbm93IHRoYXQgYSBjZXJ0YWlu IAorICAgICAgICBvcmlnaW4gaGFzIGJlZW4gYWNlZXB0ZWQvZGVuaWVkLgorCisgICAgICAgICog V2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5LmNwcDoKKyAgICAgICAg KEdlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeTo6cmVxdWVzdFBlcm1pc3Npb24pOgorICAgICAg ICAoR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5OjpjYW5jZWxQZXJtaXNzaW9uUmVxdWVzdCk6 CisgICAgICAgIChHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnk6Om9uUGVybWlzc2lvbik6CisK IDIwMTItMTItMDUgIExlbyBZYW5nICA8bGVveWFuZ0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFj a0JlcnJ5XSBFbmFibGUgQ1NTX0lNQUdFX1JFU09MVVRJT04KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVy cnkuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0 aW9uQ2xpZW50QmxhY2tCZXJyeS5jcHAKaW5kZXggYjZhNGJjMzY4ZGUxNWJmMGM2M2VhMGM5NWRl MDk1NmE5YzhkMDdkNy4uZWM4YzFlM2Q2NTM2MjZkMzAxNTY4ZDY1ZDA5YjU2NGUwNGFmYTE3ZCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xv Y2F0aW9uQ2xpZW50QmxhY2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTg3LDYg Kzg3LDEwIEBAIHZvaWQgR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5OjpyZXF1ZXN0UGVybWlz c2lvbihHZW9sb2NhdGlvbiogbG9jYXRpb24pCiAgICAgICAgIHJldHVybjsKICAgICB9CiAKKyAg ICAvLyBSZWdpc3RlciB0aGUgbGlzdGVuZXIgd2l0aCB0aGUgR2VvbG9jYXRpb25IYW5kbGVyIHRv IHJlY2VpdmUgcGVybWlzc2lvbnMuCisgICAgaWYgKG1fZ2VvbG9jYXRpb25SZXF1ZXN0TWFwLmlz RW1wdHkoKSkKKyAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06Okdlb2xvY2F0aW9uSGFuZGxl cjo6aW5zdGFuY2UoKS0+cmVnaXN0ZXJQZXJtaXNzaW9uVHJhY2tpbmcodGhpcyk7CisKICAgICAv LyBBZGQgdGhpcyBnZW9sb2NhdGlvbiBwZXJtaXNzaW9uIHJlcXVlc3QgdG8gb3VyIHJlcXVlc3Qg bWFwLgogICAgIFZlY3RvcjxSZWZQdHI8R2VvbG9jYXRpb24+ID4gZ2VvUmVxdWVzdHNGb3JPcmln aW47CiAgICAgSGFzaE1hcDxTdHJpbmcsIFZlY3RvcjxSZWZQdHI8R2VvbG9jYXRpb24+ID4gPjo6 QWRkUmVzdWx0IHJlc3VsdCA9IG1fZ2VvbG9jYXRpb25SZXF1ZXN0TWFwLmFkZChvcmlnaW4sIGdl b1JlcXVlc3RzRm9yT3JpZ2luKTsKQEAgLTEyNSw2ICsxMjksOSBAQCB2b2lkIEdlb2xvY2F0aW9u Q2xpZW50QmxhY2tCZXJyeTo6Y2FuY2VsUGVybWlzc2lvblJlcXVlc3QoR2VvbG9jYXRpb24qIGxv Y2F0aW9uKQogICAgICAgICB9CiAgICAgfQogCisgICAgaWYgKG1fZ2VvbG9jYXRpb25SZXF1ZXN0 TWFwLmlzRW1wdHkoKSkKKyAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06Okdlb2xvY2F0aW9u SGFuZGxlcjo6aW5zdGFuY2UoKS0+dW5yZWdpc3RlckZyb21QZXJtaXNzaW9uVHJhY2tpbmcodGhp cyk7CisKICAgICBtX3dlYlBhZ2VQcml2YXRlLT5tX2NsaWVudC0+Y2FuY2VsR2VvbG9jYXRpb25Q ZXJtaXNzaW9uKCk7CiB9CiAKQEAgLTE1Myw2ICsxNjAsOSBAQCB2b2lkIEdlb2xvY2F0aW9uQ2xp ZW50QmxhY2tCZXJyeTo6b25QZXJtaXNzaW9uKGNvbnN0IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpT dHJpbgogICAgIGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbnVtYmVyT2ZHZW9sb2NhdGlvbnM7ICsr aSkKICAgICAgICAgcGVuZGluZ1Blcm1pc3Npb25HZW9sb2NhdGlvbltpXS0+c2V0SXNBbGxvd2Vk KGlzQWxsb3dlZCk7CiAgICAgbV9nZW9sb2NhdGlvblJlcXVlc3RNYXAucmVtb3ZlKG9yaWdpbik7 CisKKyAgICBpZiAobV9nZW9sb2NhdGlvblJlcXVlc3RNYXAuaXNFbXB0eSgpKQorICAgICAgICBC bGFja0JlcnJ5OjpQbGF0Zm9ybTo6R2VvbG9jYXRpb25IYW5kbGVyOjppbnN0YW5jZSgpLT51bnJl Z2lzdGVyRnJvbVBlcm1pc3Npb25UcmFja2luZyh0aGlzKTsKIH0KIAogdm9pZCBHZW9sb2NhdGlv bkNsaWVudEJsYWNrQmVycnk6OnNldEVuYWJsZUhpZ2hBY2N1cmFjeShib29sIG5ld0FjY3VyYWN5 KQo= 177826 2012-12-05 14:06:47 -0800 2012-12-05 14:47:50 -0800 Patch bug-104162-20121205170412.patch text/plain 3484 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA5YWQ2MGFjMmI0Y2I2N2ZlZTMxYzZlZWM4OGI4OWUyNTc1OTdmNDBkLi5iM2I2YWUxYjIx NzkwYjI1YzMwN2UzMmE1YjVmZDYzZTI2YjZlZTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0xMi0wNSAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBHZW9sb2NhdGlvbiBwcm9t cHRzIHdvbid0IHJlc3BvbmQgdG8gdGhlIGNvcnJlY3QgZ2VvbG9jYXRpb24gb2JqZWN0IGlmIHRo ZSB1c2VyIG9wZW5zIHR3byBwYWdlcyBhbmQgcmVzcG9uZCBpbiB0aGUgcmV2ZXJzZWQgb3JkZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDE2Mgor CisgICAgICAgIFBSIDI1NzUwNQorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkgd2lsbCByZWdpc3RlciBpdHNl bGYgdG8gR2VvbG9jYXRpb25IYW5kbGVyIHdoZW4gaXQgaGFzCisgICAgICAgIGEgcGVuZGluZyBy ZXF1ZXN0LiBXaGVuIGJyb3dzZXIgcmVzcG9uZHMgd2l0aCBXZWJQYWdlQ2xpZW50SW1wbDo6c2V0 QWxsb3dHZW9sb2NhdGlvbiwKKyAgICAgICAgd2UgZ28gdGhyb3VnaCB0aGUgbGlzdCBhbmQgbGV0 IGFsbCB0aGUgcGVuZGluZyBHZW9sb2NhdGlvbkxpc3RlbmVycyBrbm93IHRoYXQgYSBjZXJ0YWlu CisgICAgICAgIG9yaWdpbiBoYXMgYmVlbiBhY2VlcHRlZC9kZW5pZWQuCisKKyAgICAgICAgKiBX ZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkuY3BwOgorICAgICAgICAo R2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5OjpnZW9sb2NhdGlvbkRlc3Ryb3llZCk6CisgICAg ICAgIChHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnk6OnJlcXVlc3RQZXJtaXNzaW9uKToKKyAg ICAgICAgKEdlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeTo6Y2FuY2VsUGVybWlzc2lvblJlcXVl c3QpOgorICAgICAgICAoR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5OjpvblBlcm1pc3Npb24p OgorCiAyMDEyLTEyLTA1ICBMZW8gWWFuZyAgPGxlb3lhbmdAcmltLmNvbT4KIAogICAgICAgICBb QmxhY2tCZXJyeV0gRW5hYmxlIENTU19JTUFHRV9SRVNPTFVUSU9OCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvR2VvbG9jYXRpb25DbGllbnRCbGFj a0JlcnJ5LmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9s b2NhdGlvbkNsaWVudEJsYWNrQmVycnkuY3BwCmluZGV4IGI2YTRiYzM2OGRlMTViZjBjNjNlYTBj OTVkZTA5NTZhOWM4ZDA3ZDcuLjQ5OWFlNGM5NTM0YjUyNjFiNDY0OWZjMDUwYzFkZDY4NWY2N2U1 ZDQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJDb3JlU3VwcG9ydC9H ZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkuY3BwCkBAIC0z OSw2ICszOSw4IEBAIEdlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeTo6R2VvbG9jYXRpb25DbGll bnRCbGFja0JlcnJ5KEJsYWNrQmVycnk6OldlYktpdDo6V2ViCiAKIHZvaWQgR2VvbG9jYXRpb25D bGllbnRCbGFja0JlcnJ5OjpnZW9sb2NhdGlvbkRlc3Ryb3llZCgpCiB7CisgICAgQmxhY2tCZXJy eTo6UGxhdGZvcm06Okdlb2xvY2F0aW9uSGFuZGxlcjo6aW5zdGFuY2UoKS0+dW5yZWdpc3RlckZy b21QZXJtaXNzaW9uVHJhY2tpbmcodGhpcyk7CisKICAgICBkZWxldGUgdGhpczsKIH0KIApAQCAt ODcsNiArODksMTAgQEAgdm9pZCBHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnk6OnJlcXVlc3RQ ZXJtaXNzaW9uKEdlb2xvY2F0aW9uKiBsb2NhdGlvbikKICAgICAgICAgcmV0dXJuOwogICAgIH0K IAorICAgIC8vIFJlZ2lzdGVyIHRoZSBsaXN0ZW5lciB3aXRoIHRoZSBHZW9sb2NhdGlvbkhhbmRs ZXIgdG8gcmVjZWl2ZSBwZXJtaXNzaW9ucy4KKyAgICBpZiAobV9nZW9sb2NhdGlvblJlcXVlc3RN YXAuaXNFbXB0eSgpKQorICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R2VvbG9jYXRpb25I YW5kbGVyOjppbnN0YW5jZSgpLT5yZWdpc3RlclBlcm1pc3Npb25UcmFja2luZyh0aGlzKTsKKwog ICAgIC8vIEFkZCB0aGlzIGdlb2xvY2F0aW9uIHBlcm1pc3Npb24gcmVxdWVzdCB0byBvdXIgcmVx dWVzdCBtYXAuCiAgICAgVmVjdG9yPFJlZlB0cjxHZW9sb2NhdGlvbj4gPiBnZW9SZXF1ZXN0c0Zv ck9yaWdpbjsKICAgICBIYXNoTWFwPFN0cmluZywgVmVjdG9yPFJlZlB0cjxHZW9sb2NhdGlvbj4g PiA+OjpBZGRSZXN1bHQgcmVzdWx0ID0gbV9nZW9sb2NhdGlvblJlcXVlc3RNYXAuYWRkKG9yaWdp biwgZ2VvUmVxdWVzdHNGb3JPcmlnaW4pOwpAQCAtMTI1LDYgKzEzMSw5IEBAIHZvaWQgR2VvbG9j YXRpb25DbGllbnRCbGFja0JlcnJ5OjpjYW5jZWxQZXJtaXNzaW9uUmVxdWVzdChHZW9sb2NhdGlv biogbG9jYXRpb24pCiAgICAgICAgIH0KICAgICB9CiAKKyAgICBpZiAobV9nZW9sb2NhdGlvblJl cXVlc3RNYXAuaXNFbXB0eSgpKQorICAgICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9ybTo6R2VvbG9j YXRpb25IYW5kbGVyOjppbnN0YW5jZSgpLT51bnJlZ2lzdGVyRnJvbVBlcm1pc3Npb25UcmFja2lu Zyh0aGlzKTsKKwogICAgIG1fd2ViUGFnZVByaXZhdGUtPm1fY2xpZW50LT5jYW5jZWxHZW9sb2Nh dGlvblBlcm1pc3Npb24oKTsKIH0KIApAQCAtMTUzLDYgKzE2Miw5IEBAIHZvaWQgR2VvbG9jYXRp b25DbGllbnRCbGFja0JlcnJ5OjpvblBlcm1pc3Npb24oY29uc3QgQmxhY2tCZXJyeTo6UGxhdGZv cm06OlN0cmluCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBudW1iZXJPZkdlb2xvY2F0aW9u czsgKytpKQogICAgICAgICBwZW5kaW5nUGVybWlzc2lvbkdlb2xvY2F0aW9uW2ldLT5zZXRJc0Fs bG93ZWQoaXNBbGxvd2VkKTsKICAgICBtX2dlb2xvY2F0aW9uUmVxdWVzdE1hcC5yZW1vdmUob3Jp Z2luKTsKKworICAgIGlmIChtX2dlb2xvY2F0aW9uUmVxdWVzdE1hcC5pc0VtcHR5KCkpCisgICAg ICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHZW9sb2NhdGlvbkhhbmRsZXI6Omluc3RhbmNlKCkt PnVucmVnaXN0ZXJGcm9tUGVybWlzc2lvblRyYWNraW5nKHRoaXMpOwogfQogCiB2b2lkIEdlb2xv Y2F0aW9uQ2xpZW50QmxhY2tCZXJyeTo6c2V0RW5hYmxlSGlnaEFjY3VyYWN5KGJvb2wgbmV3QWNj dXJhY3kpCg==