104160 2012-12-05 13:19:56 -0800 [EFL][Qt][CSS Regions] fast/regions/autowidth-normalflow-maxwidth.html is failing 2013-01-07 23:29:11 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 57312 1 yael webkit-unassigned mihnea WebkitBugTracker webkit.review.bot oldest_to_newest 784052 0 yael 2012-12-05 13:19:56 -0800 The test fast/regions/autowidth-normalflow-maxwidth.html is failing both for EFL and Qt. The test and the expected results don't look the same even when loaded in MiniBrowser. It seems that the test has an expectation that the text of the test can fit in 400 pixels, but both for Qt and for EFL MiniBrowsers, the text requires more than that. An easy fix would be to increase the height of the the region to 450 or 500 pixels. 784124 1 177832 yael 2012-12-05 14:32:48 -0800 Created attachment 177832 Patch 784884 2 177832 webkit.review.bot 2012-12-06 05:55:28 -0800 Comment on attachment 177832 Patch Clearing flags on attachment: 177832 Committed r136835: <http://trac.webkit.org/changeset/136835> 784885 3 webkit.review.bot 2012-12-06 05:55:31 -0800 All reviewed patches have been landed. Closing bug. 798642 4 mihnea 2013-01-02 06:35:47 -0800 Hi Yael, The purpose of the test was to check that max-width is honored in the case of a region with width: auto. The text, both in original and expected, is not supposed to fit in 400px, but rather to overflow the region and the div containing the test in expected file. In both cases, it should have shown about 10 lines of gray text (last one shorter) because neither the region nor the div containing the text have overflow:hidden. Because of that, changing the height to 450 seems like a wrong way to fix this test. I have build QT on Linux with latest and also revision 136322 from Dec 2 and i have changed the height to 400, without noticing any diff. Would you mind telling me what revision on QT have you used to notice the difference? Cheers, Mihnea 799112 5 yael 2013-01-02 17:14:18 -0800 (In reply to comment #4) > Hi Yael, > > The purpose of the test was to check that max-width is honored in the case of a region with width: auto. The text, both in original and expected, is not supposed to fit in 400px, but rather to overflow the region and the div containing the test in expected file. In both cases, it should have shown about 10 lines of gray text (last one shorter) because neither the region nor the div containing the text have overflow:hidden. > > Because of that, changing the height to 450 seems like a wrong way to fix this test. I have build QT on Linux with latest and also revision 136322 from Dec 2 and i have changed the height to 400, without noticing any diff. Would you mind telling me what revision on QT have you used to notice the difference? > > Cheers, > Mihnea Hi Mihnea, Sorry for misunderstanding the test and also for cc'ing the wrong person on this bug. If you think that the original version is the correct version of the test, please feel free to roll out. I just tested with r137836 on Qt's MiniBrowser and if I change the 450 back to 400, in fast/regions/autowidth-normalflow-maxwidth.html, the test is failing. With 450 it does not fail. 802075 6 mihnea 2013-01-07 23:29:11 -0800 (In reply to comment #5) > (In reply to comment #4) > > Hi Yael, > > > > The purpose of the test was to check that max-width is honored in the case of a region with width: auto. The text, both in original and expected, is not supposed to fit in 400px, but rather to overflow the region and the div containing the test in expected file. In both cases, it should have shown about 10 lines of gray text (last one shorter) because neither the region nor the div containing the text have overflow:hidden. > > > > Because of that, changing the height to 450 seems like a wrong way to fix this test. I have build QT on Linux with latest and also revision 136322 from Dec 2 and i have changed the height to 400, without noticing any diff. Would you mind telling me what revision on QT have you used to notice the difference? > > > > Cheers, > > Mihnea > > > Hi Mihnea, Sorry for misunderstanding the test and also for cc'ing the wrong person on this bug. If you think that the original version is the correct version of the test, please feel free to roll out. > > I just tested with r137836 on Qt's MiniBrowser and if I change the 450 back to 400, in fast/regions/autowidth-normalflow-maxwidth.html, the test is failing. With 450 it does not fail. Ok, now i see the failure and i need to investigate it. I was not testing with WK2. 177832 2012-12-05 14:32:48 -0800 2012-12-06 05:55:28 -0800 Patch 104160.patch text/plain 4363 yael SW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucwo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMJ KHJldmlzaW9uIDEzNjYwOCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4 cGVjdGF0aW9ucwkod29ya2luZyBjb3B5KQpAQCAtNTYwLDcgKzU2MCw2IEBACiB3ZWJraXQub3Jn L2IvMTAzNDY4IGZhc3QvZG9tL3NoYWRvdy9zaGFkb3ctcmVwcm9qZWN0aW9uLWR5bmFtaWMuaHRt bCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTAzNDY4IGZhc3QvZG9t L3NoYWRvdy9zaGFkb3dkb20tZm9yLWltYWdlLWR5bmFtaWMuaHRtbCBbIEltYWdlT25seUZhaWx1 cmUgUGFzcyBdCiB3ZWJraXQub3JnL2IvMTAzNDY4IGZhc3QvZm9ybXMvY2hlY2tib3gtYXBwZWFy YW5jZS1jaGFuZ2UtYnktY2hlY2tlZC5odG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBQYXNzIF0KLXdl YmtpdC5vcmcvYi8xMDM0NjggZmFzdC9yZWdpb25zL2F1dG93aWR0aC1ub3JtYWxmbG93LW1heHdp ZHRoLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEwMzQ2OCBm YXN0L3JlcGFpbnQvcGVyY2VudC1taW5oZWlnaHQtcmVzaXplLmh0bWwgWyBJbWFnZU9ubHlGYWls dXJlIFBhc3MgXQogd2Via2l0Lm9yZy9iLzEwMzQ2OCBmYXN0L3JlcGxhY2VkL3JlcGxhY2VkLWxh c3QtbGluZS1sYXlvdXQuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCiB3ZWJraXQub3Jn L2IvMTAzNDY4IHN2Zy9hbmltYXRpb25zL21wYXRoLXJlbW92ZS1mcm9tLWRlcGVuZGVudHMtb24t ZGVsZXRlLWNyYXNoLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIFBhc3MgXQpJbmRleDogTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL3BsYXRmb3JtL3F0LTUuMC13azIvVGVzdEV4cGVjdGF0aW9ucwkocmV2aXNp b24gMTM2NzYyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQtNS4wLXdrMi9UZXN0RXhwZWN0 YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC02ODQsNyArNjg0LDYgQEAKIHdlYmtpdC5vcmcvYi85 OTMwNiBmYXN0L211bHRpY29sL3BhZ2luYXRpb24tdi12ZXJ0aWNhbC1sci5odG1sIFsgSW1hZ2VP bmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvOTkzMDYgZmFzdC9tdWx0aWNvbC9wYWdpbmF0aW9u LXYtdmVydGljYWwtcmwuaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk5 MzA2IGZhc3QvbXVsdGljb2wvc2Nyb2xsaW5nLW92ZXJmbG93Lmh0bWwgWyBJbWFnZU9ubHlGYWls dXJlIF0KLXdlYmtpdC5vcmcvYi85OTMwNiBmYXN0L3JlZ2lvbnMvYXV0b3dpZHRoLW5vcm1hbGZs b3ctbWF4d2lkdGguaHRtbCBbIEltYWdlT25seUZhaWx1cmUgXQogd2Via2l0Lm9yZy9iLzk5MzA2 IGZhc3QvcmVwYWludC9maXhlZC1jaGlsZC1tb3ZlLWFmdGVyLXNjcm9sbC5odG1sIFsgSW1hZ2VP bmx5RmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvOTkzMDYgZmFzdC9yZXBhaW50L2ZpeGVkLWNoaWxk LW9mLXRyYW5zZm9ybWVkLW1vdmUtYWZ0ZXItc2Nyb2xsLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJl IF0KIHdlYmtpdC5vcmcvYi85OTMwNiBmYXN0L3JlcGFpbnQvZml4ZWQtaW4tcGFnZS1zY2FsZS5o dG1sIFsgSW1hZ2VPbmx5RmFpbHVyZSBdCkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzY3NjIpCisrKyBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMCBAQAorMjAx Mi0xMi0wNSAgWWFlbCBBaGFyb24gIDx5YWVsLmFoYXJvbkBpbnRlbC5jb20+CisKKyAgICAgICAg W0VGTF1bUXRdIGZhc3QvcmVnaW9ucy9hdXRvd2lkdGgtbm9ybWFsZmxvdy1tYXh3aWR0aC5odG1s IGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNDE2MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFRoZSB0ZXN0IGZhc3QvcmVnaW9ucy9hdXRvd2lkdGgtbm9ybWFsZmxvdy1tYXh3aWR0aC5o dG1sIGlzIGZhaWxpbmcgZm9yIEVGTCBhbmQgUXQKKyAgICAgICAgYmVjYXVzZSB0aGUgdGVzdCBl eHBlY3RzIHRoYXQgdGhlIHRleHQgb2YgdGhlIHRlc3Qgd291bGQgZml0IGluIDQwMCBwaXhlbHMs CisgICAgICAgIGJ1dCBib3RoIGZvciBRdCBhbmQgZm9yIEVGTCwgdGhlIHRleHQgcmVxdWlyZXMg bW9yZSB0aGFuIHRoYXQuCisgICAgICAgIENoYW5nZWQgdGhlIHRlc3QgYW5kIHRoZSBleHBlY3Rh dGlvbiByZWYtdGVzdCB0byBhbGxvdyA0NTAgcGl4ZWxzLgorCisgICAgICAgICogZmFzdC9yZWdp b25zL2F1dG93aWR0aC1ub3JtYWxmbG93LW1heHdpZHRoLWV4cGVjdGVkLmh0bWw6CisgICAgICAg ICogZmFzdC9yZWdpb25zL2F1dG93aWR0aC1ub3JtYWxmbG93LW1heHdpZHRoLmh0bWw6CisgICAg ICAgICogcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRm b3JtL3F0LTUuMC13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxMi0xMi0wNSAgVG9ueSBDaGFu ZyAgPHRvbnlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGFkZCBNYWMgYmFz ZWxpbmVzIGFmdGVyIHIxMzY0MDkgKG1hdGhtbCBzdXAvc3ViIGJveCBjaGFuZ2VzKS4KSW5kZXg6 IExheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRvd2lkdGgtbm9ybWFsZmxvdy1tYXh3aWR0aC1l eHBlY3RlZC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRv d2lkdGgtbm9ybWFsZmxvdy1tYXh3aWR0aC1leHBlY3RlZC5odG1sCShyZXZpc2lvbiAxMzY2MDgp CisrKyBMYXlvdXRUZXN0cy9mYXN0L3JlZ2lvbnMvYXV0b3dpZHRoLW5vcm1hbGZsb3ctbWF4d2lk dGgtZXhwZWN0ZWQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMyw3ICszLDcgQEAKICAgICA8aGVh ZD4KICAgICAgICAgPHN0eWxlPgogICAgICAgICAgICAgYm9keSB7IGZvbnQtZmFtaWx5OiBtb25v c3BhY2U7IH0KLSAgICAgICAgICAgICNncmF5IHsgd2lkdGg6IDIwMHB4OyBoZWlnaHQ6IDQwMHB4 OyBmb250LXNpemU6IDI1cHg7IGxpbmUtaGVpZ2h0OiAyOyB0ZXh0LWFsaWduOiBqdXN0aWZ5OyBj b2xvcjogI2EwYTBhMDsgfQorICAgICAgICAgICAgI2dyYXkgeyB3aWR0aDogMjAwcHg7IGhlaWdo dDogNDUwcHg7IGZvbnQtc2l6ZTogMjVweDsgbGluZS1oZWlnaHQ6IDI7IHRleHQtYWxpZ246IGp1 c3RpZnk7IGNvbG9yOiAjYTBhMGEwOyB9CiAgICAgICAgIDwvc3R5bGU+CiAgICAgPC9oZWFkPgog ICAgIDxib2R5PgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9yZWdpb25zL2F1dG93aWR0aC1ub3Jt YWxmbG93LW1heHdpZHRoLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9yZWdp b25zL2F1dG93aWR0aC1ub3JtYWxmbG93LW1heHdpZHRoLmh0bWwJKHJldmlzaW9uIDEzNjYwOCkK KysrIExheW91dFRlc3RzL2Zhc3QvcmVnaW9ucy9hdXRvd2lkdGgtbm9ybWFsZmxvdy1tYXh3aWR0 aC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC00LDcgKzQsNyBAQAogICAgICAgICA8c3R5bGU+CiAg ICAgICAgICAgICBib2R5IHsgZm9udC1mYW1pbHk6IG1vbm9zcGFjZTsgfQogICAgICAgICAgICAg I2FydGljbGUgeyAtd2Via2l0LWZsb3ctaW50bzogZmxvdzsgZm9udC1zaXplOiAyNXB4OyBsaW5l LWhlaWdodDogMjsgdGV4dC1hbGlnbjoganVzdGlmeTsgY29sb3I6I2EwYTBhMDsgfQotICAgICAg ICAgICAgI3JlZ2lvbiB7IC13ZWJraXQtZmxvdy1mcm9tOiBmbG93OyBoZWlnaHQ6IDQwMHB4OyBt YXgtd2lkdGg6IDIwMHB4OyB9CisgICAgICAgICAgICAjcmVnaW9uIHsgLXdlYmtpdC1mbG93LWZy b206IGZsb3c7IGhlaWdodDogNDUwcHg7IG1heC13aWR0aDogMjAwcHg7IH0KICAgICAgICAgPC9z dHlsZT4KICAgICA8L2hlYWQ+CiAgICAgPGJvZHk+Cg==