104132 2012-12-05 09:15:30 -0800 [BlackBerry] Enable CSS_IMAGE_RESOLUTION 2012-12-05 12:06:27 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104130 1 leoyang webkit-unassigned dbates gyuyoung.kim mifenton rakuco rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 783820 0 leoyang 2012-12-05 09:15:30 -0800 This is for enabling CSS_IMAGE_RESOLUTION for the BlackBerry port. 783822 1 177774 leoyang 2012-12-05 09:18:35 -0800 Created attachment 177774 Patch 783879 2 177774 yong.li.webkit 2012-12-05 10:25:32 -0800 Comment on attachment 177774 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177774&action=review > Tools/Scripts/webkitperl/FeatureList.pm:197 > + define => "ENABLE_CSS_IMAGE_RESOLUTION", default => isBlackBerry(), value => \$cssImageResolutionSupport }, Isn't the change in OptionsBlackBerry.cmake enough? 783924 3 leoyang 2012-12-05 11:16:41 -0800 (In reply to comment #2) > (From update of attachment 177774 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177774&action=review > > > Tools/Scripts/webkitperl/FeatureList.pm:197 > > + define => "ENABLE_CSS_IMAGE_RESOLUTION", default => isBlackBerry(), value => \$cssImageResolutionSupport }, > > Isn't the change in OptionsBlackBerry.cmake enough? No. 783930 4 177774 yong.li.webkit 2012-12-05 11:23:39 -0800 Comment on attachment 177774 Patch hold... 783962 5 177774 webkit.review.bot 2012-12-05 12:06:21 -0800 Comment on attachment 177774 Patch Clearing flags on attachment: 177774 Committed r136727: <http://trac.webkit.org/changeset/136727> 783963 6 webkit.review.bot 2012-12-05 12:06:27 -0800 All reviewed patches have been landed. Closing bug. 177774 2012-12-05 09:18:35 -0800 2012-12-05 12:06:21 -0800 Patch 0001-BlackBerry-Enable-CSS_IMAGE_RESOLUTION.patch text/plain 4548 leoyang RnJvbSBlZDU2MzE1NGRjYWYwZTg0MDFkNjUwNmQ1Y2NiNjY5NjE5ZmZkNTg0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMZW8gWWFuZyA8bGVveWFuZ0ByaW0uY29tPgpEYXRlOiBXZWQs IDUgRGVjIDIwMTIgMTI6MTQ6NTUgLTA1MDAKU3ViamVjdDogW1BBVENIXSBbQmxhY2tCZXJyeV0g RW5hYmxlIENTU19JTUFHRV9SRVNPTFVUSU9OCiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTA0MTMyCgpSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCi46CgoqIFNv dXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZToKClNvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeToKCiogV2ViQ29yZVN1cHBvcnQvQWJvdXREYXRhRW5hYmxlRmVhdHVyZXMuaW46CgpUb29s czoKCiogU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtOgotLS0KIENoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgOSArKysrKysrKysK IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAg OSArKysrKysrKysKIC4uLi9XZWJDb3JlU3VwcG9ydC9BYm91dERhdGFFbmFibGVGZWF0dXJlcy5p biAgICAgIHwgICAgMSArCiBTb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21ha2UgICAg ICAgICAgICAgICB8ICAgIDEgKwogVG9vbHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgfCAgICA5ICsrKysrKysrKwogVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJs L0ZlYXR1cmVMaXN0LnBtICAgICAgICAgICAgfCAgICAyICstCiA2IGZpbGVzIGNoYW5nZWQsIDMw IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIv Q2hhbmdlTG9nCmluZGV4IDE1YTEwZDkuLjAwOWMzYmQgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZwor KysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMi0xMi0wNSAgTGVvIFlhbmcgIDxs ZW95YW5nQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIEVuYWJsZSBDU1NfSU1BR0Vf UkVTT0xVVElPTgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTA0MTMyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnkuY21ha2U6CisKIDIwMTItMTItMDQg IEtvbmRhcGFsbHkgS2FseWFuICA8a2FseWFuLmtvbmRhcGFsbHlAaW50ZWwuY29tPgogCiAgICAg ICAgIFtFRkxdW1dLMl1bQUNdIFVTRV9HUkFQSElDU19TVVJGQUNFIHNob3VsZCBiZSBlbmFibGVk IG9ubHkgaWYgWGNvbXBvc2l0ZSBhbmQgWHJlbmRlciBleHRlbnNpb25zIGFyZSBmb3VuZC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi S2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCmluZGV4IDBmNTY3NDUuLmMwYjljYTUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTEyLTA1ICBMZW8g WWFuZyAgPGxlb3lhbmdAcmltLmNvbT4KKworICAgICAgICBbQmxhY2tCZXJyeV0gRW5hYmxlIENT U19JTUFHRV9SRVNPTFVUSU9OCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDQxMzIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Fib3V0RGF0YUVuYWJsZUZlYXR1cmVzLmluOgor CiAyMDEyLTEyLTA0ICBNaWtlIEZlbnRvbiAgPG1pZmVudG9uQHJpbS5jb20+CiAKICAgICAgICAg W0JsYWNrQmVycnldIFJlbW92ZSBhc3NlcnQgYW5kIGZpeCBjb25kaXRpb25hbCBmb3Igb3V0IG9m IGJvdW5kcyByZXF1ZXN0cyBpbiBJbnB1dEhhbmRsZXI6OnNwYW5uYWJsZVRleHRJblJhbmdlCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1cHBvcnQvQWJvdXRE YXRhRW5hYmxlRmVhdHVyZXMuaW4gYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViQ29yZVN1 cHBvcnQvQWJvdXREYXRhRW5hYmxlRmVhdHVyZXMuaW4KaW5kZXggN2EyZjI2Yi4uOTU5MzgwNCAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0Fib3V0 RGF0YUVuYWJsZUZlYXR1cmVzLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJD b3JlU3VwcG9ydC9BYm91dERhdGFFbmFibGVGZWF0dXJlcy5pbgpAQCAtMTksNiArMTksNyBAQCBD T05TSVNURU5DWV9DSEVDSwogQ09OVEVYVF9NRU5VUwogQ1NTX0ZJTFRFUlMKIENTU19HUklEX0xB WU9VVAorQ1NTX0lNQUdFX1JFU09MVVRJT04KIENTU19JTUFHRV9TRVQKIENTU19MQVlPVVRfR1JJ RAogQ1NTX1JFR0lPTlMKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJy eS5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQmxhY2tCZXJyeS5jbWFrZQppbmRleCA2NjBm YTM2Li5mNTRhMGMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0JsYWNrQmVycnku Y21ha2UKKysrIGIvU291cmNlL2NtYWtlL09wdGlvbnNCbGFja0JlcnJ5LmNtYWtlCkBAIC0xNTMs NiArMTUzLDcgQEAgV0VCS0lUX09QVElPTl9ERUZJTkUoRU5BQkxFX1ZJRVdQT1JUX1JFRkxPVyAi RW5hYmxlIHZpZXdwb3J0IHJlZmxvdyIgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9W QUxVRShFTkFCTEVfQU5JTUFUSU9OX0FQSSBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JU X1ZBTFVFKEVOQUJMRV9CQVRURVJZX1NUQVRVUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9Q T1JUX1ZBTFVFKEVOQUJMRV9CTE9CIE9OKQorV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM VUUoRU5BQkxFX0NTU19JTUFHRV9SRVNPTFVUSU9OIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxU X1BPUlRfVkFMVUUoRU5BQkxFX0NVU1RPTV9TQ0hFTUVfSEFORExFUiBPTikKIFdFQktJVF9PUFRJ T05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9ERVZJQ0VfT1JJRU5UQVRJT04gT04pCiBXRUJL SVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfRFJBR19TVVBQT1JUIE9GRikKZGlm ZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1Y2ExMDkz Li41ODVmZjIxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTItMTItMDUgIExlbyBZYW5nICA8bGVveWFuZ0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFbmFibGUgQ1NTX0lNQUdFX1JFU09MVVRJT04K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDEzMgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtOgorCiAyMDEyLTEyLTA0ICBBZGFtIEJhcnRoICA8 YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmVtb3ZlIG9ic29sZXRlIGNvZGUgZnJvbSB3 ZWJraXRweQpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0 LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IDc3MzBj YmIuLjVlOTU1MmIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVybC9GZWF0dXJl TGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxpc3QucG0KQEAg LTE5NCw3ICsxOTQsNyBAQCBteSBAZmVhdHVyZXMgPSAoCiAgICAgICBkZWZpbmUgPT4gIkVOQUJM RV9DU1NfSU1BR0VfT1JJRU5UQVRJT04iLCBkZWZhdWx0ID0+IDAsIHZhbHVlID0+IFwkY3NzSW1h Z2VPcmllbnRhdGlvblN1cHBvcnQgfSwKIAogICAgIHsgb3B0aW9uID0+ICJjc3MtaW1hZ2UtcmVz b2x1dGlvbiIsIGRlc2MgPT4gIlRvZ2dsZSBDU1MgaW1hZ2UtcmVzb2x1dGlvbiBzdXBwb3J0IiwK LSAgICAgIGRlZmluZSA9PiAiRU5BQkxFX0NTU19JTUFHRV9SRVNPTFVUSU9OIiwgZGVmYXVsdCA9 PiAwLCB2YWx1ZSA9PiBcJGNzc0ltYWdlUmVzb2x1dGlvblN1cHBvcnQgfSwKKyAgICAgIGRlZmlu ZSA9PiAiRU5BQkxFX0NTU19JTUFHRV9SRVNPTFVUSU9OIiwgZGVmYXVsdCA9PiBpc0JsYWNrQmVy cnkoKSwgdmFsdWUgPT4gXCRjc3NJbWFnZVJlc29sdXRpb25TdXBwb3J0IH0sCiAKICAgICB7IG9w dGlvbiA9PiAiY3NzLXJlZ2lvbnMiLCBkZXNjID0+ICJUb2dnbGUgQ1NTIFJlZ2lvbnMgc3VwcG9y dCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9DU1NfUkVHSU9OUyIsIGRlZmF1bHQgPT4gMSwg dmFsdWUgPT4gXCRjc3NSZWdpb25zU3VwcG9ydCB9LAotLSAKMS43LjUuNAoK