104131 2012-12-05 09:10:15 -0800 REGRESSION (r136683): css3/calc/background-position-parsing.html failing on EFL Linux 64-bit Debug WK2 2012-12-05 13:39:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r136683%20(6698)/results.html LayoutTestFailure, MakingBotsRed, Regression P2 Normal --- 104014 1 tmpsantos menard cmarcelo jchaffraix kling koivisto krit macpherson menard ojan webkit.review.bot oldest_to_newest 783812 0 177770 tmpsantos 2012-12-05 09:10:15 -0800 Created attachment 177770 backtrace css3/calc/background-position-parsing.html started failing on EFL Linux 64-bit Debug WK2 in r136683 <http://trac.webkit.org/changeset/136683>. http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r136682%20(6697)/results.html passed http://build.webkit.org/results/EFL%20Linux%2064-bit%20Debug%20WK2/r136683%20(6698)/results.html failed 783831 1 menard 2012-12-05 09:23:27 -0800 *** Bug 104133 has been marked as a duplicate of this bug. *** 783843 2 177779 menard 2012-12-05 09:39:13 -0800 Created attachment 177779 Patch 783844 3 menard 2012-12-05 09:39:44 -0800 (In reply to comment #2) > Created an attachment (id=177779) [details] > Patch I'm wondering if the fix should go in isPositionValue instead. Thoughts? 783854 4 177782 menard 2012-12-05 09:45:58 -0800 Created attachment 177782 Patch 783875 5 177787 menard 2012-12-05 10:21:02 -0800 Created attachment 177787 Fix comment 783955 6 177787 andersca 2012-12-05 12:00:31 -0800 Comment on attachment 177787 Fix comment View in context: https://bugs.webkit.org/attachment.cgi?id=177787&action=review > Source/WebCore/css/CSSParser.cpp:3865 > + m_parsedCalculation.release(); This should be m_parsedCalculation = nullptr; 783956 7 177787 koivisto 2012-12-05 12:01:52 -0800 Comment on attachment 177787 Fix comment View in context: https://bugs.webkit.org/attachment.cgi?id=177787&action=review > Source/WebCore/css/CSSParser.cpp:3867 > inline bool CSSParser::isPositionValue(CSSParserValue* value) > { > - return isBackgroundPositionKeyword(value->id) || validUnit(value, FPercent | FLength); > + bool ret = isBackgroundPositionKeyword(value->id) || validUnit(value, FPercent | FLength); > + // validUnit may encounter a CSS calc() and could potentially set m_parsedCalculation to a value. As we may call later isPositionValue again > + // we need to unset it otherwise the next call to validUnit will assert when it will check a calc again. parseFillPositionComponent also workaround this behavior. > + m_parsedCalculation.release(); > + return ret; > } It seems wrong that a isFoo function has a side effect like this. 784004 8 177811 menard 2012-12-05 12:41:42 -0800 Created attachment 177811 Patch 784071 9 177811 webkit.review.bot 2012-12-05 13:39:47 -0800 Comment on attachment 177811 Patch Clearing flags on attachment: 177811 Committed r136754: <http://trac.webkit.org/changeset/136754> 784072 10 webkit.review.bot 2012-12-05 13:39:51 -0800 All reviewed patches have been landed. Closing bug. 177770 2012-12-05 09:10:15 -0800 2012-12-05 09:10:15 -0800 backtrace url.txt text/plain 135 tmpsantos aHR0cDovL2J1aWxkLndlYmtpdC5vcmcvcmVzdWx0cy9FRkwlMjBMaW51eCUyMDY0LWJpdCUyMERl YnVnJTIwV0syL3IxMzY2OTIlMjAoNjcwMCkvY3NzMy9jYWxjL2JhY2tncm91bmQtcG9zaXRpb24t cGFyc2luZy1jcmFzaC1sb2cudHh0 177779 2012-12-05 09:39:13 -0800 2012-12-05 09:45:53 -0800 Patch bug-104131-20121205143637.patch text/plain 2435 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFmZDQ5ZjNjODBhNDgz N2I4MmI0MzVjZGE5MWY1ZDM0OWJkZWUyMy4uYzgxODdlOWIyYzhjNjBhMWYyNzI4YTFjMTI5ZjU1 ZTE1ZGJjNmU2MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTA1ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEz NjY4Myk6IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0aW9uLXBhcnNpbmcuaHRtbCBmYWlsaW5n IG9uIEVGTCBMaW51eCA2NC1iaXQgRGVidWcgV0syCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBjc3MzL2NhbGMvYmFja2dyb3VuZC1wb3NpdGlvbi1wYXJz aW5nLmh0bWwgYXNzZXJ0IGluIGRlYnVnIGJlY2F1c2Ugd2UKKyAgICAgICAgY2FsbCBDU1NQYXJz ZXI6OnZhbGlkVW5pdCBtdWx0aXBsZSB0aW1lcyBpbiBhIHJvdy4gVGhlIHByb2JsZW0gd2FzIHdp dGgKKyAgICAgICAgdmFsaWRVbml0IHdoaWNoIGNoZWNrIGNhbGMoKSB2YWx1ZXMgYW5kIHNhdmUg dGhlIHJlc3VsdCBpbnNpZGUKKyAgICAgICAgbV9wYXJzZWRDYWxjdWxhdGlvbiBmb3IgbGF0ZXIg dXNhZ2UuIHZhbGlkVW5pdCBleHBlY3RzIHlvdSB0bworICAgICAgICB1c2UgbV9wYXJzZWRDYWxj dWxhdGlvbiB0aGVyZWZvcmUgY2FsbGluZyB2YWxpZFVuaXQgYWdhaW4gd2l0aAorICAgICAgICBt X3BhcnNlZENhbGN1bGF0aW9uIGJlaW5nIHNldCBhc3NlcnRzLiBBcyBwYXJzZUZpbGxCYWNrZ3Jv dW5kUG9zaXRpb24KKyAgICAgICAganVzdCB3YW50IHRvIGNoZWNrIHdldGhlciB0aGUgY3VycmVu dCB2YWx1ZSBpcyB2YWxpZCBmb3IKKyAgICAgICAgYmFja2dyb3VuZC1wb3NpdGlvbiB3ZSBzaG91 bGQgdGhlbiByZWxlYXNlIG1fcGFyc2VkQ2FsY3VsYXRpb24gaW4KKyAgICAgICAgYmV0d2VlbiBj YWxscy4KKworICAgICAgICBObyBuZXcgdGVzdHMgOiB0aGUgYXNzZXJ0IHdhcyBjb3ZlcmVkIGJ5 IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0aW9uLXBhcnNpbmcuaHRtbC4KKworICAgICAgICAq IGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUZp bGxCYWNrZ3JvdW5kUG9zaXRpb24pOgorCiAyMDEyLTEyLTA1ICBNaWNoYWVsIFBydWV0dCAgPG1p Y2hhZWxANjhrLm9yZz4KIAogICAgICAgICBJbmRleGVkREI6IEltcGxlbWVudCBJbmRleGVkREIg YmluZGluZ3MgZm9yIEpTQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCAzODg5M2QxNDRl ZWMyOGI3OGMzMDRmMjY5NWQ1Mzg2MWU0YjZkYTZhLi5jOTRhNGYxZjEzOGRiNjlmZGE4NzVmYjVi ZWUwODIyNTFjMDE1NmU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2Vy LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMzg2OSw2ICsz ODY5LDkgQEAgdm9pZCBDU1NQYXJzZXI6OnBhcnNlRmlsbEJhY2tncm91bmRQb3NpdGlvbihDU1NQ YXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGlzdCwgUmVmUHQKICAgICAgICAgQ1NTUGFyc2VyVmFsdWUq IGN1cnJlbnQgPSB2YWx1ZUxpc3QtPnZhbHVlQXQoaSk7CiAgICAgICAgIGlmIChpc0NvbW1hKGN1 cnJlbnQpIHx8ICFjdXJyZW50IHx8IChjdXJyZW50LT51bml0ID09IENTU1BhcnNlclZhbHVlOjpP cGVyYXRvciAmJiBjdXJyZW50LT5pVmFsdWUgPT0gJy8nKSB8fCAhaXNQb3NpdGlvblZhbHVlKGN1 cnJlbnQpKQogICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIC8vIGlzUG9zaXRpb25WYWx1ZSBj YWxscyB2YWxpZFVuaXQgd2hpY2ggbWF5IGVuY291bnRlciBhIENTUyBjYWxjKCkgYW5kIGNvdWxk IHBvdGVudGlhbGx5IHNldCBtX3BhcnNlZENhbGN1bGF0aW9uIHRvIGEgdmFsdWUuIEFzIHdlIGNh bGwgbGF0ZXIgdmFsaWRVbml0CisgICAgICAgIC8vIHdlIG5lZWQgdG8gdW5zZXQgaXQgb3RoZXJ3 aXNlIHRoZSBuZXh0IGNhbGwgdG8gdmFsaWRVbml0IHdpbGwgYXNzZXJ0IHdoZW4gaXQgd2lsbCBj aGVjayBhIGNhbGMgYWdhaW4uIHBhcnNlRmlsbFBvc2l0aW9uQ29tcG9uZW50IGFsc28gd29ya2Fy b3VuZCB0aGlzIGJlaGF2aW9yLgorICAgICAgICBtX3BhcnNlZENhbGN1bGF0aW9uLnJlbGVhc2Uo KTsKICAgICB9CiAKICAgICBpZiAobnVtYmVyT2ZWYWx1ZXMgPiA0KQo= 177782 2012-12-05 09:45:58 -0800 2012-12-05 10:20:56 -0800 Patch bug-104131-20121205144323.patch text/plain 2557 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFmZDQ5ZjNjODBhNDgz N2I4MmI0MzVjZGE5MWY1ZDM0OWJkZWUyMy4uODliNzM3Y2JlZjM2MDU1NjYxNTA1NTFkYmI0YTBj YTE0MmQyMTcyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTA1ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEz NjY4Myk6IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0aW9uLXBhcnNpbmcuaHRtbCBmYWlsaW5n IG9uIEVGTCBMaW51eCA2NC1iaXQgRGVidWcgV0syCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBjc3MzL2NhbGMvYmFja2dyb3VuZC1wb3NpdGlvbi1wYXJz aW5nLmh0bWwgYXNzZXJ0IGluIGRlYnVnIGJlY2F1c2Ugd2UKKyAgICAgICAgY2FsbCBDU1NQYXJz ZXI6OnZhbGlkVW5pdCBtdWx0aXBsZSB0aW1lcyBpbiBhIHJvdy4gVGhlIHByb2JsZW0gd2FzIHdp dGgKKyAgICAgICAgdmFsaWRVbml0IHdoaWNoIGNoZWNrIGNhbGMoKSB2YWx1ZXMgYW5kIHNhdmUg dGhlIHJlc3VsdCBpbnNpZGUKKyAgICAgICAgbV9wYXJzZWRDYWxjdWxhdGlvbiBmb3IgbGF0ZXIg dXNhZ2UuIHZhbGlkVW5pdCBleHBlY3RzIHlvdSB0bworICAgICAgICB1c2UgbV9wYXJzZWRDYWxj dWxhdGlvbiB0aGVyZWZvcmUgY2FsbGluZyB2YWxpZFVuaXQgYWdhaW4gd2l0aAorICAgICAgICBt X3BhcnNlZENhbGN1bGF0aW9uIGJlaW5nIHNldCBhc3NlcnRzLiBBcyBwYXJzZUZpbGxCYWNrZ3Jv dW5kUG9zaXRpb24KKyAgICAgICAganVzdCB3YW50IHRvIGNoZWNrIHdldGhlciB0aGUgY3VycmVu dCB2YWx1ZSBpcyB2YWxpZCBmb3IKKyAgICAgICAgYmFja2dyb3VuZC1wb3NpdGlvbiB3ZSBzaG91 bGQgdGhlbiByZWxlYXNlIG1fcGFyc2VkQ2FsY3VsYXRpb24gaW4KKyAgICAgICAgYmV0d2VlbiBj YWxscy4KKworICAgICAgICBObyBuZXcgdGVzdHMgOiB0aGUgYXNzZXJ0IHdhcyBjb3ZlcmVkIGJ5 IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0aW9uLXBhcnNpbmcuaHRtbC4KKworICAgICAgICAq IGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjppc1Bvc2l0 aW9uVmFsdWUpOgorCiAyMDEyLTEyLTA1ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9y Zz4KIAogICAgICAgICBJbmRleGVkREI6IEltcGxlbWVudCBJbmRleGVkREIgYmluZGluZ3MgZm9y IEpTQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCAzODg5M2QxNDRlZWMyOGI3OGMzMDRm MjY5NWQ1Mzg2MWU0YjZkYTZhLi42ODRjZmE0MmI0MmViZjc4MzViZjhkZjYwMGRmZjVhOGEyYjJk Mjg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMzg1OSw3ICszODU5LDExIEBAIHZv aWQgQ1NTUGFyc2VyOjpwYXJzZTNWYWx1ZXNCYWNrZ3JvdW5kUG9zaXRpb24oQ1NTUGFyc2VyVmFs dWVMaXN0KiB2YWx1ZUxpc3QsIFJlCiAKIGlubGluZSBib29sIENTU1BhcnNlcjo6aXNQb3NpdGlv blZhbHVlKENTU1BhcnNlclZhbHVlKiB2YWx1ZSkKIHsKLSAgICByZXR1cm4gaXNCYWNrZ3JvdW5k UG9zaXRpb25LZXl3b3JkKHZhbHVlLT5pZCkgfHwgdmFsaWRVbml0KHZhbHVlLCBGUGVyY2VudCB8 IEZMZW5ndGgpOworICAgIGJvb2wgcmV0ID0gaXNCYWNrZ3JvdW5kUG9zaXRpb25LZXl3b3JkKHZh bHVlLT5pZCkgfHwgdmFsaWRVbml0KHZhbHVlLCBGUGVyY2VudCB8IEZMZW5ndGgpOworICAgIC8v IGlzUG9zaXRpb25WYWx1ZSBjYWxscyB2YWxpZFVuaXQgd2hpY2ggbWF5IGVuY291bnRlciBhIENT UyBjYWxjKCkgYW5kIGNvdWxkIHBvdGVudGlhbGx5IHNldCBtX3BhcnNlZENhbGN1bGF0aW9uIHRv IGEgdmFsdWUuIEFzIHdlIGNhbGwgbGF0ZXIgdmFsaWRVbml0CisgICAgLy8gd2UgbmVlZCB0byB1 bnNldCBpdCBvdGhlcndpc2UgdGhlIG5leHQgY2FsbCB0byB2YWxpZFVuaXQgd2lsbCBhc3NlcnQg d2hlbiBpdCB3aWxsIGNoZWNrIGEgY2FsYyBhZ2Fpbi4gcGFyc2VGaWxsUG9zaXRpb25Db21wb25l bnQgYWxzbyB3b3JrYXJvdW5kIHRoaXMgYmVoYXZpb3IuCisgICAgbV9wYXJzZWRDYWxjdWxhdGlv bi5yZWxlYXNlKCk7CisgICAgcmV0dXJuIHJldDsKIH0KIAogdm9pZCBDU1NQYXJzZXI6OnBhcnNl RmlsbEJhY2tncm91bmRQb3NpdGlvbihDU1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGlzdCwgUmVm UHRyPENTU1ZhbHVlPiYgdmFsdWUxLCBSZWZQdHI8Q1NTVmFsdWU+JiB2YWx1ZTIpCg== 177787 2012-12-05 10:21:02 -0800 2012-12-05 12:38:30 -0800 Fix comment bug-104131-20121205151827.patch text/plain 2545 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFmZDQ5ZjNjODBhNDgz N2I4MmI0MzVjZGE5MWY1ZDM0OWJkZWUyMy4uODliNzM3Y2JlZjM2MDU1NjYxNTA1NTFkYmI0YTBj YTE0MmQyMTcyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDEyLTEyLTA1ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEz NjY4Myk6IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0aW9uLXBhcnNpbmcuaHRtbCBmYWlsaW5n IG9uIEVGTCBMaW51eCA2NC1iaXQgRGVidWcgV0syCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBjc3MzL2NhbGMvYmFja2dyb3VuZC1wb3NpdGlvbi1wYXJz aW5nLmh0bWwgYXNzZXJ0IGluIGRlYnVnIGJlY2F1c2Ugd2UKKyAgICAgICAgY2FsbCBDU1NQYXJz ZXI6OnZhbGlkVW5pdCBtdWx0aXBsZSB0aW1lcyBpbiBhIHJvdy4gVGhlIHByb2JsZW0gd2FzIHdp dGgKKyAgICAgICAgdmFsaWRVbml0IHdoaWNoIGNoZWNrIGNhbGMoKSB2YWx1ZXMgYW5kIHNhdmUg dGhlIHJlc3VsdCBpbnNpZGUKKyAgICAgICAgbV9wYXJzZWRDYWxjdWxhdGlvbiBmb3IgbGF0ZXIg dXNhZ2UuIHZhbGlkVW5pdCBleHBlY3RzIHlvdSB0bworICAgICAgICB1c2UgbV9wYXJzZWRDYWxj dWxhdGlvbiB0aGVyZWZvcmUgY2FsbGluZyB2YWxpZFVuaXQgYWdhaW4gd2l0aAorICAgICAgICBt X3BhcnNlZENhbGN1bGF0aW9uIGJlaW5nIHNldCBhc3NlcnRzLiBBcyBwYXJzZUZpbGxCYWNrZ3Jv dW5kUG9zaXRpb24KKyAgICAgICAganVzdCB3YW50IHRvIGNoZWNrIHdldGhlciB0aGUgY3VycmVu dCB2YWx1ZSBpcyB2YWxpZCBmb3IKKyAgICAgICAgYmFja2dyb3VuZC1wb3NpdGlvbiB3ZSBzaG91 bGQgdGhlbiByZWxlYXNlIG1fcGFyc2VkQ2FsY3VsYXRpb24gaW4KKyAgICAgICAgYmV0d2VlbiBj YWxscy4KKworICAgICAgICBObyBuZXcgdGVzdHMgOiB0aGUgYXNzZXJ0IHdhcyBjb3ZlcmVkIGJ5 IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0aW9uLXBhcnNpbmcuaHRtbC4KKworICAgICAgICAq IGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjppc1Bvc2l0 aW9uVmFsdWUpOgorCiAyMDEyLTEyLTA1ICBNaWNoYWVsIFBydWV0dCAgPG1pY2hhZWxANjhrLm9y Zz4KIAogICAgICAgICBJbmRleGVkREI6IEltcGxlbWVudCBJbmRleGVkREIgYmluZGluZ3MgZm9y IEpTQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAppbmRleCAzODg5M2QxNDRlZWMyOGI3OGMzMDRm MjY5NWQ1Mzg2MWU0YjZkYTZhLi41NTFlMmQ4YTI0YmFkNDgzZDVmMmQyZmY3ZjcxYjhmYWY1OWY4 OTRmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmNwcApAQCAtMzg1OSw3ICszODU5LDExIEBAIHZv aWQgQ1NTUGFyc2VyOjpwYXJzZTNWYWx1ZXNCYWNrZ3JvdW5kUG9zaXRpb24oQ1NTUGFyc2VyVmFs dWVMaXN0KiB2YWx1ZUxpc3QsIFJlCiAKIGlubGluZSBib29sIENTU1BhcnNlcjo6aXNQb3NpdGlv blZhbHVlKENTU1BhcnNlclZhbHVlKiB2YWx1ZSkKIHsKLSAgICByZXR1cm4gaXNCYWNrZ3JvdW5k UG9zaXRpb25LZXl3b3JkKHZhbHVlLT5pZCkgfHwgdmFsaWRVbml0KHZhbHVlLCBGUGVyY2VudCB8 IEZMZW5ndGgpOworICAgIGJvb2wgcmV0ID0gaXNCYWNrZ3JvdW5kUG9zaXRpb25LZXl3b3JkKHZh bHVlLT5pZCkgfHwgdmFsaWRVbml0KHZhbHVlLCBGUGVyY2VudCB8IEZMZW5ndGgpOworICAgIC8v IHZhbGlkVW5pdCBtYXkgZW5jb3VudGVyIGEgQ1NTIGNhbGMoKSBhbmQgY291bGQgcG90ZW50aWFs bHkgc2V0IG1fcGFyc2VkQ2FsY3VsYXRpb24gdG8gYSB2YWx1ZS4gQXMgd2UgbWF5IGNhbGwgbGF0 ZXIgaXNQb3NpdGlvblZhbHVlIGFnYWluCisgICAgLy8gd2UgbmVlZCB0byB1bnNldCBpdCBvdGhl cndpc2UgdGhlIG5leHQgY2FsbCB0byB2YWxpZFVuaXQgd2lsbCBhc3NlcnQgd2hlbiBpdCB3aWxs IGNoZWNrIGEgY2FsYyBhZ2Fpbi4gcGFyc2VGaWxsUG9zaXRpb25Db21wb25lbnQgYWxzbyB3b3Jr YXJvdW5kIHRoaXMgYmVoYXZpb3IuCisgICAgbV9wYXJzZWRDYWxjdWxhdGlvbi5yZWxlYXNlKCk7 CisgICAgcmV0dXJuIHJldDsKIH0KIAogdm9pZCBDU1NQYXJzZXI6OnBhcnNlRmlsbEJhY2tncm91 bmRQb3NpdGlvbihDU1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGlzdCwgUmVmUHRyPENTU1ZhbHVl PiYgdmFsdWUxLCBSZWZQdHI8Q1NTVmFsdWU+JiB2YWx1ZTIpCg== 177811 2012-12-05 12:41:42 -0800 2012-12-05 13:39:47 -0800 Patch bug-104131-20121205173906.patch text/plain 4129 menard U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NjkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTFmZDQ5ZjNjODBhNDgz N2I4MmI0MzVjZGE5MWY1ZDM0OWJkZWUyMy4uOWVhNTlkNGYyOTA0MjFkOTNhNWY5MDllOTQzOGM0 ODM2NDA5N2ExNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEyLTA1ICBBbGV4 aXMgTWVuYXJkICA8YWxleGlzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTiAocjEz NjY4Myk6IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0aW9uLXBhcnNpbmcuaHRtbCBmYWlsaW5n IG9uIEVGTCBMaW51eCA2NC1iaXQgRGVidWcgV0syCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMzEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBjc3MzL2NhbGMvYmFja2dyb3VuZC1wb3NpdGlvbi1wYXJz aW5nLmh0bWwgYXNzZXJ0IGluIGRlYnVnIGJlY2F1c2Ugd2UKKyAgICAgICAgY2FsbCBDU1NQYXJz ZXI6OnZhbGlkVW5pdCBtdWx0aXBsZSB0aW1lcyBpbiBhIHJvdy4gVGhlIHByb2JsZW0gd2FzIHdp dGgKKyAgICAgICAgdmFsaWRVbml0IHdoaWNoIGNoZWNrIGNhbGMoKSB2YWx1ZXMgYW5kIHNhdmUg dGhlIHJlc3VsdCBpbnNpZGUKKyAgICAgICAgbV9wYXJzZWRDYWxjdWxhdGlvbiBmb3IgbGF0ZXIg dXNhZ2UuIHZhbGlkVW5pdCBleHBlY3RzIHlvdSB0bworICAgICAgICB1c2UgbV9wYXJzZWRDYWxj dWxhdGlvbiB0aGVyZWZvcmUgY2FsbGluZyB2YWxpZFVuaXQgYWdhaW4gd2l0aAorICAgICAgICBt X3BhcnNlZENhbGN1bGF0aW9uIGJlaW5nIHNldCBhc3NlcnRzLiBBcyBwYXJzZUZpbGxCYWNrZ3Jv dW5kUG9zaXRpb24KKyAgICAgICAganVzdCB3YW50IHRvIGNoZWNrIHdldGhlciB0aGUgY3VycmVu dCB2YWx1ZSBpcyBtYXliZSB2YWxpZCBmb3IKKyAgICAgICAgYmFja2dyb3VuZC1wb3NpdGlvbiB3 ZSBjYW4ganVzdCByZWxheCB0aGUgY2hlY2sgdG8gYWxsb3cgZWl0aGVyIHRoZQorICAgICAgICB2 YWxpZCBrZXl3b3JkcyBvciBhbnkgb3RoZXIgdW5pdHMgKHdlIHdpbGwgYW55d2F5IGZpbHRlciB0 aGUgaW5jb3JyZWN0CisgICAgICAgIHZhbHVlcyBsYXRlciBpbiB0aGUgcGFyc2luZykuIFRoZSBt b3N0IGltcG9ydGFudCBjaGVjayBhdCB0aGlzIHBvaW50CisgICAgICAgIGZvciB0aGUgc2hvcnRo YW5kIGlzIHRoZSB2YWxpZGl0eSBvZiB0aGUga2V5d29yZC4KKworICAgICAgICBObyBuZXcgdGVz dHMgOiB0aGUgYXNzZXJ0IHdhcyBjb3ZlcmVkIGJ5IGNzczMvY2FsYy9iYWNrZ3JvdW5kLXBvc2l0 aW9uLXBhcnNpbmcuaHRtbC4KKworICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjppc1BvdGVudGlhbFBvc2l0aW9uVmFsdWUpOgorICAgICAg ICAoV2ViQ29yZTo6Q1NTUGFyc2VyOjpwYXJzZUZpbGxCYWNrZ3JvdW5kUG9zaXRpb24pOgorICAg ICAgICAqIGNzcy9DU1NQYXJzZXIuaDoKKwogMjAxMi0xMi0wNSAgTWljaGFlbCBQcnVldHQgIDxt aWNoYWVsQDY4ay5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBJbXBsZW1lbnQgSW5kZXhlZERC IGJpbmRpbmdzIGZvciBKU0MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJz ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggMzg4OTNkMTQ0 ZWVjMjhiNzhjMzA0ZjI2OTVkNTM4NjFlNGI2ZGE2YS4uODJhZmZkOGFiMmVmY2I0ZDZjNThkZmJk Yzg1ZGI1MjcwY2JhNjRkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTM4NTcsOSAr Mzg1Nyw5IEBAIHZvaWQgQ1NTUGFyc2VyOjpwYXJzZTNWYWx1ZXNCYWNrZ3JvdW5kUG9zaXRpb24o Q1NTUGFyc2VyVmFsdWVMaXN0KiB2YWx1ZUxpc3QsIFJlCiAjZW5kaWYKIH0KIAotaW5saW5lIGJv b2wgQ1NTUGFyc2VyOjppc1Bvc2l0aW9uVmFsdWUoQ1NTUGFyc2VyVmFsdWUqIHZhbHVlKQoraW5s aW5lIGJvb2wgQ1NTUGFyc2VyOjppc1BvdGVudGlhbFBvc2l0aW9uVmFsdWUoQ1NTUGFyc2VyVmFs dWUqIHZhbHVlKQogewotICAgIHJldHVybiBpc0JhY2tncm91bmRQb3NpdGlvbktleXdvcmQodmFs dWUtPmlkKSB8fCB2YWxpZFVuaXQodmFsdWUsIEZQZXJjZW50IHwgRkxlbmd0aCk7CisgICAgcmV0 dXJuICF2YWx1ZS0+aWQgfHwgaXNCYWNrZ3JvdW5kUG9zaXRpb25LZXl3b3JkKHZhbHVlLT5pZCk7 CiB9CiAKIHZvaWQgQ1NTUGFyc2VyOjpwYXJzZUZpbGxCYWNrZ3JvdW5kUG9zaXRpb24oQ1NTUGFy c2VyVmFsdWVMaXN0KiB2YWx1ZUxpc3QsIFJlZlB0cjxDU1NWYWx1ZT4mIHZhbHVlMSwgUmVmUHRy PENTU1ZhbHVlPiYgdmFsdWUyKQpAQCAtMzg2Nyw3ICszODY3LDcgQEAgdm9pZCBDU1NQYXJzZXI6 OnBhcnNlRmlsbEJhY2tncm91bmRQb3NpdGlvbihDU1NQYXJzZXJWYWx1ZUxpc3QqIHZhbHVlTGlz dCwgUmVmUHQKICAgICB1bnNpZ25lZCBudW1iZXJPZlZhbHVlcyA9IDA7CiAgICAgZm9yICh1bnNp Z25lZCBpID0gdmFsdWVMaXN0LT5jdXJyZW50SW5kZXgoKTsgaSA8IHZhbHVlTGlzdC0+c2l6ZSgp OyArK2ksICsrbnVtYmVyT2ZWYWx1ZXMpIHsKICAgICAgICAgQ1NTUGFyc2VyVmFsdWUqIGN1cnJl bnQgPSB2YWx1ZUxpc3QtPnZhbHVlQXQoaSk7Ci0gICAgICAgIGlmIChpc0NvbW1hKGN1cnJlbnQp IHx8ICFjdXJyZW50IHx8IChjdXJyZW50LT51bml0ID09IENTU1BhcnNlclZhbHVlOjpPcGVyYXRv ciAmJiBjdXJyZW50LT5pVmFsdWUgPT0gJy8nKSB8fCAhaXNQb3NpdGlvblZhbHVlKGN1cnJlbnQp KQorICAgICAgICBpZiAoaXNDb21tYShjdXJyZW50KSB8fCAhY3VycmVudCB8fCAoY3VycmVudC0+ dW5pdCA9PSBDU1NQYXJzZXJWYWx1ZTo6T3BlcmF0b3IgJiYgY3VycmVudC0+aVZhbHVlID09ICcv JykgfHwgIWlzUG90ZW50aWFsUG9zaXRpb25WYWx1ZShjdXJyZW50KSkKICAgICAgICAgICAgIGJy ZWFrOwogICAgIH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5o IGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5oCmluZGV4IDUyOGIyNzVmOTM2MzFhMzQ1 YTkyNzlmMTEyMDg2ODM0YTIxNzI1NjcuLjRjNmY4YzU5YmRmZDdiNjBmODU3ZTc5ZTU3ODI2N2E4 NTFjYzA1NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTUGFyc2VyLmgKQEAgLTExOSw3ICsxMTksNyBAQCBwdWJs aWM6CiAgICAgUGFzc1JlZlB0cjxDU1NWYWx1ZT4gcGFyc2VGaWxsUG9zaXRpb25ZKENTU1BhcnNl clZhbHVlTGlzdCopOwogICAgIHZvaWQgcGFyc2VGaWxsUG9zaXRpb24oQ1NTUGFyc2VyVmFsdWVM aXN0KiwgUmVmUHRyPENTU1ZhbHVlPiYsIFJlZlB0cjxDU1NWYWx1ZT4mKTsKICNpZiBFTkFCTEUo Q1NTM19CQUNLR1JPVU5EKQotICAgIGJvb2wgaXNQb3NpdGlvblZhbHVlKENTU1BhcnNlclZhbHVl Kik7CisgICAgYm9vbCBpc1BvdGVudGlhbFBvc2l0aW9uVmFsdWUoQ1NTUGFyc2VyVmFsdWUqKTsK ICAgICB2b2lkIHBhcnNlRmlsbEJhY2tncm91bmRQb3NpdGlvbihDU1NQYXJzZXJWYWx1ZUxpc3Qq LCBSZWZQdHI8Q1NTVmFsdWU+JiwgUmVmUHRyPENTU1ZhbHVlPiYpOwogICAgIHZvaWQgcGFyc2Uz VmFsdWVzQmFja2dyb3VuZFBvc2l0aW9uKENTU1BhcnNlclZhbHVlTGlzdCosIFJlZlB0cjxDU1NW YWx1ZT4mLCBSZWZQdHI8Q1NTVmFsdWU+JiwgUGFzc1JlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4s IFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+KTsKICAgICB2b2lkIHBhcnNlNFZhbHVlc0Jh Y2tncm91bmRQb3NpdGlvbihDU1NQYXJzZXJWYWx1ZUxpc3QqLCBSZWZQdHI8Q1NTVmFsdWU+Jiwg UmVmUHRyPENTU1ZhbHVlPiYsIFBhc3NSZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+LCBQYXNzUmVm UHRyPENTU1ByaW1pdGl2ZVZhbHVlPik7Cg==