<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>104129</bug_id>
          
          <creation_ts>2012-12-05 08:56:25 -0800</creation_ts>
          <short_desc>[Qt] Unskip compositing tests</short_desc>
          <delta_ts>2014-02-03 02:30:29 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Qt</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Noam Rosenthal">noam</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>allan.jensen</cc>
    
    <cc>jturcotte</cc>
    
    <cc>kbalazs</cc>
    
    <cc>ossy</cc>
    
    <cc>rafael.lobo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>783796</commentid>
    <comment_count>0</comment_count>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2012-12-05 08:56:25 -0800</bug_when>
    <thetext>While Qt supports compositing, the compositing layout tests are skipped. This may cause instability and regressions. We should unskip and maintain the compositing layout tests for Qt.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>787352</commentid>
    <comment_count>1</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-12-10 08:14:32 -0800</bug_when>
    <thetext>Qt-WK1: Found 352 tests; running 0, skipping 352.
Qt-WK2: Found 352 tests; running 272, skipping 80.

I checked the history and https://trac.webkit.org/changeset/109167
skipped compositing tests on Qt-WK1.

And I ran a quick test what if we remove the compositing tests
from qt-5.0-wk1/TestExpectations list:

Found 352 tests; running 335, skipping 17.
Regressions: Unexpected text-only failures (52)
Regressions: Unexpected image-only failures (3)
Regressions: Unexpected crashes (1)
Regressions: Unexpected missing results (24)

It seems we can unskip many of them, but there are many many failures.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>789472</commentid>
    <comment_count>2</comment_count>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2012-12-12 05:23:36 -0800</bug_when>
    <thetext>I removed compositing from qt-5.0-wk1/TestExpectations, and skip only failing tests - https://trac.webkit.org/changeset/137454

Qt5-WK1: Found 360 tests; running 262, skipping 98.
Qt5-WK2: Found 360 tests; running 280, skipping 80.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>974977</commentid>
    <comment_count>3</comment_count>
    <who name="Allan Sandfeld Jensen">allan.jensen</who>
    <bug_when>2014-02-03 02:30:29 -0800</bug_when>
    <thetext>Mostly solved, and out of scope for WebKit anyway with Qt moved.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>