104121 2012-12-05 07:46:57 -0800 [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values. 2012-12-07 11:17:48 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Unspecified RESOLVED FIXED P2 Normal --- 0 mlattanzio webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 783741 0 mlattanzio 2012-12-05 07:46:57 -0800 The Graphics::BufferType enum has been changed to more meaningful names with differing implementations. Choose appropriate types in each place that used to call createBuffer. 785937 1 178232 mlattanzio 2012-12-07 09:48:51 -0800 Created attachment 178232 Patch 785988 2 178232 rwlbuis 2012-12-07 10:56:55 -0800 Comment on attachment 178232 Patch LGTM. 786000 3 178232 webkit.review.bot 2012-12-07 11:17:45 -0800 Comment on attachment 178232 Patch Clearing flags on attachment: 178232 Committed r136965: <http://trac.webkit.org/changeset/136965> 786001 4 webkit.review.bot 2012-12-07 11:17:48 -0800 All reviewed patches have been landed. Closing bug. 178232 2012-12-07 09:48:51 -0800 2012-12-07 11:17:45 -0800 Patch bug-104121-20121207124804.patch text/plain 4746 mlattanzio U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA1YmE5OTZlMjk0N2M4Yzk3ZjQ3NzMxMDU3ZDUxZDU4YjE1NmViNWM1Li45YTQ0NjNkMjJk ZDIzN2YyMWFlZTkxZTA1MTJiOTc1YTY1Nzc0NDBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMi0xMi0wNyAgTWlrZSBMYXR0YW56aW8gIDxtbGF0 dGFuemlvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVwZGF0ZSBCbGFja0JlcnJ5 IFBvcnQgdG8gdXNlIG5ldyBHcmFwaGljczo6Y3JlYXRlQnVmZmVyIEJ1ZmZlclR5cGUgZW51bSB2 YWx1ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDQxMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBV cGRhdGUgY3JlYXRlQnVmZmVyIGNhbGxzIHRvIHJlZmxlY3QgbmV3IEJ1ZmZlclR5cGUgZW51bS4K KyAgICAgICAgU2V0IGJ1ZmZlcnMgb3BhcXVlIGlmIHBvc3NpYmxlIHRvIGF2b2lkIHVubmVjZXNz YXJ5IGJsZW5kcy4KKyAgICAgICAgSW50ZXJuYWwgUFIgMjU0NjQ5CisgICAgICAgIEludGVybmFs IFJldmlldzogSmFrb2IgUGV0c292aXRzCisKKyAgICAgICAgKiBXZWJLaXRTdXBwb3J0L0JhY2tp bmdTdG9yZVRpbGUuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpUaWxlQnVmZmVy OjpuYXRpdmVCdWZmZXIpOgorCiAyMDEyLTEyLTA3ICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3Jj aG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIERSVCAtIFVwZGF0ZSBpbXBs ZW1lbnRhdGlvbiBvZiBUZXN0UnVubmVyLnNldEN1c3RvbVBvbGljeURlbGVnYXRlKCkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcCBiL1Nv dXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvQmFja2luZ1N0b3JlLmNwcAppbmRleCBjMWYwNjcz OTY5NzEwYTMxMzQ3NDRjY2FkMWFhNzU4ODdjNWVkNGQwLi45ZGRmMWMwYTI0MjA3MzQyZGM5Yzdi MTRmMmE2NGNkZGNhYTZiMTg1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL0JhY2tpbmdTdG9yZS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9C YWNraW5nU3RvcmUuY3BwCkBAIC0xMTE5LDYgKzExMTksNyBAQCBib29sIEJhY2tpbmdTdG9yZVBy aXZhdGU6OnJlbmRlcihjb25zdCBQbGF0Zm9ybTo6SW50UmVjdCYgcmVjdCkKICAgICAgICAgYmFj a0J1ZmZlci0+Y2xlYXJSZW5kZXJlZFJlZ2lvbigpOwogCiAgICAgICAgIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpHcmFwaGljczo6QnVmZmVyKiBuYXRpdmVCdWZmZXIgPSBiYWNrQnVmZmVyLT5uYXRp dmVCdWZmZXIoKTsKKyAgICAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpzZXRC dWZmZXJPcGFxdWVIaW50KG5hdGl2ZUJ1ZmZlciwgIUNvbG9yKG1fd2ViUGFnZS0+c2V0dGluZ3Mo KS0+YmFja2dyb3VuZENvbG9yKCkpLmhhc0FscGhhKCkpOwogCiAgICAgICAgIC8vIFRPRE86IFRo aXMgY29kZSBpcyBvbmx5IG5lZWRlZCBmb3IgRUdMSW1hZ2UgY29kZSBwYXRoLCBidXQgcHJlZmVy cmFibHkgQmFja2luZ1N0b3JlCiAgICAgICAgIC8vIHNob3VsZCBub3Qga25vdyB0aGF0LCBhbmQg dGhlIHN5bmNocm9uaXphdGlvbiBzaG91bGQgYmUgaW4gQmxhY2tCZXJyeTo6UGxhdGZvcm06Okdy YXBoaWNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9y dC9CYWNraW5nU3RvcmVUaWxlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0JhY2tpbmdTdG9yZVRpbGUuY3BwCmluZGV4IGQxYWY3ODI5OWEyMGYzNGM5ZWUwMDM4 MzMwNmE2ZWM2Mjg1MzM1YTEuLmViMTFlYjBhYTI5NjQ0NjZlNjg0ZmJlNTc5OTVlZTgwYTE3OGJl MzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0Jh Y2tpbmdTdG9yZVRpbGUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0JhY2tpbmdTdG9yZVRpbGUuY3BwCkBAIC0xMDEsNyArMTAxLDcgQEAgUGxhdGZvcm06 OkludFJlY3RSZWdpb24gVGlsZUJ1ZmZlcjo6bm90UmVuZGVyZWRSZWdpb24oKSBjb25zdAogUGxh dGZvcm06OkdyYXBoaWNzOjpCdWZmZXIqIFRpbGVCdWZmZXI6Om5hdGl2ZUJ1ZmZlcigpIGNvbnN0 CiB7CiAgICAgaWYgKCFtX25hdGl2ZUJ1ZmZlcikKLSAgICAgICAgbV9uYXRpdmVCdWZmZXIgPSBj cmVhdGVCdWZmZXIobV9zaXplLCBQbGF0Zm9ybTo6R3JhcGhpY3M6OlRpbGVCdWZmZXIsIFN1cmZh Y2VQb29sOjpnbG9iYWxTdXJmYWNlUG9vbCgpLT5zaGFyZWRQaXhtYXBHcm91cCgpKTsKKyAgICAg ICAgbV9uYXRpdmVCdWZmZXIgPSBjcmVhdGVCdWZmZXIobV9zaXplLCBQbGF0Zm9ybTo6R3JhcGhp Y3M6OkFsd2F5c0JhY2tlZCwgU3VyZmFjZVBvb2w6Omdsb2JhbFN1cmZhY2VQb29sKCktPnNoYXJl ZFBpeG1hcEdyb3VwKCkpOwogCiAgICAgcmV0dXJuIG1fbmF0aXZlQnVmZmVyOwogfQpkaWZmIC0t Z2l0IGEvVG9vbHMvQ2hhbmdlTG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IDQ2YmJhNTg4NDY4 Njk0NTVkMGI5MTVlYjVlMTIwYTBlMjMxM2RlZWQuLjM4MjRjZTdjMDdkOTdiOTNmNmYzODQyODNk ZmUyYzNlY2ExZmQyZGQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9D aGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0xMi0wNyAgTWlrZSBMYXR0YW56aW8gIDxt bGF0dGFuemlvQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFVwZGF0ZSBCbGFja0Jl cnJ5IFBvcnQgdG8gdXNlIG5ldyBHcmFwaGljczo6Y3JlYXRlQnVmZmVyIEJ1ZmZlclR5cGUgZW51 bSB2YWx1ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQxMjEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBVcGRhdGUgY3JlYXRlQnVmZmVyIGNhbGwgdG8gcmVmbGVjdCBuZXcgQnVmZmVyVHlwZSBlbnVt LgorICAgICAgICBJbnRlcm5hbCBQUiAyNTQ2NDkKKyAgICAgICAgSW50ZXJuYWwgUmV2aWV3OiBK YWtvYiBQZXRzb3ZpdHMKKworICAgICAgICBEUlQgaXMgYWx3YXlzIGJhY2tlZCBmb3IgbWF4aW11 bSBjb21wYXRpYmlsaXR5LgorCisgICAgICAgICogRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9Q aXhlbER1bXBTdXBwb3J0QmxhY2tCZXJyeS5jcHA6CisgICAgICAgIChjcmVhdGVCaXRtYXBDb250 ZXh0RnJvbVdlYlZpZXcpOgorCiAyMDEyLTEyLTA3ICBYaWFvYm8gV2FuZyAgPHhid2FuZ0B0b3Jj aG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgW0JsYWNrQmVycnldIERSVCAtIFVwZGF0ZSBpbXBs ZW1lbnRhdGlvbiBvZiBUZXN0UnVubmVyLnNldEN1c3RvbVBvbGljeURlbGVnYXRlKCkKZGlmZiAt LWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2JsYWNrYmVycnkvUGl4ZWxEdW1wU3VwcG9ydEJs YWNrQmVycnkuY3BwIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9QaXhlbER1bXBT dXBwb3J0QmxhY2tCZXJyeS5jcHAKaW5kZXggNWExYjg5YTRjN2JmMDkyYzRlMjA2OWVlYWVjMjA2 ZTczNWFhMTcxZS4uNDNlYzZjNGNhNzZkMGUzODAwMTUwMTk0NTY2OTIzMDI3NGQ2N2FlZCAxMDA2 NDQKLS0tIGEvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9QaXhlbER1bXBTdXBwb3J0 QmxhY2tCZXJyeS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvYmxhY2tiZXJyeS9QaXhl bER1bXBTdXBwb3J0QmxhY2tCZXJyeS5jcHAKQEAgLTg2LDcgKzg2LDcgQEAgUGFzc1JlZlB0cjxC aXRtYXBDb250ZXh0PiBjcmVhdGVCaXRtYXBDb250ZXh0RnJvbVdlYlZpZXcoYm9vbCAvKm9uc2Ny ZWVuKi8sIGJvb2wKICAgICAgICAgICAgIG1lbWNweShkYXRhLCB3aW5kb3dQaXhlbHMsIHdpbmRv d1NpemUud2lkdGgoKSAqIHdpbmRvd1NpemUuaGVpZ2h0KCkgKiA0KTsKICAgICB9CiAjZWxzZQot ICAgIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpHcmFwaGljczo6QnVmZmVyKiBidWZmZXIgPSBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OmNyZWF0ZUJ1ZmZlcih3aW5kb3dTaXplLCBCbGFj a0JlcnJ5OjpQbGF0Zm9ybTo6R3JhcGhpY3M6OlRlbXBvcmFyeUJ1ZmZlcik7CisgICAgQmxhY2tC ZXJyeTo6UGxhdGZvcm06OkdyYXBoaWNzOjpCdWZmZXIqIGJ1ZmZlciA9IEJsYWNrQmVycnk6OlBs YXRmb3JtOjpHcmFwaGljczo6Y3JlYXRlQnVmZmVyKHdpbmRvd1NpemUsIEJsYWNrQmVycnk6OlBs YXRmb3JtOjpHcmFwaGljczo6QWx3YXlzQmFja2VkKTsKICAgICBCbGFja0JlcnJ5OjpQbGF0Zm9y bTo6R3JhcGhpY3M6OkRyYXdhYmxlKiBkcmF3YWJsZSA9IEJsYWNrQmVycnk6OlBsYXRmb3JtOjpH cmFwaGljczo6bG9ja0J1ZmZlckRyYXdhYmxlKGJ1ZmZlcik7CiAgICAgaWYgKGRyYXdhYmxlKSB7 CiAgICAgICAgIGJhY2tpbmdTdG9yZS0+ZHJhd0NvbnRlbnRzKGRyYXdhYmxlLCB3aW5kb3dSZWN0 LCB3aW5kb3dTaXplKTsK