104110 2012-12-05 03:32:12 -0800 [EFL][WK2] EWK2UnitTestBase.ewk_favicon_database_async_icon_get is crashing with new Ewk_Context 2012-12-05 08:11:37 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103692 1 cdumez cdumez gyuyoung.kim jinwoo7.song kenneth lucas.de.marchi mikhail.pozdnyakov rakuco webkit.review.bot oldest_to_newest 783597 0 cdumez 2012-12-05 03:32:12 -0800 Bug 103692 is creating a new Ewk_Context for each API test, this causes the following API test to crash: EWK2UnitTestBase.ewk_favicon_database_async_icon_get With the following backtrace: ASSERTION FAILED: !result /home/jinwoo/webkit_opensource/webkit-efl/WebKit/Source/WTF/wtf/ThreadingPthreads.cpp(345) : void WTF::Mutex::lock() 1 0x7ffa60c82839 WTF::Mutex::lock() 2 0x7ffa6089f4a4 WTF::Locker<WTF::Mutex>::Locker(WTF::Mutex&) 3 0x7ffa5ff23d47 void WTF::addIterator<void (*)(char const*, void*), WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> >, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashMapValueTraits<WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >, WTF::HashTraits<void (*)(char const*, void*)> >(WTF::HashTable<void (*)(char const*, void*), WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> >, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashMapValueTraits<WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >, WTF::HashTraits<void (*)(char const*, void*)> > const*, WTF::HashTableConstIterator<void (*)(char const*, void*), WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> >, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashMapValueTraits<WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >, WTF::HashTraits<void (*)(char const*, void*)> >*) 4 0x7ffa5ff25f5a WTF::HashTableConstIterator<void (*)(char const*, void*), WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> >, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashMapValueTraits<WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >, WTF::HashTraits<void (*)(char const*, void*)> >::HashTableConstIterator(WTF::HashTable<void (*)(char const*, void*), WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> >, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashMapValueTraits<WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >, WTF::HashTraits<void (*)(char const*, void*)> > const*, WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> const*, WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> const*) 5 0x7ffa5ff2525b WTF::HashTable<void (*)(char const*, void*), WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> >, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashMapValueTraits<WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >, WTF::HashTraits<void (*)(char const*, void*)> >::makeConstIterator(WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>*) const 6 0x7ffa5ff23cb9 WTF::HashTable<void (*)(char const*, void*), WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<void (*)(char const*, void*), IconChangeCallbackData> >, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashMapValueTraits<WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >, WTF::HashTraits<void (*)(char const*, void*)> >::begin() const 7 0x7ffa5ff22be1 WTF::HashMap<void (*)(char const*, void*), IconChangeCallbackData, WTF::PtrHash<void (*)(char const*, void*)>, WTF::HashTraits<void (*)(char const*, void*)>, WTF::HashTraits<IconChangeCallbackData> >::begin() const 8 0x7ffa5ff21a0b EwkFaviconDatabase::didChangeIconForPageURL(OpaqueWKIconDatabase const*, OpaqueWKURL const*, void const*) 9 0x7ffa5fd52711 WebKit::WebIconDatabaseClient::didChangeIconForPageURL(WebKit::WebIconDatabase*, WebKit::WebURL*) 10 0x7ffa5fd4fae5 WebKit::WebIconDatabase::didChangeIconForPageURL(WTF::String const&) 11 0x7ffa5aa60111 WebCore::IconDatabase::setIconDataForIconURL(WTF::PassRefPtr<WebCore::SharedBuffer>, WTF::String const&) 12 0x7ffa5fd4f43d WebKit::WebIconDatabase::setIconDataForIconURL(CoreIPC::DataReference const&, WTF::String const&) 13 0x7ffa5ff6ce6f void CoreIPC::callMemberFunction<WebKit::WebIconDatabase, void (WebKit::WebIconDatabase::*)(CoreIPC::DataReference const&, WTF::String const&), CoreIPC::DataReference, WTF::String>(CoreIPC::Arguments2<CoreIPC::DataReference, WTF::String> const&, WebKit::WebIconDatabase*, void (WebKit::WebIconDatabase::*)(CoreIPC::DataReference const&, WTF::String const&)) 14 0x7ffa5ff6c9a7 void CoreIPC::handleMessage<Messages::WebIconDatabase::SetIconDataForIconURL, WebKit::WebIconDatabase, void (WebKit::WebIconDatabase::*)(CoreIPC::DataReference const&, WTF::String const&)>(CoreIPC::MessageDecoder&, WebKit::WebIconDatabase*, void (WebKit::WebIconDatabase::*)(CoreIPC::DataReference const&, WTF::String const&)) 15 0x7ffa5ff6c1f1 WebKit::WebIconDatabase::didReceiveWebIconDatabaseMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 16 0x7ffa5fd4fde8 WebKit::WebIconDatabase::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 17 0x7ffa5fc9e6c2 CoreIPC::MessageReceiverMap::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 18 0x7ffa5fd2e25d WebKit::WebContext::dispatchMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 19 0x7ffa5fdab9ba WebKit::WebProcessProxy::didReceiveMessage(CoreIPC::Connection*, CoreIPC::MessageID, CoreIPC::MessageDecoder&) 20 0x7ffa5fc936f4 CoreIPC::Connection::dispatchMessage(CoreIPC::MessageID, CoreIPC::MessageDecoder&) 21 0x7ffa5fc93860 CoreIPC::Connection::dispatchMessage(CoreIPC::Connection::Message<CoreIPC::MessageDecoder>&) 22 0x7ffa5fc93aab CoreIPC::Connection::dispatchOneMessage() 23 0x7ffa5fc9dc4c WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>::operator()(CoreIPC::Connection*) 24 0x7ffa5fc9da52 WTF::BoundFunctionImpl<WTF::FunctionWrapper<void (CoreIPC::Connection::*)()>, void (CoreIPC::Connection*)>::operator()() 25 0x7ffa60c86496 WTF::Function<void ()>::operator()() const 26 0x7ffa5ab79622 WebCore::RunLoop::performWork() 27 0x7ffa5b5a5a17 WebCore::RunLoop::wakeUpEvent(void*, void*, unsigned int) 28 0x7ffa61307751 29 0x7ffa613066a1 30 0x7ffa61306b45 ecore_main_loop_iterate 31 0x40e49f EWK2UnitTest::EWK2UnitTestBase::waitUntilLoadFinished(double) 783610 1 177717 cdumez 2012-12-05 03:45:44 -0800 Created attachment 177717 Patch 783616 2 177717 mikhail.pozdnyakov 2012-12-05 03:52:20 -0800 Comment on attachment 177717 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177717&action=review > Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp:56 > + WKIconDatabaseSetIconDatabaseClient(toAPI(m_iconDatabase.get()), 0); is it possible to use c++ analogue instead? 783620 3 177717 cdumez 2012-12-05 03:58:10 -0800 Comment on attachment 177717 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177717&action=review >> Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp:56 >> + WKIconDatabaseSetIconDatabaseClient(toAPI(m_iconDatabase.get()), 0); > > is it possible to use c++ analogue instead? In theory yes, and I don't mind if we switch to C++ in a separate patch. At the moment, my patch is consistent with the use of WKIconDatabaseSetIconDatabaseClient() in the class constructor. If I use C API in constructor and C++ API in the destructor, it is going to look weird. 783624 4 mikhail.pozdnyakov 2012-12-05 04:05:23 -0800 (In reply to comment #3) > (From update of attachment 177717 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177717&action=review > > >> Source/WebKit2/UIProcess/API/efl/ewk_favicon_database.cpp:56 > >> + WKIconDatabaseSetIconDatabaseClient(toAPI(m_iconDatabase.get()), 0); > > > > is it possible to use c++ analogue instead? > > In theory yes, and I don't mind if we switch to C++ in a separate patch. At the moment, my patch is consistent with the use of WKIconDatabaseSetIconDatabaseClient() in the class constructor. > If I use C API in constructor and C++ API in the destructor, it is going to look weird. Agreed, looks good than. 783718 5 177717 laszlo.gombos 2012-12-05 07:21:20 -0800 Comment on attachment 177717 Patch r=me. 783762 6 177717 webkit.review.bot 2012-12-05 08:11:33 -0800 Comment on attachment 177717 Patch Clearing flags on attachment: 177717 Committed r136691: <http://trac.webkit.org/changeset/136691> 783763 7 webkit.review.bot 2012-12-05 08:11:37 -0800 All reviewed patches have been landed. Closing bug. 177717 2012-12-05 03:45:44 -0800 2012-12-05 08:11:33 -0800 Patch 104110_ewk_favicon_crash.patch text/plain 1587 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMTk5NTllLi5iMWQxMGVjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjAg QEAKIDIwMTItMTItMDUgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KIAorICAgICAgICBbRUZMXVtXSzJdIEVXSzJVbml0VGVzdEJhc2UuZXdrX2Zhdmljb25f ZGF0YWJhc2VfYXN5bmNfaWNvbl9nZXQgaXMgY3Jhc2hpbmcgd2l0aCBuZXcgRXdrX0NvbnRleHQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDExMAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVucmVnaXN0 ZXIgdGhlIFdLRmF2aWNvbkRhdGFiYXNlIGNsaWVudCBpbiBFd2tGYXZpY29uRGF0YWJhc2UKKyAg ICAgICAgZGVzdHJ1Y3RvciB0byBhdm9pZCBjcmFzaGluZyBpZiB0aGUgY2FsbGJhY2tzIGdldCBj YWxsZWQKKyAgICAgICAgYWZ0ZXIgdGhlIEV3a0Zhdmljb25EYXRhYmFzZSBvYmplY3QgaGFzIGJl ZW4gZGVzdHJveWVkIChpLmUuCisgICAgICAgIHRoZSBwYXJlbnQgRXdrQ29udGV4dCBvYmplY3Qg d2FzIGRlc3Ryb3llZCkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2VmbC9ld2tfZmF2aWNv bl9kYXRhYmFzZS5jcHA6CisgICAgICAgIChFd2tGYXZpY29uRGF0YWJhc2U6On5Fd2tGYXZpY29u RGF0YWJhc2UpOgorCisyMDEyLTEyLTA1ICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5k dW1lekBpbnRlbC5jb20+CisKICAgICAgICAgW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIFVzZSB1bnNp Z25lZCBpbnRlZ2VycyBmb3IgQ29vcmRpbmF0ZWRUaWxlIElEcwogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzODE2CiAKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19mYXZpY29uX2RhdGFiYXNlLmNwcCBiL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL2V3a19mYXZpY29uX2RhdGFiYXNlLmNwcApp bmRleCAxMmFiMTFkLi5mZDBkOTgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL2VmbC9ld2tfZmF2aWNvbl9kYXRhYmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0FQSS9lZmwvZXdrX2Zhdmljb25fZGF0YWJhc2UuY3BwCkBAIC01Myw2ICs1Myw3 IEBAIEV3a0Zhdmljb25EYXRhYmFzZTo6RXdrRmF2aWNvbkRhdGFiYXNlKFdlYkljb25EYXRhYmFz ZSogaWNvbkRhdGFiYXNlKQogCiBFd2tGYXZpY29uRGF0YWJhc2U6On5Fd2tGYXZpY29uRGF0YWJh c2UoKQogeworICAgIFdLSWNvbkRhdGFiYXNlU2V0SWNvbkRhdGFiYXNlQ2xpZW50KHRvQVBJKG1f aWNvbkRhdGFiYXNlLmdldCgpKSwgMCk7CiB9CiAKIFN0cmluZyBFd2tGYXZpY29uRGF0YWJhc2U6 Omljb25VUkxGb3JQYWdlVVJMKGNvbnN0IFN0cmluZyYgcGFnZVVSTCkgY29uc3QK