104108 2012-12-05 03:23:49 -0800 Web Inspector: Title of "Record Timeline" status button on "Timeline Panel" should reflect the recording state 2012-12-05 23:29:04 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 sankeerth.vs webkit-unassigned apavlov keishi loislo pfeldman pmuellr vivek.vg vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 783590 0 sankeerth.vs 2012-12-05 03:23:49 -0800 Title of "Record Timeline" status button on "Timeline Panel" should be toggled upon the recording state. 783592 1 sankeerth.vs 2012-12-05 03:25:15 -0800 patch to follow. 783605 2 177715 sankeerth.vs 2012-12-05 03:37:44 -0800 Created attachment 177715 Patch 783639 3 177715 apavlov 2012-12-05 04:17:00 -0800 Comment on attachment 177715 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177715&action=review > Source/WebCore/ChangeLog:4 > + Panel" should be toggled upon the recording state. I'd put it as "...should reflect the recording state." > Source/WebCore/inspector/front-end/TimelinePanel.js:556 > + this.toggleTimelineButton.title = WebInspector.UIString("Stop"); The previous line looks like a more appropriate place for this line, since starting the record and toggling the title are logically related, and sending the metrics event is related to the entire sequence. 784638 4 177940 sankeerth.vs 2012-12-05 22:39:06 -0800 Created attachment 177940 Patch 784669 5 177940 webkit.review.bot 2012-12-05 23:29:01 -0800 Comment on attachment 177940 Patch Clearing flags on attachment: 177940 Committed r136809: <http://trac.webkit.org/changeset/136809> 784670 6 webkit.review.bot 2012-12-05 23:29:04 -0800 All reviewed patches have been landed. Closing bug. 177715 2012-12-05 03:37:44 -0800 2012-12-05 22:38:54 -0800 Patch bug-104108-20121205170613.patch text/plain 1987 sankeerth.vs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2OGJhMDZiN2ZkMWU0 ZDNhM2RmZmYxN2ZlNTg0NzQwN2ZkZDU5NS4uOTQzNDQ1YmZjYmZmYjYxNzgxN2ZjNmRlMGZiZDU1 NjBjMjdmZDZlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA1ICBTYW5r ZWVydGggViBTICA8c2Fua2VlcnRoLnZzQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFRpdGxlIG9mICJSZWNvcmQgVGltZWxpbmUiIHN0YXR1cyBidXR0b24gb24gIlRpbWVs aW5lCisgICAgICAgIFBhbmVsIiBzaG91bGQgYmUgdG9nZ2xlZCB1cG9uIHRoZSByZWNvcmRpbmcg c3RhdGUuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x MDQxMDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aXRsZSBzaG91bGQgYmUgdG9nZ2xlZCBiZXR3ZWVuICJSZWNvcmQiLyJTdG9wIiB0byByZWZsZWN0 IGN1cnJlbnQKKyAgICAgICAgc3RhdGUgb2YgdGhlIFN0YXR1cyBiYXIgYnV0dG9uLgorCisgICAg ICAgIE5vIG5ldyB0ZXN0cyBhcyBVSSByZWxhdGVkIGNoYW5nZS4KKworICAgICAgICAqIGluc3Bl Y3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5U aW1lbGluZVBhbmVsLnByb3RvdHlwZS5nZXQgX3RvZ2dsZVRpbWVsaW5lQnV0dG9uQ2xpY2tlZCk6 CisKIDIwMTItMTEtMzAgIFNhbmtlZXJ0aCBWIFMgIDxzYW5rZWVydGgudnNAc2Ftc3VuZy5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3RvcjogW1RpbWVsaW5lXSBKUyBlcnJvciB3aGVuIGNsaWNr aW5nIGluIE1lbW9yeSBTdGF0aXN0aWNzIHZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcyBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9mcm9udC1lbmQvVGltZWxpbmVQYW5lbC5qcwppbmRleCBmNjE2ZDQyMTllNDE1NGJi NTRjYThkNjA2MGZlMDRiN2MwMzdlYTAyLi4xYmUyZGI5ZWJlMjA5YjA4ZjA2NDk2OWQ3ZDUyNzA0 NTBiOWU5ZWYwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1RpbWVsaW5lUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9UaW1lbGluZVBhbmVsLmpzCkBAIC01NDYsMTEgKzU0NiwxNCBAQCBXZWJJbnNwZWN0b3IuVGlt ZWxpbmVQYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgewogICAgICAgICBpZiAodGhpcy5fb3BlcmF0 aW9uSW5Qcm9ncmVzcykKICAgICAgICAgICAgIHJldHVybjsKLSAgICAgICAgaWYgKHRoaXMudG9n Z2xlVGltZWxpbmVCdXR0b24udG9nZ2xlZCkKKyAgICAgICAgaWYgKHRoaXMudG9nZ2xlVGltZWxp bmVCdXR0b24udG9nZ2xlZCkgewogICAgICAgICAgICAgdGhpcy5fbW9kZWwuc3RvcFJlY29yZCgp OworICAgICAgICAgICAgdGhpcy50b2dnbGVUaW1lbGluZUJ1dHRvbi50aXRsZSA9IFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiUmVjb3JkIik7CisgICAgICAgIH0KICAgICAgICAgZWxzZSB7CiAgICAg ICAgICAgICB0aGlzLl9tb2RlbC5zdGFydFJlY29yZCgpOwogICAgICAgICAgICAgV2ViSW5zcGVj dG9yLnVzZXJNZXRyaWNzLlRpbWVsaW5lU3RhcnRlZC5yZWNvcmQoKTsKKyAgICAgICAgICAgIHRo aXMudG9nZ2xlVGltZWxpbmVCdXR0b24udGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlN0 b3AiKTsKICAgICAgICAgfQogICAgICAgICB0aGlzLnRvZ2dsZVRpbWVsaW5lQnV0dG9uLnRvZ2ds ZWQgPSAhdGhpcy50b2dnbGVUaW1lbGluZUJ1dHRvbi50b2dnbGVkOwogICAgIH0sCg== 177940 2012-12-05 22:39:06 -0800 2012-12-05 23:29:00 -0800 Patch bug-104108-20121206120732.patch text/plain 1971 sankeerth.vs U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmI2OGJhMDZiN2ZkMWU0 ZDNhM2RmZmYxN2ZlNTg0NzQwN2ZkZDU5NS4uYjBmNzVjN2U5Nzk1NWFhODMxNmY0MjAzYzdhY2U4 NDlhMDRjOTMyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTEyLTA1ICBTYW5r ZWVydGggViBTICA8c2Fua2VlcnRoLnZzQHNhbXN1bmcuY29tPgorCisgICAgICAgIFdlYiBJbnNw ZWN0b3I6IFRpdGxlIG9mICJSZWNvcmQgVGltZWxpbmUiIHN0YXR1cyBidXR0b24gb24gIlRpbWVs aW5lCisgICAgICAgIFBhbmVsIiBzaG91bGQgcmVmbGVjdCB0aGUgcmVjb3JkaW5nIHN0YXRlLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTA0MTA4CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGl0bGUgc2hv dWxkIGJlIHRvZ2dsZWQgYmV0d2VlbiAiUmVjb3JkIi8iU3RvcCIgdG8gcmVmbGVjdCBjdXJyZW50 CisgICAgICAgIHN0YXRlIG9mIHRoZSBTdGF0dXMgYmFyIGJ1dHRvbi4KKworICAgICAgICBObyBu ZXcgdGVzdHMgYXMgVUkgcmVsYXRlZCBjaGFuZ2UuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJv bnQtZW5kL1RpbWVsaW5lUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQ YW5lbC5wcm90b3R5cGUuZ2V0IF90b2dnbGVUaW1lbGluZUJ1dHRvbkNsaWNrZWQpOgorCiAyMDEy LTExLTMwICBTYW5rZWVydGggViBTICA8c2Fua2VlcnRoLnZzQHNhbXN1bmcuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFtUaW1lbGluZV0gSlMgZXJyb3Igd2hlbiBjbGlja2luZyBpbiBN ZW1vcnkgU3RhdGlzdGljcyB2aWV3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXggZjYxNmQ0MjE5ZTQxNTRiYjU0Y2E4ZDYw NjBmZTA0YjdjMDM3ZWEwMi4uOGUwNmYyZjVlNmI2YTAwMDUyZGQ3NWEwZWQ0ZTYwNzNhZDczOTY0 YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGlu ZVBhbmVsLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvVGltZWxp bmVQYW5lbC5qcwpAQCAtNTQ2LDEwICs1NDYsMTMgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFu ZWwucHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX29wZXJhdGlvbkluUHJv Z3Jlc3MpCiAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIGlmICh0aGlzLnRvZ2dsZVRpbWVs aW5lQnV0dG9uLnRvZ2dsZWQpCisgICAgICAgIGlmICh0aGlzLnRvZ2dsZVRpbWVsaW5lQnV0dG9u LnRvZ2dsZWQpIHsKICAgICAgICAgICAgIHRoaXMuX21vZGVsLnN0b3BSZWNvcmQoKTsKKyAgICAg ICAgICAgIHRoaXMudG9nZ2xlVGltZWxpbmVCdXR0b24udGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlT dHJpbmcoIlJlY29yZCIpOworICAgICAgICB9CiAgICAgICAgIGVsc2UgewogICAgICAgICAgICAg dGhpcy5fbW9kZWwuc3RhcnRSZWNvcmQoKTsKKyAgICAgICAgICAgIHRoaXMudG9nZ2xlVGltZWxp bmVCdXR0b24udGl0bGUgPSBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlN0b3AiKTsKICAgICAgICAg ICAgIFdlYkluc3BlY3Rvci51c2VyTWV0cmljcy5UaW1lbGluZVN0YXJ0ZWQucmVjb3JkKCk7CiAg ICAgICAgIH0KICAgICAgICAgdGhpcy50b2dnbGVUaW1lbGluZUJ1dHRvbi50b2dnbGVkID0gIXRo aXMudG9nZ2xlVGltZWxpbmVCdXR0b24udG9nZ2xlZDsK