104106 2012-12-05 02:28:25 -0800 Implement add64 for MIPS assembler after r136601 2012-12-18 07:22:40 -0800 1 1 1 Unclassified WebKit JavaScriptCore 420+ Unspecified Unspecified RESOLVED FIXED P2 Normal --- 102999 1 kilvadyb webkit-unassigned barraclough fpizlo fu galpeter gergely ggaren oliver ossy palfia webkit.review.bot oldest_to_newest 783562 0 kilvadyb 2012-12-05 02:28:25 -0800 +++ This bug was initially created as a clone of Bug #104103 +++ r136601 broke the MIPS build: /data/kilvadyb/webkit-mips/webkit/Source/JavaScriptCore/jit/JIT.cpp: In member function 'void JSC::JIT::privateCompileMainPass()': /data/kilvadyb/webkit-mips/webkit/Source/JavaScriptCore/jit/JIT.cpp:241: error: 'add64' was not declared in this scope It seems MIPS assembler needs add64. 783667 1 177730 kilvadyb 2012-12-05 05:03:04 -0800 Created attachment 177730 proposed patch 792568 2 galpeter 2012-12-17 01:56:32 -0800 So... are we waiting for something? 792574 3 ossy 2012-12-17 02:06:59 -0800 (In reply to comment #2) > So... are we waiting for something? Yes. For review. 792580 4 ossy 2012-12-17 02:13:26 -0800 cc more JSC reviewers 792760 5 179753 kilvadyb 2012-12-17 08:48:57 -0800 Created attachment 179753 Fixed patch for signed add. 792810 6 179753 zherczeg 2012-12-17 10:03:34 -0800 Comment on attachment 179753 Fixed patch for signed add. r=me. Tricky patch :) 792824 7 179753 webkit.review.bot 2012-12-17 10:26:12 -0800 Comment on attachment 179753 Fixed patch for signed add. Clearing flags on attachment: 179753 Committed r137919: <http://trac.webkit.org/changeset/137919> 792825 8 webkit.review.bot 2012-12-17 10:26:17 -0800 All reviewed patches have been landed. Closing bug. 177730 2012-12-05 05:03:04 -0800 2012-12-17 08:48:57 -0800 proposed patch add64.diff text/plain 1865 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDExZDE2ZTYuLmMxYmYxZGUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTA1ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IGFkZDY0IGZv ciBNSVBTIGFzc2VtYmxlciBhZnRlciByMTM2NjAxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhZGQ2NCBmdW5jdGlvbiB0byBNYWNyb0Fzc2Vi bGVyIG9mIE1JUFMuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6YWRkNjQpOgorICAgICAgICAoTWFj cm9Bc3NlbWJsZXJNSVBTKToKKwogMjAxMi0xMi0wNCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBw bGUuY29tPgogCiAgICAgICAgIGRpc3BsYXktcHJvZmlsZXItb3V0cHV0IHNob3VsZCBiZSBhYmxl IHRvIHNob3cgc291cmNlIGNvZGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9h c3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNz ZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCmluZGV4IDRmODFiNDUuLjNlN2ZiMmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBT LmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1J UFMuaApAQCAtMjQ0LDYgKzI0NCwyMiBAQCBwdWJsaWM6CiAgICAgICAgIG1fYXNzZW1ibGVyLnN3 KGRhdGFUZW1wUmVnaXN0ZXIsIGFkZHJUZW1wUmVnaXN0ZXIsIDApOwogICAgIH0KIAorICAgIHZv aWQgYWRkNjQoVHJ1c3RlZEltbTMyIGltbSwgQWJzb2x1dGVBZGRyZXNzIGFkZHJlc3MpCisgICAg eworICAgICAgICAvKgorICAgICAgICAgICAgYWRkMzIoaW1tLCBhZGRyZXNzKQorICAgICAgICAg ICAgc2x0dSAgaW1tVGVtcCwgZGF0YVRlbXAsIGltbVRlbXAgICAgIyBzZXQgY2FycnktaW4gYml0 IAorICAgICAgICAgICAgbHcgICAgZGF0YVRlbXAsIDQoYWRkclRlbXApCisgICAgICAgICAgICBh ZGR1ICBkYXRhVGVtcCwgZGF0YVRlbXAsIGltbVRlbXAKKyAgICAgICAgICAgIGFkZGl1IGRhdGFU ZW1wLCBUcnVzdGVkSW1tMzIoaW1tLm1fdmFsdWUgPj4gMzEpCisgICAgICAgICovCisgICAgICAg IGFkZDMyKGltbSwgYWRkcmVzcyk7CisgICAgICAgIG1fYXNzZW1ibGVyLnNsdHUoaW1tVGVtcFJl Z2lzdGVyLCBkYXRhVGVtcFJlZ2lzdGVyLCBpbW1UZW1wUmVnaXN0ZXIpOworICAgICAgICBtX2Fz c2VtYmxlci5sdyhkYXRhVGVtcFJlZ2lzdGVyLCBhZGRyVGVtcFJlZ2lzdGVyLCA0KTsKKyAgICAg ICAgbV9hc3NlbWJsZXIuYWRkdShkYXRhVGVtcFJlZ2lzdGVyLCBkYXRhVGVtcFJlZ2lzdGVyLCBp bW1UZW1wUmVnaXN0ZXIpOworICAgICAgICBtX2Fzc2VtYmxlci5hZGRpdShkYXRhVGVtcFJlZ2lz dGVyLCBkYXRhVGVtcFJlZ2lzdGVyLCBpbW0ubV92YWx1ZSA+PiAzMSk7CisgICAgfQorCiAgICAg dm9pZCBhbmQzMihSZWdpc3RlcklEIHNyYywgUmVnaXN0ZXJJRCBkZXN0KQogICAgIHsKICAgICAg ICAgbV9hc3NlbWJsZXIuYW5kSW5zbihkZXN0LCBkZXN0LCBzcmMpOwo= 179753 2012-12-17 08:48:57 -0800 2012-12-17 10:26:12 -0800 Fixed patch for signed add. add64.diff text/plain 3061 kilvadyb ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDE5OWI2ZjAuLmVjMTZjZjIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTEyLTE3ICBCYWxhenMgS2lsdmFk eSAgPGtpbHZhZHliQGhvbWVqaW5uaS5jb20+CisKKyAgICAgICAgSW1wbGVtZW50IGFkZDY0IGZv ciBNSVBTIGFzc2VtYmxlciBhZnRlciByMTM2NjAxCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQxMDYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBhZGQ2NCBmdW5jdGlvbiB0byBNYWNyb0Fzc2Vi bGVyIG9mIE1JUFMuCisKKyAgICAgICAgKiBhc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmg6 CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyTUlQUzo6YWRkMzIpOgorICAgICAgICAoSlND OjpNYWNyb0Fzc2VtYmxlck1JUFM6OmFkZDY0KToKKyAgICAgICAgKE1hY3JvQXNzZW1ibGVyTUlQ Uyk6CisKIDIwMTItMTItMTcgIEpvbmF0aGFuIExpdSAgPG5ldDE0N0BnbWFpbC5jb20+CiAKICAg ICAgICAgRml4IE1hdGgucG93IGltcGxlbWVudGF0aW9uIHdpdGggTWluR1ctdzY0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5o IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlck1JUFMuaApp bmRleCA0ZjgxYjQ1Li4zYWIyNTUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv YXNzZW1ibGVyL01hY3JvQXNzZW1ibGVyTUlQUy5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS9hc3NlbWJsZXIvTWFjcm9Bc3NlbWJsZXJNSVBTLmgKQEAgLTIyOCwyMiArMjI4LDQwIEBAIHB1 YmxpYzoKICAgICAgICAgLyoKICAgICAgICAgICAgbGkgICBhZGRyVGVtcCwgYWRkcmVzcwogICAg ICAgICAgICBsaSAgIGltbVRlbXAsIGltbQotICAgICAgICAgICBsdyAgIGRhdGFUZW1wLCAwKGFk ZHJUZW1wKQotICAgICAgICAgICBhZGR1IGRhdGFUZW1wLCBkYXRhVGVtcCwgaW1tVGVtcAorICAg ICAgICAgICBsdyAgIGNtcFRlbXAsIDAoYWRkclRlbXApCisgICAgICAgICAgIGFkZHUgZGF0YVRl bXAsIGNtcFRlbXAsIGltbVRlbXAKICAgICAgICAgICAgc3cgICBkYXRhVGVtcCwgMChhZGRyVGVt cCkKICAgICAgICAgKi8KICAgICAgICAgbW92ZShUcnVzdGVkSW1tUHRyKGFkZHJlc3MubV9wdHIp LCBhZGRyVGVtcFJlZ2lzdGVyKTsKLSAgICAgICAgbV9hc3NlbWJsZXIubHcoZGF0YVRlbXBSZWdp c3RlciwgYWRkclRlbXBSZWdpc3RlciwgMCk7Ci0gICAgICAgIGlmIChpbW0ubV92YWx1ZSA+PSAt MzI3NjggJiYgaW1tLm1fdmFsdWUgPD0gMzI3NjcKLSAgICAgICAgICAgICYmICFtX2ZpeGVkV2lk dGgpCi0gICAgICAgICAgICBtX2Fzc2VtYmxlci5hZGRpdShkYXRhVGVtcFJlZ2lzdGVyLCBkYXRh VGVtcFJlZ2lzdGVyLCBpbW0ubV92YWx1ZSk7CisgICAgICAgIG1fYXNzZW1ibGVyLmx3KGNtcFRl bXBSZWdpc3RlciwgYWRkclRlbXBSZWdpc3RlciwgMCk7CisgICAgICAgIGlmIChpbW0ubV92YWx1 ZSA+PSAtMzI3NjggJiYgaW1tLm1fdmFsdWUgPD0gMzI3NjcgJiYgIW1fZml4ZWRXaWR0aCkKKyAg ICAgICAgICAgIG1fYXNzZW1ibGVyLmFkZGl1KGRhdGFUZW1wUmVnaXN0ZXIsIGNtcFRlbXBSZWdp c3RlciwgaW1tLm1fdmFsdWUpOwogICAgICAgICBlbHNlIHsKICAgICAgICAgICAgIG1vdmUoaW1t LCBpbW1UZW1wUmVnaXN0ZXIpOwotICAgICAgICAgICAgbV9hc3NlbWJsZXIuYWRkdShkYXRhVGVt cFJlZ2lzdGVyLCBkYXRhVGVtcFJlZ2lzdGVyLCBpbW1UZW1wUmVnaXN0ZXIpOworICAgICAgICAg ICAgbV9hc3NlbWJsZXIuYWRkdShkYXRhVGVtcFJlZ2lzdGVyLCBjbXBUZW1wUmVnaXN0ZXIsIGlt bVRlbXBSZWdpc3Rlcik7CiAgICAgICAgIH0KICAgICAgICAgbV9hc3NlbWJsZXIuc3coZGF0YVRl bXBSZWdpc3RlciwgYWRkclRlbXBSZWdpc3RlciwgMCk7CiAgICAgfQogCisgICAgdm9pZCBhZGQ2 NChUcnVzdGVkSW1tMzIgaW1tLCBBYnNvbHV0ZUFkZHJlc3MgYWRkcmVzcykKKyAgICB7CisgICAg ICAgIC8qCisgICAgICAgICAgICBhZGQzMihpbW0sIGFkZHJlc3MpCisgICAgICAgICAgICBzbHR1 ICBpbW1UZW1wLCBkYXRhVGVtcCwgY21wVGVtcCAgICAjIHNldCBjYXJyeS1pbiBiaXQKKyAgICAg ICAgICAgIGx3ICAgIGRhdGFUZW1wLCA0KGFkZHJUZW1wKQorICAgICAgICAgICAgYWRkaXUgZGF0 YVRlbXAsIGltbS5tX3ZhbHVlID4+IDMxID8gLTEgOiAwCisgICAgICAgICAgICBhZGR1ICBkYXRh VGVtcCwgZGF0YVRlbXAsIGltbVRlbXAKKyAgICAgICAgICAgIHN3ICAgIGRhdGFUZW1wLCA0KGFk ZHJUZW1wKQorICAgICAgICAqLworICAgICAgICBhZGQzMihpbW0sIGFkZHJlc3MpOworICAgICAg ICBtX2Fzc2VtYmxlci5zbHR1KGltbVRlbXBSZWdpc3RlciwgZGF0YVRlbXBSZWdpc3RlciwgY21w VGVtcFJlZ2lzdGVyKTsKKyAgICAgICAgbV9hc3NlbWJsZXIubHcoZGF0YVRlbXBSZWdpc3Rlciwg YWRkclRlbXBSZWdpc3RlciwgNCk7CisgICAgICAgIGlmIChpbW0ubV92YWx1ZSA+PiAzMSkKKyAg ICAgICAgICAgIG1fYXNzZW1ibGVyLmFkZGl1KGRhdGFUZW1wUmVnaXN0ZXIsIGRhdGFUZW1wUmVn aXN0ZXIsIC0xKTsKKyAgICAgICAgbV9hc3NlbWJsZXIuYWRkdShkYXRhVGVtcFJlZ2lzdGVyLCBk YXRhVGVtcFJlZ2lzdGVyLCBpbW1UZW1wUmVnaXN0ZXIpOworICAgICAgICBtX2Fzc2VtYmxlci5z dyhkYXRhVGVtcFJlZ2lzdGVyLCBhZGRyVGVtcFJlZ2lzdGVyLCA0KTsKKyAgICB9CisKICAgICB2 b2lkIGFuZDMyKFJlZ2lzdGVySUQgc3JjLCBSZWdpc3RlcklEIGRlc3QpCiAgICAgewogICAgICAg ICBtX2Fzc2VtYmxlci5hbmRJbnNuKGRlc3QsIGRlc3QsIHNyYyk7Cg==