104098 2012-12-05 01:15:18 -0800 [chromium] Add some null-checks for the touch-lists in TouchEvent 2012-12-06 13:14:23 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sadrul sadrul abarth webkit.review.bot oldest_to_newest 783500 0 sadrul 2012-12-05 01:15:18 -0800 [chromium] Add some null-checks for the touch-lists in TouchEvent 783527 1 177697 sadrul 2012-12-05 01:45:29 -0800 Created attachment 177697 Patch 783543 2 sadrul 2012-12-05 01:59:57 -0800 Hi! This is for fixing: https://code.google.com/p/chromium/issues/detail?id=164228 784352 3 177697 abarth 2012-12-05 17:42:39 -0800 Comment on attachment 177697 Patch Can we test these cases? It seems like we should be able to create a Chromium API unit test. 785116 4 178050 sadrul 2012-12-06 11:59:14 -0800 Created attachment 178050 Patch 785119 5 sadrul 2012-12-06 12:01:46 -0800 (In reply to comment #3) > (From update of attachment 177697 [details]) > Can we test these cases? It seems like we should be able to create a Chromium API unit test. There are layout-tests that verify that correct mouse-events are generated for touch-events. So just added a super simple unit-test here to verify that empty touch-lists don't cause crashes. 785168 6 178050 abarth 2012-12-06 12:57:03 -0800 Comment on attachment 178050 Patch Thanks. 785180 7 178050 webkit.review.bot 2012-12-06 13:14:19 -0800 Comment on attachment 178050 Patch Clearing flags on attachment: 178050 Committed r136876: <http://trac.webkit.org/changeset/136876> 785181 8 webkit.review.bot 2012-12-06 13:14:23 -0800 All reviewed patches have been landed. Closing bug. 177697 2012-12-05 01:45:29 -0800 2012-12-06 11:59:11 -0800 Patch bug-104098-20121205044254.patch text/plain 1938 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IGI4NDA2YjAwMDhhOTViZTIwMTM2YjFmOTE1MDdjZmQ5NTRlYzAxOTMuLmI4ZDlmODc4OThkOWNm YTdiOGVkYjA0YmM3OWRlMmQ1MzIxYmUwNDkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTItMTItMDUgIFNhZHJ1bCBIYWJpYiBDaG93ZGh1cnkgIDxzYWRy dWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHNvbWUgbnVsbC1jaGVj a3MgZm9yIHRoZSB0b3VjaC1saXN0cyBpbiBUb3VjaEV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQwOTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBwb3NzaWJsZSBmb3IgdGhlIHRvdWNo LWxpc3RzIHRvIGJlIE5VTEwgaW4gYSBUb3VjaEV2ZW50LiBWOFRvdWNoRXZlbnQgY2hlY2tzIGZv ciBOVUxMCisgICAgICAgIHRvdWNoZXMoKSwgdGFyZ2V0VG91Y2hlcygpIGFuZCBjaGFuZ2VkVG91 Y2hlcygpLiBTbyBkbyB0aGUgc2FtZSBmb3IgV2ViTW91c2VFdmVudEJ1aWxkZXIuCisKKyAgICAg ICAgKiBzcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJNb3VzZUV2ZW50QnVpbGRlcjo6V2ViTW91c2VFdmVudEJ1aWxkZXIpOgorCiAyMDEyLTEyLTA0 ICBTdGVwaGVuIFdoaXRlICA8c2Vub3JibGFuY29AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJv bGxlZCBERVBTICh3L0xpbnV4IGJ1aWxkIGZpeCkuICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3BwIGIv U291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3BwCmlu ZGV4IGQ4ZTJjYWFmZmYyM2JmYjJlNmE3MzQ1NDlmY2VmNzMyZmE2OTM2YTUuLjZhMzRhNjVkNDI4 NDg5OTE4ZWI0ODE2NTU4Njc2OTg2N2UzOWNkMzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvbi5jcHAKQEAgLTQ3NSw4ICs0 NzUsMTAgQEAgV2ViTW91c2VFdmVudEJ1aWxkZXI6OldlYk1vdXNlRXZlbnRCdWlsZGVyKGNvbnN0 IFdpZGdldCogd2lkZ2V0LCBjb25zdCBXZWJDb3JlOjoKIAogV2ViTW91c2VFdmVudEJ1aWxkZXI6 OldlYk1vdXNlRXZlbnRCdWlsZGVyKGNvbnN0IFdpZGdldCogd2lkZ2V0LCBjb25zdCBXZWJDb3Jl OjpSZW5kZXJPYmplY3QqIHJlbmRlck9iamVjdCwgY29uc3QgVG91Y2hFdmVudCYgZXZlbnQpCiB7 CisgICAgaWYgKCFldmVudC50b3VjaGVzKCkpCisgICAgICAgIHJldHVybjsKICAgICBpZiAoZXZl bnQudG91Y2hlcygpLT5sZW5ndGgoKSAhPSAxKSB7Ci0gICAgICAgIGlmIChldmVudC50b3VjaGVz KCktPmxlbmd0aCgpIHx8IGV2ZW50LnR5cGUoKSAhPSBldmVudE5hbWVzKCkudG91Y2hlbmRFdmVu dCB8fCBldmVudC5jaGFuZ2VkVG91Y2hlcygpLT5sZW5ndGgoKSAhPSAxKQorICAgICAgICBpZiAo ZXZlbnQudG91Y2hlcygpLT5sZW5ndGgoKSB8fCBldmVudC50eXBlKCkgIT0gZXZlbnROYW1lcygp LnRvdWNoZW5kRXZlbnQgfHwgIWV2ZW50LmNoYW5nZWRUb3VjaGVzKCkgfHwgZXZlbnQuY2hhbmdl ZFRvdWNoZXMoKS0+bGVuZ3RoKCkgIT0gMSkKICAgICAgICAgICAgIHJldHVybjsKICAgICB9CiAK 178050 2012-12-06 11:59:14 -0800 2012-12-06 13:14:19 -0800 Patch bug-104098-20121206145638.patch text/plain 3079 sadrul U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDkxMjdkNTM1MGI2ODZmOGJiN2IyMTNiNmU2OTE4MTJiYjQ5NGY3NDQuLjY5NzY4NzhjYzkwMjAy MjhkOGFmZDA3MzI2YzQ0YjYwYTIxNGYzMDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTItMTItMDYgIFNhZHJ1bCBIYWJpYiBDaG93ZGh1cnkgIDxzYWRy dWxAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFtjaHJvbWl1bV0gQWRkIHNvbWUgbnVsbC1jaGVj a3MgZm9yIHRoZSB0b3VjaC1saXN0cyBpbiBUb3VjaEV2ZW50CisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQwOTgKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBpcyBwb3NzaWJsZSBmb3IgdGhlIHRvdWNo LWxpc3RzIHRvIGJlIE5VTEwgaW4gYSBUb3VjaEV2ZW50LiBWOFRvdWNoRXZlbnQgY2hlY2tzIGZv ciBOVUxMCisgICAgICAgIHRvdWNoZXMoKSwgdGFyZ2V0VG91Y2hlcygpIGFuZCBjaGFuZ2VkVG91 Y2hlcygpLiBTbyBkbyB0aGUgc2FtZSBmb3IgV2ViTW91c2VFdmVudEJ1aWxkZXIuCisKKyAgICAg ICAgKiBzcmMvV2ViSW5wdXRFdmVudENvbnZlcnNpb24uY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJNb3VzZUV2ZW50QnVpbGRlcjo6V2ViTW91c2VFdmVudEJ1aWxkZXIpOgorICAgICAgICAqIHRl c3RzL1dlYklucHV0RXZlbnRDb252ZXJzaW9uVGVzdC5jcHA6CisKIDIwMTItMTItMDUgIFN0ZXBo ZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjEzNjczNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vc3JjL1dlYklucHV0RXZlbnRDb252ZXJzaW9uLmNwcAppbmRleCBkOGUyY2FhZmZmMjNiZmIy ZTZhNzM0NTQ5ZmNlZjczMmZhNjkzNmE1Li42YTM0YTY1ZDQyODQ4OTkxOGViNDgxNjU1ODY3Njk4 NjdlMzljZDM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1 dEV2ZW50Q29udmVyc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2Vi SW5wdXRFdmVudENvbnZlcnNpb24uY3BwCkBAIC00NzUsOCArNDc1LDEwIEBAIFdlYk1vdXNlRXZl bnRCdWlsZGVyOjpXZWJNb3VzZUV2ZW50QnVpbGRlcihjb25zdCBXaWRnZXQqIHdpZGdldCwgY29u c3QgV2ViQ29yZTo6CiAKIFdlYk1vdXNlRXZlbnRCdWlsZGVyOjpXZWJNb3VzZUV2ZW50QnVpbGRl cihjb25zdCBXaWRnZXQqIHdpZGdldCwgY29uc3QgV2ViQ29yZTo6UmVuZGVyT2JqZWN0KiByZW5k ZXJPYmplY3QsIGNvbnN0IFRvdWNoRXZlbnQmIGV2ZW50KQogeworICAgIGlmICghZXZlbnQudG91 Y2hlcygpKQorICAgICAgICByZXR1cm47CiAgICAgaWYgKGV2ZW50LnRvdWNoZXMoKS0+bGVuZ3Ro KCkgIT0gMSkgewotICAgICAgICBpZiAoZXZlbnQudG91Y2hlcygpLT5sZW5ndGgoKSB8fCBldmVu dC50eXBlKCkgIT0gZXZlbnROYW1lcygpLnRvdWNoZW5kRXZlbnQgfHwgZXZlbnQuY2hhbmdlZFRv dWNoZXMoKS0+bGVuZ3RoKCkgIT0gMSkKKyAgICAgICAgaWYgKGV2ZW50LnRvdWNoZXMoKS0+bGVu Z3RoKCkgfHwgZXZlbnQudHlwZSgpICE9IGV2ZW50TmFtZXMoKS50b3VjaGVuZEV2ZW50IHx8ICFl dmVudC5jaGFuZ2VkVG91Y2hlcygpIHx8IGV2ZW50LmNoYW5nZWRUb3VjaGVzKCktPmxlbmd0aCgp ICE9IDEpCiAgICAgICAgICAgICByZXR1cm47CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYklucHV0RXZlbnRDb252ZXJzaW9uVGVzdC5jcHAgYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL1dlYklucHV0RXZlbnRDb252ZXJzaW9uVGVzdC5j cHAKaW5kZXggMWRmNzZkYzdjODAwNzc4MDBlOTc5YmZiNTc2M2U3NWE4YTA5ODIyMC4uOWJhOTVj ZGVlNjViYTY3MzUzYWEyYWJhYWVjNjM0MTIwYWZlMDc4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9jaHJvbWl1bS90ZXN0cy9XZWJJbnB1dEV2ZW50Q29udmVyc2lvblRlc3QuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvV2ViSW5wdXRFdmVudENvbnZlcnNpb25UZXN0 LmNwcApAQCAtMzMsMTEgKzMzLDEzIEBACiAjaW5jbHVkZSAiV2ViSW5wdXRFdmVudENvbnZlcnNp b24uaCIKIAogI2luY2x1ZGUgIktleWJvYXJkRXZlbnQuaCIKKyNpbmNsdWRlICJUb3VjaEV2ZW50 LmgiCiAjaW5jbHVkZSA8Z3Rlc3QvZ3Rlc3QuaD4KIAogdXNpbmcgV2ViS2l0OjpXZWJJbnB1dEV2 ZW50OwogdXNpbmcgV2ViS2l0OjpXZWJLZXlib2FyZEV2ZW50OwogdXNpbmcgV2ViS2l0OjpXZWJL ZXlib2FyZEV2ZW50QnVpbGRlcjsKK3VzaW5nIFdlYktpdDo6V2ViTW91c2VFdmVudEJ1aWxkZXI7 CiAKIG5hbWVzcGFjZSB7CiAKQEAgLTcyLDQgKzc0LDExIEBAIFRFU1QoV2ViSW5wdXRFdmVudENv bnZlcnNpb25UZXN0LCBXZWJLZXlib2FyZEV2ZW50QnVpbGRlcikKICAgICBFWFBFQ1RfRkFMU0Uo bW9kaWZpZXJzICYgV2ViSW5wdXRFdmVudDo6SXNMZWZ0IHx8IG1vZGlmaWVycyAmIFdlYklucHV0 RXZlbnQ6OklzUmlnaHQpOwogfQogCitURVNUKFdlYklucHV0RXZlbnRDb252ZXJzaW9uVGVzdCwg V2ViVG91Y2hFdmVudEJ1aWxkZXIpCit7CisgICAgUmVmUHRyPFdlYkNvcmU6OlRvdWNoRXZlbnQ+ IGV2ZW50ID0gV2ViQ29yZTo6VG91Y2hFdmVudDo6Y3JlYXRlKCk7CisgICAgV2ViTW91c2VFdmVu dEJ1aWxkZXIgbW91c2UoMCwgMCwgKmV2ZW50KTsKKyAgICBFWFBFQ1RfRVEoV2ViSW5wdXRFdmVu dDo6VW5kZWZpbmVkLCBtb3VzZS50eXBlKTsKK30KKwogfSAvLyBhbm9ueW1vdXMgbmFtZXNwYWNl Cg==