104090 2012-12-04 22:59:29 -0800 Layout Test fast/css-grid-layout/grid-columns-rows-get-set-multiple.html, grid-columns-rows-get-set.html is failing 2013-01-08 19:22:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tasak jchaffraix dglazkov jchaffraix webkit.review.bot oldest_to_newest 783415 0 tasak 2012-12-04 22:59:29 -0800 The following layout test is failing on Mac(Debug), fast/css-grid-layout/grid-columns-rows-get-set-multiple.html fast/css-grid-layout/grid-columns-rows-get-set.html Probable cause: crash log for DumpRenderTree (pid 1178): STDOUT: <empty> STDERR: ASSERTION FAILED: m_type == LengthTrackSizing STDERR: ../rendering/style/GridTrackSize.h(54) : const WebCore::Length &WebCore::GridTrackSize::length() const STDERR: 1 0x45ce48be WebCore::GridTrackSize::length() const STDERR: 2 0x45ce3e49 WebCore::RenderGrid::computePreferredLogicalWidths() STDERR: 3 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 4 0x45bbe156 WebCore::RenderBlock::computeBlockPreferredLogicalWidths() STDERR: 5 0x45bbc471 WebCore::RenderBlock::computePreferredLogicalWidths() STDERR: 6 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 7 0x45bbe156 WebCore::RenderBlock::computeBlockPreferredLogicalWidths() STDERR: 8 0x45bbc471 WebCore::RenderBlock::computePreferredLogicalWidths() STDERR: 9 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 10 0x45bbe156 WebCore::RenderBlock::computeBlockPreferredLogicalWidths() STDERR: 11 0x45bbc471 WebCore::RenderBlock::computePreferredLogicalWidths() STDERR: 12 0x45e7cd5b WebCore::RenderView::computePreferredLogicalWidths() STDERR: 13 0x45c3dc52 WebCore::RenderBox::minPreferredLogicalWidth() const STDERR: 14 0x435a3876 WebKit::WebFrameImpl::contentsPreferredWidth() const STDERR: 15 0x42e4a050 WebViewHost::didUpdateLayout() STDERR: 16 0x4367e90e WebKit::WebViewImpl::layoutUpdated(WebKit::WebFrameImpl*) STDERR: 17 0x434af33a WebKit::ChromeClientImpl::layoutUpdated(WebCore::Frame*) const STDERR: 18 0x45985a7a WebCore::FrameView::layout(bool) STDERR: 19 0x4597fd92 WebCore::FrameView::layoutTimerFired(WebCore::Timer<WebCore::FrameView>*) STDERR: 20 0x459a7e97 WebCore::Timer<WebCore::FrameView>::fired() STDERR: 21 0x449fb32b WebCore::ThreadTimers::sharedTimerFiredInternal() STDERR: 22 0x449fb0af WebCore::ThreadTimers::sharedTimerFired() 783427 1 tasak 2012-12-04 23:10:33 -0800 Committed r136644: <http://trac.webkit.org/changeset/136644> 802748 2 jchaffraix 2013-01-08 15:43:18 -0800 r139025 / bug 104700 removed the bad call to GridTrackSize::length in RenderGrid::computePreferredLogicalWidths() and the tests don't ASSERT anymore per http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=fast%2Fcss-grid-layout%2Fgrid-columns-rows-get-set-multiple.html I am going to re-enable them. 802840 3 181810 jchaffraix 2013-01-08 17:19:48 -0800 Created attachment 181810 Patch for landing 802908 4 181810 webkit.review.bot 2013-01-08 19:22:49 -0800 Comment on attachment 181810 Patch for landing Clearing flags on attachment: 181810 Committed r139147: <http://trac.webkit.org/changeset/139147> 802909 5 webkit.review.bot 2013-01-08 19:22:52 -0800 All reviewed patches have been landed. Closing bug. 181810 2013-01-08 17:19:48 -0800 2013-01-08 19:22:49 -0800 Patch for landing bug-104090-20130108171652.patch text/plain 1721 jchaffraix SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEzOTEzNikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDEzLTAxLTA4ICBKdWxpZW4gQ2hhZmZyYWl4 ICA8amNoYWZmcmFpeEB3ZWJraXQub3JnPgorCisgICAgICAgIExheW91dCBUZXN0IGZhc3QvY3Nz LWdyaWQtbGF5b3V0L2dyaWQtY29sdW1ucy1yb3dzLWdldC1zZXQtbXVsdGlwbGUuaHRtbCwgZ3Jp ZC1jb2x1bW5zLXJvd3MtZ2V0LXNldC5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDA5MAorCisgICAgICAgIFVucmV2aWV3 ZWQgZ2FyZGVuaW5nLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vVGVzdEV4cGVjdGF0 aW9uczoKKyAgICAgICAgSW4gcjEzOTAyNSwgdGhlIG5vdC10b3RhbGx5LU9LIGNhbGwgdG8gR3Jp ZFRyYWNrU2l6ZTo6bGVuZ3RoKCkgd2FzIHJlbW92ZWQgYW5kIHRodXMgdGhlCisgICAgICAgIHRl c3RzIGRvbid0IHRyaWdnZXIgYW4gQVNTRVJUIGFueW1vcmUuIFRoaXMgY2hhbmdlIG1lcnJpbHkg cmUtZW5hYmxlIHRoZW0uCisKIDIwMTMtMDEtMDggIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxl LmNvbT4KIAogICAgICAgICBERkcgc2hvdWxkbid0IHRyZWF0IHRoZSAndGhpcycgYXJndW1lbnQg YXMgYmVpbmcgY2FwdHVyZWQgaWYgYSBjb2RlIGJsb2NrIHVzZXMgYXJndW1lbnRzCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9UZXN0RXhwZWN0YXRpb25zCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlz aW9uIDEzOTEzNikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL1Rlc3RFeHBlY3Rh dGlvbnMJKHdvcmtpbmcgY29weSkKQEAgLTQyMzIsMTAgKzQyMzIsNiBAQCB3ZWJraXQub3JnL2Iv OTk4MDAgZmFzdC9oYXJuZXNzL3BlcmZ0ZXN0CiB3ZWJraXQub3JnL2IvMTA0MDM1IGZhc3QvdGV4 dC9vcmllbnRhdGlvbi1zaWRld2F5cy5odG1sIFsgTWlzc2luZyBdCiB3ZWJraXQub3JnL2IvMTA0 MTcyIGZhc3QvdGV4dC9kZWNvcmF0aW9ucy13aXRoLXRleHQtY29tYmluZS5odG1sIFsgTWlzc2lu ZyBdCiAKLSMgQ3Jhc2ggc2luY2UgcjEzNjU4OC4KLXdlYmtpdC5vcmcvYi8xMDQwOTAgWyBNYWMg RGVidWcgXSBmYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNvbHVtbnMtcm93cy1nZXQtc2V0LW11 bHRpcGxlLmh0bWwgWyBDcmFzaCBdCi13ZWJraXQub3JnL2IvMTA0MDkwIFsgTWFjIERlYnVnIF0g ZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1jb2x1bW5zLXJvd3MtZ2V0LXNldC5odG1sIFsgQ3Jh c2ggXQotCiB3ZWJraXQub3JnL2IvMTA0MDkyIGZhc3QvZnJhbWVzL3BhaW50LWlmcmFtZS1iYWNr Z3JvdW5kLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogCiB3ZWJraXQub3JnL2IvMTAzNDg3IFsgTGlu dXggXSBmYXN0L2Zvcm1zL3BsYWNlaG9sZGVyLXBvc2l0aW9uLmh0bWwgWyBJbWFnZU9ubHlGYWls dXJlIFBhc3MgXQo=