<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>104083</bug_id>
          
          <creation_ts>2012-12-04 21:08:42 -0800</creation_ts>
          <short_desc>[CMake] Proper encapsulation of WebKit CMake rules</short_desc>
          <delta_ts>2024-08-05 18:56:18 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>EasyFix, GoodFirstBug</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>fujii</cc>
    
    <cc>hugo.lima</cc>
    
    <cc>rakuco</cc>
    
    <cc>ryuan.choi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>783354</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2012-12-04 21:08:42 -0800</bug_when>
    <thetext>It seems to me that many of the rules in the top /CMakeLists.txt should be moved to /Source/CMakeLists.txt as most of the rules in /CMakeLists.txt are only relevant for files under /Source  (and not for example relevant for /Tools).

As an example /Makefile is a good example how to the the encapsulation properly. The top level /CMakeLists.txt should be really only responsible for invoking sub projects under /Source and /Tools and it should not specify details how things under /Source are built.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2050811</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2024-08-05 18:56:18 -0700</bug_when>
    <thetext>This has been done already.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>