104059 2012-12-04 16:20:51 -0800 nrwt: remove two unused parameters from a function 2012-12-05 12:23:12 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103824 1 dpranke dpranke abarth eric ojan rniwa webkit.review.bot oldest_to_newest 783078 0 dpranke 2012-12-04 16:20:51 -0800 nrwt: remove two unused parameters from a function 783079 1 177598 dpranke 2012-12-04 16:21:17 -0800 Created attachment 177598 Patch 783179 2 177598 rniwa 2012-12-04 17:45:28 -0800 Comment on attachment 177598 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177598&action=review > Tools/ChangeLog:3 > + nrwt: remove two unused parameters from a function It would have been better if this bug title referred to interpret_test_failures. > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:60 > """Interpret test failures and returns a test result as dict. You might as well as delete this block comment. It refers to parameters you’re deleting this patch. And comments like: " Args: failures: list of test failures Returns: A dictionary like {'is_missing_text': True, …}" doesn’t add much value beyond the code beneath it. 783187 3 177598 dpranke 2012-12-04 17:55:35 -0800 Comment on attachment 177598 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177598&action=review >> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:60 >> """Interpret test failures and returns a test result as dict. > > You might as well as delete this block comment. It refers to parameters you’re deleting this patch. > And comments like: > " Args: > failures: list of test failures > Returns: > A dictionary like {'is_missing_text': True, …}" > doesn’t add much value beyond the code beneath it. Ah, you're right. Will do. 783987 4 dpranke 2012-12-05 12:23:12 -0800 Committed r136732: <http://trac.webkit.org/changeset/136732> 177598 2012-12-04 16:21:17 -0800 2012-12-04 17:55:35 -0800 Patch bug-104059-20121204161842.patch text/plain 5100 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NTg1CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODgwNTIyZTg5MzY1ZmQ4ZDY0OTVhNGJhZjQ5NTQzMmMy YjY0NzE0NC4uNThkZmU5Y2NmNDgzMTJiZTg1MGI0YjQ5NjY3N2Q4ZTdkNDFkZWY0NCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIw IEBACiAyMDEyLTEyLTA0ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IHJlbW92ZSB0d28gdW51c2VkIHBhcmFtZXRlcnMgZnJvbSBhIGZ1bmN0aW9u CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQwNTkK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbHNvIHJl bW92ZSBhbiBvbGQsIHN0YWxlIEZJWE1FLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weToKKyAgICAgICAgKGludGVycHJldF90 ZXN0X2ZhaWx1cmVzKToKKyAgICAgICAgKHN1bW1hcml6ZV9yZXN1bHRzKToKKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyX3VuaXR0ZXN0 LnB5OgorICAgICAgICAoUmVzdWx0U3VtbWFyeVRlc3QudGVzdF9pbnRlcnByZXRfdGVzdF9mYWls dXJlcyk6CisKKzIwMTItMTItMDQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+ CisKICAgICAgICAgbnJ3dDogcmV0dXJuIHJlc3VsdF9zdW1tYXJpZXMgZnJvbSBMYXlvdXRUZXN0 UnVubmVyLnJ1bl90ZXN0cygpCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMDQwNTEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKaW5kZXggNDc0MTdiNTAzMGNi YmRhOWZmMjY3M2M1YmRkNDcyNWE4ODhiM2Y5MS4uYmRiY2EwYzY0NTcwOTQ1MjFlMDIwYjE3YjI5 MmYzMWRjZjEwNDBlNyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRf dGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CkBAIC01Niw3ICs1Niw3IEBAIEJV SUxERVJfQkFTRV9VUkwgPSAiaHR0cDovL2J1aWxkLmNocm9taXVtLm9yZy9idWlsZGJvdC9sYXlv dXRfdGVzdF9yZXN1bHRzLyIKIFRlc3RFeHBlY3RhdGlvbnMgPSB0ZXN0X2V4cGVjdGF0aW9ucy5U ZXN0RXhwZWN0YXRpb25zCiAKIAotZGVmIGludGVycHJldF90ZXN0X2ZhaWx1cmVzKHBvcnQsIHRl c3RfbmFtZSwgZmFpbHVyZXMpOgorZGVmIGludGVycHJldF90ZXN0X2ZhaWx1cmVzKGZhaWx1cmVz KToKICAgICAiIiJJbnRlcnByZXQgdGVzdCBmYWlsdXJlcyBhbmQgcmV0dXJucyBhIHRlc3QgcmVz dWx0IGFzIGRpY3QuCiAKICAgICBBcmdzOgpAQCAtMTg4LDEwICsxODgsOCBAQCBkZWYgc3VtbWFy aXplX3Jlc3VsdHMocG9ydF9vYmosIGV4cGVjdGF0aW9ucywgcmVzdWx0X3N1bW1hcnksIHJldHJ5 X3N1bW1hcnksIG9ubAogCiAgICAgICAgIHRlc3RfZGljdFsnZXhwZWN0ZWQnXSA9IGV4cGVjdGVk CiAgICAgICAgIHRlc3RfZGljdFsnYWN0dWFsJ10gPSAiICIuam9pbihhY3R1YWwpCi0gICAgICAg ICMgRklYTUU6IFNldCB0aGlzIGNvcnJlY3RseSBvbmNlIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzM3 NzM5IGlzIGZpeGVkCi0gICAgICAgICMgYW5kIG9ubHkgc2V0IGl0IGlmIHRoZXJlIGFjdHVhbGx5 IGlzIHN0ZGVyciBkYXRhLgogCi0gICAgICAgIHRlc3RfZGljdC51cGRhdGUoaW50ZXJwcmV0X3Rl c3RfZmFpbHVyZXMocG9ydF9vYmosIHRlc3RfbmFtZSwgcmVzdWx0LmZhaWx1cmVzKSkKKyAgICAg ICAgdGVzdF9kaWN0LnVwZGF0ZShpbnRlcnByZXRfdGVzdF9mYWlsdXJlcyhyZXN1bHQuZmFpbHVy ZXMpKQogCiAgICAgICAgICMgU3RvcmUgdGVzdCBoaWVyYXJjaGljYWxseSBieSBkaXJlY3Rvcnku IGUuZy4KICAgICAgICAgIyBmb28vYmFyL2Jhei5odG1sOiB0ZXN0X2RpY3QKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXJf dW5pdHRlc3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9jb250cm9s bGVycy9tYW5hZ2VyX3VuaXR0ZXN0LnB5CmluZGV4IGZiNWYxOGNhMWUzMTJhZTVmMWUxMTQzZDBh MTAzOWIzYzgwYzUxNzUuLjJlNWFiODkxOWEyMTY4NmY4Mjg1N2Y5YzNiNzk0NGU0NGRkYmE0NGYg MTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xs ZXJzL21hbmFnZXJfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlv dXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlcl91bml0dGVzdC5weQpAQCAtOTksMzIgKzk5LDI1 IEBAIGNsYXNzIFJlc3VsdFN1bW1hcnlUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKICAgICAgICAg c2VsZi5wb3J0ID0gaG9zdC5wb3J0X2ZhY3RvcnkuZ2V0KHBvcnRfbmFtZT0ndGVzdCcpCiAKICAg ICBkZWYgdGVzdF9pbnRlcnByZXRfdGVzdF9mYWlsdXJlcyhzZWxmKToKLSAgICAgICAgdGVzdF9k aWN0ID0gaW50ZXJwcmV0X3Rlc3RfZmFpbHVyZXMoc2VsZi5wb3J0LCAnZm9vL3JlZnRlc3QuaHRt bCcsCi0gICAgICAgICAgICBbdGVzdF9mYWlsdXJlcy5GYWlsdXJlSW1hZ2VIYXNoTWlzbWF0Y2go ZGlmZl9wZXJjZW50PTAuNDIpXSkKKyAgICAgICAgdGVzdF9kaWN0ID0gaW50ZXJwcmV0X3Rlc3Rf ZmFpbHVyZXMoW3Rlc3RfZmFpbHVyZXMuRmFpbHVyZUltYWdlSGFzaE1pc21hdGNoKGRpZmZfcGVy Y2VudD0wLjQyKV0pCiAgICAgICAgIHNlbGYuYXNzZXJ0RXF1YWwodGVzdF9kaWN0WydpbWFnZV9k aWZmX3BlcmNlbnQnXSwgMC40MikKIAotICAgICAgICB0ZXN0X2RpY3QgPSBpbnRlcnByZXRfdGVz dF9mYWlsdXJlcyhzZWxmLnBvcnQsICdmb28vcmVmdGVzdC5odG1sJywKLSAgICAgICAgICAgIFt0 ZXN0X2ZhaWx1cmVzLkZhaWx1cmVSZWZ0ZXN0TWlzbWF0Y2goc2VsZi5wb3J0LmFic3BhdGhfZm9y X3Rlc3QoJ2Zvby9yZWZ0ZXN0LWV4cGVjdGVkLmh0bWwnKSldKQorICAgICAgICB0ZXN0X2RpY3Qg PSBpbnRlcnByZXRfdGVzdF9mYWlsdXJlcyhbdGVzdF9mYWlsdXJlcy5GYWlsdXJlUmVmdGVzdE1p c21hdGNoKHNlbGYucG9ydC5hYnNwYXRoX2Zvcl90ZXN0KCdmb28vcmVmdGVzdC1leHBlY3RlZC5o dG1sJykpXSkKICAgICAgICAgc2VsZi5hc3NlcnRUcnVlKCdpbWFnZV9kaWZmX3BlcmNlbnQnIGlu IHRlc3RfZGljdCkKIAotICAgICAgICB0ZXN0X2RpY3QgPSBpbnRlcnByZXRfdGVzdF9mYWlsdXJl cyhzZWxmLnBvcnQsICdmb28vcmVmdGVzdC5odG1sJywKLSAgICAgICAgICAgIFt0ZXN0X2ZhaWx1 cmVzLkZhaWx1cmVSZWZ0ZXN0TWlzbWF0Y2hEaWROb3RPY2N1cihzZWxmLnBvcnQuYWJzcGF0aF9m b3JfdGVzdCgnZm9vL3JlZnRlc3QtZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbCcpKV0pCisgICAgICAg IHRlc3RfZGljdCA9IGludGVycHJldF90ZXN0X2ZhaWx1cmVzKFt0ZXN0X2ZhaWx1cmVzLkZhaWx1 cmVSZWZ0ZXN0TWlzbWF0Y2hEaWROb3RPY2N1cihzZWxmLnBvcnQuYWJzcGF0aF9mb3JfdGVzdCgn Zm9vL3JlZnRlc3QtZXhwZWN0ZWQtbWlzbWF0Y2guaHRtbCcpKV0pCiAgICAgICAgIHNlbGYuYXNz ZXJ0RXF1YWwobGVuKHRlc3RfZGljdCksIDApCiAKLSAgICAgICAgdGVzdF9kaWN0ID0gaW50ZXJw cmV0X3Rlc3RfZmFpbHVyZXMoc2VsZi5wb3J0LCAnZm9vL2F1ZGlvLXRlc3QuaHRtbCcsCi0gICAg ICAgICAgICBbdGVzdF9mYWlsdXJlcy5GYWlsdXJlTWlzc2luZ0F1ZGlvKCldKQorICAgICAgICB0 ZXN0X2RpY3QgPSBpbnRlcnByZXRfdGVzdF9mYWlsdXJlcyhbdGVzdF9mYWlsdXJlcy5GYWlsdXJl TWlzc2luZ0F1ZGlvKCldKQogICAgICAgICBzZWxmLmFzc2VydFRydWUoJ2lzX21pc3NpbmdfYXVk aW8nIGluIHRlc3RfZGljdCkKIAotICAgICAgICB0ZXN0X2RpY3QgPSBpbnRlcnByZXRfdGVzdF9m YWlsdXJlcyhzZWxmLnBvcnQsICdmb28vdGV4dC10ZXN0Lmh0bWwnLAotICAgICAgICAgICAgW3Rl c3RfZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdSZXN1bHQoKV0pCisgICAgICAgIHRlc3RfZGljdCA9 IGludGVycHJldF90ZXN0X2ZhaWx1cmVzKFt0ZXN0X2ZhaWx1cmVzLkZhaWx1cmVNaXNzaW5nUmVz dWx0KCldKQogICAgICAgICBzZWxmLmFzc2VydFRydWUoJ2lzX21pc3NpbmdfdGV4dCcgaW4gdGVz dF9kaWN0KQogCi0gICAgICAgIHRlc3RfZGljdCA9IGludGVycHJldF90ZXN0X2ZhaWx1cmVzKHNl bGYucG9ydCwgJ2Zvby9waXhlbC10ZXN0Lmh0bWwnLAotICAgICAgICAgICAgW3Rlc3RfZmFpbHVy ZXMuRmFpbHVyZU1pc3NpbmdJbWFnZSgpXSkKKyAgICAgICAgdGVzdF9kaWN0ID0gaW50ZXJwcmV0 X3Rlc3RfZmFpbHVyZXMoW3Rlc3RfZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdJbWFnZSgpXSkKICAg ICAgICAgc2VsZi5hc3NlcnRUcnVlKCdpc19taXNzaW5nX2ltYWdlJyBpbiB0ZXN0X2RpY3QpCiAK LSAgICAgICAgdGVzdF9kaWN0ID0gaW50ZXJwcmV0X3Rlc3RfZmFpbHVyZXMoc2VsZi5wb3J0LCAn Zm9vL3BpeGVsLXRlc3QuaHRtbCcsCi0gICAgICAgICAgICBbdGVzdF9mYWlsdXJlcy5GYWlsdXJl TWlzc2luZ0ltYWdlSGFzaCgpXSkKKyAgICAgICAgdGVzdF9kaWN0ID0gaW50ZXJwcmV0X3Rlc3Rf ZmFpbHVyZXMoW3Rlc3RfZmFpbHVyZXMuRmFpbHVyZU1pc3NpbmdJbWFnZUhhc2goKV0pCiAgICAg ICAgIHNlbGYuYXNzZXJ0VHJ1ZSgnaXNfbWlzc2luZ19pbWFnZScgaW4gdGVzdF9kaWN0KQogCiAg ICAgZGVmIGdldF9yZXN1bHQoc2VsZiwgdGVzdF9uYW1lLCByZXN1bHRfdHlwZT10ZXN0X2V4cGVj dGF0aW9ucy5QQVNTLCBydW5fdGltZT0wKToK