104048 2012-12-04 15:09:07 -0800 nrwt: move creation of the resultsummary objects into Manager._run_tests() 2012-12-05 12:18:54 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104047 103824 1 dpranke dpranke abarth eric ojan rniwa oldest_to_newest 783006 0 dpranke 2012-12-04 15:09:07 -0800 nrwt: move creation of the resultsummary objects into Manager._run_tests() 783007 1 177581 dpranke 2012-12-04 15:10:03 -0800 Created attachment 177581 Patch 783979 2 dpranke 2012-12-05 12:18:54 -0800 Committed r136730: <http://trac.webkit.org/changeset/136730> 177581 2012-12-04 15:10:03 -0800 2012-12-05 11:51:12 -0800 Patch bug-104048-20121204150729.patch text/plain 6096 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NTgyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjg0ZmE5MjljNDI1MGFhMDBjODBmODYzNjU4OGQ0NGIx ODgzZWNmNC4uMGI1MWIxNTZiZTk2OTI4NGE4YmQ4YzM5M2M1MDdhYzRlNTFmZmMyMiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEyLTEyLTA0ICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IG1vdmUgY3JlYXRpb24gb2YgdGhlIHJlc3VsdHN1bW1hcnkgb2JqZWN0cyBp bnRvIE1hbmFnZXIuX3J1bl90ZXN0cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDQwNDgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGlzIGlzIGEgcHJlcGFyYXRvcnkgc3RlcCB0byBtYWtpbmcgdGhl IHJlc3VsdHN1bW1hcnkganVzdCBnZXQKKyAgICAgICAgcmV0dXJuZWQgZnJvbSB0aGUgbGF5b3V0 X3Rlc3RfcnVubmVyOyB0aGlzIGRvZXMgbW9zdCBvZiBtYW5hZ2VyLXNpZGUKKyAgICAgICAgY2hh bmdlcy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xs ZXJzL21hbmFnZXIucHk6CisgICAgICAgIChNYW5hZ2VyLl9wcmVwYXJlX2xpc3RzKToKKyAgICAg ICAgKE1hbmFnZXIucnVuKToKKyAgICAgICAgKE1hbmFnZXIuX3J1bl90ZXN0cyk6CisKKzIwMTIt MTItMDQgIERpcmsgUHJhbmtlICA8ZHByYW5rZUBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgbnJ3 dDogbWFrZSBwYXRocyBhbmQgdGVzdF9uYW1lcyBwYXNzZWQgYXJndW1lbnRzIGluIE1hbmFnZXIu X3ByZXBhcmVfbGlzdHMgZXQgYWwKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEwNDA0NwogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weQppbmRleCBiYjA5OGQ5NjAz MTE1MDVlOTc1NmFhNzYyYjMzM2NjNjA4Y2FkMzNmLi5jMjJkOTliMWRiODhjZjgzMGQyZWU4OGFl NWYzYjU4ZjRkODVhMjY0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91 dF90ZXN0cy9jb250cm9sbGVycy9tYW5hZ2VyLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJzL21hbmFnZXIucHkKQEAgLTMxNSwxMyArMzE1LDcg QEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgogICAgICAgICBzZWxmLl9leHBlY3RhdGlvbnMuYWRk X3NraXBwZWRfdGVzdHModGVzdHNfaW5fb3RoZXJfY2h1bmtzKQogICAgICAgICB0ZXN0c190b19z a2lwLnVwZGF0ZSh0ZXN0c19pbl9vdGhlcl9jaHVua3MpCiAKLSAgICAgICAgc3VtbWFyeSA9IFJl c3VsdFN1bW1hcnkoc2VsZi5fZXhwZWN0YXRpb25zLCBsZW4odGVzdHNfdG9fcnVuKSAqIHNlbGYu X29wdGlvbnMucmVwZWF0X2VhY2ggKiBzZWxmLl9vcHRpb25zLml0ZXJhdGlvbnMpCi0KLSAgICAg ICAgZm9yIHRlc3RfbmFtZSBpbiBzZXQodGVzdHNfdG9fc2tpcCk6Ci0gICAgICAgICAgICByZXN1 bHQgPSB0ZXN0X3Jlc3VsdHMuVGVzdFJlc3VsdCh0ZXN0X25hbWUpCi0gICAgICAgICAgICByZXN1 bHQudHlwZSA9IHRlc3RfZXhwZWN0YXRpb25zLlNLSVAKLSAgICAgICAgICAgIHN1bW1hcnkuYWRk KHJlc3VsdCwgZXhwZWN0ZWQ9VHJ1ZSwgdGVzdF9pc19zbG93PXNlbGYuX3Rlc3RfaXNfc2xvdyh0 ZXN0X25hbWUpKQotICAgICAgICByZXR1cm4gc3VtbWFyeSwgdGVzdHNfdG9fcnVuCisgICAgICAg IHJldHVybiB0ZXN0c190b19ydW4sIHRlc3RzX3RvX3NraXAKIAogICAgIGRlZiBfdGVzdF9pbnB1 dF9mb3JfZmlsZShzZWxmLCB0ZXN0X2ZpbGUpOgogICAgICAgICByZXR1cm4gVGVzdElucHV0KHRl c3RfZmlsZSwKQEAgLTM4MiwyMyArMzc2LDIzIEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0KToKICAg ICAgICAgc2VsZi5fZXhwZWN0YXRpb25zID0gdGVzdF9leHBlY3RhdGlvbnMuVGVzdEV4cGVjdGF0 aW9ucyhzZWxmLl9wb3J0LCB0ZXN0X25hbWVzKQogCiAgICAgICAgIG51bV9hbGxfdGVzdF9maWxl c19mb3VuZCA9IGxlbih0ZXN0X25hbWVzKQotICAgICAgICByZXN1bHRfc3VtbWFyeSwgdGVzdF9u YW1lcyA9IHNlbGYuX3ByZXBhcmVfbGlzdHMocGF0aHMsIHRlc3RfbmFtZXMpCisgICAgICAgIHRl c3RzX3RvX3J1biwgdGVzdHNfdG9fc2tpcCA9IHNlbGYuX3ByZXBhcmVfbGlzdHMocGF0aHMsIHRl c3RfbmFtZXMpCisKKyAgICAgICAgc2VsZi5fcHJpbnRlci5wcmludF9mb3VuZChudW1fYWxsX3Rl c3RfZmlsZXNfZm91bmQsIGxlbih0ZXN0c190b19ydW4pLCBzZWxmLl9vcHRpb25zLnJlcGVhdF9l YWNoLCBzZWxmLl9vcHRpb25zLml0ZXJhdGlvbnMpCiAKICAgICAgICAgIyBDaGVjayB0byBtYWtl IHN1cmUgd2UncmUgbm90IHNraXBwaW5nIGV2ZXJ5IHRlc3QuCi0gICAgICAgIGlmIG5vdCB0ZXN0 X25hbWVzOgorICAgICAgICBpZiBub3QgdGVzdHNfdG9fcnVuOgogICAgICAgICAgICAgX2xvZy5j cml0aWNhbCgnTm8gdGVzdHMgdG8gcnVuLicpCiAgICAgICAgICAgICByZXR1cm4gLTEKIAotICAg ICAgICBzZWxmLl9wcmludGVyLnByaW50X2ZvdW5kKG51bV9hbGxfdGVzdF9maWxlc19mb3VuZCwg bGVuKHRlc3RfbmFtZXMpLCBzZWxmLl9vcHRpb25zLnJlcGVhdF9lYWNoLCBzZWxmLl9vcHRpb25z Lml0ZXJhdGlvbnMpCi0gICAgICAgIHNlbGYuX3ByaW50ZXIucHJpbnRfZXhwZWN0ZWQocmVzdWx0 X3N1bW1hcnksIHNlbGYuX2V4cGVjdGF0aW9ucy5nZXRfdGVzdHNfd2l0aF9yZXN1bHRfdHlwZSkK LQotICAgICAgICBpZiBub3Qgc2VsZi5fc2V0X3VwX3J1bih0ZXN0X25hbWVzKToKKyAgICAgICAg aWYgbm90IHNlbGYuX3NldF91cF9ydW4odGVzdHNfdG9fcnVuKToKICAgICAgICAgICAgIHJldHVy biAtMQogCiAgICAgICAgIHN0YXJ0X3RpbWUgPSB0aW1lLnRpbWUoKQogCiAgICAgICAgIHRyeToK LSAgICAgICAgICAgIHJlc3VsdF9zdW1tYXJ5ID0gc2VsZi5fcnVuX3Rlc3RzKHRlc3RfbmFtZXMs IHJlc3VsdF9zdW1tYXJ5LCBpbnQoc2VsZi5fb3B0aW9ucy5jaGlsZF9wcm9jZXNzZXMpLCByZXRy eWluZz1GYWxzZSkKKyAgICAgICAgICAgIHJlc3VsdF9zdW1tYXJ5ID0gc2VsZi5fcnVuX3Rlc3Rz KHRlc3RzX3RvX3J1biwgdGVzdHNfdG9fc2tpcCwgc2VsZi5fb3B0aW9ucy5yZXBlYXRfZWFjaCwg c2VsZi5fb3B0aW9ucy5pdGVyYXRpb25zLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgaW50KHNlbGYuX29wdGlvbnMuY2hpbGRfcHJvY2Vzc2VzKSwgcmV0cnlp bmc9RmFsc2UpCiAKICAgICAgICAgICAgICMgV2UgZXhjbHVkZSB0aGUgY3Jhc2hlcyBmcm9tIHRo ZSBsaXN0IG9mIHJlc3VsdHMgdG8gcmV0cnksIGJlY2F1c2UKICAgICAgICAgICAgICMgd2Ugd2Fu dCB0byB0cmVhdCBldmVuIGEgcG90ZW50aWFsbHkgZmxha3kgY3Jhc2ggYXMgYW4gZXJyb3IuCkBA IC00MDgsNyArNDAyLDcgQEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgogICAgICAgICAgICAgICAg IF9sb2cuaW5mbygnJykKICAgICAgICAgICAgICAgICBfbG9nLmluZm8oIlJldHJ5aW5nICVkIHVu ZXhwZWN0ZWQgZmFpbHVyZShzKSAuLi4iICUgbGVuKGZhaWx1cmVzKSkKICAgICAgICAgICAgICAg ICBfbG9nLmluZm8oJycpCi0gICAgICAgICAgICAgICAgcmV0cnlfc3VtbWFyeSA9IHNlbGYuX3J1 bl90ZXN0cyhmYWlsdXJlcywgUmVzdWx0U3VtbWFyeShzZWxmLl9leHBlY3RhdGlvbnMsIGxlbihm YWlsdXJlcykpLCAxLCByZXRyeWluZz1UcnVlKQorICAgICAgICAgICAgICAgIHJldHJ5X3N1bW1h cnkgPSBzZWxmLl9ydW5fdGVzdHMoZmFpbHVyZXMsIHRlc3RzX3RvX3NraXA9c2V0KCksIHJlcGVh dF9lYWNoPTEsIGl0ZXJhdGlvbnM9MSwgbnVtX3dvcmtlcnM9MSwgcmV0cnlpbmc9VHJ1ZSkKICAg ICAgICAgICAgIGVsc2U6CiAgICAgICAgICAgICAgICAgcmV0cnlfc3VtbWFyeSA9IE5vbmUKICAg ICAgICAgZmluYWxseToKQEAgLTQ0MywxNSArNDM3LDI2IEBAIGNsYXNzIE1hbmFnZXIob2JqZWN0 KToKIAogICAgICAgICByZXR1cm4gc2VsZi5fcG9ydC5leGl0X2NvZGVfZnJvbV9zdW1tYXJpemVk X3Jlc3VsdHModW5leHBlY3RlZF9yZXN1bHRzKQogCi0gICAgZGVmIF9ydW5fdGVzdHMoc2VsZiwg dGVzdHMsIHJlc3VsdF9zdW1tYXJ5LCBudW1fd29ya2VycywgcmV0cnlpbmcpOgotICAgICAgICBu ZWVkc19odHRwID0gc2VsZi5fcG9ydC5yZXF1aXJlc19odHRwX3NlcnZlcigpIG9yIGFueShzZWxm Ll9pc19odHRwX3Rlc3QodGVzdCkgZm9yIHRlc3QgaW4gdGVzdHMpCi0gICAgICAgIG5lZWRzX3dl YnNvY2tldHMgPSBhbnkoc2VsZi5faXNfd2Vic29ja2V0X3Rlc3QodGVzdCkgZm9yIHRlc3QgaW4g dGVzdHMpCisgICAgZGVmIF9ydW5fdGVzdHMoc2VsZiwgdGVzdHNfdG9fcnVuLCB0ZXN0c190b19z a2lwLCByZXBlYXRfZWFjaCwgaXRlcmF0aW9ucywgbnVtX3dvcmtlcnMsIHJldHJ5aW5nKToKKyAg ICAgICAgbmVlZHNfaHR0cCA9IHNlbGYuX3BvcnQucmVxdWlyZXNfaHR0cF9zZXJ2ZXIoKSBvciBh bnkoc2VsZi5faXNfaHR0cF90ZXN0KHRlc3QpIGZvciB0ZXN0IGluIHRlc3RzX3RvX3J1bikKKyAg ICAgICAgbmVlZHNfd2Vic29ja2V0cyA9IGFueShzZWxmLl9pc193ZWJzb2NrZXRfdGVzdCh0ZXN0 KSBmb3IgdGVzdCBpbiB0ZXN0c190b19ydW4pCisKKyAgICAgICAgc3VtbWFyeSA9IFJlc3VsdFN1 bW1hcnkoc2VsZi5fZXhwZWN0YXRpb25zLCBsZW4oc2V0KHRlc3RzX3RvX3J1bikpICogcmVwZWF0 X2VhY2ggKiBpdGVyYXRpb25zKQorICAgICAgICBmb3IgdGVzdF9uYW1lIGluIHNldCh0ZXN0c190 b19za2lwKToKKyAgICAgICAgICAgIHJlc3VsdCA9IHRlc3RfcmVzdWx0cy5UZXN0UmVzdWx0KHRl c3RfbmFtZSkKKyAgICAgICAgICAgIHJlc3VsdC50eXBlID0gdGVzdF9leHBlY3RhdGlvbnMuU0tJ UAorICAgICAgICAgICAgc3VtbWFyeS5hZGQocmVzdWx0LCBleHBlY3RlZD1UcnVlLCB0ZXN0X2lz X3Nsb3c9c2VsZi5fdGVzdF9pc19zbG93KHRlc3RfbmFtZSkpCisKICAgICAgICAgdGVzdF9pbnB1 dHMgPSBbXQotICAgICAgICBmb3IgXyBpbiB4cmFuZ2Uoc2VsZi5fb3B0aW9ucy5pdGVyYXRpb25z KToKLSAgICAgICAgICAgIGZvciB0ZXN0IGluIHRlc3RzOgotICAgICAgICAgICAgICAgIGZvciBf IGluIHhyYW5nZShzZWxmLl9vcHRpb25zLnJlcGVhdF9lYWNoKToKKyAgICAgICAgZm9yIF8gaW4g eHJhbmdlKGl0ZXJhdGlvbnMpOgorICAgICAgICAgICAgZm9yIHRlc3QgaW4gdGVzdHNfdG9fcnVu OgorICAgICAgICAgICAgICAgIGZvciBfIGluIHhyYW5nZShyZXBlYXRfZWFjaCk6CiAgICAgICAg ICAgICAgICAgICAgIHRlc3RfaW5wdXRzLmFwcGVuZChzZWxmLl90ZXN0X2lucHV0X2Zvcl9maWxl KHRlc3QpKQotICAgICAgICByZXR1cm4gc2VsZi5fcnVubmVyLnJ1bl90ZXN0cyh0ZXN0X2lucHV0 cywgc2VsZi5fZXhwZWN0YXRpb25zLCByZXN1bHRfc3VtbWFyeSwgbnVtX3dvcmtlcnMsIG5lZWRz X2h0dHAsIG5lZWRzX3dlYnNvY2tldHMsIHJldHJ5aW5nKQorCisgICAgICAgIGlmIG5vdCByZXRy eWluZzoKKyAgICAgICAgICAgIHNlbGYuX3ByaW50ZXIucHJpbnRfZXhwZWN0ZWQoc3VtbWFyeSwg c2VsZi5fZXhwZWN0YXRpb25zLmdldF90ZXN0c193aXRoX3Jlc3VsdF90eXBlKQorCisgICAgICAg IHJldHVybiBzZWxmLl9ydW5uZXIucnVuX3Rlc3RzKHRlc3RfaW5wdXRzLCBzZWxmLl9leHBlY3Rh dGlvbnMsIHN1bW1hcnksIG51bV93b3JrZXJzLCBuZWVkc19odHRwLCBuZWVkc193ZWJzb2NrZXRz LCByZXRyeWluZykKIAogICAgIGRlZiBfY2xlYW5fdXBfcnVuKHNlbGYpOgogICAgICAgICAiIiJS ZXN0b3JlcyB0aGUgc3lzdGVtIGFmdGVyIHdlJ3JlIGRvbmUgcnVubmluZyB0ZXN0cy4iIiIK