104041 2012-12-04 14:04:02 -0800 [BlackBerry] Keep screen updates suspended until after a viewport resize 2012-12-05 13:38:32 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jpetsovits jpetsovits manyoso mifenton rwlbuis staikos tonikitoo webkit.review.bot oldest_to_newest 782909 0 jpetsovits 2012-12-04 14:04:02 -0800 Now that screen and backing store updates can be suspended and resumed separately from each other, we should prevent blits for the whole duration of setViewportSize() and always issue a blit at the end. This would make WebPage::setViewportSize() more robust (no possible way that a blit would end up being performed in a different thread even in case of race conditions) and easier to read/understand. 782918 1 177554 jpetsovits 2012-12-04 14:10:17 -0800 Created attachment 177554 Patch And also fixes a few FIXMEs that were in here from the initial screen/backingstore split of suspend/resumes. 784042 2 177554 manyoso 2012-12-05 13:12:53 -0800 Comment on attachment 177554 Patch LGTM 784069 3 177554 webkit.review.bot 2012-12-05 13:38:29 -0800 Comment on attachment 177554 Patch Clearing flags on attachment: 177554 Committed r136753: <http://trac.webkit.org/changeset/136753> 784070 4 webkit.review.bot 2012-12-05 13:38:32 -0800 All reviewed patches have been landed. Closing bug. 177554 2012-12-04 14:10:17 -0800 2012-12-05 13:38:29 -0800 Patch bug-104041-20121204170731.patch text/plain 4276 jpetsovits U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NTQ3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCAwZjU2NzQ1NDE3YjE1MWMxNzUyMThkMzJlOTAyMmRiNTg0MmQ3NWFlLi5hNjUwMWJmMWYw MWI2ZDViZGY3MzUzYTljYjU1NDIyODY0ZmI5NjM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMi0xMi0wNCAgSmFrb2IgUGV0c292aXRzICA8anBl dHNvdml0c0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBLZWVwIHNjcmVlbiB1cGRh dGVzIHN1c3BlbmRlZCB1bnRpbCBhZnRlciBhIHZpZXdwb3J0IHJlc2l6ZS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDA0MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdyB0aGF0IHNjcmVlbiBhbmQg YmFja2luZyBzdG9yZSB1cGRhdGVzIGNhbiBiZSBzdXNwZW5kZWQKKyAgICAgICAgYW5kIHJlc3Vt ZWQgc2VwYXJhdGVseSBmcm9tIGVhY2ggb3RoZXIsIHByZXZlbnQgYmxpdHMgZm9yCisgICAgICAg IHRoZSB3aG9sZSBkdXJhdGlvbiBvZiBzZXRWaWV3cG9ydFNpemUoKSBhbmQgYWx3YXlzIGlzc3Vl CisgICAgICAgIGEgYmxpdCBhdCB0aGUgZW5kLgorCisgICAgICAgIE1ha2VzIFdlYlBhZ2U6OnNl dFZpZXdwb3J0U2l6ZSgpIG1vcmUgcm9idXN0IGluIHRocmVhZGVkIHVzYWdlLAorICAgICAgICBl YXNpZXIgdG8gcmVhZC91bmRlcnN0YW5kLCBhbmQgZ2V0cyByaWQgb2YgYSBjb3VwbGUgb2YgRklY TUVzLgorCisgICAgICAgICogQXBpL1dlYlBhZ2UuY3BwOgorICAgICAgICAoQmxhY2tCZXJyeTo6 V2ViS2l0OjpXZWJQYWdlUHJpdmF0ZTo6c2V0Vmlld3BvcnRTaXplKToKKwogMjAxMi0xMi0wNCAg TWlrZSBGZW50b24gIDxtaWZlbnRvbkByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBS ZW1vdmUgYXNzZXJ0IGFuZCBmaXggY29uZGl0aW9uYWwgZm9yIG91dCBvZiBib3VuZHMgcmVxdWVz dHMgaW4gSW5wdXRIYW5kbGVyOjpzcGFubmFibGVUZXh0SW5SYW5nZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxh Y2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggYmM0YmJmMTNiMGJmYTQzNGNhMzVjYzc0ZDRl NzczMmNmYTc3YjI2Yy4uY2ZjODBmNGI5NmU1NzViMjJkNzlkNzQ5MWMyN2IzOGFiZTlmN2MxZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBAIC0zNTg1LDkgKzM1 ODUsOSBAQCB2b2lkIFdlYlBhZ2VQcml2YXRlOjpzZXRWaWV3cG9ydFNpemUoY29uc3QgSW50U2l6 ZSYgdHJhbnNmb3JtZWRBY3R1YWxWaXNpYmxlU2l6ZQogCiAgICAgLy8gU3VzcGVuZCBhbGwgc2Ny ZWVuIHVwZGF0ZXMgdG8gdGhlIGJhY2tpbmdzdG9yZSB0byBtYWtlIHN1cmUgbm8tb25lIHRyaWVz IHRvIGJsaXQKICAgICAvLyB3aGlsZSB0aGUgd2luZG93IHN1cmZhY2UgYW5kIHRoZSBCYWNraW5n U3RvcmUgYXJlIG91dCBvZiBzeW5jLgotICAgIC8vIEZJWE1FOiBEbyB3ZSByZWFsbHkgbmVlZCB0 byBzdXNwZW5kL3Jlc3VtZSBib3RoIGJhY2tpbmdzdG9yZSBhbmQgc2NyZWVuIGhlcmU/Ci0gICAg bV9iYWNraW5nU3RvcmUtPmQtPnN1c3BlbmRCYWNraW5nU3RvcmVVcGRhdGVzKCk7CisgICAgQmFj a2luZ1N0b3JlOjpSZXN1bWVVcGRhdGVPcGVyYXRpb24gc2NyZWVuUmVzdW1lT3BlcmF0aW9uID0g QmFja2luZ1N0b3JlOjpCbGl0OwogICAgIG1fYmFja2luZ1N0b3JlLT5kLT5zdXNwZW5kU2NyZWVu VXBkYXRlcygpOworICAgIG1fYmFja2luZ1N0b3JlLT5kLT5zdXNwZW5kQmFja2luZ1N0b3JlVXBk YXRlcygpOwogCiAgICAgLy8gVGhlIHNjcmVlbiByb3RhdGlvbiBpcyBhIG1ham9yIHN0YXRlIHRy YW5zaXRpb24gdGhhdCBpbiB0aGlzIGNhc2UgaXMgbm90IHByb3Blcmx5CiAgICAgLy8gY29tbXVu aWNhdGVkIHRvIHRoZSBiYWNraW5nIHN0b3JlLCBzaW5jZSBpdCBkb2VzIGVhcmx5IHJldHVybiBp biBtb3N0IG1ldGhvZHMgd2hlbgpAQCAtMzcwMyw5ICszNzAzLDcgQEAgdm9pZCBXZWJQYWdlUHJp dmF0ZTo6c2V0Vmlld3BvcnRTaXplKGNvbnN0IEludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlz aWJsZVNpemUKIAogICAgIC8vIE5lZWQgdG8gcmVzdW1lIHNvIHRoYXQgdGhlIGJhY2tpbmdzdG9y ZSB3aWxsIHN0YXJ0IHJlY29yZGluZyB0aGUgaW52YWxpZGF0ZWQKICAgICAvLyByZWN0cyBmcm9t IGJlbG93LgotICAgIC8vIEZJWE1FOiBEbyB3ZSByZWFsbHkgbmVlZCB0byBzdXNwZW5kL3Jlc3Vt ZSBib3RoIGJhY2tpbmdzdG9yZSBhbmQgc2NyZWVuIGhlcmU/CiAgICAgbV9iYWNraW5nU3RvcmUt PmQtPnJlc3VtZUJhY2tpbmdTdG9yZVVwZGF0ZXMoKTsKLSAgICBtX2JhY2tpbmdTdG9yZS0+ZC0+ cmVzdW1lU2NyZWVuVXBkYXRlcyhCYWNraW5nU3RvcmU6Ok5vbmUpOwogCiAgICAgLy8gV2UgbWln aHQgbmVlZCB0byBsYXlvdXQgaGVyZSB0byBnZXQgYSBjb3JyZWN0IGNvbnRlbnRzU2l6ZSBzbyB0 aGF0IHpvb21Ub0ZpdAogICAgIC8vIGlzIGNhbGN1bGF0ZWQgY29ycmVjdGx5LgpAQCAtMzc3Nywx MCArMzc3NSw4IEBAIHZvaWQgV2ViUGFnZVByaXZhdGU6OnNldFZpZXdwb3J0U2l6ZShjb25zdCBJ bnRTaXplJiB0cmFuc2Zvcm1lZEFjdHVhbFZpc2libGVTaXplCiAKICAgICB9IGVsc2UgewogCi0g ICAgICAgIC8vIFN1c3BlbmQgYWxsIHNjcmVlbiB1cGRhdGVzIHRvIHRoZSBiYWNraW5nc3RvcmUu Ci0gICAgICAgIC8vIEZJWE1FOiBEbyB3ZSByZWFsbHkgbmVlZCB0byBzdXNwZW5kL3Jlc3VtZSBi b3RoIGJhY2tpbmdzdG9yZSBhbmQgc2NyZWVuIGhlcmU/CisgICAgICAgIC8vIFN1c3BlbmQgYWxs IHVwZGF0ZXMgdG8gdGhlIGJhY2tpbmdzdG9yZS4KICAgICAgICAgbV9iYWNraW5nU3RvcmUtPmQt PnN1c3BlbmRCYWNraW5nU3RvcmVVcGRhdGVzKCk7Ci0gICAgICAgIG1fYmFja2luZ1N0b3JlLT5k LT5zdXNwZW5kU2NyZWVuVXBkYXRlcygpOwogCiAgICAgICAgIC8vIElmIHRoZSB6b29tIGZhaWxl ZCwgdGhlbiB3ZSBzaG91bGQgc3RpbGwgcHJlc2VydmUgdGhlIHNwZWNpYWwgY2FzZSBvZiBzY3Jv bGwgcG9zaXRpb24uCiAgICAgICAgIEludFBvaW50IHNjcm9sbFBvc2l0aW9uID0gdGhpcy0+c2Ny b2xsUG9zaXRpb24oKTsKQEAgLTM4MDUsMTMgKzM4MDEsMTQgQEAgdm9pZCBXZWJQYWdlUHJpdmF0 ZTo6c2V0Vmlld3BvcnRTaXplKGNvbnN0IEludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJs ZVNpemUKICAgICAgICAgaWYgKG5lZWRzTGF5b3V0KSB7CiAgICAgICAgICAgICBtX2JhY2tpbmdT dG9yZS0+ZC0+cmVzZXRUaWxlcygpOwogICAgICAgICAgICAgbV9iYWNraW5nU3RvcmUtPmQtPnVw ZGF0ZVRpbGVzKGZhbHNlIC8qIHVwZGF0ZVZpc2libGUgKi8sIGZhbHNlIC8qIGltbWVkaWF0ZSAq Lyk7CisgICAgICAgICAgICBzY3JlZW5SZXN1bWVPcGVyYXRpb24gPSBCYWNraW5nU3RvcmU6OlJl bmRlckFuZEJsaXQ7CiAgICAgICAgIH0KIAogICAgICAgICAvLyBJZiB3ZSBuZWVkIGxheW91dCB0 aGVuIHJlbmRlciBhbmQgYmxpdCwgb3RoZXJ3aXNlIGp1c3QgYmxpdCBhcyBvdXIgdmlld3BvcnQg aGFzIGNoYW5nZWQuCi0gICAgICAgIC8vIEZJWE1FOiBEbyB3ZSByZWFsbHkgbmVlZCB0byBzdXNw ZW5kL3Jlc3VtZSBib3RoIGJhY2tpbmdzdG9yZSBhbmQgc2NyZWVuIGhlcmU/CiAgICAgICAgIG1f YmFja2luZ1N0b3JlLT5kLT5yZXN1bWVCYWNraW5nU3RvcmVVcGRhdGVzKCk7Ci0gICAgICAgIG1f YmFja2luZ1N0b3JlLT5kLT5yZXN1bWVTY3JlZW5VcGRhdGVzKG5lZWRzTGF5b3V0ID8gQmFja2lu Z1N0b3JlOjpSZW5kZXJBbmRCbGl0IDogQmFja2luZ1N0b3JlOjpCbGl0KTsKICAgICB9CisKKyAg ICBtX2JhY2tpbmdTdG9yZS0+ZC0+cmVzdW1lU2NyZWVuVXBkYXRlcyhzY3JlZW5SZXN1bWVPcGVy YXRpb24pOwogfQogCiB2b2lkIFdlYlBhZ2U6OnNldFZpZXdwb3J0U2l6ZShjb25zdCBQbGF0Zm9y bTo6SW50U2l6ZSYgdmlld3BvcnRTaXplLCBib29sIGVuc3VyZUZvY3VzRWxlbWVudFZpc2libGUp Cg==