104039 2012-12-04 13:59:57 -0800 Web Inspector: Keep LiveEdit API disabled when idle 2012-12-24 08:01:00 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 prybin webkit-unassigned abarth apavlov haraken japhet keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 782898 0 prybin 2012-12-04 13:59:57 -0800 LiveEdit is a sophisticated routine in V8, and potentially it may have some vulnerabilities. Enable C-level blocks in V8 core, that won't allow LiveEdit code unless actually called LiveEdit command. Related Chromium bug: https://code.google.com/p/chromium/issues/detail?id=159124 786886 1 178444 prybin 2012-12-09 16:03:39 -0800 Created attachment 178444 Patch 787170 2 178444 yurys 2012-12-10 03:45:09 -0800 Comment on attachment 178444 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178444&action=review > Source/WebCore/bindings/v8/ScriptDebugServer.cpp:318 > + EnableLiveEditScope() { v8::Debug::SetLiveEditEnabled(true); } Can it happen that LiveEdit is already on and will be turned off when the scope is destroyed? 787217 3 prybin 2012-12-10 05:15:18 -0800 (In reply to comment #2) > (From update of attachment 178444 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=178444&action=review > > > Source/WebCore/bindings/v8/ScriptDebugServer.cpp:318 > > + EnableLiveEditScope() { v8::Debug::SetLiveEditEnabled(true); } > > Can it happen that LiveEdit is already on and will be turned off when the scope is destroyed? That's possibly, but shouldn't be considered a problem I think. The V8 API is not fully accurate here, because it should also provide getter. However I think we assume the only mode currently: LiveEdit is disabled all the time except when needed. 796976 4 178444 webkit.review.bot 2012-12-24 08:00:56 -0800 Comment on attachment 178444 Patch Clearing flags on attachment: 178444 Committed r138442: <http://trac.webkit.org/changeset/138442> 796977 5 webkit.review.bot 2012-12-24 08:01:00 -0800 All reviewed patches have been landed. Closing bug. 178444 2012-12-09 16:03:39 -0800 2012-12-24 08:00:56 -0800 Patch bug-104039-20121210040100.patch text/plain 2888 prybin U3VidmVyc2lvbiBSZXZpc2lvbjogMTM3MDk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDNkZmYxZjhkZjc3MDIy MjUzMDJmZDFmMDQzY2I5ZTdjMGZkMDY5Yi4uOGUzMTFjMWEwMjE0NDZlMzdiZDU5ZWQwOGQ2N2M3 N2EwNjU3MTIxOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTA5ICBQZXRl ciBSeWJpbiAgPHByeWJpbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog S2VlcCBMaXZlRWRpdCBBUEkgZGlzYWJsZWQgd2hlbiBpZGxlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQwMzkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHdWFyZHMgYXJlIGFkZGVkIHRvIExpdmVFZGl0 IGNhbGwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNjcmlwdERlYnVnU2VydmVyOjpzZXRTY3JpcHRTb3VyY2UpOgorCiAy MDEyLTEyLTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBbR1RLXSBVc2UgR09iamVjdCBjYXN0cyBpbnN0ZWFkIG9mIEMrKyBjYXN0IGZvciBH T2JqZWN0cyBpbiBET00gYmluZGluZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRp bmdzL3Y4L1NjcmlwdERlYnVnU2VydmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdERlYnVnU2VydmVyLmNwcAppbmRleCBiYzdmYWUwOGExYTk0NGFkNjM2MGZlNjE4ZDk4 YzE5MGZhYzEyMzJlLi42YjNmYTdiMTJkYzFmZGQwMDAzMThhMTZhOGRiZGZiYTU2NGFhMGU1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHREZWJ1Z1NlcnZlci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvU2NyaXB0RGVidWdTZXJ2ZXIuY3Bw CkBAIC0zMTMsNiArMzEzLDEyIEBAIGJvb2wgU2NyaXB0RGVidWdTZXJ2ZXI6OmNhblNldFNjcmlw dFNvdXJjZSgpCiAKIGJvb2wgU2NyaXB0RGVidWdTZXJ2ZXI6OnNldFNjcmlwdFNvdXJjZShjb25z dCBTdHJpbmcmIHNvdXJjZUlELCBjb25zdCBTdHJpbmcmIG5ld0NvbnRlbnQsIGJvb2wgcHJldmll dywgU3RyaW5nKiBlcnJvciwgU2NyaXB0VmFsdWUqIG5ld0NhbGxGcmFtZXMsIFNjcmlwdE9iamVj dCogcmVzdWx0KQogeworICAgIGNsYXNzIEVuYWJsZUxpdmVFZGl0U2NvcGUgeworICAgIHB1Ymxp YzoKKyAgICAgICAgRW5hYmxlTGl2ZUVkaXRTY29wZSgpIHsgdjg6OkRlYnVnOjpTZXRMaXZlRWRp dEVuYWJsZWQodHJ1ZSk7IH0KKyAgICAgICAgfkVuYWJsZUxpdmVFZGl0U2NvcGUoKSB7IHY4OjpE ZWJ1Zzo6U2V0TGl2ZUVkaXRFbmFibGVkKGZhbHNlKTsgfQorICAgIH07CisKICAgICBlbnN1cmVE ZWJ1Z2dlclNjcmlwdENvbXBpbGVkKCk7CiAgICAgdjg6OkhhbmRsZVNjb3BlIHNjb3BlOwogCkBA IC0zMjIsMTYgKzMyOCwyMCBAQCBib29sIFNjcmlwdERlYnVnU2VydmVyOjpzZXRTY3JpcHRTb3Vy Y2UoY29uc3QgU3RyaW5nJiBzb3VyY2VJRCwgY29uc3QgU3RyaW5nJiBuZQogCiAgICAgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IGFyZ3ZbXSA9IHsgZGVwcmVjYXRlZFY4U3RyaW5nKHNvdXJjZUlEKSwg ZGVwcmVjYXRlZFY4U3RyaW5nKG5ld0NvbnRlbnQpLCB2OEJvb2xlYW4ocHJldmlldykgfTsKIAot ICAgIHY4OjpUcnlDYXRjaCB0cnlDYXRjaDsKLSAgICB0cnlDYXRjaC5TZXRWZXJib3NlKGZhbHNl KTsKLSAgICB2ODo6TG9jYWw8djg6OlZhbHVlPiB2OHJlc3VsdCA9IGNhbGxEZWJ1Z2dlck1ldGhv ZCgibGl2ZUVkaXRTY3JpcHRTb3VyY2UiLCAzLCBhcmd2KTsKLSAgICBpZiAodHJ5Q2F0Y2guSGFz Q2F1Z2h0KCkpIHsKLSAgICAgICAgdjg6OkxvY2FsPHY4OjpNZXNzYWdlPiBtZXNzYWdlID0gdHJ5 Q2F0Y2guTWVzc2FnZSgpOwotICAgICAgICBpZiAoIW1lc3NhZ2UuSXNFbXB0eSgpKQotICAgICAg ICAgICAgKmVycm9yID0gdG9XZWJDb3JlU3RyaW5nV2l0aFVuZGVmaW5lZE9yTnVsbENoZWNrKG1l c3NhZ2UtPkdldCgpKTsKLSAgICAgICAgZWxzZQotICAgICAgICAgICAgKmVycm9yID0gIlVua25v d24gZXJyb3IuIjsKLSAgICAgICAgcmV0dXJuIGZhbHNlOworICAgIHY4OjpMb2NhbDx2ODo6VmFs dWU+IHY4cmVzdWx0OworICAgIHsKKyAgICAgICAgRW5hYmxlTGl2ZUVkaXRTY29wZSBlbmFibGVM aXZlRWRpdFNjb3BlOworICAgICAgICB2ODo6VHJ5Q2F0Y2ggdHJ5Q2F0Y2g7CisgICAgICAgIHRy eUNhdGNoLlNldFZlcmJvc2UoZmFsc2UpOworICAgICAgICB2OHJlc3VsdCA9IGNhbGxEZWJ1Z2dl ck1ldGhvZCgibGl2ZUVkaXRTY3JpcHRTb3VyY2UiLCAzLCBhcmd2KTsKKyAgICAgICAgaWYgKHRy eUNhdGNoLkhhc0NhdWdodCgpKSB7CisgICAgICAgICAgICB2ODo6TG9jYWw8djg6Ok1lc3NhZ2U+ IG1lc3NhZ2UgPSB0cnlDYXRjaC5NZXNzYWdlKCk7CisgICAgICAgICAgICBpZiAoIW1lc3NhZ2Uu SXNFbXB0eSgpKQorICAgICAgICAgICAgICAgICplcnJvciA9IHRvV2ViQ29yZVN0cmluZ1dpdGhV bmRlZmluZWRPck51bGxDaGVjayhtZXNzYWdlLT5HZXQoKSk7CisgICAgICAgICAgICBlbHNlCisg ICAgICAgICAgICAgICAgKmVycm9yID0gIlVua25vd24gZXJyb3IuIjsKKyAgICAgICAgICAgIHJl dHVybiBmYWxzZTsKKyAgICAgICAgfQogICAgIH0KICAgICBBU1NFUlQoIXY4cmVzdWx0LklzRW1w dHkoKSk7CiAgICAgaWYgKHY4cmVzdWx0LT5Jc09iamVjdCgpKQo=