104037 2012-12-04 13:54:03 -0800 Properly create the header links in the code review tool 2012-12-04 14:49:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan abarth gtk-ews xan.lopez oldest_to_newest 782886 0 ojan 2012-12-04 13:54:03 -0800 Properly create the header links in the code review tool 782891 1 177545 ojan 2012-12-04 13:55:38 -0800 Created attachment 177545 Patch 782915 2 177545 gtk-ews 2012-12-04 14:05:38 -0800 Comment on attachment 177545 Patch Attachment 177545 did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/15132594 782920 3 abarth 2012-12-04 14:13:09 -0800 Omg. I've wanted to fix this forever! 782975 4 ojan 2012-12-04 14:49:07 -0800 Committed r136578: <http://trac.webkit.org/changeset/136578> 177545 2012-12-04 13:55:38 -0800 2012-12-04 14:12:42 -0800 Patch bug-104037-20121204135303.patch text/plain 4694 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NTU2CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndl YmtpdC5vcmcvQ2hhbmdlTG9nIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5nZUxvZwpp bmRleCBjMTdiNzliZjlkMzEwMGY3MDY4MWNlODI1YmU5YTQ1NzZkYjAzYjY3Li4yMGZjZmRmNTE4 ZDhkMjNjOTdjZTNiODI3N2E5MzQ2N2FjMmZmNzUwIDEwMDY0NAotLS0gYS9XZWJzaXRlcy9idWdz LndlYmtpdC5vcmcvQ2hhbmdlTG9nCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMi0xMi0wNCAgT2phbiBWYWZhaSAgPG9qYW5AY2hy b21pdW0ub3JnPgogCisgICAgICAgIFByb3Blcmx5IGNyZWF0ZSB0aGUgaGVhZGVyIGxpbmtzIGlu IHRoZSBjb2RlIHJldmlldyB0b29sCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMDQwMzcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBSaWdodCBub3csIHdlIGp1c3QgcHJlcGVuZCAiaGVhZGVyIiB0byB0aGUg dHdvIGV4aXN0aW5nIGxpbmtzIGFuZCBjaGFuZ2UKKyAgICAgICAgdGhlIGZpcnN0IGxpbmsgdG8g cG9pbnQgdG8gdGhlIGhlYWRlci4gVGhlIHByb2JsZW0gaXMgdGhhdCBqUXVlcnkncyBwcmVwZW5k CisgICAgICAgIG1ldGhvZCBqdXN0IHByZXBlbmRzIHRvIGVhY2ggaXRlbSBpbiB0aGUgalF1ZXJ5 IG9iamVjdCBpbnN0ZWFkIG9mIGFkZGluZworICAgICAgICB0aGUgaXRlbSB0byB0aGUgYmVnaW5u aW5nIG9mIHRoZSBsaXN0IGFzIHRoaXMgY29kZSBhc3N1bWVkLgorCisgICAgICAgICogY29kZS1y ZXZpZXctdGVzdC5odG1sOgorICAgICAgICAqIGNvZGUtcmV2aWV3LmpzOgorCisyMDEyLTEyLTA0 ICBPamFuIFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgQ2FuJ3QgYWRkIGZv bGxvd3VwIGNvbW1lbnQgdG8gYSBwcmV2aW91cyBjb21tZW50CiAgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQwMjUKIApkaWZmIC0tZ2l0IGEvV2Vic2l0 ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3LXRlc3QuaHRtbCBiL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9jb2RlLXJldmlldy10ZXN0Lmh0bWwKaW5kZXggOTVmZWVhMjAzY2M4NzgyNGMz NjQ2ZjNhMDBhMDUzMmQ1MzM2ZmU2NC4uMTg1ZDQzZjBkYTI4M2U2YTkxODZjODIxNjMwYzJjZTA2 ZjE0OWNjOSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL2NvZGUtcmV2aWV3 LXRlc3QuaHRtbAorKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXctdGVz dC5odG1sCkBAIC0yMiw3ICsyMiw3IEBAIGZ1bmN0aW9uIGluaGVyaXRzKGNoaWxkQ29uc3RydWN0 b3IsIHBhcmVudENvbnN0cnVjdG9yKSB7CiB9CiAKIGZ1bmN0aW9uIGxvZyhtc2cpIHsKLSAgICBk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgnb3V0cHV0JykuaW5uZXJIVE1MICs9IG1zZyArICdcblxu JzsKKyAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnb3V0cHV0JykudGV4dENvbnRlbnQgKz0g bXNnICsgJ1xuXG4nOwogfQogCiBmdW5jdGlvbiBBU1NFUlQobXNnLCBhc3NlcnRpb24pIHsKQEAg LTQxLDEwICs0MSwzMiBAQCBmdW5jdGlvbiBBU1NFUlRfRVFVQUwoYWN0dWFsLCBleHBlY3RlZCkg ewogCiBmdW5jdGlvbiB0ZXN0VHJhY0xpbmtzKCkgewogICB2YXIgbGlua3MgPSB0cmFjTGlua3Mo J2Zvby9iYXIvYmF6LmNwcCcsICcnKTsKLSAgQVNTRVJUX0VRVUFMKCQobGlua3MpLmF0dHIoJ2hy ZWYnKSwgJ2h0dHA6Ly90cmFjLndlYmtpdC5vcmcvbG9nL3RydW5rL2Zvby9iYXIvYmF6LmgnKTsK KyAgQVNTRVJUX0VRVUFMKCQoJzxkaXY+JykuYXBwZW5kKGxpbmtzKS5odG1sKCksCisgICAgJzxh IHRhcmdldD0iX2JsYW5rIiBocmVmPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL2xvZy90cnVuay9m b28vYmFyL2Jhei5oIj5oZWFkZXI8L2E+JyArCisgICAgJzxhIHRhcmdldD0iX2JsYW5rIiBocmVm PSJodHRwOi8vdHJhYy53ZWJraXQub3JnL2Jyb3dzZXIvdHJ1bmsvZm9vL2Jhci9iYXouY3BwP2Fu bm90YXRlPWJsYW1lIj5hbm5vdGF0ZTwvYT4nICsKKyAgICAnPGEgdGFyZ2V0PSJfYmxhbmsiIGhy ZWY9Imh0dHA6Ly90cmFjLndlYmtpdC5vcmcvbG9nL3RydW5rL2Zvby9iYXIvYmF6LmNwcCI+cmV2 aXNpb24gbG9nPC9hPicpOwogCiAgIHZhciBsaW5rcyA9IHRyYWNMaW5rcygnZm9vL2Jhci5jcHAv cXV4Lm1tJywgJycpOwotICBBU1NFUlRfRVFVQUwoJChsaW5rcykuYXR0cignaHJlZicpLCAnaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9sb2cvdHJ1bmsvZm9vL2Jhci5jcHAvcXV4LmgnKTsKKyAgQVNT RVJUX0VRVUFMKCQoJzxkaXY+JykuYXBwZW5kKGxpbmtzKS5odG1sKCksCisgICAgJzxhIHRhcmdl dD0iX2JsYW5rIiBocmVmPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL2xvZy90cnVuay9mb28vYmFy LmNwcC9xdXguaCI+aGVhZGVyPC9hPicgKworICAgICc8YSB0YXJnZXQ9Il9ibGFuayIgaHJlZj0i aHR0cDovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3RydW5rL2Zvby9iYXIuY3BwL3F1eC5tbT9h bm5vdGF0ZT1ibGFtZSI+YW5ub3RhdGU8L2E+JyArCisgICAgJzxhIHRhcmdldD0iX2JsYW5rIiBo cmVmPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL2xvZy90cnVuay9mb28vYmFyLmNwcC9xdXgubW0i PnJldmlzaW9uIGxvZzwvYT4KKycpOworCisgIHZhciBsaW5rcyA9IHRyYWNMaW5rcygnZm9vL2Jh ci5oJywgJycpOworICBBU1NFUlRfRVFVQUwoJCgnPGRpdj4nKS5hcHBlbmQobGlua3MpLmh0bWwo KSwKKyAgICAnPGEgdGFyZ2V0PSJfYmxhbmsiIGhyZWY9Imh0dHA6Ly90cmFjLndlYmtpdC5vcmcv YnJvd3Nlci90cnVuay9mb28vYmFyLmg/YW5ub3RhdGU9YmxhbWUiPmFubm90YXRlPC9hPicgKwor ICAgICc8YSB0YXJnZXQ9Il9ibGFuayIgaHJlZj0iaHR0cDovL3RyYWMud2Via2l0Lm9yZy9sb2cv dHJ1bmsvZm9vL2Jhci5oIj5yZXZpc2lvbiBsb2c8L2E+Jyk7CisKKyAgdmFyIGxpbmtzID0gdHJh Y0xpbmtzKCdmb28vYmFyLmd5cGknLCAnJyk7CisgIEFTU0VSVF9FUVVBTCgkKCc8ZGl2PicpLmFw cGVuZChsaW5rcykuaHRtbCgpLAorICAgICc8YSB0YXJnZXQ9Il9ibGFuayIgaHJlZj0iaHR0cDov L3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3RydW5rL2Zvby9iYXIuZ3lwaT9hbm5vdGF0ZT1ibGFt ZSI+YW5ub3RhdGU8L2E+JyArCisgICAgJzxhIHRhcmdldD0iX2JsYW5rIiBocmVmPSJodHRwOi8v dHJhYy53ZWJraXQub3JnL2xvZy90cnVuay9mb28vYmFyLmd5cGkiPnJldmlzaW9uIGxvZzwvYT4n KTsKKworICB2YXIgbGlua3MgPSB0cmFjTGlua3MoJ2Zvby9DaGFuZ2VMb2cnLCAnJyk7CisgIEFT U0VSVF9FUVVBTCgkKCc8ZGl2PicpLmFwcGVuZChsaW5rcykuaHRtbCgpLAorICAgICc8YSB0YXJn ZXQ9Il9ibGFuayIgaHJlZj0iaHR0cDovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3RydW5rL2Zv by9DaGFuZ2VMb2c/YW5ub3RhdGU9YmxhbWUiPmFubm90YXRlPC9hPicgKworICAgICc8YSB0YXJn ZXQ9Il9ibGFuayIgaHJlZj0iaHR0cDovL3RyYWMud2Via2l0Lm9yZy9sb2cvdHJ1bmsvZm9vL0No YW5nZUxvZyI+cmV2aXNpb24gbG9nPC9hPicpOwogfQogCiBmdW5jdGlvbiB0ZXN0RHJhZnRDb21t ZW50U2F2ZXIoKSB7CmRpZmYgLS1naXQgYS9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1y ZXZpZXcuanMgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvY29kZS1yZXZpZXcuanMKaW5kZXgg MzJjN2QxM2EzMmUyNTE1MWViZDJhZTJmMjQ3NjY3YzZjMjEwZmZhZS4uMDliMWE2M2ZjZWMxNWJj ZjM0ODNlZjAyZjUyYjRlMmU0MDhiYWE3MSAxMDA2NDQKLS0tIGEvV2Vic2l0ZXMvYnVncy53ZWJr aXQub3JnL2NvZGUtcmV2aWV3LmpzCisrKyBiL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9yZy9jb2Rl LXJldmlldy5qcwpAQCAtNjM4LDkgKzYzOCwxMCBAQCB2YXIgQ09ERV9SRVZJRVdfVU5JVFRFU1Q7 CiAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCBpbXBsZW1lbnRhdGlvbl9zdWZmaXhfbGlzdC5sZW5n dGg7ICsraSkgewogICAgICAgdmFyIHN1ZmZpeCA9IGltcGxlbWVudGF0aW9uX3N1ZmZpeF9saXN0 W2ldOwogICAgICAgaWYgKGZpbGVfbmFtZS5sYXN0SW5kZXhPZihzdWZmaXgpID09IGZpbGVfbmFt ZS5sZW5ndGggLSBzdWZmaXgubGVuZ3RoKSB7Ci0gICAgICAgIHRyYWNfbGlua3MucHJlcGVuZCgn PGEgdGFyZ2V0PSJfYmxhbmsiPmhlYWRlcjwvYT4nKTsKKyAgICAgICAgdmFyIG5ld19saW5rID0g JCgnPGEgdGFyZ2V0PSJfYmxhbmsiPmhlYWRlcjwvYT4nKTsKICAgICAgICAgdmFyIHN0ZW0gPSBm aWxlX25hbWUuc3Vic3RyKDAsIGZpbGVfbmFtZS5sZW5ndGggLSBzdWZmaXgubGVuZ3RoKTsKLSAg ICAgICAgdHJhY19saW5rc1swXS5ocmVmPSAnaHR0cDovL3RyYWMud2Via2l0Lm9yZy9sb2cvdHJ1 bmsvJyArIHN0ZW0gKyAnLmgnOworICAgICAgICBuZXdfbGlua1swXS5ocmVmPSAnaHR0cDovL3Ry YWMud2Via2l0Lm9yZy9sb2cvdHJ1bmsvJyArIHN0ZW0gKyAnLmgnOworICAgICAgICB0cmFjX2xp bmtzID0gJC5tZXJnZShuZXdfbGluaywgdHJhY19saW5rcyk7CiAgICAgICB9CiAgICAgfQogICAg IHJldHVybiB0cmFjX2xpbmtzOwo=