104013 2012-12-04 10:22:10 -0800 [WK2] URL schemes registered as local, no access, display isolated and as CORS enabled are not registered again after a web process crash 2012-12-05 00:27:36 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 jrocha webkit-unassigned darin webkit.review.bot oldest_to_newest 782675 0 jrocha 2012-12-04 10:22:10 -0800 Although urlSchemesRegisteredAsLocal, urlSchemesRegisteredAsNoAccess, urlSchemesRegisteredAsDisplayIsolated and urlSchemesRegisteredAsCORSEnabled are correctly dealt with in WebProcessCreationParameters and there are methods to register them in WebProcess, those are not called on initializeWebProcess so in case of e.g. a crash, when the web process is relaunched again, these schmes do not get registered. It is an easy fix and I'll upload a patch very soon. 782687 1 177508 jrocha 2012-12-04 10:38:24 -0800 Created attachment 177508 Patch 783463 2 177508 webkit.review.bot 2012-12-05 00:27:33 -0800 Comment on attachment 177508 Patch Clearing flags on attachment: 177508 Committed r136650: <http://trac.webkit.org/changeset/136650> 783465 3 webkit.review.bot 2012-12-05 00:27:36 -0800 All reviewed patches have been landed. Closing bug. 177508 2012-12-04 10:38:24 -0800 2012-12-05 00:27:33 -0800 Patch bug-104013-20121204193523.patch text/plain 2480 jrocha U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDkxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNGI2Yzg1NmM1ZGNlYWFm ODgzZWRkODFhYWYwN2QzMjI1ZDEwNzM4OC4uN2RhOGRhNzk4NzVhZDAxYTk5ZTg0ZDZlM2Q5MGEw NmE3YzI2ZmRkYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTEyLTA0ICBKb2Fx dWltIFJvY2hhICA8anJvY2hhQGlnYWxpYS5jb20+CisKKyAgICAgICAgVVJMIHNjaGVtZXMgcmVn aXN0ZXJlZCBhcyBsb2NhbCwgbm8gYWNjZXNzLCBkaXNwbGF5IGlzb2xhdGVkIGFuZCBhcyBDT1JT IGVuYWJsZWQgYXJlIG5vdCByZWdpc3RlcmVkIGFnYWluIGFmdGVyIGEgd2ViIHByb2Nlc3MgY3Jh c2gKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDAx MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2Vi UHJvY2Vzcy9XZWJQcm9jZXNzLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6aW5p dGlhbGl6ZVdlYlByb2Nlc3MpOiBJdGVyYXRlIHRocm91Z2ggdGhlIHNjaGVtZXMgc3RvcmVkIGlu CisgICAgICAgIHVybFNjaGVtZXNSZWdpc3RlcmVkQXNMb2NhbCwgdXJsU2NoZW1lc1JlZ2lzdGVy ZWRBc05vQWNjZXNzLAorICAgICAgICB1cmxTY2hlbWVzUmVnaXN0ZXJlZEFzRGlzcGxheUlzb2xh dGVkIGFuZCB1cmxTY2hlbWVzUmVnaXN0ZXJlZEFzQ09SU0VuYWJsZWQgYW5kCisgICAgICAgIGNh bGwgdGhlIHJlc3BlY3RpdmUgKGFscmVhZHkgZXhpc3RpbmcpIG1ldGhvZHMgZm9yIHJlZ2lzdGVy aW5nIHRoZW0uCisKIDIwMTItMTItMDQgIEphZWh1biBMaW0gIDxsamFlaHVuLmxpbUBzYW1zdW5n LmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIFVzZSBjb25zaXN0ZW50IGNsYXNzIG5hbWVzIGlu c2lkZSBFd2sgY2xhc3NlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9X ZWJQcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUHJvY2Vzcy5jcHAK aW5kZXggMTYyMTYxMmYyZGE3MTY1OWMwZTRiMzg5MzBlN2VlOTE5ZDAxMGFlMy4uYTA5Y2JiOGQx MTFmYTc3ZTM2NjZkMWY2NmQ3Yjk5ZTgxODg0ZTEyNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlByb2Nlc3MuY3BwCkBAIC0yNzQsNiArMjc0LDE4IEBAIHZvaWQgV2ViUHJvY2Vzczo6 aW5pdGlhbGl6ZVdlYlByb2Nlc3MoY29uc3QgV2ViUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyYg cGFyYW1lCiAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBwYXJhbWV0ZXJzLnVybFNjaGVtZXNG b3JXaGljaERvbWFpblJlbGF4YXRpb25Jc0ZvcmJpZGRlbi5zaXplKCk7ICsraSkKICAgICAgICAg c2V0RG9tYWluUmVsYXhhdGlvbkZvcmJpZGRlbkZvclVSTFNjaGVtZShwYXJhbWV0ZXJzLnVybFNj aGVtZXNGb3JXaGljaERvbWFpblJlbGF4YXRpb25Jc0ZvcmJpZGRlbltpXSk7CiAKKyAgICBmb3Ig KHNpemVfdCBpID0gMDsgaSA8IHBhcmFtZXRlcnMudXJsU2NoZW1lc1JlZ2lzdGVyZWRBc0xvY2Fs LnNpemUoKTsgKytpKQorICAgICAgICByZWdpc3RlclVSTFNjaGVtZUFzTG9jYWwocGFyYW1ldGVy cy51cmxTY2hlbWVzUmVnaXN0ZXJlZEFzTG9jYWxbaV0pOworCisgICAgZm9yIChzaXplX3QgaSA9 IDA7IGkgPCBwYXJhbWV0ZXJzLnVybFNjaGVtZXNSZWdpc3RlcmVkQXNOb0FjY2Vzcy5zaXplKCk7 ICsraSkKKyAgICAgICAgcmVnaXN0ZXJVUkxTY2hlbWVBc05vQWNjZXNzKHBhcmFtZXRlcnMudXJs U2NoZW1lc1JlZ2lzdGVyZWRBc05vQWNjZXNzW2ldKTsKKworICAgIGZvciAoc2l6ZV90IGkgPSAw OyBpIDwgcGFyYW1ldGVycy51cmxTY2hlbWVzUmVnaXN0ZXJlZEFzRGlzcGxheUlzb2xhdGVkLnNp emUoKTsgKytpKQorICAgICAgICByZWdpc3RlclVSTFNjaGVtZUFzRGlzcGxheUlzb2xhdGVkKHBh cmFtZXRlcnMudXJsU2NoZW1lc1JlZ2lzdGVyZWRBc0Rpc3BsYXlJc29sYXRlZFtpXSk7CisKKyAg ICBmb3IgKHNpemVfdCBpID0gMDsgaSA8IHBhcmFtZXRlcnMudXJsU2NoZW1lc1JlZ2lzdGVyZWRB c0NPUlNFbmFibGVkLnNpemUoKTsgKytpKQorICAgICAgICByZWdpc3RlclVSTFNjaGVtZUFzQ09S U0VuYWJsZWQocGFyYW1ldGVycy51cmxTY2hlbWVzUmVnaXN0ZXJlZEFzQ09SU0VuYWJsZWRbaV0p OworCiAgICAgc2V0RGVmYXVsdFJlcXVlc3RUaW1lb3V0SW50ZXJ2YWwocGFyYW1ldGVycy5kZWZh dWx0UmVxdWVzdFRpbWVvdXRJbnRlcnZhbCk7CiAKICAgICBpZiAocGFyYW1ldGVycy5zaG91bGRB bHdheXNVc2VDb21wbGV4VGV4dENvZGVQYXRoKQo=