104003 2012-12-04 08:08:38 -0800 WebKit tests for the Qt API should include tests of CMake config files 2012-12-11 06:04:18 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 steveire webkit-unassigned gyuyoung.kim hausmann rakuco webkit.review.bot oldest_to_newest 782551 0 177483 steveire 2012-12-04 08:08:38 -0800 Created attachment 177483 Add unit test Patch attached. 787149 1 177483 hausmann 2012-12-10 03:13:00 -0800 Comment on attachment 177483 Add unit test Patch looks good in general, but please include a ChangeLog. You can do this for example by calling Tools/Scripts/webkit-patch prepare 104003 The number is the number of this bug, so that the ChangeLog will automatically include a reference to this bug. After calling this command, open the ChangeLog changed files and complete the new entries. Afterwards you can post your patch automatically to bugzilla by using Tools/Scripts/webkit-patch post and you can pass --request-commit as parameter to the post command if you'd like to get the patch landed automatically using the commit queue. (you probably want this unless you are a committer yourself or you know somebody how is going to care of landing the change in SVN) 788319 2 178777 steveire 2012-12-11 04:28:56 -0800 Created attachment 178777 Patch 788372 3 178777 hausmann 2012-12-11 06:02:14 -0800 Comment on attachment 178777 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=178777&action=review > Source/WebKit/qt/ChangeLog:6 > + Rubber-stamped by Simon Hausmann. This field should've been left as is the NOBODY (OOPS) line) because it's not known in advance who the reviewer is (usually) or if it's a rubber stamp or not. r=me on the patch anyway, I'll land it manually. 788374 4 hausmann 2012-12-11 06:04:18 -0800 Committed r137302: <http://trac.webkit.org/changeset/137302> 177483 2012-12-04 08:08:38 -0800 2012-12-11 04:28:48 -0800 Add unit test 0001-Add-unit-tests-for-the-CMake-config-files.patch text/plain 1726 steveire RnJvbSA5YzA3NGQwYjNkNzk0ZmZkZGViZTg3MTQ3ODJjMmNiMzFhZWMwODYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVwaGVuIEtlbGx5IDxzdGVwaGVuLmtlbGx5QGtkYWIuY29t PgpEYXRlOiBUdWUsIDQgRGVjIDIwMTIgMTc6MDI6MzkgKzAxMDAKU3ViamVjdDogW1BBVENIXSBB ZGQgdW5pdCB0ZXN0cyBmb3IgdGhlIENNYWtlIGNvbmZpZyBmaWxlcy4KCi0tLQogU291cmNlL1dl YktpdC9xdC90ZXN0cy9jbWFrZS9DTWFrZUxpc3RzLnR4dCB8ICAgMTcgKysrKysrKysrKysrKysr KysKIFNvdXJjZS9XZWJLaXQvcXQvdGVzdHMvY21ha2UvY21ha2UucHJvICAgICAgfCAgICA1ICsr KysrCiBTb3VyY2UvdGVzdHMucHJpICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAgMSAr CiAzIGZpbGVzIGNoYW5nZWQsIDIzIGluc2VydGlvbnMoKykKIGNyZWF0ZSBtb2RlIDEwMDY0NCBT b3VyY2UvV2ViS2l0L3F0L3Rlc3RzL2NtYWtlL0NNYWtlTGlzdHMudHh0CiBjcmVhdGUgbW9kZSAx MDA2NDQgU291cmNlL1dlYktpdC9xdC90ZXN0cy9jbWFrZS9jbWFrZS5wcm8KCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL2NtYWtlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dl YktpdC9xdC90ZXN0cy9jbWFrZS9DTWFrZUxpc3RzLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwLi44ZjI2NmZjCi0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dlYktpdC9x dC90ZXN0cy9jbWFrZS9DTWFrZUxpc3RzLnR4dApAQCAtMCwwICsxLDE3IEBACisKK2NtYWtlX21p bmltdW1fcmVxdWlyZWQoVkVSU0lPTiAyLjgpCisKK3Byb2plY3QocW1ha2VfY21ha2VfZmlsZXMp CisKK2VuYWJsZV90ZXN0aW5nKCkKKworZmluZF9wYWNrYWdlKFF0NUNvcmUgUkVRVUlSRUQpCisK K2luY2x1ZGUoIiR7X1F0NUNUZXN0TWFjcm9zfSIpCisKK3NldChRdDVfTU9EVUxFX1RFU1RfREVQ RU5EUyBXaWRnZXRzKQorCit0ZXN0X21vZHVsZV9pbmNsdWRlcygKKyAgV2ViS2l0IFFXZWJFbGVt ZW50CisgIFdlYktpdFdpZGdldHMgUVdlYlZpZXcKKykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvcXQvdGVzdHMvY21ha2UvY21ha2UucHJvIGIvU291cmNlL1dlYktpdC9xdC90ZXN0cy9jbWFr ZS9jbWFrZS5wcm8KbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uYmYyZGJjYgot LS0gL2Rldi9udWxsCisrKyBiL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvY21ha2UvY21ha2UucHJv CkBAIC0wLDAgKzEsNSBAQAorCisjIENhdXNlIG1ha2UgdG8gZG8gbm90aGluZy4KK1RFTVBMQVRF ID0gc3ViZGlycworCitDT05GSUcgKz0gY3Rlc3RfdGVzdGNhc2UKZGlmZiAtLWdpdCBhL1NvdXJj ZS90ZXN0cy5wcmkgYi9Tb3VyY2UvdGVzdHMucHJpCmluZGV4IDk4MWZiOWIuLmRhNzUzOGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS90ZXN0cy5wcmkKKysrIGIvU291cmNlL3Rlc3RzLnByaQpAQCAtMTAs NiArMTAsNyBAQCBDT05GSUcgKz0gb3JkZXJlZAogV0VCS0lUX1RFU1RTX0RJUiA9ICQkUFdEL1dl YktpdC9xdC90ZXN0cwogCiBTVUJESVJTICs9IFwKKyAgICAkJFdFQktJVF9URVNUU19ESVIvY21h a2UgXAogICAgICQkV0VCS0lUX1RFU1RTX0RJUi9xb2JqZWN0YnJpZGdlIFwKICAgICAkJFdFQktJ VF9URVNUU19ESVIvcXdlYmZyYW1lIFwKICAgICAkJFdFQktJVF9URVNUU19ESVIvcXdlYnBhZ2Ug XAotLSAKMS43LjEwLjQKCg== 178777 2012-12-11 04:28:56 -0800 2012-12-11 06:02:14 -0800 Patch bug-104003-20121211132617.patch text/plain 2869 steveire U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L3F0 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDBiNzIyNTBlOGYz MmRiN2ZmMGJjMWRlZWFlOTI2OWVmZGJkZDFjNmEuLjM3ODMzYjQ0MzliYjYyYTI4YTk3MDFhMTQx NjM4OWUwOGY4MTA5N2MgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1NvdXJjZS9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTIt MTEgIFN0ZXBoZW4gS2VsbHkgIDxzdGVwaGVuLmtlbGx5QGtkYWIuY29tPgorCisgICAgICAgIFdl YktpdCB0ZXN0cyBmb3IgdGhlIFF0IEFQSSBzaG91bGQgaW5jbHVkZSB0ZXN0cyBvZiBDTWFrZSBj b25maWcgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEwNDAwMworCisgICAgICAgIFJ1YmJlci1zdGFtcGVkIGJ5IFNpbW9uIEhhdXNtYW5uLgor CisgICAgICAgIFRoZSBRdCBXZWJLaXQgQ0kgc3lzdGVtIGlzIG5vdCBnb2luZyB0byBydW4gdGhp cyB0ZXN0LCBidXQgaXQgY2FuCisgICAgICAgIGJlIHJ1biBsb2NhbGx5IGFuZCB0byB0ZXN0IHBh Y2thZ2VzLgorCisgICAgICAgICogdGVzdHMvY21ha2UvQ01ha2VMaXN0cy50eHQ6IEFkZGVkLgor ICAgICAgICAqIHRlc3RzL2NtYWtlL2NtYWtlLnBybzogQWRkZWQuCisKIDIwMTItMTEtMzAgIFBp ZXJyZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBnbWFpbC5jb20+CiAKICAgICAgICAgW1F0XSBJbnRy b2R1Y2Ugc2V0VGV4dFNpemVNdWx0aXBsaWVyIGluIHRoZSBwYWdlIGFkYXB0ZXIgYXMgd2VsbC4K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvcXQvdGVzdHMvY21ha2UvQ01ha2VMaXN0cy50eHQg Yi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL2NtYWtlL0NNYWtlTGlzdHMudHh0Cm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LjhmMjY2ZmNjYjQ4YzI3ZTJmNDFlMWNjMjc0MzViOGIzMDBlOWI1NWUKLS0tIC9kZXYvbnVsbAor KysgYi9Tb3VyY2UvV2ViS2l0L3F0L3Rlc3RzL2NtYWtlL0NNYWtlTGlzdHMudHh0CkBAIC0wLDAg KzEsMTcgQEAKKworY21ha2VfbWluaW11bV9yZXF1aXJlZChWRVJTSU9OIDIuOCkKKworcHJvamVj dChxbWFrZV9jbWFrZV9maWxlcykKKworZW5hYmxlX3Rlc3RpbmcoKQorCitmaW5kX3BhY2thZ2Uo UXQ1Q29yZSBSRVFVSVJFRCkKKworaW5jbHVkZSgiJHtfUXQ1Q1Rlc3RNYWNyb3N9IikKKworc2V0 KFF0NV9NT0RVTEVfVEVTVF9ERVBFTkRTIFdpZGdldHMpCisKK3Rlc3RfbW9kdWxlX2luY2x1ZGVz KAorICBXZWJLaXQgUVdlYkVsZW1lbnQKKyAgV2ViS2l0V2lkZ2V0cyBRV2ViVmlldworKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9xdC90ZXN0cy9jbWFrZS9jbWFrZS5wcm8gYi9Tb3VyY2Uv V2ViS2l0L3F0L3Rlc3RzL2NtYWtlL2NtYWtlLnBybwpuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5iZjJkYmNiNzcyY2Mx MWYxM2QwY2YwOWEzNDE5YzJhMzU5OTYyYzE3Ci0tLSAvZGV2L251bGwKKysrIGIvU291cmNlL1dl YktpdC9xdC90ZXN0cy9jbWFrZS9jbWFrZS5wcm8KQEAgLTAsMCArMSw1IEBACisKKyMgQ2F1c2Ug bWFrZSB0byBkbyBub3RoaW5nLgorVEVNUExBVEUgPSBzdWJkaXJzCisKK0NPTkZJRyArPSBjdGVz dF90ZXN0Y2FzZQpkaWZmIC0tZ2l0IGEvU291cmNlL3Rlc3RzLnByaSBiL1NvdXJjZS90ZXN0cy5w cmkKaW5kZXggOTgxZmI5Yjg2YTFjZjQ3ZDUzOWU1ZGMzMWMzYWQyZmI5NjNiZDQxMS4uZGE3NTM4 YjBhNGQ4OTY1NjE0NzM4YTQyM2I2ZWMwYzkzNmY5NDhlNCAxMDA2NDQKLS0tIGEvU291cmNlL3Rl c3RzLnByaQorKysgYi9Tb3VyY2UvdGVzdHMucHJpCkBAIC0xMCw2ICsxMCw3IEBAIENPTkZJRyAr PSBvcmRlcmVkCiBXRUJLSVRfVEVTVFNfRElSID0gJCRQV0QvV2ViS2l0L3F0L3Rlc3RzCiAKIFNV QkRJUlMgKz0gXAorICAgICQkV0VCS0lUX1RFU1RTX0RJUi9jbWFrZSBcCiAgICAgJCRXRUJLSVRf VEVTVFNfRElSL3FvYmplY3RicmlkZ2UgXAogICAgICQkV0VCS0lUX1RFU1RTX0RJUi9xd2ViZnJh bWUgXAogICAgICQkV0VCS0lUX1RFU1RTX0RJUi9xd2VicGFnZSBcCmRpZmYgLS1naXQgYS9DaGFu Z2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggMjc4MjVmODlkNWU2MTExNGNkZDliMWM5ZDJhNzVkYmJl MzdhYmRiYy4uYmI4ZDg1ZDBhNTMwNTY3MWUwZWNiNmNkODkwMjBhYzgwMTRhODhhMyAxMDA2NDQK LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEy LTExICBTdGVwaGVuIEtlbGx5ICA8c3RlcGhlbi5rZWxseUBrZGFiLmNvbT4KKworICAgICAgICBX ZWJLaXQgdGVzdHMgZm9yIHRoZSBRdCBBUEkgc2hvdWxkIGluY2x1ZGUgdGVzdHMgb2YgQ01ha2Ug Y29uZmlnIGZpbGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMDQwMDMKKworICAgICAgICBSdWJiZXItc3RhbXBlZCBieSBTaW1vbiBIYXVzbWFubi4K KworICAgICAgICBUaGUgUXQgV2ViS2l0IENJIHN5c3RlbSBpcyBub3QgZ29pbmcgdG8gcnVuIHRo aXMgdGVzdCwgYnV0IGl0IGNhbgorICAgICAgICBiZSBydW4gbG9jYWxseSBhbmQgdG8gdGVzdCBw YWNrYWdlcy4KKworICAgICAgICAqIFNvdXJjZS90ZXN0cy5wcmk6CisKIDIwMTItMTEtMzAgIFNp bW9uIEhhdXNtYW5uICA8c2ltb24uaGF1c21hbm5AZGlnaWEuY29tPgogCiAgICAgICAgIFtRdF0g VW5yZXZpZXdlZCBkb2MgZml4Cg==