104000 2012-12-04 07:27:50 -0800 [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies. 2012-12-05 09:57:10 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 104101 0 k.czech webkit-unassigned apinheiro cfleizach dmazzoni g.czajkowski jdiggs lucas.de.marchi webkit.review.bot oldest_to_newest 782531 0 k.czech 2012-12-04 07:27:50 -0800 Assistive Technologies should find a way to distinguish WebKit-EFL. 782540 1 177480 k.czech 2012-12-04 07:53:50 -0800 Created attachment 177480 [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies 782547 2 g.czajkowski 2012-12-04 08:03:14 -0800 LGTM. 782570 3 dmazzoni 2012-12-04 08:27:59 -0800 Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.) 782668 4 177480 cfleizach 2012-12-04 10:19:54 -0800 Comment on attachment 177480 [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies View in context: https://bugs.webkit.org/attachment.cgi?id=177480&action=review > Source/WebCore/ChangeLog:8 > + Introduce Webkit-EFL so that Assistive Technologies could distinguish it. ...so that Assistive Technologies "can" distinguish it. 782670 5 cfleizach 2012-12-04 10:20:25 -0800 (In reply to comment #3) > Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.) I agree with dominic here. Once that's done, it looks ready to go. 783522 6 177696 k.czech 2012-12-05 01:41:07 -0800 Created attachment 177696 [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies 783529 7 k.czech 2012-12-05 01:46:54 -0800 (In reply to comment #4) > (From update of attachment 177480 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177480&action=review > > > Source/WebCore/ChangeLog:8 > > + Introduce Webkit-EFL so that Assistive Technologies could distinguish it. > > ...so that Assistive Technologies "can" distinguish it. Thank you. Done. 783531 8 k.czech 2012-12-05 01:47:06 -0800 (In reply to comment #5) > (In reply to comment #3) > > Looks great, but should this maybe be two changes? (One to modify attributeSet, and one to fix the table tests, which is unrelated.) > > I agree with dominic here. Once that's done, it looks ready to go. Done. 783868 9 177696 webkit.review.bot 2012-12-05 09:57:07 -0800 Comment on attachment 177696 [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies Clearing flags on attachment: 177696 Committed r136710: <http://trac.webkit.org/changeset/136710> 783869 10 webkit.review.bot 2012-12-05 09:57:10 -0800 All reviewed patches have been landed. Closing bug. 177480 2012-12-04 07:53:50 -0800 2012-12-05 01:41:07 -0800 [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies introduce-efl-to-at.patch text/plain 4542 k.czech ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5OGVhNDVmLi4yODdhN2VkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTItMTIt MDQgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0VG TF1bV0syXSBJbnRyb2R1Y2UgV2ViS2l0LUVGTCB0byBBc3Npc3RpdmUgVGVjaG5vbG9naWVzCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDQwMDAKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRlZCBFRkwg YmFzZWxpbmVzIGZvciBhY2Nlc3NpYmlsaXR5L3RhYmxlLWNlbGxzLmh0bWwgYW5kIGFjY2Vzc2li aWxpdHkvdGFibGUtY2VsbC1zcGFucy5odG1sLgorCisgICAgICAgICogcGxhdGZvcm0vZWZsLXdr Mi9UZXN0RXhwZWN0YXRpb25zOgorICAgICAgICAqIHBsYXRmb3JtL2VmbC13azIvYWNjZXNzaWJp bGl0eS90YWJsZS1jZWxsLXNwYW5zLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxh dGZvcm0vZWZsLXdrMi9hY2Nlc3NpYmlsaXR5L3RhYmxlLWNlbGxzLWV4cGVjdGVkLnR4dDogQWRk ZWQuCisKIDIwMTItMTItMDMgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3JnPgog CiAgICAgICAgIFVucmV2aWV3ZWQgUXQgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZv cm0vZWZsLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IDg0MGM5ZjMuLmU5NzcxMDEgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvVGVzdEV4cGVjdGF0aW9ucworKysg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTI5Miw4 ICsyOTIsNiBAQCBhY2Nlc3NpYmlsaXR5L3JhZGlvLWJ1dHRvbi1ncm91cC1tZW1iZXJzLmh0bWwg WyBTa2lwIF0KIGFjY2Vzc2liaWxpdHkvc3ZnLWJvdW5kcy5odG1sIFsgU2tpcCBdCiBhY2Nlc3Np YmlsaXR5L3N2Zy1pbWFnZS5odG1sIFsgU2tpcCBdCiBhY2Nlc3NpYmlsaXR5L3RhYmxlLWF0dHJp YnV0ZXMuaHRtbCBbIFNraXAgXQotYWNjZXNzaWJpbGl0eS90YWJsZS1jZWxsLXNwYW5zLmh0bWwg WyBTa2lwIF0KLWFjY2Vzc2liaWxpdHkvdGFibGUtY2VsbHMuaHRtbCBbIFNraXAgXQogYWNjZXNz aWJpbGl0eS90YWJsZS1kZXRlY3Rpb24uaHRtbCBbIFNraXAgXQogYWNjZXNzaWJpbGl0eS90YWJs ZS1vbmUtY2VsbC5odG1sIFsgU2tpcCBdCiBhY2Nlc3NpYmlsaXR5L3RhYmxlLXNlY3Rpb25zLmh0 bWwgWyBTa2lwIF0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvYWNj ZXNzaWJpbGl0eS90YWJsZS1jZWxsLXNwYW5zLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL3Bs YXRmb3JtL2VmbC13azIvYWNjZXNzaWJpbGl0eS90YWJsZS1jZWxsLXNwYW5zLWV4cGVjdGVkLnR4 dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi5hYTIwYzRkCi0tLSAvZGV2L251 bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZWZsLXdrMi9hY2Nlc3NpYmlsaXR5L3RhYmxl LWNlbGwtc3BhbnMtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMzkgQEAKK0NlbGwgQQorQ09MU1BB Tj0iMiIKK1JPV1NQQU49IjIiCUNlbGwgQgorQ09MU1BBTj0iMiIKKzIsMwkyLDQKK0NlbGwgQwor Uk9XU1BBTj0iMiIJMywyCTMsMwkzLDQKKzQsMgk0LDMJNCw0CistLS0tLS0tLS0tLS0tLS0tLS0t LS0tCit7IDAsIDAgfQordG9vbGtpdDpXZWJLaXRFZmwKK3swLCAyfSwgezAsIDJ9CisKKy0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KK3sgMSwgMSB9Cit0b29sa2l0OldlYktpdEVmbAorezAsIDJ9LCB7 MCwgMn0KKworLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQoreyAzLCAwIH0KK3Rvb2xraXQ6V2ViS2l0 RWZsCit7MiwgMn0sIHswLCAxfQorCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tCit7IDIsIDAgfQor dG9vbGtpdDpXZWJLaXRFZmwKK3syLCAyfSwgezAsIDF9CisKKy0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KK3sgMiwgMyB9Cit0b29sa2l0OldlYktpdEVmbAorezIsIDF9LCB7MywgMX0KKworLS0tLS0t LS0tLS0tLS0tLS0tLS0tLQoreyAxMCwgMTAgfQorCit7MCwgMH0sIHswLCAwfQorCisKZGlmZiAt LWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2VmbC13azIvYWNjZXNzaWJpbGl0eS90YWJsZS1j ZWxscy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9lZmwtd2syL2FjY2Vzc2li aWxpdHkvdGFibGUtY2VsbHMtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4 IDAwMDAwMDAuLmZjYzYzNDIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9y bS9lZmwtd2syL2FjY2Vzc2liaWxpdHkvdGFibGUtY2VsbHMtZXhwZWN0ZWQudHh0CkBAIC0wLDAg KzEsMzIgQEAKK0V4YW1wbGUgIzE6IE5lc3RlZCBTdHVicworUnVyaXRhbmlhbgorUG9wdWxhdGlv biAKK1N1cnZleQlBbGwKK0dlbmRlcnMJQnkgR2VuZGVyCitNYWxlcwlGZW1hbGVzCitBbGwgUmVn aW9ucwlOb3J0aAkzMzMzCTExMTEJMjIyMgorU291dGgJMzMzMwkxMTExCTIyMjIKK1NvdXRoCTMz MzMJMTExMQkyMjIyCitTb3V0aAkzMzMzCTExMTEJMjIyMgorLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tCitbMCwwXQordG9vbGtpdDpXZWJLaXRFZmwKKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQor WzMsMV0KK3Rvb2xraXQ6V2ViS2l0RWZsCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK1sxLDFd Cit0b29sa2l0OldlYktpdEVmbAorLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCitbMiwyXQordG9v bGtpdDpXZWJLaXRFZmwKKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQorWzMsNV0KK3Rvb2xraXQ6 V2ViS2l0RWZsCistLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KK1sxMDAsMF0KKworLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tCitbMCwxMDBdCisKKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDllZDBlMzcuLjk2NWEx NDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0xMi0wNCAgS3J6eXN6dG9mIEN6 ZWNoICA8ay5jemVjaEBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXVtXSzJdIEludHJvZHVj ZSBXZWJLaXQtRUZMIHRvIEFzc2lzdGl2ZSBUZWNobm9sb2dpZXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwNDAwMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEludHJvZHVjZSBXZWJraXQtRUZMIHNvIHRo YXQgQXNzaXN0aXZlIFRlY2hub2xvZ2llcyBjb3VsZCBkaXN0aW5ndWlzaCBpdC4KKworICAgICAg ICAqIGFjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcDoKKyAg ICAgICAgKHdlYmtpdEFjY2Vzc2libGVHZXRBdHRyaWJ1dGVzKToKKwogMjAxMi0xMi0wMyAgVG9t bXkgV2lkZW5mbHljaHQgIDx0b21teXdAZ29vZ2xlLmNvbT4KIAogICAgICAgICBTcGVlY2ggUmVj b2duaXRpb24gQVBJOiBVcGRhdGUgU3BlZWNoUmVjb2duaXRpb25FdmVudCB0byBtYXRjaCB0aGUg c3BlY2lmaWNhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9h dGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCmluZGV4IGJkNzhkNWMu LmRlZmQ5YzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dl YktpdEFjY2Vzc2libGVXcmFwcGVyQXRrLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3Np YmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5jcHAKQEAgLTQzNiw2ICs0MzYs OCBAQCBzdGF0aWMgQXRrQXR0cmlidXRlU2V0KiB3ZWJraXRBY2Nlc3NpYmxlR2V0QXR0cmlidXRl cyhBdGtPYmplY3QqIG9iamVjdCkKICAgICBBdGtBdHRyaWJ1dGVTZXQqIGF0dHJpYnV0ZVNldCA9 IDA7CiAjaWYgUExBVEZPUk0oR1RLKQogICAgIGF0dHJpYnV0ZVNldCA9IGFkZFRvQXRrQXR0cmli dXRlU2V0KGF0dHJpYnV0ZVNldCwgInRvb2xraXQiLCAiV2ViS2l0R3RrIik7CisjZWxpZiBQTEFU Rk9STShFRkwpCisgICAgYXR0cmlidXRlU2V0ID0gYWRkVG9BdGtBdHRyaWJ1dGVTZXQoYXR0cmli dXRlU2V0LCAidG9vbGtpdCIsICJXZWJLaXRFZmwiKTsKICNlbmRpZgogCiAgICAgQWNjZXNzaWJp bGl0eU9iamVjdCogY29yZU9iamVjdCA9IGNvcmUob2JqZWN0KTsK 177696 2012-12-05 01:41:07 -0800 2012-12-05 09:57:06 -0800 [EFL][WK2] Introduce WebKit-EFL to Assistive Technologies introduce-efl-to-at.patch text/plain 1433 k.czech ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZWQwZTM3Li5lMTRiMDU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMTItMDQgIEtyenlzenRvZiBDemVjaCAgPGsuY3plY2hAc2Ftc3VuZy5jb20+CisK KyAgICAgICAgW0VGTF1bV0syXSBJbnRyb2R1Y2UgV2ViS2l0LUVGTCB0byBBc3Npc3RpdmUgVGVj aG5vbG9naWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDQwMDAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJbnRyb2R1Y2UgV2Via2l0LUVGTCBzbyB0aGF0IEFzc2lzdGl2ZSBUZWNobm9sb2dpZXMgY2Fu IGRpc3Rpbmd1aXNoIGl0LgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNj ZXNzaWJsZVdyYXBwZXJBdGsuY3BwOgorICAgICAgICAod2Via2l0QWNjZXNzaWJsZUdldEF0dHJp YnV0ZXMpOgorCiAyMDEyLTEyLTAzICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15d0Bnb29nbGUu Y29tPgogCiAgICAgICAgIFNwZWVjaCBSZWNvZ25pdGlvbiBBUEk6IFVwZGF0ZSBTcGVlY2hSZWNv Z25pdGlvbkV2ZW50IHRvIG1hdGNoIHRoZSBzcGVjaWZpY2F0aW9uCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3JhcHBlckF0ay5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0ay9XZWJLaXRBY2Nlc3NpYmxlV3Jh cHBlckF0ay5jcHAKaW5kZXggYmQ3OGQ1Yy4uZGVmZDljNSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9hdGsvV2ViS2l0QWNjZXNzaWJsZVdyYXBwZXJBdGsuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRrL1dlYktpdEFjY2Vzc2libGVXcmFw cGVyQXRrLmNwcApAQCAtNDM2LDYgKzQzNiw4IEBAIHN0YXRpYyBBdGtBdHRyaWJ1dGVTZXQqIHdl YmtpdEFjY2Vzc2libGVHZXRBdHRyaWJ1dGVzKEF0a09iamVjdCogb2JqZWN0KQogICAgIEF0a0F0 dHJpYnV0ZVNldCogYXR0cmlidXRlU2V0ID0gMDsKICNpZiBQTEFURk9STShHVEspCiAgICAgYXR0 cmlidXRlU2V0ID0gYWRkVG9BdGtBdHRyaWJ1dGVTZXQoYXR0cmlidXRlU2V0LCAidG9vbGtpdCIs ICJXZWJLaXRHdGsiKTsKKyNlbGlmIFBMQVRGT1JNKEVGTCkKKyAgICBhdHRyaWJ1dGVTZXQgPSBh ZGRUb0F0a0F0dHJpYnV0ZVNldChhdHRyaWJ1dGVTZXQsICJ0b29sa2l0IiwgIldlYktpdEVmbCIp OwogI2VuZGlmCiAKICAgICBBY2Nlc3NpYmlsaXR5T2JqZWN0KiBjb3JlT2JqZWN0ID0gY29yZShv YmplY3QpOwo=