103997 2012-12-04 07:20:58 -0800 Web Inspector: Can't take a heap snapshot in chromium ("Uncaught ReferenceError") 2012-12-04 13:55:38 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All Linux RESOLVED FIXED P2 Normal --- 1 marja yurys apavlov eae keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 782524 0 marja 2012-12-04 07:20:58 -0800 Tried this with chromium trunk build, chromium revision is r170925 and WebKit revision is 136420. Repro steps: load a simple page, try to take a heap snapshot. This error is printed immediate: [15265:15265:1204/161033:ERROR:CONSOLE(3213)] "Uncaught ReferenceError: window is not defined", source: chrome-devtools://devtools/HeapSnapshotWorker.js (3213) ... and the dev tools UI keeps waiting forever. 782602 1 177498 yurys 2012-12-04 09:24:27 -0800 Created attachment 177498 Patch 782626 2 177498 webkit.review.bot 2012-12-04 09:43:48 -0800 Comment on attachment 177498 Patch Rejecting attachment 177498 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ripts/update-webkit line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit 16b6329..69df7e9 HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at 69df7e90d827085e08064fe2060b71e2a596ead5 but expected 16b6329a5796e11a418c6e68e9effd8d7e1537bf ! 16b6329..69df7e9 master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15147111 782727 3 177498 webkit.review.bot 2012-12-04 11:05:34 -0800 Comment on attachment 177498 Patch Clearing flags on attachment: 177498 Committed r136534: <http://trac.webkit.org/changeset/136534> 782728 4 webkit.review.bot 2012-12-04 11:05:38 -0800 All reviewed patches have been landed. Closing bug. 782771 5 eae 2012-12-04 11:57:47 -0800 This broke the css3/filters/effect-reference-hw.html test. Is the change in rendering expected? 782772 6 eae 2012-12-04 11:58:05 -0800 http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=css3%2Ffilters%2Feffect-reference-hw.html 782890 7 yurys 2012-12-04 13:55:38 -0800 (In reply to comment #5) > This broke the css3/filters/effect-reference-hw.html test. Is the change in rendering expected? The change could not affect that test, it was limited to inspector front-end which is not even loaded in case of the filter tests. 177498 2012-12-04 09:24:27 -0800 2012-12-04 11:05:34 -0800 Patch bug-103997-20121204212151.patch text/plain 4741 yurys U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjZkNzRjMTYxOWQ0YWE3 OGJmYWU1ZTFhNWZhOTRiZDA2MDZmZDIyYS4uMDhmY2Q3MzU0ZWY2MDE1OTA2NjZhZWNiNGYzY2Vm ZDExMmFhMGJjMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTA0ICBZdXJ5 IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IENhbid0IHRha2UgYSBoZWFwIHNuYXBzaG90IGluIGNocm9taXVtICgiVW5jYXVnaHQgUmVm ZXJlbmNlRXJyb3IiKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAzOTk3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgdXRpbGl0aWVzLmpzIHVzZWQgaW4gYm90aCBwYWdlIGFuZCB3b3JrZXIgY29udGV4dHMg c2hvdWxkIG5vdCBhY2Nlc3Mgd2luZG93CisgICAgICAgIG9iamVjdCBhcyB0aGVyZSBpcyBubyBv bmUgaW4gY2FzZSBvZiB3b3JrZXJzLiBOb25MZWFraW5nTXV0YXRpb25PYnNlcnZlciBpbXBsZW1l bnRhdGlvbgorICAgICAgICBoYXMgbW92ZWQgdG8gRE9NRXh0ZW5zaW9uLmpzCisKKyAgICAgICAg KiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RPTUV4dGVuc2lvbi5qczoKKyAgICAgICAgKE5vbkxlYWtp bmdNdXRhdGlvbk9ic2VydmVyLk5vbkxlYWtpbmdNdXRhdGlvbk9ic2VydmVyLl91bmxvYWRMaXN0 ZW5lcik6CisgICAgICAgIChOb25MZWFraW5nTXV0YXRpb25PYnNlcnZlcik6CisgICAgICAgIChO b25MZWFraW5nTXV0YXRpb25PYnNlcnZlci5wcm90b3R5cGUub2JzZXJ2ZSk6CisgICAgICAgIChO b25MZWFraW5nTXV0YXRpb25PYnNlcnZlci5wcm90b3R5cGUuZGlzY29ubmVjdCk6CisgICAgICAg ICogaW5zcGVjdG9yL2Zyb250LWVuZC91dGlsaXRpZXMuanM6CisKIDIwMTItMTItMDMgIFBpZXJy ZSBSb3NzaSAgPHBpZXJyZS5yb3NzaUBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBVbnJldmll d2VkIGJ1aWxkIGZpeCBhZnRlciByMTM2NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvZnJvbnQtZW5kL0RPTUV4dGVuc2lvbi5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9mcm9udC1lbmQvRE9NRXh0ZW5zaW9uLmpzCmluZGV4IDViZmNkMjIzM2M4ODgzNTkxODhj MjhiMDc3OWVmNWE5M2E0NTZiYTUuLjNmMWUxNzNlZGUyNmM0NDBhMTgzMjk3NzQ3ZTM4NGEwNWVi Njc5ODIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9N RXh0ZW5zaW9uLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRE9N RXh0ZW5zaW9uLmpzCkBAIC01NDcsMyArNTQ3LDQ3IEBAIGZ1bmN0aW9uIGNvbnN1bWVFdmVudChl KQogewogICAgIGUuY29uc3VtZSgpOwogfQorCit3aW5kb3cuaXNVbmRlclRlc3QgPSBmYWxzZTsK KworLyoqCisgKiBNdXRhdGlvbiBvYnNlcnZlcnMgbGVhayBtZW1vcnkuIEtlZXAgdHJhY2sgb2Yg dGhlbSBhbmQgZGlzY29ubmVjdAorICogb24gdW5sb2FkLgorICogQGNvbnN0cnVjdG9yCisgKiBA cGFyYW0ge2Z1bmN0aW9uKEFycmF5LjxXZWJLaXRNdXRhdGlvbj4pfSBoYW5kbGVyCisgKi8KK2Z1 bmN0aW9uIE5vbkxlYWtpbmdNdXRhdGlvbk9ic2VydmVyKGhhbmRsZXIpCit7CisgICAgdGhpcy5f b2JzZXJ2ZXIgPSBuZXcgV2ViS2l0TXV0YXRpb25PYnNlcnZlcihoYW5kbGVyKTsKKyAgICBOb25M ZWFraW5nTXV0YXRpb25PYnNlcnZlci5faW5zdGFuY2VzLnB1c2godGhpcyk7CisgICAgaWYgKCF3 aW5kb3cudGVzdFJ1bm5lciAmJiAhd2luZG93LmlzVW5kZXJUZXN0ICYmICFOb25MZWFraW5nTXV0 YXRpb25PYnNlcnZlci5fdW5sb2FkTGlzdGVuZXIpIHsKKyAgICAgICAgTm9uTGVha2luZ011dGF0 aW9uT2JzZXJ2ZXIuX3VubG9hZExpc3RlbmVyID0gZnVuY3Rpb24oKSB7CisgICAgICAgICAgICB3 aGlsZSAoTm9uTGVha2luZ011dGF0aW9uT2JzZXJ2ZXIuX2luc3RhbmNlcy5sZW5ndGgpCisgICAg ICAgICAgICAgICAgTm9uTGVha2luZ011dGF0aW9uT2JzZXJ2ZXIuX2luc3RhbmNlc1tOb25MZWFr aW5nTXV0YXRpb25PYnNlcnZlci5faW5zdGFuY2VzLmxlbmd0aCAtIDFdLmRpc2Nvbm5lY3QoKTsK KyAgICAgICAgfTsKKyAgICAgICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoInVubG9hZCIsIE5v bkxlYWtpbmdNdXRhdGlvbk9ic2VydmVyLl91bmxvYWRMaXN0ZW5lciwgZmFsc2UpOworICAgIH0K K30KKworTm9uTGVha2luZ011dGF0aW9uT2JzZXJ2ZXIuX2luc3RhbmNlcyA9IFtdOworCitOb25M ZWFraW5nTXV0YXRpb25PYnNlcnZlci5wcm90b3R5cGUgPSB7CisgICAgLyoqCisgICAgICogQHBh cmFtIHtFbGVtZW50fSBlbGVtZW50CisgICAgICogQHBhcmFtIHtPYmplY3R9IGNvbmZpZworICAg ICAqLworICAgIG9ic2VydmU6IGZ1bmN0aW9uKGVsZW1lbnQsIGNvbmZpZykKKyAgICB7CisgICAg ICAgIGlmICh0aGlzLl9vYnNlcnZlcikKKyAgICAgICAgICAgIHRoaXMuX29ic2VydmVyLm9ic2Vy dmUoZWxlbWVudCwgY29uZmlnKTsKKyAgICB9LAorCisgICAgZGlzY29ubmVjdDogZnVuY3Rpb24o KQorICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX29ic2VydmVyKQorICAgICAgICAgICAgdGhpcy5f b2JzZXJ2ZXIuZGlzY29ubmVjdCgpOworICAgICAgICBOb25MZWFraW5nTXV0YXRpb25PYnNlcnZl ci5faW5zdGFuY2VzLnJlbW92ZSh0aGlzKTsKKyAgICAgICAgZGVsZXRlIHRoaXMuX29ic2VydmVy OworICAgIH0KK30KKwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250 LWVuZC91dGlsaXRpZXMuanMgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0 aWxpdGllcy5qcwppbmRleCBiNGJiZWM1MTAzNzM1OTNhMGMyOWY1ZTE4OTk2ZWRlNDMxMzYwNjJl Li4yNzIxZGFkNGViZGQ2MGMwNmVjMTNhNjllMjg3NzljN2Y5ZTA2NDc5IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL3V0aWxpdGllcy5qcwpAQCAtODYwLDQ3ICs4 NjAsMyBAQCBmdW5jdGlvbiBpbXBvcnRTY3JpcHQoc2NyaXB0TmFtZSkKICAgICB4aHIuc2VuZChu dWxsKTsKICAgICB3aW5kb3cuZXZhbCh4aHIucmVzcG9uc2VUZXh0ICsgIlxuLy9AIHNvdXJjZVVS TD0iICsgc2NyaXB0TmFtZSk7CiB9Ci0KLXdpbmRvdy5pc1VuZGVyVGVzdCA9IGZhbHNlOwotCi0v KioKLSAqIE11dGF0aW9uIG9ic2VydmVycyBsZWFrIG1lbW9yeS4gS2VlcCB0cmFjayBvZiB0aGVt IGFuZCBkaXNjb25uZWN0Ci0gKiBvbiB1bmxvYWQuCi0gKiBAY29uc3RydWN0b3IKLSAqIEBwYXJh bSB7ZnVuY3Rpb24oQXJyYXkuPFdlYktpdE11dGF0aW9uPil9IGhhbmRsZXIKLSAqLwotZnVuY3Rp b24gTm9uTGVha2luZ011dGF0aW9uT2JzZXJ2ZXIoaGFuZGxlcikKLXsKLSAgICB0aGlzLl9vYnNl cnZlciA9IG5ldyBXZWJLaXRNdXRhdGlvbk9ic2VydmVyKGhhbmRsZXIpOwotICAgIE5vbkxlYWtp bmdNdXRhdGlvbk9ic2VydmVyLl9pbnN0YW5jZXMucHVzaCh0aGlzKTsKLSAgICBpZiAoIXdpbmRv dy50ZXN0UnVubmVyICYmICF3aW5kb3cuaXNVbmRlclRlc3QgJiYgIU5vbkxlYWtpbmdNdXRhdGlv bk9ic2VydmVyLl91bmxvYWRMaXN0ZW5lcikgewotICAgICAgICBOb25MZWFraW5nTXV0YXRpb25P YnNlcnZlci5fdW5sb2FkTGlzdGVuZXIgPSBmdW5jdGlvbigpIHsKLSAgICAgICAgICAgIHdoaWxl IChOb25MZWFraW5nTXV0YXRpb25PYnNlcnZlci5faW5zdGFuY2VzLmxlbmd0aCkKLSAgICAgICAg ICAgICAgICBOb25MZWFraW5nTXV0YXRpb25PYnNlcnZlci5faW5zdGFuY2VzW05vbkxlYWtpbmdN dXRhdGlvbk9ic2VydmVyLl9pbnN0YW5jZXMubGVuZ3RoIC0gMV0uZGlzY29ubmVjdCgpOwotICAg ICAgICB9OwotICAgICAgICB3aW5kb3cuYWRkRXZlbnRMaXN0ZW5lcigidW5sb2FkIiwgTm9uTGVh a2luZ011dGF0aW9uT2JzZXJ2ZXIuX3VubG9hZExpc3RlbmVyLCBmYWxzZSk7Ci0gICAgfQotfQot Ci1Ob25MZWFraW5nTXV0YXRpb25PYnNlcnZlci5faW5zdGFuY2VzID0gW107Ci0KLU5vbkxlYWtp bmdNdXRhdGlvbk9ic2VydmVyLnByb3RvdHlwZSA9IHsKLSAgICAvKioKLSAgICAgKiBAcGFyYW0g e0VsZW1lbnR9IGVsZW1lbnQKLSAgICAgKiBAcGFyYW0ge09iamVjdH0gY29uZmlnCi0gICAgICov Ci0gICAgb2JzZXJ2ZTogZnVuY3Rpb24oZWxlbWVudCwgY29uZmlnKQotICAgIHsKLSAgICAgICAg aWYgKHRoaXMuX29ic2VydmVyKQotICAgICAgICAgICAgdGhpcy5fb2JzZXJ2ZXIub2JzZXJ2ZShl bGVtZW50LCBjb25maWcpOwotICAgIH0sCi0KLSAgICBkaXNjb25uZWN0OiBmdW5jdGlvbigpCi0g ICAgewotICAgICAgICBpZiAodGhpcy5fb2JzZXJ2ZXIpCi0gICAgICAgICAgICB0aGlzLl9vYnNl cnZlci5kaXNjb25uZWN0KCk7Ci0gICAgICAgIE5vbkxlYWtpbmdNdXRhdGlvbk9ic2VydmVyLl9p bnN0YW5jZXMucmVtb3ZlKHRoaXMpOwotICAgICAgICBkZWxldGUgdGhpcy5fb2JzZXJ2ZXI7Ci0g ICAgfQotfQotCg==