103978 2012-12-04 00:26:09 -0800 [V8] Remove IntegerCache::m_initialized 2012-12-04 16:34:02 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 haraken haraken abarth japhet webkit.review.bot oldest_to_newest 782315 0 haraken 2012-12-04 00:26:09 -0800 Thanks to r136479, we can now initialize V8 integers in IntegerCache's constructor. We can remove IntegerCache::m_initialized, which slightly improves performance. BTW, v8Integer() looks much slower than JSC's one. (https://docs.google.com/a/google.com/spreadsheet/ccc?key=0ArGPzKNdEGeQdGItaF8yVVVMM2trS3R5VW1heDFmcGc#gid=2) 782318 1 177434 haraken 2012-12-04 00:29:24 -0800 Created attachment 177434 Patch 782323 2 haraken 2012-12-04 00:32:13 -0800 I'll replace Persistent handles with ScopedPersistents in a follow-up patch. 782654 3 177434 abarth 2012-12-04 10:09:27 -0800 Comment on attachment 177434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177434&action=review > Source/WebCore/bindings/v8/V8ValueCache.cpp:103 > -void IntegerCache::createSmallIntegers(v8::Isolate* isolate) > +IntegerCache::IntegerCache() I probably would have passed in isolate to the constructor, but this is fine too. 782655 4 abarth 2012-12-04 10:09:35 -0800 (In reply to comment #2) > I'll replace Persistent handles with ScopedPersistents in a follow-up patch. Thanks. 783090 5 haraken 2012-12-04 16:33:28 -0800 Committed r136590: <http://trac.webkit.org/changeset/136590> 783091 6 177434 haraken 2012-12-04 16:34:02 -0800 Comment on attachment 177434 Patch Landed manually. 177434 2012-12-04 00:29:24 -0800 2012-12-04 16:34:02 -0800 Patch bug-103978-20121204172649.patch text/plain 4310 haraken U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDc5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjdiYjBiZjk5NTM1Yjgx NjIxOGRlMWFlNjQzZGQyOTJhZWQ3MjY3MS4uODkwYTc3MzdiZTdmZjA1ZjllNzJmOTVjMTgyYjQx NjYzMjFjNjUyMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDEyLTEyLTA0ICBLZW50 YXJvIEhhcmEgIDxoYXJha2VuQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIFJlbW92ZSBJ bnRlZ2VyQ2FjaGU6Om1faW5pdGlhbGl6ZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEwMzk3OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoYW5rcyB0byByMTM2NDc5LCB3ZSBjYW4gbm93IGluaXRpYWxp emUgVjggaW50ZWdlcnMgaW4gSW50ZWdlckNhY2hlJ3MKKyAgICAgICAgY29uc3RydWN0b3IuIFdl IGNhbiByZW1vdmUgSW50ZWdlckNhY2hlOjptX2luaXRpYWxpemVkLCB3aGljaCBzbGlnaHRseQor ICAgICAgICBpbXByb3ZlcyBwZXJmb3JtYW5jZS4KKworICAgICAgICBbQmluZGluZ3Mvc2Nyb2xs LXRvcC5odG1sIGluIENocm9taXVtL0xpbnV4XQorICAgICAgICBCZWZvcmUgdGhpcyBwYXRjaDog Mjg1IHJ1bnMvc2VjLCAyODEgcnVucy9zZWMsIDI4MSBydW5zL3NlYywgMjgwIHJ1bnMvc2VjCisg ICAgICAgIEFmdGVyIHRoaXMgcGF0Y2ggOiAyOTAgcnVucy9zZWMsIDI5MSBydW5zL3NlYywgMjk3 IHJ1bnMvc2VjLCAyOTEgcnVucy9zZWMKKworICAgICAgICBObyB0ZXN0cy4gTm8gY2hhbmdlIGlu IGJlaGF2aW9yLgorCisgICAgICAgICogYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hlLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OkludGVnZXJDYWNoZTo6SW50ZWdlckNhY2hlKToKKyAgICAgICAgKFdl YkNvcmU6OkludGVnZXJDYWNoZTo6fkludGVnZXJDYWNoZSk6CisgICAgICAgICogYmluZGluZ3Mv djgvVjhWYWx1ZUNhY2hlLmg6CisgICAgICAgIChJbnRlZ2VyQ2FjaGUpOgorICAgICAgICAoV2Vi Q29yZTo6SW50ZWdlckNhY2hlOjp2OEludGVnZXIpOgorICAgICAgICAoV2ViQ29yZTo6SW50ZWdl ckNhY2hlOjp2OFVuc2lnbmVkSW50ZWdlcik6CisgICAgICAgIChXZWJDb3JlKToKKwogMjAxMi0x Mi0wMyAgS2VudGFybyBIYXJhICA8aGFyYWtlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW1Y4 XSBFbnRlciBhbiBJc29sYXRlIGJlZm9yZSBpbml0aWFsaXppbmcgUGVySXNvbGF0ZURhdGEKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4VmFsdWVDYWNoZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUuY3BwCmluZGV4IDY0NjgzMjNj ZTI5Mjc5NTE0MDRjY2QwNDg2NjdhYWMyY2VhN2JmYTAuLmNkNzcxMTNkZjQzNzdlYWMxN2U5ZGY1 NzU3MDRjYjM4OTk0NDRkODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1Y4VmFsdWVDYWNoZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhWYWx1 ZUNhY2hlLmNwcApAQCAtMTAwLDI1ICsxMDAsMTggQEAgdjg6OkxvY2FsPHY4OjpTdHJpbmc+IFN0 cmluZ0NhY2hlOjp2OEV4dGVybmFsU3RyaW5nU2xvdyhTdHJpbmdJbXBsKiBzdHJpbmdJbXBsLAog ICAgIHJldHVybiBuZXdTdHJpbmc7CiB9CiAKLXZvaWQgSW50ZWdlckNhY2hlOjpjcmVhdGVTbWFs bEludGVnZXJzKHY4OjpJc29sYXRlKiBpc29sYXRlKQorSW50ZWdlckNhY2hlOjpJbnRlZ2VyQ2Fj aGUoKQogewotICAgIEFTU0VSVCghbV9pbml0aWFsaXplZCk7Ci0gICAgLy8gV2UgaW5pdGlhbGl6 ZSBtX3NtYWxsSW50ZWdlcnMgbm90IGluIGEgY29uc3RydWN0b3IgYnV0IGluIHY4SW50ZWdlcigp LAotICAgIC8vIGJlY2F1c2UgSW50ZWdlcjo6TmV3KCkgcmVxdWlyZXMgYSBIYW5kbGVTY29wZS4g QXQgdGhlIHBvaW50IHdoZXJlCi0gICAgLy8gSW50ZWdlckNhY2hlIGlzIGNvbnN0cnVjdGVkLCBh IEhhbmRsZVNjb3BlIG1pZ2h0IG5vdCBleGlzdC4KKyAgICB2ODo6SGFuZGxlU2NvcGUgaGFuZGxl U2NvcGU7CiAgICAgZm9yIChpbnQgdmFsdWUgPSAwOyB2YWx1ZSA8IG51bWJlck9mQ2FjaGVkU21h bGxJbnRlZ2VyczsgdmFsdWUrKykKLSAgICAgICAgbV9zbWFsbEludGVnZXJzW3ZhbHVlXSA9IHY4 OjpQZXJzaXN0ZW50PHY4OjpJbnRlZ2VyPjo6TmV3KHY4OjpJbnRlZ2VyOjpOZXcodmFsdWUsIGlz b2xhdGUpKTsKLSAgICBtX2luaXRpYWxpemVkID0gdHJ1ZTsKKyAgICAgICAgbV9zbWFsbEludGVn ZXJzW3ZhbHVlXSA9IHY4OjpQZXJzaXN0ZW50PHY4OjpJbnRlZ2VyPjo6TmV3KHY4OjpJbnRlZ2Vy OjpOZXcodmFsdWUpKTsKIH0KIAogSW50ZWdlckNhY2hlOjp+SW50ZWdlckNhY2hlKCkKIHsKLSAg ICBpZiAobV9pbml0aWFsaXplZCkgewotICAgICAgICBmb3IgKGludCB2YWx1ZSA9IDA7IHZhbHVl IDwgbnVtYmVyT2ZDYWNoZWRTbWFsbEludGVnZXJzOyB2YWx1ZSsrKSB7Ci0gICAgICAgICAgICBt X3NtYWxsSW50ZWdlcnNbdmFsdWVdLkRpc3Bvc2UoKTsKLSAgICAgICAgICAgIG1fc21hbGxJbnRl Z2Vyc1t2YWx1ZV0uQ2xlYXIoKTsKLSAgICAgICAgfQotICAgICAgICBtX2luaXRpYWxpemVkID0g ZmFsc2U7CisgICAgZm9yIChpbnQgdmFsdWUgPSAwOyB2YWx1ZSA8IG51bWJlck9mQ2FjaGVkU21h bGxJbnRlZ2VyczsgdmFsdWUrKykgeworICAgICAgICBtX3NtYWxsSW50ZWdlcnNbdmFsdWVdLkRp c3Bvc2UoKTsKKyAgICAgICAgbV9zbWFsbEludGVnZXJzW3ZhbHVlXS5DbGVhcigpOwogICAgIH0K IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhWYWx1ZUNhY2hl LmggYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZhbHVlQ2FjaGUuaAppbmRleCAwYjE0 YTJhMGQzNjg4NTdmMzE0YjdiODdmNjMxZTEwNWE1ZDBjNTgwLi5mMzA4MjAwYzY3NTBjYWQ0OWVm NGFlNDhhZTM0NjgwYTJmNDExMTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy92OC9WOFZhbHVlQ2FjaGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFZh bHVlQ2FjaGUuaApAQCAtNzAsMTMgKzcwLDExIEBAIGNvbnN0IGludCBudW1iZXJPZkNhY2hlZFNt YWxsSW50ZWdlcnMgPSA2NDsKIAogY2xhc3MgSW50ZWdlckNhY2hlIHsKIHB1YmxpYzoKLSAgICAg SW50ZWdlckNhY2hlKCkgOiBtX2luaXRpYWxpemVkKGZhbHNlKSB7IH07CisgICAgSW50ZWdlckNh Y2hlKCk7CiAgICAgfkludGVnZXJDYWNoZSgpOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6SW50ZWdl cj4gdjhJbnRlZ2VyKGludCB2YWx1ZSwgdjg6Oklzb2xhdGUqIGlzb2xhdGUpCiAgICAgewotICAg ICAgICBpZiAoIW1faW5pdGlhbGl6ZWQpCi0gICAgICAgICAgICBjcmVhdGVTbWFsbEludGVnZXJz KGlzb2xhdGUpOwogICAgICAgICBpZiAoMCA8PSB2YWx1ZSAmJiB2YWx1ZSA8IG51bWJlck9mQ2Fj aGVkU21hbGxJbnRlZ2VycykKICAgICAgICAgICAgIHJldHVybiBtX3NtYWxsSW50ZWdlcnNbdmFs dWVdOwogICAgICAgICByZXR1cm4gdjg6OkludGVnZXI6Ok5ldyh2YWx1ZSwgaXNvbGF0ZSk7CkBA IC04NCwyMCArODIsMTUgQEAgcHVibGljOgogCiAgICAgdjg6OkhhbmRsZTx2ODo6SW50ZWdlcj4g djhVbnNpZ25lZEludGVnZXIodW5zaWduZWQgdmFsdWUsIHY4OjpJc29sYXRlKiBpc29sYXRlKQog ICAgIHsKLSAgICAgICAgaWYgKCFtX2luaXRpYWxpemVkKQotICAgICAgICAgICAgY3JlYXRlU21h bGxJbnRlZ2Vycyhpc29sYXRlKTsKICAgICAgICAgaWYgKHZhbHVlIDwgc3RhdGljX2Nhc3Q8dW5z aWduZWQ+KG51bWJlck9mQ2FjaGVkU21hbGxJbnRlZ2VycykpCiAgICAgICAgICAgICByZXR1cm4g bV9zbWFsbEludGVnZXJzW3ZhbHVlXTsKICAgICAgICAgcmV0dXJuIHY4OjpJbnRlZ2VyOjpOZXdG cm9tVW5zaWduZWQodmFsdWUsIGlzb2xhdGUpOwogICAgIH0KIAogcHJpdmF0ZToKLSAgICB2b2lk IGNyZWF0ZVNtYWxsSW50ZWdlcnModjg6Oklzb2xhdGUqKTsKLQogICAgIHY4OjpQZXJzaXN0ZW50 PHY4OjpJbnRlZ2VyPiBtX3NtYWxsSW50ZWdlcnNbbnVtYmVyT2ZDYWNoZWRTbWFsbEludGVnZXJz XTsKLSAgICBib29sIG1faW5pdGlhbGl6ZWQ7CiB9OwotICAgIAorCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCiAKICNlbmRpZiAvLyBWOFZhbHVlQ2FjaGVfaAo=