103961 2012-12-03 19:36:10 -0800 nrwt: do less work when ctrl-c'ed 2012-12-04 14:54:50 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103951 103824 103963 1 dpranke dpranke abarth eric ojan rniwa tony oldest_to_newest 782139 0 dpranke 2012-12-03 19:36:10 -0800 nrwt: do less work when ctrl-c'ed 782144 1 177397 dpranke 2012-12-03 19:45:45 -0800 Created attachment 177397 Patch 782155 2 177397 rniwa 2012-12-03 20:01:36 -0800 Comment on attachment 177397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177397&action=review > Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-435 > - # FIXME: Modify summarize_results to handle retry_summary == None. > - retry_summary = result_summary Do we support this case now? r=me provided that the answer to this question is yes. 782209 3 177397 dpranke 2012-12-03 21:43:06 -0800 Comment on attachment 177397 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177397&action=review >> Tools/Scripts/webkitpy/layout_tests/controllers/manager.py:-435 >> - retry_summary = result_summary > > Do we support this case now? r=me provided that the answer to this question is yes. Ah, yes. I missed removing the fixme in the cleanup of the patch. 782982 4 dpranke 2012-12-04 14:54:50 -0800 Committed r136581: <http://trac.webkit.org/changeset/136581> 177397 2012-12-03 19:45:45 -0800 2012-12-03 21:43:06 -0800 Patch bug-103961-20121203194311.patch text/plain 5292 dpranke U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDQzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNmIyNzNiZjY2OTk0NzcxYjMzZjMyMjQ2NWQyNTI4Nzlk Y2MxOGY4MS4uMjI1NjRjNDAwZWY2NmJmNzI1MGYxOGQ0Mjg5ZGE3ZTNiNmEyYzdhZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIx IEBACiAyMDEyLTEyLTAzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCisg ICAgICAgIG5yd3Q6IGRvIGxlc3Mgd29yayB3aGVuIGN0cmwtYydlZAorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzOTYxCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbGVzcyB3b3JrIHdoZW4gd2UgYXJl IGN0cmwtYydlZCwgYmVjYXVzZSB0aGUgc3RhdGlzdGljcyBhcmVuJ3QKKyAgICAgICAgdGhhdCB1 c2VmdWwgYW55d2F5LiBXaGlsZSB3ZSdyZSBhdCBpdCwgbW9kaWZ5IHN1bW1hcml6ZV9yZXN1bHRz CisgICAgICAgIHRvIGJlIGF3YXJlIHRoYXQgd2UgZG9uJ3QgYWx3YXlzIHJldHJ5IHJlc3VsdHMg KGluc3RlYWQgb2YgcHJldGVuZGluZworICAgICAgICB0aGF0IHRoZSByZXRyeSBwcm9kdWNlZCB0 aGUgc2FtZSByZXN1bHRzIHRoZSBpbml0aWFsIHJ1biBkaWQpLgorCisgICAgICAgICogU2NyaXB0 cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29udHJvbGxlcnMvbWFuYWdlci5weToKKyAgICAgICAg KHN1bW1hcml6ZV9yZXN1bHRzKToKKyAgICAgICAgKE1hbmFnZXIucnVuKToKKworMjAxMi0xMi0w MyAgRGlyayBQcmFua2UgIDxkcHJhbmtlQGNocm9taXVtLm9yZz4KKwogICAgICAgICBucnd0OiBy ZXN1bHQgc3VtbWFyaWVzIHNob3VsZCBub3QgcmVxdWlyZSBhIGxpc3Qgb2YgdGVzdHMgdG8gc2tp cAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzOTUx CiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRy b2xsZXJzL21hbmFnZXIucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9j b250cm9sbGVycy9tYW5hZ2VyLnB5CmluZGV4IDMzZDdjNjM0MjkwMTQ5MzAwMGI5OWU4ZTBiZGM2 MDc0YmU3NGRlMGQuLjQ1N2NmMTdjMzVkMDIyNjNiZTExMWExNmEwYTJkZWY2NDFmNjkzZjAgMTAw NjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL2NvbnRyb2xsZXJz L21hbmFnZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvY29u dHJvbGxlcnMvbWFuYWdlci5weQpAQCAtMTE2LDcgKzExNiw3IEBAIGRlZiBzdW1tYXJpemVfcmVz dWx0cyhwb3J0X29iaiwgZXhwZWN0YXRpb25zLCByZXN1bHRfc3VtbWFyeSwgcmV0cnlfc3VtbWFy eSwgb25sCiAgICAgICAgIHBvcnRfb2JqOiBpbnRlcmZhY2UgdG8gcG9ydC1zcGVjaWZpYyBob29r cwogICAgICAgICBleHBlY3RhdGlvbnM6IHRlc3RfZXhwZWN0YXRpb25zLlRlc3RFeHBlY3RhdGlv bnMgb2JqZWN0CiAgICAgICAgIHJlc3VsdF9zdW1tYXJ5OiBzdW1tYXJ5IG9iamVjdCBmcm9tIGlu aXRpYWwgdGVzdCBydW5zCi0gICAgICAgIHJldHJ5X3N1bW1hcnk6IHN1bW1hcnkgb2JqZWN0IGZy b20gZmluYWwgdGVzdCBydW4gb2YgcmV0cmllZCB0ZXN0cworICAgICAgICByZXRyeV9zdW1tYXJ5 OiBzdW1tYXJ5IG9iamVjdCBmcm9tIGZpbmFsIHRlc3QgcnVuIG9mIHJldHJpZWQgdGVzdHMgKGlm IGFueSkKICAgICAgICAgb25seV91bmV4cGVjdGVkOiB3aGV0aGVyIHRvIHJldHVybiBhIHN1bW1h cnkgb25seSBmb3IgdGhlIHVuZXhwZWN0ZWQgcmVzdWx0cwogICAgIFJldHVybnM6CiAgICAgICAg IEEgZGljdGlvbmFyeSBjb250YWluaW5nIGEgc3VtbWFyeSBvZiB0aGUgdW5leHBlY3RlZCByZXN1 bHRzIGZyb20gdGhlCkBAIC0xODQsMTYgKzE4NCwxOCBAQCBkZWYgc3VtbWFyaXplX3Jlc3VsdHMo cG9ydF9vYmosIGV4cGVjdGF0aW9ucywgcmVzdWx0X3N1bW1hcnksIHJldHJ5X3N1bW1hcnksIG9u bAogICAgICAgICAgICAgaWYgdGVzdF9uYW1lIGluIHJlc3VsdF9zdW1tYXJ5LnVuZXhwZWN0ZWRf cmVzdWx0czoKICAgICAgICAgICAgICAgICBudW1fbWlzc2luZyArPSAxCiAgICAgICAgIGVsaWYg dGVzdF9uYW1lIGluIHJlc3VsdF9zdW1tYXJ5LnVuZXhwZWN0ZWRfcmVzdWx0czoKLSAgICAgICAg ICAgIGlmIHRlc3RfbmFtZSBub3QgaW4gcmV0cnlfc3VtbWFyeS51bmV4cGVjdGVkX3Jlc3VsdHM6 CisgICAgICAgICAgICBpZiByZXRyeV9zdW1tYXJ5IGFuZCB0ZXN0X25hbWUgbm90IGluIHJldHJ5 X3N1bW1hcnkudW5leHBlY3RlZF9yZXN1bHRzOgogICAgICAgICAgICAgICAgIGFjdHVhbC5leHRl bmQoZXhwZWN0YXRpb25zLmdldF9leHBlY3RhdGlvbnNfc3RyaW5nKHRlc3RfbmFtZSkuc3BsaXQo IiAiKSkKICAgICAgICAgICAgICAgICBudW1fZmxha3kgKz0gMQotICAgICAgICAgICAgZWxzZToK KyAgICAgICAgICAgIGVsaWYgcmV0cnlfc3VtbWFyeToKICAgICAgICAgICAgICAgICByZXRyeV9y ZXN1bHRfdHlwZSA9IHJldHJ5X3N1bW1hcnkudW5leHBlY3RlZF9yZXN1bHRzW3Rlc3RfbmFtZV0u dHlwZQogICAgICAgICAgICAgICAgIGlmIHJlc3VsdF90eXBlICE9IHJldHJ5X3Jlc3VsdF90eXBl OgogICAgICAgICAgICAgICAgICAgICBhY3R1YWwuYXBwZW5kKGtleXdvcmRzW3JldHJ5X3Jlc3Vs dF90eXBlXSkKICAgICAgICAgICAgICAgICAgICAgbnVtX2ZsYWt5ICs9IDEKICAgICAgICAgICAg ICAgICBlbHNlOgogICAgICAgICAgICAgICAgICAgICBudW1fcmVncmVzc2lvbnMgKz0gMQorICAg ICAgICAgICAgZWxzZToKKyAgICAgICAgICAgICAgICBudW1fcmVncmVzc2lvbnMgKz0gMQogCiAg ICAgICAgIHRlc3RfZGljdFsnZXhwZWN0ZWQnXSA9IGV4cGVjdGVkCiAgICAgICAgIHRlc3RfZGlj dFsnYWN0dWFsJ10gPSAiICIuam9pbihhY3R1YWwpCkBAIC00MDcsNyArNDA5LDYgQEAgY2xhc3Mg TWFuYWdlcihvYmplY3QpOgogCiAgICAgICAgIHN0YXJ0X3RpbWUgPSB0aW1lLnRpbWUoKQogCi0g ICAgICAgIHJldHJ5X3N1bW1hcnkgPSBOb25lCiAgICAgICAgIHRyeToKICAgICAgICAgICAgIHJl c3VsdF9zdW1tYXJ5ID0gc2VsZi5fcnVuX3Rlc3RzKHNlbGYuX3Rlc3RfbmFtZXMsIHJlc3VsdF9z dW1tYXJ5LCBpbnQoc2VsZi5fb3B0aW9ucy5jaGlsZF9wcm9jZXNzZXMpLCByZXRyeWluZz1GYWxz ZSkKIApAQCAtNDIwLDI1ICs0MjEsMjIgQEAgY2xhc3MgTWFuYWdlcihvYmplY3QpOgogICAgICAg ICAgICAgICAgIF9sb2cuaW5mbygiUmV0cnlpbmcgJWQgdW5leHBlY3RlZCBmYWlsdXJlKHMpIC4u LiIgJSBsZW4oZmFpbHVyZXMpKQogICAgICAgICAgICAgICAgIF9sb2cuaW5mbygnJykKICAgICAg ICAgICAgICAgICByZXRyeV9zdW1tYXJ5ID0gc2VsZi5fcnVuX3Rlc3RzKGZhaWx1cmVzLCBSZXN1 bHRTdW1tYXJ5KHNlbGYuX2V4cGVjdGF0aW9ucywgZmFpbHVyZXMsIDEpLCAxLCByZXRyeWluZz1U cnVlKQotICAgICAgICBmaW5hbGx5OgotICAgICAgICAgICAgIyBJZiB3ZSBhcmUgY3RybC1jJ2Vk OyB3ZSBzdGlsbCB3YW50IHRvIHRyeSBhbmQgcHJpbnQgdGhlIHJlc3VsdHMgd2UgZ290LCBhbmQg Y2xlYW4gdXAsCi0gICAgICAgICAgICAjIGJ1dCB3ZSBkb24ndCB3YW50IHRvIHVwbG9hZCBhbnl0 aGluZy4KLSAgICAgICAgICAgIGVuZF90aW1lID0gdGltZS50aW1lKCkKLQotICAgICAgICAgICAg IyBTb21lIGNyYXNoIGxvZ3MgY2FuIHRha2UgYSBsb25nIHRpbWUgdG8gYmUgd3JpdHRlbiBvdXQg c28gbG9vawotICAgICAgICAgICAgIyBmb3IgbmV3IGxvZ3MgYWZ0ZXIgdGhlIHRlc3QgcnVuIGZp bmlzaGVzLgotICAgICAgICAgICAgc2VsZi5fbG9va19mb3JfbmV3X2NyYXNoX2xvZ3MocmVzdWx0 X3N1bW1hcnksIHN0YXJ0X3RpbWUpCi0gICAgICAgICAgICBpZiByZXRyeV9zdW1tYXJ5OgotICAg ICAgICAgICAgICAgIHNlbGYuX2xvb2tfZm9yX25ld19jcmFzaF9sb2dzKHJldHJ5X3N1bW1hcnks IHN0YXJ0X3RpbWUpCiAgICAgICAgICAgICBlbHNlOgotICAgICAgICAgICAgICAgICMgRklYTUU6 IE1vZGlmeSBzdW1tYXJpemVfcmVzdWx0cyB0byBoYW5kbGUgcmV0cnlfc3VtbWFyeSA9PSBOb25l LgotICAgICAgICAgICAgICAgIHJldHJ5X3N1bW1hcnkgPSByZXN1bHRfc3VtbWFyeQotCisgICAg ICAgICAgICAgICAgcmV0cnlfc3VtbWFyeSA9IE5vbmUKKyAgICAgICAgZmluYWxseToKICAgICAg ICAgICAgIHNlbGYuX2NsZWFuX3VwX3J1bigpCiAKLSAgICAgICAgICAgIHVuZXhwZWN0ZWRfcmVz dWx0cyA9IHN1bW1hcml6ZV9yZXN1bHRzKHNlbGYuX3BvcnQsIHNlbGYuX2V4cGVjdGF0aW9ucywg cmVzdWx0X3N1bW1hcnksIHJldHJ5X3N1bW1hcnksIG9ubHlfdW5leHBlY3RlZD1UcnVlKQorICAg ICAgICBlbmRfdGltZSA9IHRpbWUudGltZSgpCisKKyAgICAgICAgIyBTb21lIGNyYXNoIGxvZ3Mg Y2FuIHRha2UgYSBsb25nIHRpbWUgdG8gYmUgd3JpdHRlbiBvdXQgc28gbG9vaworICAgICAgICAj IGZvciBuZXcgbG9ncyBhZnRlciB0aGUgdGVzdCBydW4gZmluaXNoZXMuCisgICAgICAgIHNlbGYu X2xvb2tfZm9yX25ld19jcmFzaF9sb2dzKHJlc3VsdF9zdW1tYXJ5LCBzdGFydF90aW1lKQorICAg ICAgICBpZiByZXRyeV9zdW1tYXJ5OgorICAgICAgICAgICAgc2VsZi5fbG9va19mb3JfbmV3X2Ny YXNoX2xvZ3MocmV0cnlfc3VtbWFyeSwgc3RhcnRfdGltZSkKKworICAgICAgICB1bmV4cGVjdGVk X3Jlc3VsdHMgPSBzdW1tYXJpemVfcmVzdWx0cyhzZWxmLl9wb3J0LCBzZWxmLl9leHBlY3RhdGlv bnMsIHJlc3VsdF9zdW1tYXJ5LCByZXRyeV9zdW1tYXJ5LCBvbmx5X3VuZXhwZWN0ZWQ9VHJ1ZSkK IAotICAgICAgICAgICAgc2VsZi5fcHJpbnRlci5wcmludF9yZXN1bHRzKGVuZF90aW1lIC0gc3Rh cnRfdGltZSwgcmVzdWx0X3N1bW1hcnksIHVuZXhwZWN0ZWRfcmVzdWx0cykKKyAgICAgICAgc2Vs Zi5fcHJpbnRlci5wcmludF9yZXN1bHRzKGVuZF90aW1lIC0gc3RhcnRfdGltZSwgcmVzdWx0X3N1 bW1hcnksIHVuZXhwZWN0ZWRfcmVzdWx0cykKIAogICAgICAgICAjIEZJWE1FOiByZW1vdmUgcmVj b3JkX3Jlc3VsdHMuIEl0J3MganVzdCB1c2VkIGZvciB0ZXN0aW5nLiBUaGVyZSdzIG5vIG5lZWQK ICAgICAgICAgIyBmb3IgaXQgdG8gYmUgYSBjb21tYW5kbGluZSBhcmd1bWVudC4K