103941 2012-12-03 15:43:03 -0800 Build fix after r136444 2012-12-03 19:47:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 103938 P2 Normal --- 1 ktf.kim ktf.kim oldest_to_newest 781965 0 ktf.kim 2012-12-03 15:43:03 -0800 r136444 blocks #include "JPEGImageDecoder.h" with #if USE(LIBJPEG), but it should be #if !PLATFORM(QT) || (PLATFORM(QT) && USE(LIBJPEG)), same with the code using JPEGImageDecode (126 line). 781971 1 177355 ktf.kim 2012-12-03 15:45:47 -0800 Created attachment 177355 Patch 781973 2 ktf.kim 2012-12-03 15:47:17 -0800 Source/WebCore/platform/image-decoders/ImageDecoder.cpp: In static member function ‘static WebCore::ImageDecoder* WebCore::ImageDecoder::create(const WebCore::SharedBuffer&, WebCore::ImageSource::AlphaOption, WebCore::ImageSource::GammaAndColorProfileOption)’: Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:20: error: expected type-specifier before ‘JPEGImageDecoder’ Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:20: error: cannot convert ‘int*’ to ‘WebCore::ImageDecoder*’ in return Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:20: error: expected ‘;’ before ‘JPEGImageDecoder’ Source/WebCore/platform/image-decoders/ImageDecoder.cpp:126:76: error: ‘JPEGImageDecoder’ was not declared in this scope 781980 3 177355 leviw 2012-12-03 15:51:34 -0800 Comment on attachment 177355 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177355&action=review > Source/WebCore/ChangeLog:9 > + Unreviewd build fix > + > + r136444 blocks #include "JPEGImageDecoder.h" with #if USE(LIBJPEG), > + but it should be #if !PLATFORM(QT) || (PLATFORM(QT) && USE(LIBJPEG)). Typo: "Unreviewd". Qualify the revision with a link and don't worry about writing the entire patch in the description. Just say the platform that's broken. 781990 4 ktf.kim 2012-12-03 15:59:53 -0800 *** This bug has been marked as a duplicate of bug 103938 *** 782147 5 177355 laszlo.gombos 2012-12-03 19:47:48 -0800 Comment on attachment 177355 Patch removing cq? as this is a dup of a fixed bug. 177355 2012-12-03 15:45:47 -0800 2012-12-03 19:47:48 -0800 Patch bug-103941-20121204084315.patch text/plain 1317 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDQ0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWNhZmQyZWNkMDA3MTMz ZmJhOTNiYzY1N2Y1MDY4MzE2M2MxN2M3NC4uMDY4MGMyOGU4MmU1NWVmNGUxNzgyYWVjZjgzYmQw NzRlZTFmZjk1MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTAzICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIEJ1aWxkIGZpeCBhZnRl ciByMTM2NDQ0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMDM5NDEKKworICAgICAgICBVbnJldmlld2QgYnVpbGQgZml4CisKKyAgICAgICAgcjEzNjQ0 NCBibG9ja3MgI2luY2x1ZGUgIkpQRUdJbWFnZURlY29kZXIuaCIgd2l0aCAjaWYgVVNFKExJQkpQ RUcpLAorICAgICAgICBidXQgaXQgc2hvdWxkIGJlICNpZiAhUExBVEZPUk0oUVQpIHx8IChQTEFU Rk9STShRVCkgJiYgVVNFKExJQkpQRUcpKS4KKworICAgICAgICAqIHBsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL0ltYWdlRGVjb2Rlci5jcHA6CisKIDIwMTItMTItMDMgIFBpZXJyZSBSb3NzaSAgPHBp ZXJyZS5yb3NzaUBkaWdpYS5jb20+CiAKICAgICAgICAgW1F0XSBVbnJldmlld2VkIGJ1aWxkIGZp eCBhZnRlciByMTM2NDEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFn ZS1kZWNvZGVycy9JbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1h Z2UtZGVjb2RlcnMvSW1hZ2VEZWNvZGVyLmNwcAppbmRleCBlZDYwODU5YzQ0ZGNkMTIxMjE2MmI4 MDFjZWQ0YmMyOGFhNzhiYWVhLi43MDFjMTJjN2E3NTEwNGMyYzYxMGYwYWZhYTM4NTk3YzUxODVk MDM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9J bWFnZURlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRlY29k ZXJzL0ltYWdlRGVjb2Rlci5jcHAKQEAgLTI4LDcgKzI4LDcgQEAKICNpZiBQTEFURk9STShRVCkK ICNpbmNsdWRlICJJbWFnZURlY29kZXJRdC5oIgogI2VuZGlmCi0jaWYgVVNFKExJQkpQRUcpCisj aWYgIVBMQVRGT1JNKFFUKSB8fCAoUExBVEZPUk0oUVQpICYmIFVTRShMSUJKUEVHKSkKICNpbmNs dWRlICJKUEVHSW1hZ2VEZWNvZGVyLmgiCiAjZW5kaWYKICNpbmNsdWRlICJQTkdJbWFnZURlY29k ZXIuaCIK