103939 2012-12-03 15:37:12 -0800 [CSS Exclusions] ExclusionShape inlines should use isFlippedBlocksWritingMode() 2012-12-05 00:04:57 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103327 1 giles_joplin giles_joplin eric ojan webkit.review.bot oldest_to_newest 781959 0 giles_joplin 2012-12-03 15:37:12 -0800 The protected ExclusionShape inlines, like minYForLogicalLine(), now use isFlippedBlocksWritingMode() instead of testing for RightToLeftWritingMode directly. This changeimproves consistency with the rest of WebKit and will work correctly if "horizontal-bt" writing-mode support is ever added. 782000 1 177362 giles_joplin 2012-12-03 16:06:50 -0800 Created attachment 177362 Patch Elliot Sprehn suggested factoring this small cleanup out of the patch for https://bugs.webkit.org/show_bug.cgi?id=103327. 782764 2 177362 krit 2012-12-04 11:43:41 -0800 Comment on attachment 177362 Patch LGTM. r=me 782804 3 177362 webkit.review.bot 2012-12-04 12:29:25 -0800 Comment on attachment 177362 Patch Rejecting attachment 177362 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ripts/update-webkit line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit 9cffc45..a0bd058 HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at a0bd0584a2eb25a8bb88b2de129e3453f2ab97d7 but expected 9cffc451c10239895188285fa8cdb2dbd36f385d ! 9cffc45..a0bd058 master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15138298 783279 4 177362 webkit.review.bot 2012-12-04 19:52:38 -0800 Comment on attachment 177362 Patch Rejecting attachment 177362 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ripts/update-webkit line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit 4c9966d..c0a4c3a HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at c0a4c3a40ce96884ae4c1472ef9d4edf6af9b111 but expected 4c9966dabd73e7df4d0cfc1858ece45aeb05b888 ! 4c9966d..c0a4c3a master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15158110 783441 5 177362 eric 2012-12-04 23:44:10 -0800 Comment on attachment 177362 Patch I believe abarth has fixed the cq for now. 783453 6 177362 webkit.review.bot 2012-12-05 00:04:53 -0800 Comment on attachment 177362 Patch Clearing flags on attachment: 177362 Committed r136647: <http://trac.webkit.org/changeset/136647> 783454 7 webkit.review.bot 2012-12-05 00:04:57 -0800 All reviewed patches have been landed. Closing bug. 177362 2012-12-03 16:06:50 -0800 2012-12-05 00:04:53 -0800 Patch tmp.patch text/plain 2784 giles_joplin ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ODBmNjg1Li41YmFiYmIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMTItMDMgIEhhbnMgTXVsbGVyICA8aG11bGxlckBhZG9iZS5jb20+CisKKyAgICAg ICAgW0NTUyBFeGNsdXNpb25zXSBFeGNsdXNpb25TaGFwZSBpbmxpbmVzIHNob3VsZCB1c2UgaXNG bGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAzOTM5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgSnVzdCBhIG1pbm9yIGNsZWFudXA6IHRoZSBwcm90ZWN0ZWQgRXhj bHVzaW9uU2hhcGUgaW5saW5lcywgbGlrZSBtaW5ZRm9yTG9naWNhbExpbmUoKSwKKyAgICAgICAg bm93IHVzZSBpc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpIGluc3RlYWQgb2YgdGVzdGluZyBm b3IgUmlnaHRUb0xlZnRXcml0aW5nTW9kZSBkaXJlY3RseS4KKyAgICAgICAgVGhpcyBjaGFuZ2Vp bXByb3ZlcyBjb25zaXN0ZW5jeSB3aXRoIHRoZSByZXN0IG9mIFdlYktpdCBhbmQgd2lsbCB3b3Jr IGNvcnJlY3RseQorICAgICAgICBpZiAiaG9yaXpvbnRhbC1idCIgd3JpdGluZy1tb2RlIHN1cHBv cnQgaXMgZXZlciBhZGRlZC4KKworICAgICAgICBObyBuZXcgdGVzdHMgd2VyZSBhZGRlZCBzaW5j ZSB0aGUgZXhpc3RpbmcgdGVzdHMgY292ZXIgdGhlc2UgbWV0aG9kcy4KKworICAgICAgICAqIHJl bmRlcmluZy9FeGNsdXNpb25TaGFwZS5oOgorICAgICAgICAoV2ViQ29yZTo6RXhjbHVzaW9uU2hh cGU6Om1pbllGb3JMb2dpY2FsTGluZSk6CisgICAgICAgIChXZWJDb3JlOjpFeGNsdXNpb25TaGFw ZTo6bWF4WUZvckxvZ2ljYWxMaW5lKToKKyAgICAgICAgKFdlYkNvcmU6OkV4Y2x1c2lvblNoYXBl OjppbnRlcm5hbFRvTG9naWNhbEJvdW5kaW5nQm94KToKKwogMjAxMi0xMS0zMCAgQW5kcmV5IEtv c3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IG1h a2UgaXQgcG9zc2libGUgdG8gZmxpdGVyIG91dCBtZXNzYWdlcyBmcm9tIGNvbnNvbGUue3RpbWUs dGltZUVuZH0oKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0V4Y2x1c2lv blNoYXBlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRXhjbHVzaW9uU2hhcGUuaAppbmRl eCAwNzVjMDAyLi5mNDNkYmY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv RXhjbHVzaW9uU2hhcGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvRXhjbHVzaW9u U2hhcGUuaApAQCAtNjksOSArNjksOSBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIGdldEV4 Y2x1ZGVkSW50ZXJ2YWxzKGZsb2F0IGxvZ2ljYWxUb3AsIGZsb2F0IGxvZ2ljYWxIZWlnaHQsIFNl Z21lbnRMaXN0JikgY29uc3QgPSAwOwogCiBwcm90ZWN0ZWQ6Ci0gICAgZmxvYXQgbWluWUZvckxv Z2ljYWxMaW5lKGZsb2F0IGxvZ2ljYWxUb3AsIGZsb2F0IGxvZ2ljYWxIZWlnaHQpIGNvbnN0IHsg cmV0dXJuIChtX3dyaXRpbmdNb2RlID09IFJpZ2h0VG9MZWZ0V3JpdGluZ01vZGUpID8gbV9sb2dp Y2FsQm94SGVpZ2h0IC0gbG9naWNhbFRvcCAtIGxvZ2ljYWxIZWlnaHQgOiBsb2dpY2FsVG9wOyB9 Ci0gICAgZmxvYXQgbWF4WUZvckxvZ2ljYWxMaW5lKGZsb2F0IGxvZ2ljYWxUb3AsIGZsb2F0IGxv Z2ljYWxIZWlnaHQpIGNvbnN0IHsgcmV0dXJuIChtX3dyaXRpbmdNb2RlID09IFJpZ2h0VG9MZWZ0 V3JpdGluZ01vZGUpID8gbV9sb2dpY2FsQm94SGVpZ2h0IC0gbG9naWNhbFRvcCA6IGxvZ2ljYWxU b3AgKyBsb2dpY2FsSGVpZ2h0OyB9Ci0gICAgRmxvYXRSZWN0IGludGVybmFsVG9Mb2dpY2FsQm91 bmRpbmdCb3goRmxvYXRSZWN0IHIpIGNvbnN0IHsgcmV0dXJuIChtX3dyaXRpbmdNb2RlID09IFJp Z2h0VG9MZWZ0V3JpdGluZ01vZGUpID8gRmxvYXRSZWN0KHIueCgpLCBtX2xvZ2ljYWxCb3hIZWln aHQgLSByLm1heFkoKSwgci53aWR0aCgpLCByLmhlaWdodCgpKSA6IHI7IH0KKyAgICBmbG9hdCBt aW5ZRm9yTG9naWNhbExpbmUoZmxvYXQgbG9naWNhbFRvcCwgZmxvYXQgbG9naWNhbEhlaWdodCkg Y29uc3QgeyByZXR1cm4gaXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUobV93cml0aW5nTW9kZSkg PyBtX2xvZ2ljYWxCb3hIZWlnaHQgLSBsb2dpY2FsVG9wIC0gbG9naWNhbEhlaWdodCA6IGxvZ2lj YWxUb3A7IH0KKyAgICBmbG9hdCBtYXhZRm9yTG9naWNhbExpbmUoZmxvYXQgbG9naWNhbFRvcCwg ZmxvYXQgbG9naWNhbEhlaWdodCkgY29uc3QgeyByZXR1cm4gIGlzRmxpcHBlZEJsb2Nrc1dyaXRp bmdNb2RlKG1fd3JpdGluZ01vZGUpID8gbV9sb2dpY2FsQm94SGVpZ2h0IC0gbG9naWNhbFRvcCA6 IGxvZ2ljYWxUb3AgKyBsb2dpY2FsSGVpZ2h0OyB9CisgICAgRmxvYXRSZWN0IGludGVybmFsVG9M b2dpY2FsQm91bmRpbmdCb3goY29uc3QgRmxvYXRSZWN0JiByKSBjb25zdCB7IHJldHVybiBpc0Zs aXBwZWRCbG9ja3NXcml0aW5nTW9kZShtX3dyaXRpbmdNb2RlKSA/IEZsb2F0UmVjdChyLngoKSwg bV9sb2dpY2FsQm94SGVpZ2h0IC0gci5tYXhZKCksIHIud2lkdGgoKSwgci5oZWlnaHQoKSkgOiBy OyB9CiAKIHByaXZhdGU6CiAgICAgV3JpdGluZ01vZGUgbV93cml0aW5nTW9kZTsK