103932 2012-12-03 14:48:28 -0800 Web Inspector: Don't include error message text in the editor buffer. 2012-12-05 09:42:00 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 johnjbarton pfeldman apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 781900 0 johnjbarton 2012-12-03 14:48:28 -0800 I updated today and the editor is now grabbing the text of error messages: loc.traceId = traceId; // used to match traces to the AST Uncaught TypeError: Cannot set property 'traceId' of null ===========================================================^^^^ Click at the end the line above an error and hit enter. 782688 1 177509 pfeldman 2012-12-04 10:38:33 -0800 Created attachment 177509 Patch 783846 2 177509 webkit.review.bot 2012-12-05 09:41:57 -0800 Comment on attachment 177509 Patch Clearing flags on attachment: 177509 Committed r136703: <http://trac.webkit.org/changeset/136703> 783847 3 webkit.review.bot 2012-12-05 09:42:00 -0800 All reviewed patches have been landed. Closing bug. 177509 2012-12-04 10:38:33 -0800 2012-12-05 09:41:56 -0800 Patch bug-103932-20121204223557.patch text/plain 6386 pfeldman U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmU4ZTBjZWU3NTBjNGNl NzEyNWQ4OTNjZmRlMGEyYjM5MGQyNzYxNC4uMGQ2OTdiMGJjNWM1ZmQ3MjU0MTc2NjJkMjQ2OGQ3 ODdhMWU4MTlhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTEyLTA0ICBQYXZl bCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IERvbid0IGluY2x1ZGUgZXJyb3IgbWVzc2FnZSB0ZXh0IGluIHRoZSBlZGl0b3IgYnVmZmVy LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzOTMy CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU2tpcCBl bnRpcmUgZGVjb3JhdGlvbiBjb250ZW50IHdoZW4gY29sbGVjdGluZyBkaXJ0eSByZWdpb25zLgor ICAgICAgICAKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0RWRpdG9y LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0b3JNYWluUGFuZWwucHJvdG90eXBl Ll9jb2xsZWN0TGluZXNGcm9tRE9NKToKKwogMjAxMi0xMi0wNCAgQ2hhcmxpZSBSZWlzICA8Y3Jl aXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIEFkZCBGcmFtZUxvYWRlckNsaWVudDo6ZGlkRGlz b3duT3BlbmVyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L0RlZmF1bHRUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9EZWZhdWx0VGV4dEVkaXRvci5qcwppbmRleCA0NThlNTQ1NTJhOWFhOTQ3ZDI2NDJkZDdlZTJj NTE0MWIyYmRmYWNkLi44YTM3YmM0OTdjM2I5NjNlYjZmNTg0MzM0NGZhNzU3Mzg0Nzc0YjJkIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL0RlZmF1bHRUZXh0 RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvRGVmYXVs dFRleHRFZGl0b3IuanMKQEAgLTI0OTIsOCArMjQ5MiwxMiBAQCBXZWJJbnNwZWN0b3IuVGV4dEVk aXRvck1haW5QYW5lbC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHZhciB0ZXh0Q29udGVudHMgPSBb XTsKICAgICAgICAgdmFyIGhhc0NvbnRlbnQgPSBmYWxzZTsKICAgICAgICAgZm9yICh2YXIgbm9k ZSA9IGZyb20gPyBmcm9tLm5leHRTaWJsaW5nIDogdGhpcy5fY29udGFpbmVyOyBub2RlICYmIG5v ZGUgIT09IHRvOyBub2RlID0gbm9kZS50cmF2ZXJzZU5leHROb2RlKHRoaXMuX2NvbnRhaW5lcikp IHsKLSAgICAgICAgICAgIGlmIChub2RlLl9pc0RlY29yYXRpb25zRWxlbWVudCkKLSAgICAgICAg ICAgICAgICBjb250aW51ZTsKKyAgICAgICAgICAgIGlmIChub2RlLl9pc0RlY29yYXRpb25zRWxl bWVudCkgeworICAgICAgICAgICAgICAgIC8vIFNraXAgYWxsIGNoaWxkcmVuIG9mIHRoZSBkZWNv cmF0aW9uIGNvbnRhaW5lci4KKyAgICAgICAgICAgICAgICBub2RlID0gbm9kZS5uZXh0U2libGlu ZzsKKyAgICAgICAgICAgICAgICBpZiAoIW5vZGUgfHwgbm9kZSA9PT0gdG8pCisgICAgICAgICAg ICAgICAgICAgIGJyZWFrOworICAgICAgICAgICAgfQogICAgICAgICAgICAgaGFzQ29udGVudCA9 IHRydWU7CiAgICAgICAgICAgICBpZiAobm9kZS5ub2RlTmFtZS50b0xvd2VyQ2FzZSgpID09PSAi YnIiKQogICAgICAgICAgICAgICAgIHRleHRDb250ZW50cy5wdXNoKCJcbiIpOwpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGY0 YTVkMDhkNzMzYzc2YmZkODA2ZDU4MDYxMmZiMTc5OTU0MmRmOTguLjA1OWY2M2IyMDhjZTljMmI5 ZTBhMDAyZDU0YjU1OWFhZWYyNTJkZGQgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxv ZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0xMi0w NCAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBXZWIg SW5zcGVjdG9yOiBEb24ndCBpbmNsdWRlIGVycm9yIG1lc3NhZ2UgdGV4dCBpbiB0aGUgZWRpdG9y IGJ1ZmZlci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMzkzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogaW5zcGVjdG9yL2VkaXRvci9lZGl0b3ItdGVzdC5qczoKKyAgICAgICAgKGluaXRpYWxpemVf RWRpdG9yVGVzdHMuSW5zcGVjdG9yVGVzdC5nZXRMaW5lRWxlbWVudCk6CisgICAgICAgIChpbml0 aWFsaXplX0VkaXRvclRlc3RzKToKKyAgICAgICAgKiBpbnNwZWN0b3IvZWRpdG9yL3RleHQtZWRp dG9yLXR5cGUtb3Zlci1kZWNvcmF0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog aW5zcGVjdG9yL2VkaXRvci90ZXh0LWVkaXRvci10eXBlLW92ZXItZGVjb3JhdGlvbi5odG1sOiBB ZGRlZC4KKwogMjAxMi0xMi0wNCAgRW1pbCBBIEVrbHVuZCAgPGVhZUBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZCBjaHJvbWl1bSBleHBlY3RhdGlvbnMgdXBkYXRlLCBtYXJrIHVu c2tpcHBlZCBzdmcgdGVzdHMgYXMgc2xvdy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3Bl Y3Rvci9lZGl0b3IvZWRpdG9yLXRlc3QuanMgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZWRpdG9y L2VkaXRvci10ZXN0LmpzCmluZGV4IDI1MThjZTFjNWMxMTc1YjZmMjgyYTdkZGZjMWZmN2M4NWM1 ODc1OGUuLmQwOTkzY2EzNjQ5ZmYwMWJmOWQ1ZTJkZjE1N2I2ZjllNWU1ZDYzZjcgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9lZGl0b3IvZWRpdG9yLXRlc3QuanMKKysrIGIvTGF5 b3V0VGVzdHMvaW5zcGVjdG9yL2VkaXRvci9lZGl0b3ItdGVzdC5qcwpAQCAtNTAsNCArNTAsOSBA QCBJbnNwZWN0b3JUZXN0LmR1bXBFZGl0b3JET00gPSBmdW5jdGlvbih0ZXh0RWRpdG9yKQogICAg IH0KIH07CiAKK0luc3BlY3RvclRlc3QuZ2V0TGluZUVsZW1lbnQgPSBmdW5jdGlvbih0ZXh0RWRp dG9yLCBsaW5lTnVtYmVyKQoreworICAgIHJldHVybiB0ZXh0RWRpdG9yLl9tYWluUGFuZWwuY2h1 bmtGb3JMaW5lKGxpbmVOdW1iZXIpLmV4cGFuZGVkTGluZVJvdyhsaW5lTnVtYmVyKTsKK307CisK IH0KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9lZGl0b3IvdGV4dC1lZGl0b3It dHlwZS1vdmVyLWRlY29yYXRpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9y L2VkaXRvci90ZXh0LWVkaXRvci10eXBlLW92ZXItZGVjb3JhdGlvbi1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uMmVjZTA2NTdmNWZjNjBiOTc0ZmU1MWVlZGNlMzM5YzM3ODI2ZTMwNgotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9lZGl0b3IvdGV4dC1lZGl0b3ItdHlw ZS1vdmVyLWRlY29yYXRpb24tZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjYgQEAKK1RoaXMgdGVz dCBjaGVja3MgdGhhdCB0eXBpbmcgb3ZlciB0aGUgZGVjb3JhdGlvbiBkb2VzIG5vdCBjb2xsZWN0 IGRlY29yYXRpb24gdGV4dCBhcyBhIHBhcnQgb2YgZGFtYWdlZCBET00uCisKK0NodW5rIG1vZGVs CitDaHVuayBbMF0gMDoxMCAoZXhwYW5kZWQpCitFZGl0b3IgRE9NCitbMF0gICAgICAgPGRpdiBj bGFzcz0id2Via2l0LWxpbmUtY29udGVudCI+MDwvZGl2PgorWzFdICAgICAgIDxkaXYgY2xhc3M9 IndlYmtpdC1saW5lLWNvbnRlbnQiPjE8L2Rpdj4KK1syXSAgICAgICA8ZGl2IGNsYXNzPSJ3ZWJr aXQtbGluZS1jb250ZW50Ij4yPC9kaXY+CitbM10gICAgICAgPGRpdiBjbGFzcz0id2Via2l0LWxp bmUtY29udGVudCI+MzwvZGl2PgorWzRdICAgICAgIDxkaXYgY2xhc3M9IndlYmtpdC1saW5lLWNv bnRlbnQiPjQ8L2Rpdj4KK1s1OjZdICAgICA8ZGl2IGNsYXNzPSJ3ZWJraXQtbGluZS1jb250ZW50 Ij41PGRpdiBjbGFzcz0id2Via2l0LWxpbmUtZGVjb3JhdGlvbnMiPjxzcGFuPkRlY29yYXRpb24g Y29udGVudDwvc3Bhbj48L2Rpdj48L2Rpdj4KK1s2XSAgICAgICA8ZGl2IGNsYXNzPSJ3ZWJraXQt bGluZS1jb250ZW50Ij42PC9kaXY+CitbN10gICAgICAgPGRpdiBjbGFzcz0id2Via2l0LWxpbmUt Y29udGVudCI+NzwvZGl2PgorWzhdICAgICAgIDxkaXYgY2xhc3M9IndlYmtpdC1saW5lLWNvbnRl bnQiPjg8L2Rpdj4KK1s5XSAgICAgICA8ZGl2IGNsYXNzPSJ3ZWJraXQtbGluZS1jb250ZW50Ij45 PC9kaXY+CitFZGl0b3IgRE9NCitbMF0gICAgICAgPGRpdiBjbGFzcz0id2Via2l0LWxpbmUtY29u dGVudCI+MDwvZGl2PgorWzFdICAgICAgIDxkaXYgY2xhc3M9IndlYmtpdC1saW5lLWNvbnRlbnQi PjE8L2Rpdj4KK1syXSAgICAgICA8ZGl2IGNsYXNzPSJ3ZWJraXQtbGluZS1jb250ZW50Ij4yPC9k aXY+CitbM10gICAgICAgPGRpdiBjbGFzcz0id2Via2l0LWxpbmUtY29udGVudCI+MzwvZGl2Pgor WzRdICAgICAgIDxkaXYgY2xhc3M9IndlYmtpdC1saW5lLWNvbnRlbnQiPjRhNTwvZGl2PgorWzVd ICAgICAgIDxkaXYgY2xhc3M9IndlYmtpdC1saW5lLWNvbnRlbnQiPjY8L2Rpdj4KK1s2XSAgICAg ICA8ZGl2IGNsYXNzPSJ3ZWJraXQtbGluZS1jb250ZW50Ij43PC9kaXY+CitbN10gICAgICAgPGRp diBjbGFzcz0id2Via2l0LWxpbmUtY29udGVudCI+ODwvZGl2PgorWzhdICAgICAgIDxkaXYgY2xh c3M9IndlYmtpdC1saW5lLWNvbnRlbnQiPjk8L2Rpdj4KKwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVz dHMvaW5zcGVjdG9yL2VkaXRvci90ZXh0LWVkaXRvci10eXBlLW92ZXItZGVjb3JhdGlvbi5odG1s IGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2VkaXRvci90ZXh0LWVkaXRvci10eXBlLW92ZXItZGVj b3JhdGlvbi5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmNkNGEwNWQxODBiZDdjNTg0MWM5ZWUyYTdhYTExNGE5 MzAyYzZmMGEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvZWRpdG9y L3RleHQtZWRpdG9yLXR5cGUtb3Zlci1kZWNvcmF0aW9uLmh0bWwKQEAgLTAsMCArMSwzNSBAQAor PGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9p bnNwZWN0b3ItdGVzdC5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iZWRpdG9yLXRlc3QuanM/ Zm9vPTE0MyI+PC9zY3JpcHQ+Cis8c2NyaXB0PgorCitmdW5jdGlvbiB0ZXN0KCkKK3sKKyAgICB2 YXIgdGV4dEVkaXRvciA9IEluc3BlY3RvclRlc3QuY3JlYXRlVGVzdEVkaXRvcigxMCk7CisgICAg dmFyIHRleHRNb2RlbCA9IHRleHRFZGl0b3IuX3RleHRNb2RlbDsKKworICAgIEluc3BlY3RvclRl c3QuZHVtcEVkaXRvckNodW5rcyh0ZXh0RWRpdG9yKTsKKyAgICB2YXIgZGVjb3JhdGlvbkVsZW1l bnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzcGFuIik7CisgICAgZGVjb3JhdGlvbkVsZW1l bnQudGV4dENvbnRlbnQgPSAiRGVjb3JhdGlvbiBjb250ZW50IjsKKyAgICB0ZXh0RWRpdG9yLmFk ZERlY29yYXRpb24oNSwgZGVjb3JhdGlvbkVsZW1lbnQpOworICAgIEluc3BlY3RvclRlc3QuZHVt cEVkaXRvckRPTSh0ZXh0RWRpdG9yKTsKKworICAgIC8vIEluc2VydCBFbnRlciBiZWZvcmUgdGhl IGRlY29yYXRpb24KKyAgICB2YXIgbGluZVJvd0VsZW1lbnQgPSBJbnNwZWN0b3JUZXN0LmdldExp bmVFbGVtZW50KHRleHRFZGl0b3IsIDUpOworICAgIGxpbmVSb3dFbGVtZW50LnBhcmVudEVsZW1l bnQuaW5zZXJ0QmVmb3JlKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKCJhIiksIGxpbmVSb3dFbGVt ZW50KTsKKyAgICB0ZXh0RWRpdG9yLl9tYWluUGFuZWwuX2FwcGx5RG9tVXBkYXRlcyh7c3RhcnQ6 NCwgZW5kOjV9KTsKKyAgICBJbnNwZWN0b3JUZXN0LmR1bXBFZGl0b3JET00odGV4dEVkaXRvcik7 CisgICAgSW5zcGVjdG9yVGVzdC5jb21wbGV0ZVRlc3QoKTsKK30KKworPC9zY3JpcHQ+Cis8L2hl YWQ+CisKKzxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KKzxwPgorVGhpcyB0ZXN0IGNoZWNrcyB0 aGF0IHR5cGluZyBvdmVyIHRoZSBkZWNvcmF0aW9uIGRvZXMgbm90IGNvbGxlY3QgZGVjb3JhdGlv biB0ZXh0IGFzIGEgcGFydCBvZiBkYW1hZ2VkIERPTS4KKzwvcD4KKworPC9ib2R5PgorPC9odG1s Pgo=