103929 2012-12-03 14:33:01 -0800 Disable WebKit2 api tests on Apple Windows port 2013-01-04 00:53:56 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 1 roger_fong webkit-unassigned adele andersca ap sam thorton oldest_to_newest 781891 0 roger_fong 2012-12-03 14:33:01 -0800 We will be disabling WebKit2 API tests. Disabling WebKit2 API tests for Windows port. 781902 1 177338 roger_fong 2012-12-03 14:48:49 -0800 Created attachment 177338 patch 781908 2 177338 thorton 2012-12-03 14:58:56 -0800 Comment on attachment 177338 patch Can we early-"next" instead of nesting the meat of the function? 781976 3 177358 roger_fong 2012-12-03 15:49:49 -0800 Created attachment 177358 patch 781989 4 177358 thorton 2012-12-03 15:57:06 -0800 Comment on attachment 177358 patch View in context: https://bugs.webkit.org/attachment.cgi?id=177358&action=review > Tools/Scripts/run-api-tests:276 > + } elsif (!isAppleWinWebKit() || $suite !~ m/WebKit2*/) { > + # Disabling WebKit2 API test on Windows since we will be disabling WebKit2 on Windows. A little wacky but better, but maybe use next to make it less wacky. 782002 5 177363 roger_fong 2012-12-03 16:09:17 -0800 Created attachment 177363 less whacky 782042 6 roger_fong 2012-12-03 16:53:13 -0800 http://trac.webkit.org/changeset/136456 800050 7 177363 eric 2013-01-04 00:53:56 -0800 Comment on attachment 177363 less whacky Cleared review? from attachment 177363 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 177338 2012-12-03 14:48:49 -0800 2012-12-03 15:49:49 -0800 patch apitestpatch.txt text/plain 1630 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNjQzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTEyLTAzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgRGlzYWJsZSBXZWJLaXQyIEFQSSB0ZXN0cyBvbiBBcHBsZSBXaW5kb3dzIHBv cnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM5 MjkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3J1bi1hcGktdGVzdHM6CisgICAgICAgIChydW5UZXN0c0J5U3VpdGUpOgorCiAyMDEy LTEyLTAzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIG5y d3Q6IGNsZWFuIHVwIGV4Y2VwdGlvbiBwcm9wYWdhdGlvbiAvIGhhbmRsaW5nIGZvciBpbnRlcnJ1 cHRzIGFuZCBlYXJseSBleGl0cwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cwkocmV2aXNpb24gMTM2Mjk4 KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0xMzQs MTIgKzEzNCwxNSBAQCBzdWIgcnVuVGVzdHNCeVN1aXRlKFxAJCkKICAgICBteSAkbGFzdFN1aXRl ID0gIiI7CiAgICAgZm9yIG15ICRzdWl0ZUFuZFRlc3QgKHNvcnQgQCR0ZXN0cykgewogICAgICAg ICBteSAoJHN1aXRlLCAkdGVzdCkgPSBzcGxpdCgvXC4vLCAkc3VpdGVBbmRUZXN0KTsKLSAgICAg ICAgaWYgKCRsYXN0U3VpdGUgbmUgJHN1aXRlKSB7Ci0gICAgICAgICAgICAkbGFzdFN1aXRlID0g JHN1aXRlOwotICAgICAgICAgICAgcHJpbnQgIlN1aXRlOiAkc3VpdGVcbiIgdW5sZXNzICR2ZXJi b3NlOworICAgICAgICAjIERpc2FibGluZyBXZWJLaXQyIEFQSSB0ZXN0IG9uIFdpbmRvd3Mgc2lu Y2Ugd2Ugd2lsbCBiZSBkaXNhYmxpbmcgV2ViS2l0MiBvbiBXaW5kb3dzLgorICAgICAgICBpZiAo aXNBcHBsZVdpbldlYktpdCgpICYmICRzdWl0ZSAhfiBtL1dlYktpdDIqLyl7CisgICAgICAgICAg ICBpZiAoJGxhc3RTdWl0ZSBuZSAkc3VpdGUpIHsKKyAgICAgICAgICAgICAgICAkbGFzdFN1aXRl ID0gJHN1aXRlOworICAgICAgICAgICAgICAgIHByaW50ICJTdWl0ZTogJHN1aXRlXG4iIHVubGVz cyAkdmVyYm9zZTsKKyAgICAgICAgICAgIH0KKyAgICAgICAgICAgIG15ICRmYWlsZWQgPSBydW5U ZXN0KCRzdWl0ZSwgJHRlc3QsICR2ZXJib3NlKTsKKyAgICAgICAgICAgICRhbnlGYWlsdXJlcyB8 fD0gJGZhaWxlZDsKICAgICAgICAgfQotICAgICAgICBteSAkZmFpbGVkID0gcnVuVGVzdCgkc3Vp dGUsICR0ZXN0LCAkdmVyYm9zZSk7Ci0gICAgICAgICRhbnlGYWlsdXJlcyB8fD0gJGZhaWxlZDsK ICAgICB9CiAgICAgCiAgICAgaWYgKCR2ZXJib3NlKSB7Cg== 177358 2012-12-03 15:49:49 -0800 2012-12-03 16:09:17 -0800 patch apitestspatch.txt text/plain 1230 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNjQzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTEyLTAzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgRGlzYWJsZSBXZWJLaXQyIEFQSSB0ZXN0cyBvbiBBcHBsZSBXaW5kb3dzIHBv cnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM5 MjkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3J1bi1hcGktdGVzdHM6CisgICAgICAgIChydW5UZXN0c0J5U3VpdGUpOgorCiAyMDEy LTEyLTAzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIG5y d3Q6IGNsZWFuIHVwIGV4Y2VwdGlvbiBwcm9wYWdhdGlvbiAvIGhhbmRsaW5nIGZvciBpbnRlcnJ1 cHRzIGFuZCBlYXJseSBleGl0cwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cwkocmV2aXNpb24gMTM2Mjk4 KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0yNzIs NyArMjcyLDggQEAgc3ViIGxpc3RBbGxUZXN0cygpCiAgICAgICAgJGxpbmUgPX4gcy9bXHJcbl0q JC8vOwogICAgICAgIGlmICgkbGluZSA9fiBtL1wuJC8pIHsKICAgICAgICAgICAkc3VpdGUgPSAk bGluZTsgIyAiU3VpdGVOYW1lLiIKLSAgICAgICB9IGVsc2UgeworICAgICAgIH0gZWxzaWYgKCFp c0FwcGxlV2luV2ViS2l0KCkgfHwgJHN1aXRlICF+IG0vV2ViS2l0MiovKSB7CisgICAgICAgICAg IyBEaXNhYmxpbmcgV2ViS2l0MiBBUEkgdGVzdCBvbiBXaW5kb3dzIHNpbmNlIHdlIHdpbGwgYmUg ZGlzYWJsaW5nIFdlYktpdDIgb24gV2luZG93cy4KICAgICAgICAgICAkbGluZSA9fiBzL15ccyov LzsgIyAiVGVzdE5hbWUiCiAgICAgICAgICAgcHVzaCBAdGVzdHMsICRzdWl0ZSAuICRsaW5lOyAj ICJTdWl0ZU5hbWUuVGVzdE5hbWUiCiAgICAgICAgIH0K 177363 2012-12-03 16:09:17 -0800 2013-01-04 00:53:56 -0800 less whacky apitest_final.txt text/plain 1205 roger_fong SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNjQzOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDEzIEBACisyMDEyLTEyLTAzICBSb2dlciBGb25nICA8cm9nZXJfZm9uZ0BhcHBsZS5jb20+ CisKKyAgICAgICAgRGlzYWJsZSBXZWJLaXQyIEFQSSB0ZXN0cyBvbiBBcHBsZSBXaW5kb3dzIHBv cnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM5 MjkuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBT Y3JpcHRzL3J1bi1hcGktdGVzdHM6CisgICAgICAgIChydW5UZXN0c0J5U3VpdGUpOgorCiAyMDEy LTEyLTAzICBEaXJrIFByYW5rZSAgPGRwcmFua2VAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIG5y d3Q6IGNsZWFuIHVwIGV4Y2VwdGlvbiBwcm9wYWdhdGlvbiAvIGhhbmRsaW5nIGZvciBpbnRlcnJ1 cHRzIGFuZCBlYXJseSBleGl0cwpJbmRleDogVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvcnVuLWFwaS10ZXN0cwkocmV2aXNpb24gMTM2Mjk4 KQorKysgVG9vbHMvU2NyaXB0cy9ydW4tYXBpLXRlc3RzCSh3b3JraW5nIGNvcHkpCkBAIC0yNzMs NiArMjczLDggQEAgc3ViIGxpc3RBbGxUZXN0cygpCiAgICAgICAgaWYgKCRsaW5lID1+IG0vXC4k LykgewogICAgICAgICAgICRzdWl0ZSA9ICRsaW5lOyAjICJTdWl0ZU5hbWUuIgogICAgICAgIH0g ZWxzZSB7CisgICAgICAgICAgIyBEaXNhYmxpbmcgV2ViS2l0MiBBUEkgdGVzdCBvbiBXaW5kb3dz IHNpbmNlIHdlIHdpbGwgYmUgZGlzYWJsaW5nIFdlYktpdDIgb24gV2luZG93cy4KKyAgICAgICAg ICBuZXh0IGlmIGlzQXBwbGVXaW5XZWJLaXQoKSAmJiAkc3VpdGUgPX4gbS9XZWJLaXQyKi87ICAg ICAgIAogICAgICAgICAgICRsaW5lID1+IHMvXlxzKi8vOyAjICJUZXN0TmFtZSIKICAgICAgICAg ICBwdXNoIEB0ZXN0cywgJHN1aXRlIC4gJGxpbmU7ICMgIlN1aXRlTmFtZS5UZXN0TmFtZSIKICAg ICAgICAgfQo=