103919 2012-12-03 13:08:29 -0800 Flex item auto margins in the cross direction should safe center 2012-12-05 02:26:58 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://plexode.com/eval3/#ht=%3Cdiv%20style%3D%22display%3A%20-webkit-flex%3B%20width%3A%20100px%3B%20height%3A%20100px%3B%20background-color%3A%20grey%3B%22%3E%0A%20%20%3Cdiv%20style%3D%22background-color%3A%20green%3B%20height%3A%20200px%3B%20width%3A%2020px%3B%20margin%3A%20auto%22%3E%3C%2Fdiv%3E%0A%3C%2Fdiv%3E P2 Normal --- 62048 1 tony webkit-unassigned cgarcia eric ojan webkit.review.bot oldest_to_newest 781799 0 tony 2012-12-03 13:08:29 -0800 See example in the URL. setting the margin to auto shouldn't overflow out the top of the flexbox. 781800 1 tony 2012-12-03 13:08:47 -0800 This would be a pretty easy bug to fix. 782564 2 177488 cgarcia 2012-12-04 08:24:00 -0800 Created attachment 177488 Patch 782634 3 177488 ojan 2012-12-04 09:52:21 -0800 Comment on attachment 177488 Patch Can you also add asserts in updateAutoMarginsInCrossAxis and updateAutoMarginsInMainAxis that the LayoutUnit passed in is >= 0? 782869 4 177488 tony 2012-12-04 13:40:58 -0800 Comment on attachment 177488 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177488&action=review > LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space.html:4 > +<style> > +body { Please use resources/flexbox.css and the styles defined there when possible. This makes the tests runnable in Firefox and makes it easy to add other vendor prefixes to the tests. 783561 5 177488 cgarcia 2012-12-05 02:26:43 -0800 Comment on attachment 177488 Patch Committed r136660: <http://trac.webkit.org/changeset/136660> 177488 2012-12-04 08:24:00 -0800 2012-12-05 02:26:43 -0800 Patch wk-flexbox-cross-axis-auto-margins.diff text/plain 4483 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1M2ViMDcyLi4zNzc5YmUyIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTItMTIt MDQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IEZsZXggaXRlbSBhdXRvIG1hcmdpbnMgaW4gdGhlIGNyb3NzIGRpcmVjdGlvbiBzaG91bGQgc2Fm ZSBjZW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMzkxOQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogY3NzMy9mbGV4Ym94L2ZsZXgtZmxvdy1hdXRvLW1hcmdpbnMtbm8tYXZhaWxhYmxlLXNwYWNl LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogY3NzMy9mbGV4Ym94L2ZsZXgtZmxvdy1h dXRvLW1hcmdpbnMtbm8tYXZhaWxhYmxlLXNwYWNlLmh0bWw6IEFkZGVkLgorCiAyMDEyLTEyLTA0 ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZp ZXdlZCBHVEsgZ2FyZGVuaW5nLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9n IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDkzNWFhMTMuLjAyMDA0ZWQgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu Z2VMb2cKQEAgLTEsNSArMSwyMiBAQAogMjAxMi0xMi0wNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3Mg IDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKKyAgICAgICAgRmxleCBpdGVtIGF1dG8gbWFyZ2lucyBp biB0aGUgY3Jvc3MgZGlyZWN0aW9uIHNob3VsZCBzYWZlIGNlbnRlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzOTE5CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG8gbm90IGFwcGx5IGF1dG8gbWFyZ2lu cyBmb3IgY3Jvc3MgYXhpcyBpZiB0aGVyZSdzIG5vIGFsaWdubWVudAorICAgICAgICBzcGFjZSBh dmFpbGFibGUuCisKKyAgICAgICAgVGVzdDogY3NzMy9mbGV4Ym94L2ZsZXgtZmxvdy1hdXRvLW1h cmdpbnMtbm8tYXZhaWxhYmxlLXNwYWNlLmh0bWwKKworICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJGbGV4aWJsZUJveC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6 YWxpZ25DaGlsZHJlbik6IE1ha2Ugc3VyZSB3ZSBwYXNzIGEKKyAgICAgICAgcG9zaXRpdmUgdmFs dWUgZm9yIGF2YWlsYWJsZUFsaWdubWVudFNwYWNlIHRvCisgICAgICAgIHVwZGF0ZUF1dG9NYXJn aW5zSW5Dcm9zc0F4aXMoKS4KKworMjAxMi0xMi0wNCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxj Z2FyY2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gVXNlIGEgcHJpdmF0ZSBzdHJ1Y3Qg YW5kIHBsYWNlbWVudCBuZXcgc3ludGF4IGluIEdPYmplY3QgRE9NIGJpbmRpbmdzCiAgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDEwNzQKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvY3NzMy9mbGV4Ym94L2ZsZXgtZmxvdy1hdXRvLW1hcmdpbnMtbm8t YXZhaWxhYmxlLXNwYWNlLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9m bGV4LWZsb3ctYXV0by1tYXJnaW5zLW5vLWF2YWlsYWJsZS1zcGFjZS1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uNjBhMGQ3MAotLS0gL2Rldi9udWxsCisr KyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9mbGV4LWZsb3ctYXV0by1tYXJnaW5zLW5vLWF2 YWlsYWJsZS1zcGFjZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSw1IEBACitQQVNTCisgUEFTUwor IFBBU1MKKyBQQVNTCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9mbGV4 LWZsb3ctYXV0by1tYXJnaW5zLW5vLWF2YWlsYWJsZS1zcGFjZS5odG1sIGIvTGF5b3V0VGVzdHMv Y3NzMy9mbGV4Ym94L2ZsZXgtZmxvdy1hdXRvLW1hcmdpbnMtbm8tYXZhaWxhYmxlLXNwYWNlLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uZWY5NjhhMAotLS0gL2Rldi9u dWxsCisrKyBiL0xheW91dFRlc3RzL2NzczMvZmxleGJveC9mbGV4LWZsb3ctYXV0by1tYXJnaW5z LW5vLWF2YWlsYWJsZS1zcGFjZS5odG1sCkBAIC0wLDAgKzEsNjcgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8c3R5bGU+Citib2R5IHsKKyAgICBtYXJnaW46IDA7Cit9CisuY29udGFpbmVy IHsKKyAgICBwb3NpdGlvbjogcmVsYXRpdmU7CisgICAgYmFja2dyb3VuZC1jb2xvcjogcGluazsK KyAgICBvdXRsaW5lOiAxcHggc29saWQgYmxhY2s7CisgICAgZGlzcGxheTogaW5saW5lLWJsb2Nr OworfQorLmZsZXhib3ggeworICAgIGRpc3BsYXk6IC13ZWJraXQtZmxleDsKKyAgICBiYWNrZ3Jv dW5kLWNvbG9yOiBncmV5OworICAgIHdpZHRoOiAxMDBweDsKKyAgICBoZWlnaHQ6IDEwMHB4Owor ICAgIG1hcmdpbjogMjBweDsKK30KKy5mbGV4Ym94ID4gKiB7CisgICAgLXdlYmtpdC1mbGV4OiBu b25lOworfQorLnJvdyB7CisgICAgLXdlYmtpdC1mbGV4LWZsb3c6IHJvdzsKK30KKy5yb3ctcmV2 ZXJzZSB7CisgICAgLXdlYmtpdC1mbGV4LWZsb3c6IHJvdy1yZXZlcnNlOworfQorLmNvbHVtbiB7 CisgICAgLXdlYmtpdC1mbGV4LWZsb3c6IGNvbHVtbjsKK30KKy5jb2x1bW4tcmV2ZXJzZSB7Cisg ICAgLXdlYmtpdC1mbGV4LWZsb3c6IGNvbHVtbi1yZXZlcnNlOworfQorLmZsZXhib3ggPiA6bnRo LWNoaWxkKDEpIHsKKyAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOworICAgIG1hcmdpbjogYXV0 bzsKK30KKzwvc3R5bGU+Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2NoZWNrLWxheW91 dC5qcyI+PC9zY3JpcHQ+Cis8Ym9keSBvbmxvYWQ9ImNoZWNrTGF5b3V0KCcuZmxleGJveCcpIj4K KworPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgPGRpdiBjbGFzcz0iZmxleGJveCByb3ciPgor ICAgIDxkaXYgZGF0YS1vZmZzZXQteD02MCBkYXRhLW9mZnNldC15PTIwIHN0eWxlPSJ3aWR0aDog MjBweDsgaGVpZ2h0OiAxMjBweCI+PC9kaXY+CisgIDwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xh c3M9ImNvbnRhaW5lciI+CisgIDxkaXYgY2xhc3M9ImZsZXhib3ggcm93LXJldmVyc2UiPgorICAg IDxkaXYgZGF0YS1vZmZzZXQteD02MCBkYXRhLW9mZnNldC15PTIwIHN0eWxlPSJ3aWR0aDogMjBw eDsgaGVpZ2h0OiAxMjBweCI+PC9kaXY+CisgIDwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xhc3M9 ImNvbnRhaW5lciI+CisgIDxkaXYgY2xhc3M9ImZsZXhib3ggY29sdW1uIj4KKyAgICA8ZGl2IGRh dGEtb2Zmc2V0LXg9MjAgZGF0YS1vZmZzZXQteT02MCBzdHlsZT0id2lkdGg6IDEyMHB4OyBoZWln aHQ6IDIwcHgiPjwvZGl2PgorICA8L2Rpdj4KKzwvZGl2PgorCis8ZGl2IGNsYXNzPSJjb250YWlu ZXIiPgorICA8ZGl2IGNsYXNzPSJmbGV4Ym94IGNvbHVtbi1yZXZlcnNlIj4KKyAgICA8ZGl2IGRh dGEtb2Zmc2V0LXg9MjAgZGF0YS1vZmZzZXQteT02MCBzdHlsZT0id2lkdGg6IDEyMHB4OyBoZWln aHQ6IDIwcHgiPjwvZGl2PgorICA8L2Rpdj4KKzwvZGl2PgorPC9ib2R5PgorPC9odG1sPgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZsZXhpYmxlQm94LmNwcCBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGbGV4aWJsZUJveC5jcHAKaW5kZXggNDEw YzVkMS4uYTQ2OTM3MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckZsZXhpYmxlQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRmxl eGlibGVCb3guY3BwCkBAIC0xMjczLDcgKzEyNzMsNyBAQCB2b2lkIFJlbmRlckZsZXhpYmxlQm94 OjphbGlnbkNoaWxkcmVuKE9yZGVySXRlcmF0b3ImIGl0ZXJhdG9yLCBjb25zdCBXVEY6OlZlY3Rv cgogICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogICAgICAgICAgICAgfQogCi0gICAgICAgICAg ICBpZiAodXBkYXRlQXV0b01hcmdpbnNJbkNyb3NzQXhpcyhjaGlsZCwgYXZhaWxhYmxlQWxpZ25t ZW50U3BhY2VGb3JDaGlsZChsaW5lQ3Jvc3NBeGlzRXh0ZW50LCBjaGlsZCkpKQorICAgICAgICAg ICAgaWYgKHVwZGF0ZUF1dG9NYXJnaW5zSW5Dcm9zc0F4aXMoY2hpbGQsIHN0ZDo6bWF4KExheW91 dFVuaXQoMCksIGF2YWlsYWJsZUFsaWdubWVudFNwYWNlRm9yQ2hpbGQobGluZUNyb3NzQXhpc0V4 dGVudCwgY2hpbGQpKSkpCiAgICAgICAgICAgICAgICAgY29udGludWU7CiAKICAgICAgICAgICAg IHN3aXRjaCAoYWxpZ25tZW50Rm9yQ2hpbGQoY2hpbGQpKSB7Cg==