103918 2012-12-03 12:42:41 -0800 [CMake] Enable building WebKit sources without Tools 2012-12-05 11:00:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned gyuyoung.kim kenneth mxie paroga rakuco webkit.review.bot oldest_to_newest 781782 0 laszlo.gombos 2012-12-03 12:42:41 -0800 This build configuration could be useful for: - downstream in a productization branch for package maintainers) where Tools directory might not be used/needed - building just WebKit sources without building Tools for faster build times - ENABLE_TOOLS cmake variable was always set to true, which made not much sense - we should allow it to be configurable 781787 1 177313 laszlo.gombos 2012-12-03 12:54:34 -0800 Created attachment 177313 proposed patch Also moved a section of the code so that the TOOLS_DIR variable is initialized before it gets used. As a test I create a directory with only CMakeLists.txt file and the Source directory in it and successfully built the EFL WebKit port from it by invoking cmake directly (instead of using the build-webkit script). 783360 2 177313 gyuyoung.kim 2012-12-04 21:17:17 -0800 Comment on attachment 177313 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=177313&action=review Looks find on my side. > CMakeLists.txt:-14 > -SET(ENABLE_WEBCORE ON) Should we move existing place to here ? 783373 3 177313 gyuyoung.kim 2012-12-04 21:25:08 -0800 Comment on attachment 177313 proposed patch typo : find -> fine. 783905 4 laszlo.gombos 2012-12-05 10:54:31 -0800 (In reply to comment #2) > (From update of attachment 177313 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=177313&action=review > > Looks find on my side. > > > CMakeLists.txt:-14 > > -SET(ENABLE_WEBCORE ON) > > Should we move existing place to here ? This should be done together with a bigger refactoring as a separate patch. I think this variable should not even be exposed at this level and should be moved under Source - see bug 104083. 783908 5 177313 webkit.review.bot 2012-12-05 11:00:10 -0800 Comment on attachment 177313 proposed patch Clearing flags on attachment: 177313 Committed r136715: <http://trac.webkit.org/changeset/136715> 783909 6 webkit.review.bot 2012-12-05 11:00:15 -0800 All reviewed patches have been landed. Closing bug. 177313 2012-12-03 12:54:34 -0800 2012-12-05 11:00:10 -0800 proposed patch 103918.patch text/plain 1861 laszlo.gombos SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjQy OCkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTEy LTAzICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NN YWtlXSBFbmFibGUgdG8gYnVpbGQgV2ViS2l0IHNvdXJjZXMgd2l0aG91dCBUb29scworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzOTE4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVHVybiBvbiBidWlsZGlu ZyBUb29scyBieSBkZWZhdWx0IG9ubHkgaWYgRU5BQkxFX1RPT0xTIGlzIG5vdCBleHBsaWNpdGx5 IHNldAorICAgICAgICAoZW5hYmxlZCBvciBkaXNhYmxlZCkgYW5kIHRoZSBUb29scyBkaXJlY3Rv cnkgZXhpc3RzIGZvciBhbGwgQ01ha2UgYmFzZWQgcG9ydHMuCisKKyAgICAgICAgVGhpcyBjaGFu Z2UgZW5hYmxlcyB0aGUgcG9zc2liaWxpdHkgdG8gYnVpbGQgV2ViS2l0IGV2ZW4gaWYgdGhlIFRv b2xzIGRpcmVjdG9yeSAKKyAgICAgICAgZG9lcyBub3QgZXhpc3RzLgorCisgICAgICAgICogQ01h a2VMaXN0cy50eHQ6CisKIDIwMTItMTItMDMgIEFsZXhpcyBNZW5hcmQgIDxhbGV4aXNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBbRUZMXSBFbmFibGUgQ1NTMyBiYWNrZ3JvdW5kLXBvc2l0aW9uIG9m ZnNldHMgYnkgZGVmYXVsdC4KSW5kZXg6IENNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIENN YWtlTGlzdHMudHh0CShyZXZpc2lvbiAxMzYzOTkpCisrKyBDTWFrZUxpc3RzLnR4dAkod29ya2lu ZyBjb3B5KQpAQCAtMTEsMTQgKzExLDYgQEAgRU5ESUYgKCkKICMgLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0KICMgRGVmYXVsdCBsaWJyYXJ5IHR5cGUKICMgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KLVNFVChF TkFCTEVfV0VCQ09SRSBPTikKLQotSUYgKE5PVCBERUZJTkVEIEVOQUJMRV9XRUJLSVQpCi0gICAg U0VUKEVOQUJMRV9XRUJLSVQgT04pCi1FTkRJRiAoKQotCi1TRVQoRU5BQkxFX1RPT0xTIE9OKQot CiBTRVQoV1RGX0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV1RGIikKIFNFVChKQVZB U0NSSVBUQ09SRV9ESVIgIiR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlL0phdmFTY3JpcHRDb3Jl IikKIFNFVChXRUJDT1JFX0RJUiAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2UvV2ViQ29yZSIp CkBAIC0zNiw2ICsyOCwxNiBAQCBTRVQoREVSSVZFRF9TT1VSQ0VTX1dFQktJVDJfRElSICIke0NN QUtFCiAKIFNFVChDTUFLRV9NT0RVTEVfUEFUSCAiJHtDTUFLRV9TT1VSQ0VfRElSfS9Tb3VyY2Uv Y21ha2UiKQogCitTRVQoRU5BQkxFX1dFQkNPUkUgT04pCisKK0lGIChOT1QgREVGSU5FRCBFTkFC TEVfV0VCS0lUKQorICAgIFNFVChFTkFCTEVfV0VCS0lUIE9OKQorRU5ESUYgKCkKKworSUYgKE5P VCBERUZJTkVEIEVOQUJMRV9UT09MUyBBTkQgRVhJU1RTICR7VE9PTFNfRElSfSkKKyAgICBTRVQo RU5BQkxFX1RPT0xTIE9OKQorRU5ESUYoKQorCiBJTkNMVURFKFdlYktpdE1hY3JvcykKIElOQ0xV REUoV2ViS2l0RlMpCiBJTkNMVURFKFdlYktpdEhlbHBlcnMpCg==