103912 2012-12-03 11:44:09 -0800 setIsInTopLayer is not really a setter 2012-12-04 14:44:19 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn abarth cmarcelo dglazkov dpranke eric jchaffraix ojan webkit.review.bot wsiegrist oldest_to_newest 781720 0 esprehn 2012-12-03 11:44:09 -0800 setIsInTopLayer is not really a setter 781728 1 177298 esprehn 2012-12-03 11:48:38 -0800 Created attachment 177298 Patch 781761 2 177298 eric 2012-12-03 12:24:19 -0800 Comment on attachment 177298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177298&action=review > Source/WebCore/html/HTMLDialogElement.cpp:56 > - setIsInTopLayer(false); > + document()->addToTopLayer(this); Isn't this reversed? 781764 3 177298 esprehn 2012-12-03 12:26:23 -0800 Comment on attachment 177298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177298&action=review >> Source/WebCore/html/HTMLDialogElement.cpp:56 >> + document()->addToTopLayer(this); > > Isn't this reversed? Err, yes it is. 781765 4 eric 2012-12-03 12:28:40 -0800 Should I be concerned that tests didn't catch that? (Or is it just that they hadn't run yet.) 781768 5 esprehn 2012-12-03 12:30:49 -0800 (In reply to comment #4) > Should I be concerned that tests didn't catch that? (Or is it just that they hadn't run yet.) There's definitely dialog tests for when they display, it seems the mac port doesn't enable the build flag for dialog and the chromium bot is busted and not applying patches :/ 781771 6 177307 esprehn 2012-12-03 12:31:12 -0800 Created attachment 177307 Patch 781772 7 177307 eric 2012-12-03 12:33:35 -0800 Comment on attachment 177307 Patch OK. 781792 8 177307 webkit.review.bot 2012-12-03 12:57:59 -0800 Comment on attachment 177307 Patch Attachment 177307 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15106603 781832 9 177316 esprehn 2012-12-03 13:40:16 -0800 Created attachment 177316 Patch 781835 10 esprehn 2012-12-03 13:40:52 -0800 (In reply to comment #9) > Created an attachment (id=177316) [details] > Patch Stupid typo, setInTopLayer => setIsInTopLayer. 781949 11 177316 webkit.review.bot 2012-12-03 15:31:02 -0800 Comment on attachment 177316 Patch Rejecting attachment 177316 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: ripts/update-webkit line 152. Failed to run "['Tools/Scripts/update-webkit', '--chromium', '--force-update']" exit_code: 2 Updating OpenSource From http://git.chromium.org/external/Webkit f10c1a4..e507ad4 HEAD -> origin/HEAD error: Ref refs/remotes/origin/master is at e507ad4c79d65f31547bf48bfa32467849b3b8e5 but expected f10c1a4675c348ff6c5220ad7a631f0f400f381a ! f10c1a4..e507ad4 master -> origin/master (unable to update local ref) Died at Tools/Scripts/update-webkit line 152. Full output: http://queues.webkit.org/results/15120536 781952 12 eric 2012-12-03 15:32:48 -0800 Either the cq-bot's checkout is hosed, or the git.webkit.org master is confused... or both. 782965 13 177316 dpranke 2012-12-04 14:44:15 -0800 Comment on attachment 177316 Patch Clearing flags on attachment: 177316 Committed r136575: <http://trac.webkit.org/changeset/136575> 782966 14 dpranke 2012-12-04 14:44:19 -0800 All reviewed patches have been landed. Closing bug. 177298 2012-12-03 11:48:38 -0800 2012-12-03 12:31:10 -0800 Patch bug-103912-20121203114559.patch text/plain 4335 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTJjYjA2MzliZGY0ODQ5 MTRhMDQ5YTNjM2JhNmFhMWNjMjViOWEwNS4uZDc2ZGI1MjZkYmRhMWNmNDVmOTFkNmViMTk1YzQy NGQxNjkwMjRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTEyLTAzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIHNldElzSW5Ub3BM YXllciBpcyBub3QgcmVhbGx5IGEgc2V0dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM5MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFbGVtZW50OjpzZXRJblRvcExheWVyIGlzbid0IGp1c3QgYSBz ZXR0ZXIsIGl0IGFsc28gYWRkcyB0aGUgZWxlbWVudAorICAgICAgICB0byB0aGUgdG9wIGxheWVy IHZlY3RvciBpbiB0aGUgZG9jdW1lbnQgd2hpY2ggY2hhbmdlcyBpdCdzIGRpc3BsYXkgYW5kCisg ICAgICAgIGNhdXNlcyBhIHJlYXR0YWNoLgorCisgICAgICAgIFRvIG1ha2UgdGhpcyBtb3JlIG9i dmlvdXMgbWFrZSBIVE1MRGlhbG9nRWxlbWVudCB1c2UgdGhlIG1ldGhvZHMgb24KKyAgICAgICAg RG9jdW1lbnQgYW5kIG1ha2UgdGhvc2UgdXBkYXRlIHRoZSBzdGF0ZSBib29sZWFuLgorCisgICAg ICAgIFRoZXJlIGFsc28gZG9lc24ndCBzZWVtIHRvIGJlIGFueSByZWFzb24gZm9yIHNldEluVG9w TGF5ZXIKKyAgICAgICAgb3IgaXNJblRvcExheWVyIHRvIGJlIHZpcnR1YWwsIGl0IGFwcGVhcnMg aXQgd2FzIGEgdHlwby4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVmYWN0b3Jpbmcu CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OmFkZFRvVG9wTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnJlbW92ZUZy b21Ub3BMYXllcik6CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6c2V0SXNJblRvcExheWVyKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgor ICAgICAgICAqIGh0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTERpYWxvZ0VsZW1lbnQ6OmNsb3NlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dF bGVtZW50OjpzaG93TW9kYWwpOgorCiAyMDEyLTEyLTAzICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRy ZXlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDYW52YXNdIHNob3cg cmVwbGF5IHNjcmVlbnNob3Qgb2YgdGhlIGxhc3QgY2FsbCdzIGNhbnZhcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKaW5kZXggZjgwNTZhZTRjMGE4NDY2YjRlODkzNTFhN2FmYjFkMzIwMTkwYjMzOS4u OTkyY2NiNzgxZjI4ZDczNDUwZjU3M2VjMTkzYmQ3ZDcxM2IwYzVkYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCkBAIC01NDI2LDE1ICs1NDI2LDIxIEBAIHZvaWQgRG9jdW1lbnQ6OmFkZERvY3Vt ZW50VG9GdWxsU2NyZWVuQ2hhbmdlRXZlbnRRdWV1ZShEb2N1bWVudCogZG9jKQogI2lmIEVOQUJM RShESUFMT0dfRUxFTUVOVCkKIHZvaWQgRG9jdW1lbnQ6OmFkZFRvVG9wTGF5ZXIoRWxlbWVudCog ZWxlbWVudCkKIHsKKyAgICBpZiAoZWxlbWVudC0+aXNJblRvcExheWVyKCkpCisgICAgICAgIHJl dHVybjsKICAgICBBU1NFUlQoIW1fdG9wTGF5ZXJFbGVtZW50cy5jb250YWlucyhlbGVtZW50KSk7 CiAgICAgbV90b3BMYXllckVsZW1lbnRzLmFwcGVuZChlbGVtZW50KTsKKyAgICBlbGVtZW50LT5z ZXRJblRvcExheWVyKHRydWUpOwogfQogCiB2b2lkIERvY3VtZW50OjpyZW1vdmVGcm9tVG9wTGF5 ZXIoRWxlbWVudCogZWxlbWVudCkKIHsKKyAgICBpZiAoIWVsZW1lbnQtPmlzSW5Ub3BMYXllcigp KQorICAgICAgICByZXR1cm47CiAgICAgc2l6ZV90IHBvc2l0aW9uID0gbV90b3BMYXllckVsZW1l bnRzLmZpbmQoZWxlbWVudCk7CiAgICAgQVNTRVJUKHBvc2l0aW9uICE9IG5vdEZvdW5kKTsKICAg ICBtX3RvcExheWVyRWxlbWVudHMucmVtb3ZlKHBvc2l0aW9uKTsKKyAgICBlbGVtZW50LT5zZXRJ blRvcExheWVyKGZhbHNlKTsKIH0KICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXgg NGRjMGM1ZGY1M2E5MjNiZjliZTljZjBhZWZlNDI3M2VkNDBkN2ZlNC4uMTM2MWYwZjU2NWU0MjJh ZjIzOWU2YTA5ZDg4YmI0ZDZmMDYyZDE0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMjIz NCwxNSArMjIzNCw3IEBAIGJvb2wgRWxlbWVudDo6aXNJblRvcExheWVyKCkgY29uc3QKIAogdm9p ZCBFbGVtZW50OjpzZXRJc0luVG9wTGF5ZXIoYm9vbCBpblRvcExheWVyKQogewotICAgIGlmIChp c0luVG9wTGF5ZXIoKSA9PSBpblRvcExheWVyKQotICAgICAgICByZXR1cm47Ci0KICAgICBlbnN1 cmVFbGVtZW50UmFyZURhdGEoKS0+c2V0SXNJblRvcExheWVyKGluVG9wTGF5ZXIpOwotCi0gICAg aWYgKGluVG9wTGF5ZXIpCi0gICAgICAgIGRvY3VtZW50KCktPmFkZFRvVG9wTGF5ZXIodGhpcyk7 Ci0gICAgZWxzZQotICAgICAgICBkb2N1bWVudCgpLT5yZW1vdmVGcm9tVG9wTGF5ZXIodGhpcyk7 CiAgICAgc2V0TmVlZHNTdHlsZVJlY2FsYyhTeW50aGV0aWNTdHlsZUNoYW5nZSk7CiB9CiAjZW5k aWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5oCmluZGV4IGEyNDU5NGY1ZTZiZDgxNzM2NDM3YWNmNWVlNWVjMzc5 YzFmODg2ZWQuLjE4OGNhNTU1ZWI2YzVkOGVjMjg2ODUzNWNkMTAxMjkwYmFmMTMxNjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuaApAQCAtNDM3LDggKzQzNyw4IEBAIHB1YmxpYzoKICNlbmRpZgogCiAjaWYg RU5BQkxFKERJQUxPR19FTEVNRU5UKQotICAgIHZpcnR1YWwgYm9vbCBpc0luVG9wTGF5ZXIoKSBj b25zdDsKLSAgICB2aXJ0dWFsIHZvaWQgc2V0SXNJblRvcExheWVyKGJvb2wpOworICAgIGJvb2wg aXNJblRvcExheWVyKCkgY29uc3Q7CisgICAgdm9pZCBzZXRJc0luVG9wTGF5ZXIoYm9vbCk7CiAj ZW5kaWYKIAogI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TERpYWxvZ0VsZW1lbnQuY3BwCmluZGV4IDI5NTBmYmE2YjJlNWVjZjVjZmE5MmY5ZWU4N2IzYzgz MjkzNzNkNGYuLmU5ZDU2ODMzMTU1YTZkMDAyNzhlNDE3MTRjNDdlOWRjM2E1ZmEzNGMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwCkBAIC01Myw3ICs1Myw3IEBA IHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OmNsb3NlKEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgICAg ICByZXR1cm47CiAgICAgfQogICAgIHNldEJvb2xlYW5BdHRyaWJ1dGUob3BlbkF0dHIsIGZhbHNl KTsKLSAgICBzZXRJc0luVG9wTGF5ZXIoZmFsc2UpOworICAgIGRvY3VtZW50KCktPmFkZFRvVG9w TGF5ZXIodGhpcyk7CiB9CiAKIHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnNob3coKQpAQCAtNzAs NyArNzAsNyBAQCB2b2lkIEhUTUxEaWFsb2dFbGVtZW50OjpzaG93TW9kYWwoRXhjZXB0aW9uQ29k ZSYgZWMpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgc2V0Qm9vbGVhbkF0dHJpYnV0ZShv cGVuQXR0ciwgdHJ1ZSk7Ci0gICAgc2V0SXNJblRvcExheWVyKHRydWUpOworICAgIGRvY3VtZW50 KCktPnJlbW92ZUZyb21Ub3BMYXllcih0aGlzKTsKIH0KIAogYm9vbCBIVE1MRGlhbG9nRWxlbWVu dDo6aXNQcmVzZW50YXRpb25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29u c3QK 177307 2012-12-03 12:31:12 -0800 2012-12-03 13:40:14 -0800 Patch bug-103912-20121203122838.patch text/plain 4335 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTJjYjA2MzliZGY0ODQ5 MTRhMDQ5YTNjM2JhNmFhMWNjMjViOWEwNS4uZDc2ZGI1MjZkYmRhMWNmNDVmOTFkNmViMTk1YzQy NGQxNjkwMjRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTEyLTAzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIHNldElzSW5Ub3BM YXllciBpcyBub3QgcmVhbGx5IGEgc2V0dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM5MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFbGVtZW50OjpzZXRJblRvcExheWVyIGlzbid0IGp1c3QgYSBz ZXR0ZXIsIGl0IGFsc28gYWRkcyB0aGUgZWxlbWVudAorICAgICAgICB0byB0aGUgdG9wIGxheWVy IHZlY3RvciBpbiB0aGUgZG9jdW1lbnQgd2hpY2ggY2hhbmdlcyBpdCdzIGRpc3BsYXkgYW5kCisg ICAgICAgIGNhdXNlcyBhIHJlYXR0YWNoLgorCisgICAgICAgIFRvIG1ha2UgdGhpcyBtb3JlIG9i dmlvdXMgbWFrZSBIVE1MRGlhbG9nRWxlbWVudCB1c2UgdGhlIG1ldGhvZHMgb24KKyAgICAgICAg RG9jdW1lbnQgYW5kIG1ha2UgdGhvc2UgdXBkYXRlIHRoZSBzdGF0ZSBib29sZWFuLgorCisgICAg ICAgIFRoZXJlIGFsc28gZG9lc24ndCBzZWVtIHRvIGJlIGFueSByZWFzb24gZm9yIHNldEluVG9w TGF5ZXIKKyAgICAgICAgb3IgaXNJblRvcExheWVyIHRvIGJlIHZpcnR1YWwsIGl0IGFwcGVhcnMg aXQgd2FzIGEgdHlwby4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVmYWN0b3Jpbmcu CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OmFkZFRvVG9wTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnJlbW92ZUZy b21Ub3BMYXllcik6CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6c2V0SXNJblRvcExheWVyKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgor ICAgICAgICAqIGh0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTERpYWxvZ0VsZW1lbnQ6OmNsb3NlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dF bGVtZW50OjpzaG93TW9kYWwpOgorCiAyMDEyLTEyLTAzICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRy ZXlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDYW52YXNdIHNob3cg cmVwbGF5IHNjcmVlbnNob3Qgb2YgdGhlIGxhc3QgY2FsbCdzIGNhbnZhcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKaW5kZXggZjgwNTZhZTRjMGE4NDY2YjRlODkzNTFhN2FmYjFkMzIwMTkwYjMzOS4u OTkyY2NiNzgxZjI4ZDczNDUwZjU3M2VjMTkzYmQ3ZDcxM2IwYzVkYSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCkBAIC01NDI2LDE1ICs1NDI2LDIxIEBAIHZvaWQgRG9jdW1lbnQ6OmFkZERvY3Vt ZW50VG9GdWxsU2NyZWVuQ2hhbmdlRXZlbnRRdWV1ZShEb2N1bWVudCogZG9jKQogI2lmIEVOQUJM RShESUFMT0dfRUxFTUVOVCkKIHZvaWQgRG9jdW1lbnQ6OmFkZFRvVG9wTGF5ZXIoRWxlbWVudCog ZWxlbWVudCkKIHsKKyAgICBpZiAoZWxlbWVudC0+aXNJblRvcExheWVyKCkpCisgICAgICAgIHJl dHVybjsKICAgICBBU1NFUlQoIW1fdG9wTGF5ZXJFbGVtZW50cy5jb250YWlucyhlbGVtZW50KSk7 CiAgICAgbV90b3BMYXllckVsZW1lbnRzLmFwcGVuZChlbGVtZW50KTsKKyAgICBlbGVtZW50LT5z ZXRJblRvcExheWVyKHRydWUpOwogfQogCiB2b2lkIERvY3VtZW50OjpyZW1vdmVGcm9tVG9wTGF5 ZXIoRWxlbWVudCogZWxlbWVudCkKIHsKKyAgICBpZiAoIWVsZW1lbnQtPmlzSW5Ub3BMYXllcigp KQorICAgICAgICByZXR1cm47CiAgICAgc2l6ZV90IHBvc2l0aW9uID0gbV90b3BMYXllckVsZW1l bnRzLmZpbmQoZWxlbWVudCk7CiAgICAgQVNTRVJUKHBvc2l0aW9uICE9IG5vdEZvdW5kKTsKICAg ICBtX3RvcExheWVyRWxlbWVudHMucmVtb3ZlKHBvc2l0aW9uKTsKKyAgICBlbGVtZW50LT5zZXRJ blRvcExheWVyKGZhbHNlKTsKIH0KICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXgg NGRjMGM1ZGY1M2E5MjNiZjliZTljZjBhZWZlNDI3M2VkNDBkN2ZlNC4uMTM2MWYwZjU2NWU0MjJh ZjIzOWU2YTA5ZDg4YmI0ZDZmMDYyZDE0ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMjIz NCwxNSArMjIzNCw3IEBAIGJvb2wgRWxlbWVudDo6aXNJblRvcExheWVyKCkgY29uc3QKIAogdm9p ZCBFbGVtZW50OjpzZXRJc0luVG9wTGF5ZXIoYm9vbCBpblRvcExheWVyKQogewotICAgIGlmIChp c0luVG9wTGF5ZXIoKSA9PSBpblRvcExheWVyKQotICAgICAgICByZXR1cm47Ci0KICAgICBlbnN1 cmVFbGVtZW50UmFyZURhdGEoKS0+c2V0SXNJblRvcExheWVyKGluVG9wTGF5ZXIpOwotCi0gICAg aWYgKGluVG9wTGF5ZXIpCi0gICAgICAgIGRvY3VtZW50KCktPmFkZFRvVG9wTGF5ZXIodGhpcyk7 Ci0gICAgZWxzZQotICAgICAgICBkb2N1bWVudCgpLT5yZW1vdmVGcm9tVG9wTGF5ZXIodGhpcyk7 CiAgICAgc2V0TmVlZHNTdHlsZVJlY2FsYyhTeW50aGV0aWNTdHlsZUNoYW5nZSk7CiB9CiAjZW5k aWYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmggYi9Tb3VyY2UvV2Vi Q29yZS9kb20vRWxlbWVudC5oCmluZGV4IGEyNDU5NGY1ZTZiZDgxNzM2NDM3YWNmNWVlNWVjMzc5 YzFmODg2ZWQuLjE4OGNhNTU1ZWI2YzVkOGVjMjg2ODUzNWNkMTAxMjkwYmFmMTMxNjUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUv ZG9tL0VsZW1lbnQuaApAQCAtNDM3LDggKzQzNyw4IEBAIHB1YmxpYzoKICNlbmRpZgogCiAjaWYg RU5BQkxFKERJQUxPR19FTEVNRU5UKQotICAgIHZpcnR1YWwgYm9vbCBpc0luVG9wTGF5ZXIoKSBj b25zdDsKLSAgICB2aXJ0dWFsIHZvaWQgc2V0SXNJblRvcExheWVyKGJvb2wpOworICAgIGJvb2wg aXNJblRvcExheWVyKCkgY29uc3Q7CisgICAgdm9pZCBzZXRJc0luVG9wTGF5ZXIoYm9vbCk7CiAj ZW5kaWYKIAogI2lmIEVOQUJMRShQT0lOVEVSX0xPQ0spCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TERpYWxvZ0VsZW1lbnQuY3BwCmluZGV4IDI5NTBmYmE2YjJlNWVjZjVjZmE5MmY5ZWU4N2IzYzgz MjkzNzNkNGYuLmI3OTkxNGUwZWFlODg5YTc0MGZlMmFhNzM3ODViN2U4NzdkZWE5ZTMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2h0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwCkBAIC01Myw3ICs1Myw3IEBA IHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OmNsb3NlKEV4Y2VwdGlvbkNvZGUmIGVjKQogICAgICAg ICByZXR1cm47CiAgICAgfQogICAgIHNldEJvb2xlYW5BdHRyaWJ1dGUob3BlbkF0dHIsIGZhbHNl KTsKLSAgICBzZXRJc0luVG9wTGF5ZXIoZmFsc2UpOworICAgIGRvY3VtZW50KCktPnJlbW92ZUZy b21Ub3BMYXllcih0aGlzKTsKIH0KIAogdm9pZCBIVE1MRGlhbG9nRWxlbWVudDo6c2hvdygpCkBA IC03MCw3ICs3MCw3IEBAIHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnNob3dNb2RhbChFeGNlcHRp b25Db2RlJiBlYykKICAgICAgICAgcmV0dXJuOwogICAgIH0KICAgICBzZXRCb29sZWFuQXR0cmli dXRlKG9wZW5BdHRyLCB0cnVlKTsKLSAgICBzZXRJc0luVG9wTGF5ZXIodHJ1ZSk7CisgICAgZG9j dW1lbnQoKS0+YWRkVG9Ub3BMYXllcih0aGlzKTsKIH0KIAogYm9vbCBIVE1MRGlhbG9nRWxlbWVu dDo6aXNQcmVzZW50YXRpb25BdHRyaWJ1dGUoY29uc3QgUXVhbGlmaWVkTmFtZSYgbmFtZSkgY29u c3QK 177316 2012-12-03 13:40:16 -0800 2012-12-04 14:44:15 -0800 Patch bug-103912-20121203133743.patch text/plain 4339 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTJjYjA2MzliZGY0ODQ5 MTRhMDQ5YTNjM2JhNmFhMWNjMjViOWEwNS4uZDc2ZGI1MjZkYmRhMWNmNDVmOTFkNmViMTk1YzQy NGQxNjkwMjRmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMyIEBACisyMDEyLTEyLTAzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIHNldElzSW5Ub3BM YXllciBpcyBub3QgcmVhbGx5IGEgc2V0dGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM5MTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBFbGVtZW50OjpzZXRJblRvcExheWVyIGlzbid0IGp1c3QgYSBz ZXR0ZXIsIGl0IGFsc28gYWRkcyB0aGUgZWxlbWVudAorICAgICAgICB0byB0aGUgdG9wIGxheWVy IHZlY3RvciBpbiB0aGUgZG9jdW1lbnQgd2hpY2ggY2hhbmdlcyBpdCdzIGRpc3BsYXkgYW5kCisg ICAgICAgIGNhdXNlcyBhIHJlYXR0YWNoLgorCisgICAgICAgIFRvIG1ha2UgdGhpcyBtb3JlIG9i dmlvdXMgbWFrZSBIVE1MRGlhbG9nRWxlbWVudCB1c2UgdGhlIG1ldGhvZHMgb24KKyAgICAgICAg RG9jdW1lbnQgYW5kIG1ha2UgdGhvc2UgdXBkYXRlIHRoZSBzdGF0ZSBib29sZWFuLgorCisgICAg ICAgIFRoZXJlIGFsc28gZG9lc24ndCBzZWVtIHRvIGJlIGFueSByZWFzb24gZm9yIHNldEluVG9w TGF5ZXIKKyAgICAgICAgb3IgaXNJblRvcExheWVyIHRvIGJlIHZpcnR1YWwsIGl0IGFwcGVhcnMg aXQgd2FzIGEgdHlwby4KKworICAgICAgICBObyBuZXcgdGVzdHMsIGp1c3QgcmVmYWN0b3Jpbmcu CisKKyAgICAgICAgKiBkb20vRG9jdW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OmFkZFRvVG9wTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnJlbW92ZUZy b21Ub3BMYXllcik6CisgICAgICAgICogZG9tL0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RWxlbWVudDo6c2V0SXNJblRvcExheWVyKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgor ICAgICAgICAqIGh0bWwvSFRNTERpYWxvZ0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 SFRNTERpYWxvZ0VsZW1lbnQ6OmNsb3NlKToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxEaWFsb2dF bGVtZW50OjpzaG93TW9kYWwpOgorCiAyMDEyLTEyLTAzICBBbmRyZXkgQWRhaWtpbiAgPGFhbmRy ZXlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IFtDYW52YXNdIHNob3cg cmVwbGF5IHNjcmVlbnNob3Qgb2YgdGhlIGxhc3QgY2FsbCdzIGNhbnZhcwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKaW5kZXggZjgwNTZhZTRjMGE4NDY2YjRlODkzNTFhN2FmYjFkMzIwMTkwYjMzOS4u YWExMjE5MzRlZTM2YmY2YWFiZjFlZDJmMzU2NzJkZjAxMmE4NTgxZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCkBAIC01NDI2LDE1ICs1NDI2LDIxIEBAIHZvaWQgRG9jdW1lbnQ6OmFkZERvY3Vt ZW50VG9GdWxsU2NyZWVuQ2hhbmdlRXZlbnRRdWV1ZShEb2N1bWVudCogZG9jKQogI2lmIEVOQUJM RShESUFMT0dfRUxFTUVOVCkKIHZvaWQgRG9jdW1lbnQ6OmFkZFRvVG9wTGF5ZXIoRWxlbWVudCog ZWxlbWVudCkKIHsKKyAgICBpZiAoZWxlbWVudC0+aXNJblRvcExheWVyKCkpCisgICAgICAgIHJl dHVybjsKICAgICBBU1NFUlQoIW1fdG9wTGF5ZXJFbGVtZW50cy5jb250YWlucyhlbGVtZW50KSk7 CiAgICAgbV90b3BMYXllckVsZW1lbnRzLmFwcGVuZChlbGVtZW50KTsKKyAgICBlbGVtZW50LT5z ZXRJc0luVG9wTGF5ZXIodHJ1ZSk7CiB9CiAKIHZvaWQgRG9jdW1lbnQ6OnJlbW92ZUZyb21Ub3BM YXllcihFbGVtZW50KiBlbGVtZW50KQogeworICAgIGlmICghZWxlbWVudC0+aXNJblRvcExheWVy KCkpCisgICAgICAgIHJldHVybjsKICAgICBzaXplX3QgcG9zaXRpb24gPSBtX3RvcExheWVyRWxl bWVudHMuZmluZChlbGVtZW50KTsKICAgICBBU1NFUlQocG9zaXRpb24gIT0gbm90Rm91bmQpOwog ICAgIG1fdG9wTGF5ZXJFbGVtZW50cy5yZW1vdmUocG9zaXRpb24pOworICAgIGVsZW1lbnQtPnNl dElzSW5Ub3BMYXllcihmYWxzZSk7CiB9CiAjZW5kaWYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCmlu ZGV4IDRkYzBjNWRmNTNhOTIzYmY5YmU5Y2YwYWVmZTQyNzNlZDQwZDdmZTQuLjEzNjFmMGY1NjVl NDIyYWYyMzllNmEwOWQ4OGJiNGQ2ZjA2MmQxNGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKQEAg LTIyMzQsMTUgKzIyMzQsNyBAQCBib29sIEVsZW1lbnQ6OmlzSW5Ub3BMYXllcigpIGNvbnN0CiAK IHZvaWQgRWxlbWVudDo6c2V0SXNJblRvcExheWVyKGJvb2wgaW5Ub3BMYXllcikKIHsKLSAgICBp ZiAoaXNJblRvcExheWVyKCkgPT0gaW5Ub3BMYXllcikKLSAgICAgICAgcmV0dXJuOwotCiAgICAg ZW5zdXJlRWxlbWVudFJhcmVEYXRhKCktPnNldElzSW5Ub3BMYXllcihpblRvcExheWVyKTsKLQot ICAgIGlmIChpblRvcExheWVyKQotICAgICAgICBkb2N1bWVudCgpLT5hZGRUb1RvcExheWVyKHRo aXMpOwotICAgIGVsc2UKLSAgICAgICAgZG9jdW1lbnQoKS0+cmVtb3ZlRnJvbVRvcExheWVyKHRo aXMpOwogICAgIHNldE5lZWRzU3R5bGVSZWNhbGMoU3ludGhldGljU3R5bGVDaGFuZ2UpOwogfQog I2VuZGlmCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oIGIvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCBhMjQ1OTRmNWU2YmQ4MTczNjQzN2FjZjVlZTVl YzM3OWMxZjg4NmVkLi4xODhjYTU1NWViNmM1ZDhlYzI4Njg1MzVjZDEwMTI5MGJhZjEzMTY1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBiL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmgKQEAgLTQzNyw4ICs0MzcsOCBAQCBwdWJsaWM6CiAjZW5kaWYKIAog I2lmIEVOQUJMRShESUFMT0dfRUxFTUVOVCkKLSAgICB2aXJ0dWFsIGJvb2wgaXNJblRvcExheWVy KCkgY29uc3Q7Ci0gICAgdmlydHVhbCB2b2lkIHNldElzSW5Ub3BMYXllcihib29sKTsKKyAgICBi b29sIGlzSW5Ub3BMYXllcigpIGNvbnN0OworICAgIHZvaWQgc2V0SXNJblRvcExheWVyKGJvb2wp OwogI2VuZGlmCiAKICNpZiBFTkFCTEUoUE9JTlRFUl9MT0NLKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvaHRtbC9IVE1MRGlhbG9nRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxEaWFsb2dFbGVtZW50LmNwcAppbmRleCAyOTUwZmJhNmIyZTVlY2Y1Y2ZhOTJmOWVlODdi M2M4MzI5MzczZDRmLi5iNzk5MTRlMGVhZTg4OWE3NDBmZTJhYTczNzg1YjdlODc3ZGVhOWUzIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxEaWFsb2dFbGVtZW50LmNwcApAQCAtNTMsNyArNTMs NyBAQCB2b2lkIEhUTUxEaWFsb2dFbGVtZW50OjpjbG9zZShFeGNlcHRpb25Db2RlJiBlYykKICAg ICAgICAgcmV0dXJuOwogICAgIH0KICAgICBzZXRCb29sZWFuQXR0cmlidXRlKG9wZW5BdHRyLCBm YWxzZSk7Ci0gICAgc2V0SXNJblRvcExheWVyKGZhbHNlKTsKKyAgICBkb2N1bWVudCgpLT5yZW1v dmVGcm9tVG9wTGF5ZXIodGhpcyk7CiB9CiAKIHZvaWQgSFRNTERpYWxvZ0VsZW1lbnQ6OnNob3co KQpAQCAtNzAsNyArNzAsNyBAQCB2b2lkIEhUTUxEaWFsb2dFbGVtZW50OjpzaG93TW9kYWwoRXhj ZXB0aW9uQ29kZSYgZWMpCiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgc2V0Qm9vbGVhbkF0 dHJpYnV0ZShvcGVuQXR0ciwgdHJ1ZSk7Ci0gICAgc2V0SXNJblRvcExheWVyKHRydWUpOworICAg IGRvY3VtZW50KCktPmFkZFRvVG9wTGF5ZXIodGhpcyk7CiB9CiAKIGJvb2wgSFRNTERpYWxvZ0Vs ZW1lbnQ6OmlzUHJlc2VudGF0aW9uQXR0cmlidXRlKGNvbnN0IFF1YWxpZmllZE5hbWUmIG5hbWUp IGNvbnN0Cg==