103904 2012-12-03 09:10:29 -0800 [EFL] Fix tools for WebKit2-only builds 2012-12-07 08:55:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED EasyFix P2 Normal --- 1 laszlo.gombos ktf.kim dbates gyuyoung.kim ktf.kim laszlo.gombos webkit.review.bot oldest_to_newest 781520 0 laszlo.gombos 2012-12-03 09:10:29 -0800 run-launcher --efl -2 fails in a WebKit2-only build (WebKit$ ./Tools/Scripts/build-webkit --efl --cmakeargs="-DENABLE_WEBKIT=OFF"). This is likely an issue with the scripts as running MiniBrowser from the bin directory runs just fine. 785527 1 178132 ktf.kim 2012-12-06 18:42:43 -0800 Created attachment 178132 Patch 785535 2 ktf.kim 2012-12-06 18:48:17 -0800 run-launcher --efl -2 checked library path as WebKitBuild/Release/lib/libwebkit.so, and died because it does not exist in ENABLE_WEBKIT=OFF case. In library path check routine (checkFrameworks -> builtDylibPathForName), there was no consider for WK2 case. 785900 3 178132 laszlo.gombos 2012-12-07 08:38:22 -0800 Comment on attachment 178132 Patch r=me. 785904 4 178132 webkit.review.bot 2012-12-07 08:55:28 -0800 Comment on attachment 178132 Patch Clearing flags on attachment: 178132 Committed r136957: <http://trac.webkit.org/changeset/136957> 785905 5 webkit.review.bot 2012-12-07 08:55:32 -0800 All reviewed patches have been landed. Closing bug. 178132 2012-12-06 18:42:43 -0800 2012-12-07 08:55:28 -0800 Patch bug-103904-20121207114007.patch text/plain 1246 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2OTE2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggN2U3NjhjNWMwZjcwM2NhMDc1MzYwNDNmMTViNWUyNjU5 YmRiOWE2My4uYWJhODBiMWI2ZjAyZjE3YWFkMzVlZTZlMjVkYmU5YWY3YTI5YTY2NyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTEyLTA2ICBLeXVuZ1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFtFRkxdIEZpeCB0b29scyBmb3IgV2ViS2l0Mi1vbmx5IGJ1aWxkcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzOTA0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGxpYmV3ZWJraXQyLnNv IHNob3VsZCBiZSB1c2VkIGZvciBsaWJyYXJ5IHBhdGggZm9yIEVGTCBXZWJLaXQyLgorCisgICAg ICAgICogU2NyaXB0cy93ZWJraXRkaXJzLnBtOgorICAgICAgICAoYnVpbHREeWxpYlBhdGhGb3JO YW1lKToKKwogMjAxMi0xMi0wNiAgVml2ZWsgR2FsYXRhZ2UgIDx2aXZlay52Z0BzYW1zdW5nLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXhpbmcgdGhlIGVtYWlsIGFkZHJlc3Mgb3JkZXIg dG8gd29yayBjb3JyZWN0bHkgd2l0aCBidWd6aWxsYS4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRleCBhNTU0 NWIzOGVhZDNhYzM5NWFhOGQ1ZDc2MWJlMTEyYTA0NTQ3NWExLi5jN2VkODA4ZDIzNmNiYjhmMjAy MzczNjM2ZjgxM2FhNzc0NGQ4N2M3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRp cnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC03NzQsNiArNzc0LDkg QEAgc3ViIGJ1aWx0RHlsaWJQYXRoRm9yTmFtZQogICAgICAgICByZXR1cm4gIk5vdEZvdW5kIjsK ICAgICB9CiAgICAgaWYgKGlzRWZsKCkpIHsKKyAgICAgICAgaWYgKGlzV0syKCkpIHsKKyAgICAg ICAgICAgIHJldHVybiAiJGNvbmZpZ3VyYXRpb25Qcm9kdWN0RGlyL2xpYi9saWJld2Via2l0Mi5z byI7CisgICAgICAgIH0KICAgICAgICAgcmV0dXJuICIkY29uZmlndXJhdGlvblByb2R1Y3REaXIv bGliL2xpYmV3ZWJraXQuc28iOwogICAgIH0KICAgICBpZiAoaXNXaW5DRSgpKSB7Cg==