103888 2012-12-03 06:38:08 -0800 Web Inspector: free Page resources on inspector disconnect 2012-12-03 10:42:28 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kpiascik kpiascik apavlov keishi loislo pfeldman pmuellr vsevik web-inspector-bugs webkit.review.bot yurys oldest_to_newest 781400 0 kpiascik 2012-12-03 06:38:08 -0800 Web Inspector: free Page resources on inspector disconnect 781403 1 177245 kpiascik 2012-12-03 06:41:35 -0800 Created attachment 177245 Patch 781562 2 177245 webkit.review.bot 2012-12-03 09:55:18 -0800 Comment on attachment 177245 Patch Clearing flags on attachment: 177245 Committed r136408: <http://trac.webkit.org/changeset/136408> 781563 3 webkit.review.bot 2012-12-03 09:55:21 -0800 All reviewed patches have been landed. Closing bug. 781603 4 177245 pfeldman 2012-12-03 10:28:22 -0800 Comment on attachment 177245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177245&action=review > Source/WebCore/inspector/InspectorController.cpp:257 > + m_overlay->freePage(); nit: I'd call this reset. 781621 5 177245 kpiascik 2012-12-03 10:42:28 -0800 Comment on attachment 177245 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177245&action=review >> Source/WebCore/inspector/InspectorController.cpp:257 >> + m_overlay->freePage(); > > nit: I'd call this reset. the reset method already exists for InspectorOverlay class 177245 2012-12-03 06:41:35 -0800 2012-12-03 10:42:28 -0800 Patch bug-103888-20121203093514.patch text/plain 2800 kpiascik U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmNiMDZlNWYwMTBhMWQ4 ZjNhZDZmNGM2OGNhN2E1MzEyMzdhNTY4OS4uOWUzMmM3YzAxMzRjYTM1NTQ5YTA3NTliZWEyMDc1 MzczOTA0NjAxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTEyLTAzICBLb25y YWQgUGlhc2NpayAgPGtwaWFzY2lrQHJpbS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3Rvcjog ZnJlZSBQYWdlIHJlc291cmNlcyBvbiBpbnNwZWN0b3IgZGlzY29ubmVjdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzODg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZG9uJ3QgbmVlZCB0byBrZWVw IHRoZSBwYWdlIGFyb3VuZCBhbmQgY2FuIGZyZWUgdXAgbWVtb3J5IHdoZW4gZGlzY29ubmVjdGlu ZyB3ZWIgaW5zcGVjdG9yLgorCisgICAgICAgIE5vdCB0ZXN0YWJsZS4KKworICAgICAgICAqIGlu c3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3Bl Y3RvckNvbnRyb2xsZXI6OmRpc2Nvbm5lY3RGcm9udGVuZCk6CisgICAgICAgICogaW5zcGVjdG9y L0luc3BlY3Rvck92ZXJsYXkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yT3Zlcmxh eTo6ZnJlZVBhZ2UpOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogaW5zcGVjdG9yL0lu c3BlY3Rvck92ZXJsYXkuaDoKKyAgICAgICAgKEluc3BlY3Rvck92ZXJsYXkpOgorCiAyMDEyLTEy LTAyICBNYXJ5IFd1ICA8bWFyeS53dUB0b3JjaG1vYmlsZS5jb20uY24+CiAKICAgICAgICAgc2hv dWxkIHNuaWZmIGl0IGlmIG1pbWV0eXBlIGRvbid0IGNvbnRhaW4gYSBzbGFzaC4KZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCBkZmM0 MWFjYzEyOGUyOTYzZGRiNGI5YjllZjg4NmM4M2Y4NGNjMDZlLi5jYzBkYzYxOTEyNzc5NDdiMTk5 YjE5MDdlZDVlYjBlYWZhNmJmNGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0 b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9y L0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0yNTMsNiArMjUzLDggQEAgdm9pZCBJbnNwZWN0 b3JDb250cm9sbGVyOjpkaXNjb25uZWN0RnJvbnRlbmQoKQogCiAgICAgbV9pbnNwZWN0b3JGcm9u dGVuZC5jbGVhcigpOwogCisgICAgLy8gcmVsZXNlIG92ZXJsYXkgcGFnZSByZXNvdXJjZXMKKyAg ICBtX292ZXJsYXktPmZyZWVQYWdlKCk7CiAgICAgSW5zcGVjdG9ySW5zdHJ1bWVudGF0aW9uOjpm cm9udGVuZERlbGV0ZWQoKTsKICAgICBpZiAoIUluc3BlY3Rvckluc3RydW1lbnRhdGlvbjo6aGFz RnJvbnRlbmRzKCkpCiAgICAgICAgIFNjcmlwdENvbnRyb2xsZXI6OnNldENhcHR1cmVDYWxsU3Rh Y2tGb3JVbmNhdWdodEV4Y2VwdGlvbnMoZmFsc2UpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3Rvck92ZXJsYXkuY3BwCmluZGV4IDI4ZmQxYjIzOTE1NWVjOGYwYTAyYjVhYjhh ZWE2NzA5OTgxNTQzOTEuLmUwNmYwYzRmNDI0NDUzMDQwZDU5NDIyYzFmMDlkNjUwZGMxNGEwZDAg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5LmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKQEAg LTQ2NCw2ICs0NjQsMTEgQEAgdm9pZCBJbnNwZWN0b3JPdmVybGF5OjpldmFsdWF0ZUluT3Zlcmxh eShjb25zdCBTdHJpbmcmIG1ldGhvZCwgUGFzc1JlZlB0cjxJbnNwZWMKICAgICBvdmVybGF5UGFn ZSgpLT5tYWluRnJhbWUoKS0+c2NyaXB0KCktPmV2YWx1YXRlKFNjcmlwdFNvdXJjZUNvZGUobWFr ZVN0cmluZygiZGlzcGF0Y2goIiwgY29tbWFuZC0+dG9KU09OU3RyaW5nKCksICIpIikpKTsKIH0K IAordm9pZCBJbnNwZWN0b3JPdmVybGF5OjpmcmVlUGFnZSgpCit7CisgICAgbV9vdmVybGF5UGFn ZS5jbGVhcigpOworfQorCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFC TEUoSU5TUEVDVE9SKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3Bl Y3Rvck92ZXJsYXkuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5 LmgKaW5kZXggZTYwYTEwNTJlM2VhYjkxMGU4M2E3Mzc0YjA1YTBmZjc1NzBhNDZjMS4uODc2MDdk MzAzN2QxYWYxMjA1YjQyNWQ2MzJkNGJkYWVkNmY3YjRmYSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rvck92ZXJsYXkuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5oCkBAIC0xMTUsNiArMTE1LDcgQEAgcHVibGljOgog CiAgICAgTm9kZSogaGlnaGxpZ2h0ZWROb2RlKCkgY29uc3Q7CiAKKyAgICB2b2lkIGZyZWVQYWdl KCk7CiBwcml2YXRlOgogICAgIEluc3BlY3Rvck92ZXJsYXkoUGFnZSosIEluc3BlY3RvckNsaWVu dCopOwogCg==