103851 2012-12-02 21:24:44 -0800 createRareData should return a PassOwnPtr 2012-12-04 14:43:14 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 esprehn esprehn cmarcelo dpranke eric ojan webkit.review.bot oldest_to_newest 781110 0 esprehn 2012-12-02 21:24:44 -0800 Don't use an OwnPtr for Node rare data 781115 1 177174 esprehn 2012-12-02 21:30:49 -0800 Created attachment 177174 Patch 781118 2 177175 esprehn 2012-12-02 21:34:53 -0800 Created attachment 177175 Patch 781133 3 177175 eric 2012-12-02 22:20:30 -0800 Comment on attachment 177175 Patch This should have been PassOwnPtr anyway, right? I think it's good to use PassOwnPtr here, even if we always call leakPtr. 781157 4 esprehn 2012-12-02 23:12:46 -0800 (In reply to comment #3) > (From update of attachment 177175 [details]) > This should have been PassOwnPtr anyway, right? I think it's good to use PassOwnPtr here, even if we always call leakPtr. I guess if we want to wrap it then it should be PassOwnPtr though I'm not sure there's an advantage of using PassOwnPtr vs OwnPtr. What's the reason for wanting to wrap it? 781160 5 eric 2012-12-02 23:20:00 -0800 (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 177175 [details] [details]) > > This should have been PassOwnPtr anyway, right? I think it's good to use PassOwnPtr here, even if we always call leakPtr. > > I guess if we want to wrap it then it should be PassOwnPtr though I'm not sure there's an advantage of using PassOwnPtr vs OwnPtr. > > What's the reason for wanting to wrap it? The goal of wrapping it is the same as any use of smartpointers. :) To make the ownership clear and prevent memory leaks. it just so happens that every caller calls leakPtr() today, but this being OwnPtr/PassOwnPtr prevents any future leaks. 781567 6 177175 darin 2012-12-03 10:00:26 -0800 Comment on attachment 177175 Patch This change doesn’t seem good. Using a return type of PassOwnPtr is an excellent way to make it clear to people reading the code what the lifetime of a returned object is, even if we use leakPtr right after the fact. Moving to a raw pointer does not seem like an improvement, unless there is some concrete benefit of doing so. Using a return type of OwnPtr is incorrect, though, and should be fixed. 781640 7 177285 esprehn 2012-12-03 10:48:37 -0800 Created attachment 177285 Patch 781643 8 esprehn 2012-12-03 10:51:14 -0800 (In reply to comment #6) > (From update of attachment 177175 [details]) > This change doesn’t seem good. Using a return type of PassOwnPtr is an excellent way to make it clear to people reading the code what the lifetime of a returned object is, even if we use leakPtr right after the fact. Moving to a raw pointer does not seem like an improvement, unless there is some concrete benefit of doing so. > > Using a return type of OwnPtr is incorrect, though, and should be fixed. Okay, patch uploaded with these changes. 781659 9 177285 eric 2012-12-03 11:02:44 -0800 Comment on attachment 177285 Patch I don't see why you're adding the ASSERT. That method, as written, doesn't need to care about whether it has rare data or not yet. setRareData might care, but this method seems idempotent as previously written. 781660 10 177285 eric 2012-12-03 11:03:53 -0800 Comment on attachment 177285 Patch Please consider removing the ASSERT. 781677 11 esprehn 2012-12-03 11:13:34 -0800 (In reply to comment #10) > (From update of attachment 177285 [details]) > Please consider removing the ASSERT. Okay I'll remove the assert. 781701 12 177294 esprehn 2012-12-03 11:31:49 -0800 Created attachment 177294 Patch for landing 782961 13 177294 dpranke 2012-12-04 14:43:11 -0800 Comment on attachment 177294 Patch for landing Clearing flags on attachment: 177294 Committed r136573: <http://trac.webkit.org/changeset/136573> 782962 14 dpranke 2012-12-04 14:43:14 -0800 All reviewed patches have been landed. Closing bug. 177174 2012-12-02 21:30:49 -0800 2012-12-02 21:34:39 -0800 Patch bug-103851-20121202212814.patch text/plain 3732 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRiYjk2YWQzYjBkYTNj MWRlMzg0NWI1MzcwYzg1MTcwMDEyOGFhZC4uYzk2NGE5MmJkYzBjNDQ2Y2YyNWQzN2IzNzQ0YTkz NmVkYTZlNTA0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTAyICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IHVzZSBh biBPd25QdHIgZm9yIE5vZGUgcmFyZSBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIHJlYXNvbiB0byB3cmFwIHRoZSBOb2RlUmFy ZURhdGEgb3IgRWxlbWVudFJhcmVEYXRhIGluIGFuCisgICAgICAgIE93blB0ciBzaW5jZSB3ZSBh bHdheXMgY2FsbCBsZWFrUHRyKCkgb24gaXQgYW55d2F5LgorCisgICAgICAgICogZG9tL0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpj cmVhdGVSYXJlRGF0YSk6CisgICAgICAgICogZG9tL0VsZW1lbnQuaDoKKyAgICAgICAgKEVsZW1l bnQpOgorICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmVu c3VyZVJhcmVEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmNyZWF0ZVJhcmVEYXRhKToK KyAgICAgICAgKiBkb20vTm9kZS5oOgorCiAyMDEyLTEyLTAyICBPdHRvIERlcmVrIENoZXVuZyAg PG90Y2hldW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZGluZyBjaGVja3Mg Zm9yIG51bGwgd2hlbiBjaGVja2luZyBjb29raWUgc3RhdHVzIGluIENvb2tpZUphckJsYWNrQmVy cnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA0ZGMwYzVkZjUzYTkyM2JmOWJlOWNmMGFlZmU0 MjczZWQ0MGQ3ZmU0Li5hOGRhMWYzZmQxMjA3YTIyM2U0ZmJlYmE1NTQ1M2I1MDQ5NmRmMmIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yMDcsMTAgKzIwNywxMCBAQCBpbmxpbmUgRWxlbWVu dFJhcmVEYXRhKiBFbGVtZW50OjplbnN1cmVFbGVtZW50UmFyZURhdGEoKQogewogICAgIHJldHVy biBzdGF0aWNfY2FzdDxFbGVtZW50UmFyZURhdGEqPihlbnN1cmVSYXJlRGF0YSgpKTsKIH0KLSAg ICAKLU93blB0cjxOb2RlUmFyZURhdGE+IEVsZW1lbnQ6OmNyZWF0ZVJhcmVEYXRhKCkKKworTm9k ZVJhcmVEYXRhKiBFbGVtZW50OjpjcmVhdGVSYXJlRGF0YSgpCiB7Ci0gICAgcmV0dXJuIGFkb3B0 UHRyKG5ldyBFbGVtZW50UmFyZURhdGEoZG9jdW1lbnRJbnRlcm5hbCgpKSk7CisgICAgcmV0dXJu IG5ldyBFbGVtZW50UmFyZURhdGEoZG9jdW1lbnRJbnRlcm5hbCgpKTsKIH0KIAogREVGSU5FX1ZJ UlRVQUxfQVRUUklCVVRFX0VWRU5UX0xJU1RFTkVSKEVsZW1lbnQsIGJsdXIpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmgKaW5kZXggYTI0NTk0ZjVlNmJkODE3MzY0MzdhY2Y1ZWU1ZWMzNzljMWY4ODZlZC4uMmVj YjEwOTcyZDU2YzJmNzkzZTJmZWI0YmZmYWY5NDAwNWUzYmZmZSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvZG9tL0VsZW1lbnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5o CkBAIC01NDAsNyArNTQwLDcgQEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIFBhc3NSZWZQdHI8RWxl bWVudD4gY2xvbmVFbGVtZW50V2l0aG91dEF0dHJpYnV0ZXNBbmRDaGlsZHJlbigpOwogCiAgICAg UXVhbGlmaWVkTmFtZSBtX3RhZ05hbWU7Ci0gICAgdmlydHVhbCBPd25QdHI8Tm9kZVJhcmVEYXRh PiBjcmVhdGVSYXJlRGF0YSgpOworICAgIHZpcnR1YWwgTm9kZVJhcmVEYXRhKiBjcmVhdGVSYXJl RGF0YSgpOwogICAgIGJvb2wgcmFyZURhdGFTdHlsZUFmZmVjdGVkQnlFbXB0eSgpIGNvbnN0Owog ICAgIGJvb2wgcmFyZURhdGFDaGlsZHJlbkFmZmVjdGVkQnlIb3ZlcigpIGNvbnN0OwogICAgIGJv b2wgcmFyZURhdGFDaGlsZHJlbkFmZmVjdGVkQnlBY3RpdmUoKSBjb25zdDsKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNw cAppbmRleCBkMmZiYjE2YzhmNDU4OWZmNDIwNGI5NGU3YTU5NmFkYzkwMDUxYmRkLi4yYzliZTE2 Y2EyM2RlMzhmNzAyNzBkZmEzZDFlY2U2Njc3MGI0YWI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9kb20vTm9kZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCkBAIC00 NTgsNyArNDU4LDcgQEAgTm9kZVJhcmVEYXRhKiBOb2RlOjplbnN1cmVSYXJlRGF0YSgpCiAgICAg aWYgKGhhc1JhcmVEYXRhKCkpCiAgICAgICAgIHJldHVybiByYXJlRGF0YSgpOwogCi0gICAgTm9k ZVJhcmVEYXRhKiBkYXRhID0gY3JlYXRlUmFyZURhdGEoKS5sZWFrUHRyKCk7CisgICAgTm9kZVJh cmVEYXRhKiBkYXRhID0gY3JlYXRlUmFyZURhdGEoKTsKICAgICBBU1NFUlQoZGF0YSk7CiAgICAg ZGF0YS0+c2V0UmVuZGVyZXIobV9kYXRhLm1fcmVuZGVyZXIpOwogICAgIG1fZGF0YS5tX3JhcmVE YXRhID0gZGF0YTsKQEAgLTQ2Niw5ICs0NjYsMTAgQEAgTm9kZVJhcmVEYXRhKiBOb2RlOjplbnN1 cmVSYXJlRGF0YSgpCiAgICAgcmV0dXJuIGRhdGE7CiB9CiAKLU93blB0cjxOb2RlUmFyZURhdGE+ IE5vZGU6OmNyZWF0ZVJhcmVEYXRhKCkKK05vZGVSYXJlRGF0YSogTm9kZTo6Y3JlYXRlUmFyZURh dGEoKQogewotICAgIHJldHVybiBhZG9wdFB0cihuZXcgTm9kZVJhcmVEYXRhKGRvY3VtZW50SW50 ZXJuYWwoKSkpOworICAgIEFTU0VSVCghaGFzUmFyZURhdGEoKSk7CisgICAgcmV0dXJuIG5ldyBO b2RlUmFyZURhdGEoZG9jdW1lbnRJbnRlcm5hbCgpKTsKIH0KIAogdm9pZCBOb2RlOjpjbGVhclJh cmVEYXRhKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmggYi9Tb3VyY2Uv V2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IDViZGZiZWFlMDZiYjhmNDM0NTA0MTg0MjNjNGZhZDE5 ZDVhYmE2YWQuLmFmYTAwNmM1YmJkMTJkMGJmNjNhZDhhZmRjN2E2MTNhNDZiMTliZTEgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9t L05vZGUuaApAQCAtNzkzLDcgKzc5Myw3IEBAIHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHJl ZkV2ZW50VGFyZ2V0KCk7CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmRXZlbnRUYXJnZXQoKTsKIAot ICAgIHZpcnR1YWwgT3duUHRyPE5vZGVSYXJlRGF0YT4gY3JlYXRlUmFyZURhdGEoKTsKKyAgICB2 aXJ0dWFsIE5vZGVSYXJlRGF0YSogY3JlYXRlUmFyZURhdGEoKTsKICAgICBib29sIHJhcmVEYXRh Rm9jdXNlZCgpIGNvbnN0OwogCiAgICAgdmlydHVhbCBSZW5kZXJTdHlsZSogbm9uUmVuZGVyZXJT dHlsZSgpIGNvbnN0IHsgcmV0dXJuIDA7IH0K 177175 2012-12-02 21:34:53 -0800 2012-12-03 10:48:19 -0800 Patch bug-103851-20121202213218.patch text/plain 3761 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MzU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDRiYjk2YWQzYjBkYTNj MWRlMzg0NWI1MzcwYzg1MTcwMDEyOGFhZC4uYzk2NGE5MmJkYzBjNDQ2Y2YyNWQzN2IzNzQ0YTkz NmVkYTZlNTA0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDEyLTEyLTAyICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIERvbid0IHVzZSBh biBPd25QdHIgZm9yIE5vZGUgcmFyZSBkYXRhCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIHJlYXNvbiB0byB3cmFwIHRoZSBOb2RlUmFy ZURhdGEgb3IgRWxlbWVudFJhcmVEYXRhIGluIGFuCisgICAgICAgIE93blB0ciBzaW5jZSB3ZSBh bHdheXMgY2FsbCBsZWFrUHRyKCkgb24gaXQgYW55d2F5LgorCisgICAgICAgICogZG9tL0VsZW1l bnQuY3BwOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgIChXZWJDb3JlOjpFbGVtZW50Ojpj cmVhdGVSYXJlRGF0YSk6CisgICAgICAgICogZG9tL0VsZW1lbnQuaDoKKyAgICAgICAgKEVsZW1l bnQpOgorICAgICAgICAqIGRvbS9Ob2RlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmVu c3VyZVJhcmVEYXRhKToKKyAgICAgICAgKFdlYkNvcmU6Ok5vZGU6OmNyZWF0ZVJhcmVEYXRhKToK KyAgICAgICAgKiBkb20vTm9kZS5oOgorCiAyMDEyLTEyLTAyICBPdHRvIERlcmVrIENoZXVuZyAg PG90Y2hldW5nQHJpbS5jb20+CiAKICAgICAgICAgW0JsYWNrQmVycnldIEFkZGluZyBjaGVja3Mg Zm9yIG51bGwgd2hlbiBjaGVja2luZyBjb29raWUgc3RhdHVzIGluIENvb2tpZUphckJsYWNrQmVy cnkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCA0ZGMwYzVkZjUzYTkyM2JmOWJlOWNmMGFlZmU0 MjczZWQ0MGQ3ZmU0Li40MDdkOTgwMDE1MDIwNzI2ZjM5YWZhNGMwNTUzMmI2NTMwODM0NjcxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvZG9tL0VsZW1lbnQuY3BwCkBAIC0yMDcsMTAgKzIwNywxMSBAQCBpbmxpbmUgRWxlbWVu dFJhcmVEYXRhKiBFbGVtZW50OjplbnN1cmVFbGVtZW50UmFyZURhdGEoKQogewogICAgIHJldHVy biBzdGF0aWNfY2FzdDxFbGVtZW50UmFyZURhdGEqPihlbnN1cmVSYXJlRGF0YSgpKTsKIH0KLSAg ICAKLU93blB0cjxOb2RlUmFyZURhdGE+IEVsZW1lbnQ6OmNyZWF0ZVJhcmVEYXRhKCkKKworTm9k ZVJhcmVEYXRhKiBFbGVtZW50OjpjcmVhdGVSYXJlRGF0YSgpCiB7Ci0gICAgcmV0dXJuIGFkb3B0 UHRyKG5ldyBFbGVtZW50UmFyZURhdGEoZG9jdW1lbnRJbnRlcm5hbCgpKSk7CisgICAgQVNTRVJU KCFoYXNSYXJlRGF0YSgpKTsKKyAgICByZXR1cm4gbmV3IEVsZW1lbnRSYXJlRGF0YShkb2N1bWVu dEludGVybmFsKCkpOwogfQogCiBERUZJTkVfVklSVFVBTF9BVFRSSUJVVEVfRVZFTlRfTElTVEVO RVIoRWxlbWVudCwgYmx1cik7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCBhMjQ1OTRmNWU2YmQ4MTcz NjQzN2FjZjVlZTVlYzM3OWMxZjg4NmVkLi4yZWNiMTA5NzJkNTZjMmY3OTNlMmZlYjRiZmZhZjk0 MDA1ZTNiZmZlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAgLTU0MCw3ICs1NDAsNyBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxFbGVtZW50PiBjbG9uZUVsZW1lbnRXaXRob3V0QXR0 cmlidXRlc0FuZENoaWxkcmVuKCk7CiAKICAgICBRdWFsaWZpZWROYW1lIG1fdGFnTmFtZTsKLSAg ICB2aXJ0dWFsIE93blB0cjxOb2RlUmFyZURhdGE+IGNyZWF0ZVJhcmVEYXRhKCk7CisgICAgdmly dHVhbCBOb2RlUmFyZURhdGEqIGNyZWF0ZVJhcmVEYXRhKCk7CiAgICAgYm9vbCByYXJlRGF0YVN0 eWxlQWZmZWN0ZWRCeUVtcHR5KCkgY29uc3Q7CiAgICAgYm9vbCByYXJlRGF0YUNoaWxkcmVuQWZm ZWN0ZWRCeUhvdmVyKCkgY29uc3Q7CiAgICAgYm9vbCByYXJlRGF0YUNoaWxkcmVuQWZmZWN0ZWRC eUFjdGl2ZSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3Bw IGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IGQyZmJiMTZjOGY0NTg5ZmY0MjA0 Yjk0ZTdhNTk2YWRjOTAwNTFiZGQuLjJjOWJlMTZjYTIzZGUzOGY3MDI3MGRmYTNkMWVjZTY2Nzcw YjRhYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTQ1OCw3ICs0NTgsNyBAQCBOb2RlUmFyZURhdGEq IE5vZGU6OmVuc3VyZVJhcmVEYXRhKCkKICAgICBpZiAoaGFzUmFyZURhdGEoKSkKICAgICAgICAg cmV0dXJuIHJhcmVEYXRhKCk7CiAKLSAgICBOb2RlUmFyZURhdGEqIGRhdGEgPSBjcmVhdGVSYXJl RGF0YSgpLmxlYWtQdHIoKTsKKyAgICBOb2RlUmFyZURhdGEqIGRhdGEgPSBjcmVhdGVSYXJlRGF0 YSgpOwogICAgIEFTU0VSVChkYXRhKTsKICAgICBkYXRhLT5zZXRSZW5kZXJlcihtX2RhdGEubV9y ZW5kZXJlcik7CiAgICAgbV9kYXRhLm1fcmFyZURhdGEgPSBkYXRhOwpAQCAtNDY2LDkgKzQ2Niwx MCBAQCBOb2RlUmFyZURhdGEqIE5vZGU6OmVuc3VyZVJhcmVEYXRhKCkKICAgICByZXR1cm4gZGF0 YTsKIH0KIAotT3duUHRyPE5vZGVSYXJlRGF0YT4gTm9kZTo6Y3JlYXRlUmFyZURhdGEoKQorTm9k ZVJhcmVEYXRhKiBOb2RlOjpjcmVhdGVSYXJlRGF0YSgpCiB7Ci0gICAgcmV0dXJuIGFkb3B0UHRy KG5ldyBOb2RlUmFyZURhdGEoZG9jdW1lbnRJbnRlcm5hbCgpKSk7CisgICAgQVNTRVJUKCFoYXNS YXJlRGF0YSgpKTsKKyAgICByZXR1cm4gbmV3IE5vZGVSYXJlRGF0YShkb2N1bWVudEludGVybmFs KCkpOwogfQogCiB2b2lkIE5vZGU6OmNsZWFyUmFyZURhdGEoKQpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvZG9tL05vZGUuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKaW5kZXggNWJk ZmJlYWUwNmJiOGY0MzQ1MDQxODQyM2M0ZmFkMTlkNWFiYTZhZC4uYWZhMDA2YzViYmQxMmQwYmY2 M2FkOGFmZGM3YTYxM2E0NmIxOWJlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05v ZGUuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCkBAIC03OTMsNyArNzkzLDcgQEAg cHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgcmVmRXZlbnRUYXJnZXQoKTsKICAgICB2aXJ0dWFs IHZvaWQgZGVyZWZFdmVudFRhcmdldCgpOwogCi0gICAgdmlydHVhbCBPd25QdHI8Tm9kZVJhcmVE YXRhPiBjcmVhdGVSYXJlRGF0YSgpOworICAgIHZpcnR1YWwgTm9kZVJhcmVEYXRhKiBjcmVhdGVS YXJlRGF0YSgpOwogICAgIGJvb2wgcmFyZURhdGFGb2N1c2VkKCkgY29uc3Q7CiAKICAgICB2aXJ0 dWFsIFJlbmRlclN0eWxlKiBub25SZW5kZXJlclN0eWxlKCkgY29uc3QgeyByZXR1cm4gMDsgfQo= 177285 2012-12-03 10:48:37 -0800 2012-12-03 11:31:30 -0800 Patch bug-103851-20121203104558.patch text/plain 3185 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDEyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2M2MTNjZWViYTdhOGQx ZmY1MGYyZTA1NGY2NmRiODcxZTc2MDUwMy4uYWYzNWQyYTlmYWVkYWFkY2EyZmE2Y2JjN2NjMDZj YTI1YTcwZWI2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTAzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGNyZWF0ZVJhcmVE YXRhIHNob3VsZCByZXR1cm4gYSBQYXNzT3duUHRyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBjcmVhdGVSYXJlRGF0YSBzaG91bGQgcmV0dXJuIGEgUGFz c093blB0ciwgbm90IGFuIE93blB0ciBzaW5jZSBpdCdzCisgICAgICAgIHRyYW5zZmVyaW5nIG93 bmVyc2hpcC4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkVsZW1lbnQ6OmNyZWF0ZVJhcmVEYXRhKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAg ICAgICAoRWxlbWVudCk6CisgICAgICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6Tm9kZTo6Y3JlYXRlUmFyZURhdGEpOgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisKIDIwMTIt MTItMDMgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBNYWtl IE1haW5SZXNvdXJjZUxvYWRlciBub3QgdXNlIG1fZnJhbWUgZGlyZWN0bHkuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxl bWVudC5jcHAKaW5kZXggNGRjMGM1ZGY1M2E5MjNiZjliZTljZjBhZWZlNDI3M2VkNDBkN2ZlNC4u YmM5NjMyN2Y1NTFkYmE4YjBmOGFjOTU3M2U3NGQwOWNkYmI5N2VmMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmNwcApAQCAtMjA3LDkgKzIwNywxMCBAQCBpbmxpbmUgRWxlbWVudFJhcmVEYXRhKiBFbGVt ZW50OjplbnN1cmVFbGVtZW50UmFyZURhdGEoKQogewogICAgIHJldHVybiBzdGF0aWNfY2FzdDxF bGVtZW50UmFyZURhdGEqPihlbnN1cmVSYXJlRGF0YSgpKTsKIH0KLSAgICAKLU93blB0cjxOb2Rl UmFyZURhdGE+IEVsZW1lbnQ6OmNyZWF0ZVJhcmVEYXRhKCkKKworUGFzc093blB0cjxOb2RlUmFy ZURhdGE+IEVsZW1lbnQ6OmNyZWF0ZVJhcmVEYXRhKCkKIHsKKyAgICBBU1NFUlQoIWhhc1JhcmVE YXRhKCkpOwogICAgIHJldHVybiBhZG9wdFB0cihuZXcgRWxlbWVudFJhcmVEYXRhKGRvY3VtZW50 SW50ZXJuYWwoKSkpOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAppbmRleCBhMjQ1OTRmNWU2YmQ4MTcz NjQzN2FjZjVlZTVlYzM3OWMxZjg4NmVkLi5jMTBmMjg3NDA4ZDdhMmJmNjE1MzVlZGYxZDhiMzhj N2VhNDRhNWRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKQEAgLTU0MCw3ICs1NDAsNyBAQCBwcml2YXRl OgogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxFbGVtZW50PiBjbG9uZUVsZW1lbnRXaXRob3V0QXR0 cmlidXRlc0FuZENoaWxkcmVuKCk7CiAKICAgICBRdWFsaWZpZWROYW1lIG1fdGFnTmFtZTsKLSAg ICB2aXJ0dWFsIE93blB0cjxOb2RlUmFyZURhdGE+IGNyZWF0ZVJhcmVEYXRhKCk7CisgICAgdmly dHVhbCBQYXNzT3duUHRyPE5vZGVSYXJlRGF0YT4gY3JlYXRlUmFyZURhdGEoKTsKICAgICBib29s IHJhcmVEYXRhU3R5bGVBZmZlY3RlZEJ5RW1wdHkoKSBjb25zdDsKICAgICBib29sIHJhcmVEYXRh Q2hpbGRyZW5BZmZlY3RlZEJ5SG92ZXIoKSBjb25zdDsKICAgICBib29sIHJhcmVEYXRhQ2hpbGRy ZW5BZmZlY3RlZEJ5QWN0aXZlKCkgY29uc3Q7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9k b20vTm9kZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKaW5kZXggZDJmYmIxNmM4 ZjQ1ODlmZjQyMDRiOTRlN2E1OTZhZGM5MDA1MWJkZC4uZmQxNmJhZTkyMDVjOGRjNWI1Nzg1NDNm ODRiNGIwYjg4ZjQ2NDdlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcApAQCAtNDY2LDggKzQ2Niw5IEBAIE5v ZGVSYXJlRGF0YSogTm9kZTo6ZW5zdXJlUmFyZURhdGEoKQogICAgIHJldHVybiBkYXRhOwogfQog Ci1Pd25QdHI8Tm9kZVJhcmVEYXRhPiBOb2RlOjpjcmVhdGVSYXJlRGF0YSgpCitQYXNzT3duUHRy PE5vZGVSYXJlRGF0YT4gTm9kZTo6Y3JlYXRlUmFyZURhdGEoKQogeworICAgIEFTU0VSVCghaGFz UmFyZURhdGEoKSk7CiAgICAgcmV0dXJuIGFkb3B0UHRyKG5ldyBOb2RlUmFyZURhdGEoZG9jdW1l bnRJbnRlcm5hbCgpKSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2Rl LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IDViZGZiZWFlMDZiYjhmNDM0NTA0 MTg0MjNjNGZhZDE5ZDVhYmE2YWQuLjQxZGFiYzMzNWNjNjI0MTg3MTFjNmNhMDM1YmNlNWMwNzU4 YjE4ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmgKKysrIGIvU291cmNl L1dlYkNvcmUvZG9tL05vZGUuaApAQCAtNzkzLDcgKzc5Myw3IEBAIHByaXZhdGU6CiAgICAgdmly dHVhbCB2b2lkIHJlZkV2ZW50VGFyZ2V0KCk7CiAgICAgdmlydHVhbCB2b2lkIGRlcmVmRXZlbnRU YXJnZXQoKTsKIAotICAgIHZpcnR1YWwgT3duUHRyPE5vZGVSYXJlRGF0YT4gY3JlYXRlUmFyZURh dGEoKTsKKyAgICB2aXJ0dWFsIFBhc3NPd25QdHI8Tm9kZVJhcmVEYXRhPiBjcmVhdGVSYXJlRGF0 YSgpOwogICAgIGJvb2wgcmFyZURhdGFGb2N1c2VkKCkgY29uc3Q7CiAKICAgICB2aXJ0dWFsIFJl bmRlclN0eWxlKiBub25SZW5kZXJlclN0eWxlKCkgY29uc3QgeyByZXR1cm4gMDsgfQo= 177294 2012-12-03 11:31:49 -0800 2012-12-04 14:43:11 -0800 Patch for landing bug-103851-20121203112910.patch text/plain 3146 esprehn U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTJjYjA2MzliZGY0ODQ5 MTRhMDQ5YTNjM2JhNmFhMWNjMjViOWEwNS4uMDc2ZWI4ODhkMDYyOGE2ODcwYTY2OWM0ZTNmOWFi MWVhZjMyZmVjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTEyLTAzICBFbGxp b3R0IFNwcmVobiAgPGVzcHJlaG5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIGNyZWF0ZVJhcmVE YXRhIHNob3VsZCByZXR1cm4gYSBQYXNzT3duUHRyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM4NTEKKworICAgICAgICBSZXZpZXdlZCBieSBFcmlj IFNlaWRlbC4KKworICAgICAgICBjcmVhdGVSYXJlRGF0YSBzaG91bGQgcmV0dXJuIGEgUGFzc093 blB0ciwgbm90IGFuIE93blB0ciBzaW5jZSBpdCdzCisgICAgICAgIHRyYW5zZmVyaW5nIG93bmVy c2hpcC4KKworICAgICAgICAqIGRvbS9FbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkVs ZW1lbnQ6OmNyZWF0ZVJhcmVEYXRhKToKKyAgICAgICAgKiBkb20vRWxlbWVudC5oOgorICAgICAg ICAoRWxlbWVudCk6CisgICAgICAgICogZG9tL05vZGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Tm9kZTo6Y3JlYXRlUmFyZURhdGEpOgorICAgICAgICAqIGRvbS9Ob2RlLmg6CisKIDIwMTItMTIt MDMgIEFuZHJleSBBZGFpa2luICA8YWFuZHJleUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Vi IEluc3BlY3RvcjogW0NhbnZhc10gc2hvdyByZXBsYXkgc2NyZWVuc2hvdCBvZiB0aGUgbGFzdCBj YWxsJ3MgY2FudmFzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5jcHAKaW5kZXggNGRjMGM1ZGY1M2E5MjNiZjli ZTljZjBhZWZlNDI3M2VkNDBkN2ZlNC4uNDM2MWY5OTk5YjA5NThjMTg0NTQ4MTA5ZThkODQ1ZGM1 ZDgzZGM4OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuY3BwCisrKyBi L1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcApAQCAtMjA3LDggKzIwNyw4IEBAIGlubGlu ZSBFbGVtZW50UmFyZURhdGEqIEVsZW1lbnQ6OmVuc3VyZUVsZW1lbnRSYXJlRGF0YSgpCiB7CiAg ICAgcmV0dXJuIHN0YXRpY19jYXN0PEVsZW1lbnRSYXJlRGF0YSo+KGVuc3VyZVJhcmVEYXRhKCkp OwogfQotICAgIAotT3duUHRyPE5vZGVSYXJlRGF0YT4gRWxlbWVudDo6Y3JlYXRlUmFyZURhdGEo KQorCitQYXNzT3duUHRyPE5vZGVSYXJlRGF0YT4gRWxlbWVudDo6Y3JlYXRlUmFyZURhdGEoKQog ewogICAgIHJldHVybiBhZG9wdFB0cihuZXcgRWxlbWVudFJhcmVEYXRhKGRvY3VtZW50SW50ZXJu YWwoKSkpOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaCBiL1Nv dXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmgKaW5kZXggYTI0NTk0ZjVlNmJkODE3MzY0MzdhY2Y1 ZWU1ZWMzNzljMWY4ODZlZC4uYzEwZjI4NzQwOGQ3YTJiZjYxNTM1ZWRmMWQ4YjM4YzdlYTQ0YTVk ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5oCkBAIC01NDAsNyArNTQwLDcgQEAgcHJpdmF0ZToKICAgICB2 aXJ0dWFsIFBhc3NSZWZQdHI8RWxlbWVudD4gY2xvbmVFbGVtZW50V2l0aG91dEF0dHJpYnV0ZXNB bmRDaGlsZHJlbigpOwogCiAgICAgUXVhbGlmaWVkTmFtZSBtX3RhZ05hbWU7Ci0gICAgdmlydHVh bCBPd25QdHI8Tm9kZVJhcmVEYXRhPiBjcmVhdGVSYXJlRGF0YSgpOworICAgIHZpcnR1YWwgUGFz c093blB0cjxOb2RlUmFyZURhdGE+IGNyZWF0ZVJhcmVEYXRhKCk7CiAgICAgYm9vbCByYXJlRGF0 YVN0eWxlQWZmZWN0ZWRCeUVtcHR5KCkgY29uc3Q7CiAgICAgYm9vbCByYXJlRGF0YUNoaWxkcmVu QWZmZWN0ZWRCeUhvdmVyKCkgY29uc3Q7CiAgICAgYm9vbCByYXJlRGF0YUNoaWxkcmVuQWZmZWN0 ZWRCeUFjdGl2ZSgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL05vZGUu Y3BwIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuY3BwCmluZGV4IGQyZmJiMTZjOGY0NTg5ZmY0 MjA0Yjk0ZTdhNTk2YWRjOTAwNTFiZGQuLmE4NTU5MmRhNDg3ZTBjMzE0NjY2MDFlZGM5Y2Y2ZDU2 MjNkMGJjZWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Ob2RlLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9kb20vTm9kZS5jcHAKQEAgLTQ2Niw3ICs0NjYsNyBAQCBOb2RlUmFyZURh dGEqIE5vZGU6OmVuc3VyZVJhcmVEYXRhKCkKICAgICByZXR1cm4gZGF0YTsKIH0KIAotT3duUHRy PE5vZGVSYXJlRGF0YT4gTm9kZTo6Y3JlYXRlUmFyZURhdGEoKQorUGFzc093blB0cjxOb2RlUmFy ZURhdGE+IE5vZGU6OmNyZWF0ZVJhcmVEYXRhKCkKIHsKICAgICByZXR1cm4gYWRvcHRQdHIobmV3 IE5vZGVSYXJlRGF0YShkb2N1bWVudEludGVybmFsKCkpKTsKIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL2RvbS9Ob2RlLmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vTm9kZS5oCmluZGV4IDVi ZGZiZWFlMDZiYjhmNDM0NTA0MTg0MjNjNGZhZDE5ZDVhYmE2YWQuLjQxZGFiYzMzNWNjNjI0MTg3 MTFjNmNhMDM1YmNlNWMwNzU4YjE4ZGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9O b2RlLmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL05vZGUuaApAQCAtNzkzLDcgKzc5Myw3IEBA IHByaXZhdGU6CiAgICAgdmlydHVhbCB2b2lkIHJlZkV2ZW50VGFyZ2V0KCk7CiAgICAgdmlydHVh bCB2b2lkIGRlcmVmRXZlbnRUYXJnZXQoKTsKIAotICAgIHZpcnR1YWwgT3duUHRyPE5vZGVSYXJl RGF0YT4gY3JlYXRlUmFyZURhdGEoKTsKKyAgICB2aXJ0dWFsIFBhc3NPd25QdHI8Tm9kZVJhcmVE YXRhPiBjcmVhdGVSYXJlRGF0YSgpOwogICAgIGJvb2wgcmFyZURhdGFGb2N1c2VkKCkgY29uc3Q7 CiAKICAgICB2aXJ0dWFsIFJlbmRlclN0eWxlKiBub25SZW5kZXJlclN0eWxlKCkgY29uc3QgeyBy ZXR1cm4gMDsgfQo=