103815 2012-12-01 08:42:33 -0800 [CoordinatedGraphics] LayerTreeRenderer::removeImageBacking() calls HashMap::find() twice 2012-12-02 05:01:19 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez jturcotte kenneth noam webkit.review.bot zeno oldest_to_newest 780740 0 cdumez 2012-12-01 08:42:33 -0800 LayerTreeRenderer::removeImageBacking() currently calls HashMap::find() twice for the same imageID: - Once explicitly to get an iterator - A second time implicitly by calling HashMap::remove(key) Since we already, have an iterator to the element, we should call HashMap::remove(iterator) to avoid calling HashMap::find() again. 780741 1 cdumez 2012-12-01 08:44:51 -0800 Or we could just call HashMap::take() and make the code a bit simpler even. 780742 2 177108 cdumez 2012-12-01 08:52:59 -0800 Created attachment 177108 Patch 780932 3 177108 webkit.review.bot 2012-12-02 05:01:15 -0800 Comment on attachment 177108 Patch Clearing flags on attachment: 177108 Committed r136342: <http://trac.webkit.org/changeset/136342> 780933 4 webkit.review.bot 2012-12-02 05:01:19 -0800 All reviewed patches have been landed. Closing bug. 177108 2012-12-01 08:52:59 -0800 2012-12-02 05:01:15 -0800 Patch 103815_removeImageBacking.patch text/plain 1933 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjMjhkY2ViYi4uZmU4ZDI2ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIw IEBACisyMDEyLTEyLTAxICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5kdW1lekBpbnRl bC5jb20+CisKKyAgICAgICAgW0Nvb3JkaW5hdGVkR3JhcGhpY3NdIExheWVyVHJlZVJlbmRlcmVy OjpyZW1vdmVJbWFnZUJhY2tpbmcoKSBjYWxscyBIYXNoTWFwOjpmaW5kKCkgdHdpY2UKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzgxNQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgSGFzaE1hcDo6 dGFrZSgpIGluIExheWVyVHJlZVJlbmRlcmVyOjpyZW1vdmVJbWFnZUJhY2tpbmcoKQorICAgICAg ICB0byBhdm9pZCBjYWxsaW5nIEhhc2hNYXA6OmZpbmQoKSB0d2ljZS4gZmluZCgpIHdhcyBjYWxs ZWQgb25jZQorICAgICAgICBleHBsaWNpdGx5IHRvIGdldCBhbiBpdGVyYXRvciBhbmQgYSBzZWNv bmQgdGltZSB0byByZW1vdmUgdGhlCisgICAgICAgIHZhbHVlIGZyb20gdGhlIHZhbHVlIGZyb20g dGhlIEhhc2hNYXAuIFdlIGNvdWxkIGhhdmUgdXNlZAorICAgICAgICByZW1vdmUoaXRlcmF0b3Ip IGluc3RlYWQgb2YgcmVtb3ZlKGtleSkgYnV0IHVzaW5nIHRha2UoKSByZXN1bHRzCisgICAgICAg IGluIHNpbXBsZXIgY29kZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBo aWNzL0xheWVyVHJlZVJlbmRlcmVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6TGF5ZXJUcmVlUmVu ZGVyZXI6OnJlbW92ZUltYWdlQmFja2luZyk6CisKIDIwMTItMTEtMzAgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBBbHdheXMgbGlzdGVuIGZvciB0aGUg RGlkRmlyc3RMYXlvdXQgbGF5b3V0IG1pbGVzdG9uZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3BwIGIv U291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVu ZGVyZXIuY3BwCmluZGV4IDcxYzRiY2IuLmZjMjE3MjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRy ZWVSZW5kZXJlci5jcHAKQEAgLTU1NSw5ICs1NTUsNyBAQCB2b2lkIExheWVyVHJlZVJlbmRlcmVy OjpyZW1vdmVJbWFnZUJhY2tpbmcoQ29vcmRpbmF0ZWRJbWFnZUJhY2tpbmdJRCBpbWFnZUlEKQog ICAgIEFTU0VSVChtX2ltYWdlQmFja2luZ3MuY29udGFpbnMoaW1hZ2VJRCkpOwogCiAgICAgLy8g V2UgZG9uJ3Qgd2FudCBUZXh0dXJlTWFwcGVyTGF5ZXIgcmVmZXJzIGEgZGFuZ2xpbmcgcG9pbnRl ci4KLSAgICBJbWFnZUJhY2tpbmdNYXA6Oml0ZXJhdG9yIGl0ID0gbV9pbWFnZUJhY2tpbmdzLmZp bmQoaW1hZ2VJRCk7Ci0gICAgbV9yZWxlYXNlZEltYWdlQmFja2luZ3MuYXBwZW5kKGl0LT52YWx1 ZSk7Ci0gICAgbV9pbWFnZUJhY2tpbmdzLnJlbW92ZShpbWFnZUlEKTsKKyAgICBtX3JlbGVhc2Vk SW1hZ2VCYWNraW5ncy5hcHBlbmQobV9pbWFnZUJhY2tpbmdzLnRha2UoaW1hZ2VJRCkpOwogfQog CiB2b2lkIExheWVyVHJlZVJlbmRlcmVyOjphc3NpZ25JbWFnZUJhY2tpbmdUb0xheWVyKEdyYXBo aWNzTGF5ZXIqIGxheWVyLCBDb29yZGluYXRlZEltYWdlQmFja2luZ0lEIGltYWdlSUQpCg==