103814 2012-12-01 07:11:09 -0800 Correct the spelling of cmakeargs 2012-12-02 04:44:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned mxie paroga rakuco ryuan.choi webkit.review.bot oldest_to_newest 780727 0 laszlo.gombos 2012-12-01 07:11:09 -0800 build-webkit --help reports "cmakearg" but the script expects "cmakeargs" (plural). The EFL WebKit Wiki (http://trac.webkit.org/wiki/EFLWebKit) also references "cmakearg" (which does not work at the moment on WebKit trunk). We should address these inconsistencies. 780729 1 177105 laszlo.gombos 2012-12-01 07:16:28 -0800 Created attachment 177105 proposed patch I will fix the wiki after the patch lands (and there is an agreement that we fix the documentation and not the script behavior). It seems that the original patch from https://bugs.webkit.org/show_bug.cgi?id=72156 was also intent to have cmakeargs. 780927 2 177105 webkit.review.bot 2012-12-02 04:44:17 -0800 Comment on attachment 177105 proposed patch Clearing flags on attachment: 177105 Committed r136340: <http://trac.webkit.org/changeset/136340> 780928 3 webkit.review.bot 2012-12-02 04:44:21 -0800 All reviewed patches have been landed. Closing bug. 177105 2012-12-01 07:16:28 -0800 2012-12-02 04:44:17 -0800 proposed patch 103814.patch text/plain 1532 laszlo.gombos SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDEzNjMwOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDEyLTEyLTAxICBMYXN6bG8gR29tYm9zICA8bC5nb21ib3NAc2Ftc3VuZy5j b20+CisKKyAgICAgICAgQ29ycmVjdCB0aGUgc3BlbGxpbmcgb2YgdGhlIGNtYWtlYXJncyBhcmd1 bWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz ODE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhl IHNjcmlwdCBleHBlY3RzIGNtYWtlYXJncyAocGx1cmFsKSwgc28gbGV0cyBnZXQgdGhlCisgICAg ICAgIGRvY3VtZW50YXRpb24gb2YgdGhlIHNjcmlwdCByZXBvcnQgdGhlIHNhbWUuCisKKyAgICAg ICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAxMi0xMi0wMSAgWmFuIERvYmVyc2VrICA8 emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFtHVEtdIEExMXkgdGVzdHMgaW4gV0sy IHJlcG9ydCBiYWRseS1mb3JtYXR0ZWQgQVggcm9sZXMKSW5kZXg6IFRvb2xzL1NjcmlwdHMvYnVp bGQtd2Via2l0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0CShyZXZp c2lvbiAxMzU2MzEpCisrKyBUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtpdAkod29ya2luZyBjb3B5 KQpAQCAtMTI4LDcgKzEyOCw3IEBAIFVzYWdlOiAkcHJvZ3JhbU5hbWUgW29wdGlvbnNdIFtvcHRp b25zIHQKICAgLS1wcmVmaXg9PHBhdGg+ICAgICAgICAgICAgICAgICAgIFNldCBpbnN0YWxsYXRp b24gcHJlZml4IHRvIHRoZSBnaXZlbiBwYXRoIChHdGsvRWZsL0JsYWNrQmVycnkgb25seSkKICAg LS1tYWtlYXJncz08YXJndW1lbnRzPiAgICAgICAgICAgIE9wdGlvbmFsIE1ha2VmaWxlIGZsYWdz CiAgIC0tcW1ha2Vhcmc9PGFyZ3VtZW50cz4gICAgICAgICAgICBPcHRpb25hbCBxbWFrZSBmbGFn cyAoUXQgb25seSwgZS5nLiAtLXFtYWtlYXJnPSJDT05GSUcrPXdlYmtpdDIiIHRvIGJ1aWxkIFdl YktpdDIpCi0gIC0tY21ha2Vhcmc9PGFyZ3VtZW50cz4gICAgICAgICAgICBPcHRpb25hbCBDTWFr ZSBmbGFncyAoZS5nLiAtLWNtYWtlYXJnPSItREZPTz1iYXIgLURDTUFLRV9QUkVGSVhfUEFUSD0v dXNyL2xvY2FsIikKKyAgLS1jbWFrZWFyZ3M9PGFyZ3VtZW50cz4gICAgICAgICAgIE9wdGlvbmFs IENNYWtlIGZsYWdzIChlLmcuIC0tY21ha2VhcmdzPSItREZPTz1iYXIgLURDTUFLRV9QUkVGSVhf UEFUSD0vdXNyL2xvY2FsIikKIAogICAtLW1pbmltYWwgICAgICAgICAgICAgICAgICAgICAgICAg Tm8gb3B0aW9uYWwgZmVhdHVyZXMsIHVubGVzcyBleHBsaWNpdGx5IGVuYWJsZWQKIAo=