103804 2012-11-30 22:01:36 -0800 Avoid calling into NSUserDefaults every time we start a scroll 2012-12-03 11:11:27 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified REOPENED P2 Normal --- 1 simon.fraser simon.fraser ap bdakin mitz simon.fraser oldest_to_newest 780641 0 simon.fraser 2012-11-30 22:01:36 -0800 Avoid calling into NSUserDefaults every time we start a scroll 780644 1 177083 simon.fraser 2012-11-30 22:03:30 -0800 Created attachment 177083 Patch 780646 2 177084 simon.fraser 2012-11-30 22:04:41 -0800 Created attachment 177084 Patch 780649 3 177084 mitz 2012-11-30 22:08:14 -0800 Comment on attachment 177084 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177084&action=review > Source/WebCore/platform/mac/ScrollAnimatorMac.mm:638 > + NSString* prefName = key? scrollAnimationDefaultsKey? 780653 4 simon.fraser 2012-11-30 22:13:30 -0800 http://trac.webkit.org/changeset/136303 780734 5 177084 darin 2012-12-01 08:12:39 -0800 Comment on attachment 177084 Patch Can this setting be changed by the user while a process is running? If so, what code would we need to write to make sure we’d actually respond to that change? 780754 6 simon.fraser 2012-12-01 11:44:49 -0800 Sorry, I failed to address that in the commit message. There is no user-visible UI to change this setting on Mountain Lion. On Lion there is...so maybe I am only able to cache post-Lion. 781674 7 ap 2012-12-03 11:11:27 -0800 I think that reading this preference needs to move to UI process. What we care about what the preference is in main process, not in WebProcess. 177083 2012-11-30 22:03:30 -0800 2012-11-30 22:04:38 -0800 Patch bug-103804-20121130220100.patch text/plain 1779 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI0NzVlYWMwNWFiNWU1 NjU1OTA3OTExYTAxNDNjYTEyYjczZGRlMS4uMDA5YjRkZTc2N2NmMjNhMWRlYzc3YzJlODdkZDA1 NzAwNTlmNWZkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGNhbGxp bmcgaW50byBOU1VzZXJEZWZhdWx0cyBldmVyeSB0aW1lIHdlIHN0YXJ0IGEgc2Nyb2xsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM4MDQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWNoZSB0aGUgTlNT Y3JvbGxBbmltYXRpb25FbmFibGVkIHByZWZlcmVuY2UgdG8gYXZvaWQKKyAgICAgICAgaGl0dGlu ZyBOU1VzZXJEZWZhdWx0cyBldmVyeSB0aW1lIHdlIHN0YXJ0IHNjcm9sbGluZy4KKworICAgICAg ICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6 OnNjcm9sbEFuaW1hdGlvbkVuYWJsZWRGb3JTeXN0ZW0pOgorCiAyMDEyLTExLTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KaW5kZXggMjRlNDQ2MmU5NjY4YjY2ZDFlYjNmMzY4MzBl NThlZmY1YjhmNTlhZi4uNjc1ZWI2YmIwZjgxNzkwZjIwYzIzNzc2MmE0Zjc3ODBjZWJhNWRjYyAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5t bQpAQCAtNjM1LDExICs2MzUsMTQgQEAgU2Nyb2xsQW5pbWF0b3JNYWM6On5TY3JvbGxBbmltYXRv ck1hYygpCiAKIHN0YXRpYyBib29sIHNjcm9sbEFuaW1hdGlvbkVuYWJsZWRGb3JTeXN0ZW0oKQog eworICAgIE5TU3RyaW5nKiBjb25zdCBwcmVmTmFtZSA9IAogI2lmIF9fTUFDX09TX1hfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPD0gMTA3MCB8fCBQTEFURk9STShDSFJPTUlVTSkKLSAgICByZXR1cm4g W1tOU1VzZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gYm9vbEZvcktleTpAIkFwcGxl U2Nyb2xsQW5pbWF0aW9uRW5hYmxlZCJdOworICAgICAgICBAIkFwcGxlU2Nyb2xsQW5pbWF0aW9u RW5hYmxlZCI7CiAjZWxzZQotICAgIHJldHVybiBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNl ckRlZmF1bHRzXSBib29sRm9yS2V5OkAiTlNTY3JvbGxBbmltYXRpb25FbmFibGVkIl07CisgICAg ICAgIEAiTlNTY3JvbGxBbmltYXRpb25FbmFibGVkIjsKICNlbmRpZgorICAgIHN0YXRpYyBib29s IGVuYWJsZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9y S2V5OnByZWZOYW1lXTsKKyAgICByZXR1cm4gZW5hYmxlZDsKIH0KIAogI2lmIEVOQUJMRShSVUJC RVJfQkFORElORykK 177084 2012-11-30 22:04:41 -0800 2012-12-01 08:12:39 -0800 Patch bug-103804-20121130220211.patch text/plain 1773 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MzAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzI0NzVlYWMwNWFiNWU1 NjU1OTA3OTExYTAxNDNjYTEyYjczZGRlMS4uMDA5YjRkZTc2N2NmMjNhMWRlYzc3YzJlODdkZDA1 NzAwNTlmNWZkMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIGNhbGxp bmcgaW50byBOU1VzZXJEZWZhdWx0cyBldmVyeSB0aW1lIHdlIHN0YXJ0IGEgc2Nyb2xsCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM4MDQKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWNoZSB0aGUgTlNT Y3JvbGxBbmltYXRpb25FbmFibGVkIHByZWZlcmVuY2UgdG8gYXZvaWQKKyAgICAgICAgaGl0dGlu ZyBOU1VzZXJEZWZhdWx0cyBldmVyeSB0aW1lIHdlIHN0YXJ0IHNjcm9sbGluZy4KKworICAgICAg ICAqIHBsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6 OnNjcm9sbEFuaW1hdGlvbkVuYWJsZWRGb3JTeXN0ZW0pOgorCiAyMDEyLTExLTMwICBCZXRoIERh a2luICA8YmRha2luQGFwcGxlLmNvbT4KIAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNzkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t YWMvU2Nyb2xsQW5pbWF0b3JNYWMubW0KaW5kZXggMjRlNDQ2MmU5NjY4YjY2ZDFlYjNmMzY4MzBl NThlZmY1YjhmNTlhZi4uYjJkYWVjYjA5MzEzZTU4YTE2MmFiODc4NjU5ODFmNzMxMjk0NDkxYiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1Njcm9sbEFuaW1hdG9yTWFj Lm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9TY3JvbGxBbmltYXRvck1hYy5t bQpAQCAtNjM1LDExICs2MzUsMTQgQEAgU2Nyb2xsQW5pbWF0b3JNYWM6On5TY3JvbGxBbmltYXRv ck1hYygpCiAKIHN0YXRpYyBib29sIHNjcm9sbEFuaW1hdGlvbkVuYWJsZWRGb3JTeXN0ZW0oKQog eworICAgIE5TU3RyaW5nKiBwcmVmTmFtZSA9IAogI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5f UkVRVUlSRUQgPD0gMTA3MCB8fCBQTEFURk9STShDSFJPTUlVTSkKLSAgICByZXR1cm4gW1tOU1Vz ZXJEZWZhdWx0cyBzdGFuZGFyZFVzZXJEZWZhdWx0c10gYm9vbEZvcktleTpAIkFwcGxlU2Nyb2xs QW5pbWF0aW9uRW5hYmxlZCJdOworICAgICAgICBAIkFwcGxlU2Nyb2xsQW5pbWF0aW9uRW5hYmxl ZCI7CiAjZWxzZQotICAgIHJldHVybiBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1 bHRzXSBib29sRm9yS2V5OkAiTlNTY3JvbGxBbmltYXRpb25FbmFibGVkIl07CisgICAgICAgIEAi TlNTY3JvbGxBbmltYXRpb25FbmFibGVkIjsKICNlbmRpZgorICAgIHN0YXRpYyBib29sIGVuYWJs ZWQgPSBbW05TVXNlckRlZmF1bHRzIHN0YW5kYXJkVXNlckRlZmF1bHRzXSBib29sRm9yS2V5OnBy ZWZOYW1lXTsKKyAgICByZXR1cm4gZW5hYmxlZDsKIH0KIAogI2lmIEVOQUJMRShSVUJCRVJfQkFO RElORykK