103794 2012-11-30 17:53:10 -0800 AX: the text of render counters are not exposed to Accessibility 2013-01-08 10:59:48 -0800 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach apinheiro dglazkov dmazzoni jdiggs rniwa webkit.review.bot oldest_to_newest 780589 0 cfleizach 2012-11-30 17:53:10 -0800 Use something like this and the text of "1, 2, 3" won't be exposed to accessibility <style> ol li::before { content: counter(l1) ":"; counter-increment: l1;} ol li { list-style-type: decimial; display: block; } </style> <div style="counter-reset:l1;"> <ol style="list-style-type:decimal"><li>asdf<li>qwerwqer<li>yasdsf</ol> </div> 780593 1 177070 cfleizach 2012-11-30 17:57:23 -0800 Created attachment 177070 patch 780944 2 177070 webkit.review.bot 2012-12-02 05:52:17 -0800 Comment on attachment 177070 patch Attachment 177070 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/15105131 New failing tests: inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html 801580 3 177070 rniwa 2013-01-07 13:01:36 -0800 Comment on attachment 177070 patch View in context: https://bugs.webkit.org/attachment.cgi?id=177070&action=review > LayoutTests/accessibility/render-counter-text-expected.txt:3 > +line1 > +line2 > +line3 Could you hide this before the test finishes? 801731 4 cfleizach 2013-01-07 15:34:57 -0800 rdar://10733019 801732 5 cfleizach 2013-01-07 15:35:20 -0800 http://trac.webkit.org/changeset/139002 801882 6 rniwa 2013-01-07 17:32:37 -0800 accessibility/canvas-fallback-content-2.html started failing after this patch: http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r139007%20(4529)/results.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=accessibility%2Fcanvas-fallback-content-2.html 801887 7 cfleizach 2013-01-07 17:43:46 -0800 Weird. I'll look into it tonight. 802124 8 cfleizach 2013-01-08 01:04:09 -0800 It looks like the <select> element are calculating textUnderElement() and the <option> elements are RenderText things. Looking how AX is done for popup buttons, it seems we are doing things incorrectly at least on the Mac. The Mac should return the the selected <option> as the AXValue and not use the textUnderElement() as its title. There are a few tests that rely on pop up buttons having an AXTitle. 802382 9 rniwa 2013-01-08 10:55:41 -0800 Presumably http://trac.webkit.org/changeset/139077 fixes the test failure? 802385 10 cfleizach 2013-01-08 10:56:19 -0800 (In reply to comment #9) > Presumably http://trac.webkit.org/changeset/139077 fixes the test failure? No, that was another bug semi-independent. I nearly have a fix ready for this one 802387 11 rniwa 2013-01-08 10:58:13 -0800 (In reply to comment #10) > (In reply to comment #9) > > Presumably http://trac.webkit.org/changeset/139077 fixes the test failure? > > No, that was another bug semi-independent. I nearly have a fix ready for this one Okay. It'll be great if you could upload & land that ASAP. Currently, it's only test failing on build.webkit.org ML/Lion release bots. 802392 12 cfleizach 2013-01-08 10:59:48 -0800 here's the new bug https://bugs.webkit.org/show_bug.cgi?id=106349A 177070 2012-11-30 17:57:23 -0800 2013-01-07 13:01:36 -0800 patch patch text/plain 4812 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEzNjMwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEyLTExLTMwICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHRoZSB0ZXh0IG9m IHJlbmRlciBjb3VudGVycyBhcmUgbm90IGV4cG9zZWQgdG8gQWNjZXNzaWJpbGl0eQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNzk0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3VwcG9ydCBSZW5kZXJU ZXh0IG9iamVjdHMgdGhhdCBkb24ndCBoYXZlIG5vZGVzIChsaWtlIFJlbmRlckNvdW50ZXIpLgor CisgICAgICAgIFRlc3Q6IGFjY2Vzc2liaWxpdHkvcmVuZGVyLWNvdW50ZXItdGV4dC5odG1sCisK KyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6dGV4dFVuZGVyRWxl bWVudCk6CisKIDIwMTItMTEtMzAgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM3OTAKSW5k ZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3Np YmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkocmV2aXNpb24gMTM2Mjk1KQorKysgU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAkod29ya2luZyBj b3B5KQpAQCAtNjUxLDExICs2NTEsMTMgQEAKICAgICB9CiAgICAgCiAgICAgLy8gU29tZXRpbWVz IHRleHQgZnJhZ21lbnRzIGRvbid0IGhhdmUgTm9kZSdzIGFzc29jaWF0ZWQgd2l0aCB0aGVtIChs aWtlIHdoZW4KLSAgICAvLyBDU1MgY29udGVudCBpcyB1c2VkIHRvIGluc2VydCB0ZXh0KS4KKyAg ICAvLyBDU1MgY29udGVudCBpcyB1c2VkIHRvIGluc2VydCB0ZXh0IG9yIHdoZW4gYSBSZW5kZXJD b3VudGVyIGlzIHVzZWQuKS4KICAgICBpZiAobV9yZW5kZXJlci0+aXNUZXh0KCkpIHsKICAgICAg ICAgUmVuZGVyVGV4dCogcmVuZGVyVGV4dE9iamVjdCA9IHRvUmVuZGVyVGV4dChtX3JlbmRlcmVy KTsKICAgICAgICAgaWYgKHJlbmRlclRleHRPYmplY3QtPmlzVGV4dEZyYWdtZW50KCkpCiAgICAg ICAgICAgICByZXR1cm4gU3RyaW5nKHN0YXRpY19jYXN0PFJlbmRlclRleHRGcmFnbWVudCo+KG1f cmVuZGVyZXIpLT5jb250ZW50U3RyaW5nKCkpOworICAgICAgICBlbHNlCisgICAgICAgICAgICBy ZXR1cm4gU3RyaW5nKHJlbmRlclRleHRPYmplY3QtPnRleHQoKSk7CiAgICAgfQogICAgIAogICAg IC8vIHJldHVybiB0aGUgbnVsbCBzdHJpbmcgZm9yIGFub255bW91cyB0ZXh0IGJlY2F1c2UgaXQg aXMgbm9uLXRyaXZpYWwgdG8gZ2V0CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxMzYzMDEpCisrKyBMYXlv dXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxMi0x MS0zMCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAgIEFY OiB0aGUgdGV4dCBvZiByZW5kZXIgY291bnRlcnMgYXJlIG5vdCBleHBvc2VkIHRvIEFjY2Vzc2li aWxpdHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw Mzc5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog YWNjZXNzaWJpbGl0eS9yZW5kZXItY291bnRlci10ZXh0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisg ICAgICAgICogYWNjZXNzaWJpbGl0eS9yZW5kZXItY291bnRlci10ZXh0Lmh0bWw6IEFkZGVkLgor CiAyMDEyLTExLTMwICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBzdXBwb3J0IGZvciB0aGUgJ3VucGF1c2UoKScgbWV0aG9kIG9uIE1lZGlhQ29udHJvbGxl ci4KSW5kZXg6IExheW91dFRlc3RzL2FjY2Vzc2liaWxpdHkvcmVuZGVyLWNvdW50ZXItdGV4dC1l eHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvYWNjZXNzaWJpbGl0eS9yZW5k ZXItY291bnRlci10ZXh0LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3Rz L2FjY2Vzc2liaWxpdHkvcmVuZGVyLWNvdW50ZXItdGV4dC1leHBlY3RlZC50eHQJKHJldmlzaW9u IDApCkBAIC0wLDAgKzEsMTcgQEAKK2xpbmUxCitsaW5lMgorbGluZTMKK1RoaXMgdGVzdHMgdGhh dCB0aGUgdGV4dCBmb3IgUmVuZGVyQ291bnRlciBpcyBleHBvc2VkIGNvcnJlY3RseS4KKworT24g c3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93 ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgorCitQQVNTIGxpbmUxLmNoaWxkQXRJbmRleCgwKS5zdHJp bmdWYWx1ZSBpcyAnQVhWYWx1ZTogMScKK1BBU1MgbGluZTEuY2hpbGRBdEluZGV4KDEpLnN0cmlu Z1ZhbHVlIGlzICdBWFZhbHVlOiA6JworUEFTUyBsaW5lMS5jaGlsZEF0SW5kZXgoMikuc3RyaW5n VmFsdWUgaXMgJ0FYVmFsdWU6IGxpbmUxJworUEFTUyBsaW5lMi5jaGlsZEF0SW5kZXgoMCkuc3Ry aW5nVmFsdWUgaXMgJ0FYVmFsdWU6IDInCitQQVNTIGxpbmUyLmNoaWxkQXRJbmRleCgxKS5zdHJp bmdWYWx1ZSBpcyAnQVhWYWx1ZTogOicKK1BBU1MgbGluZTIuY2hpbGRBdEluZGV4KDIpLnN0cmlu Z1ZhbHVlIGlzICdBWFZhbHVlOiBsaW5lMicKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRy dWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmlsaXR5L3Jl bmRlci1jb3VudGVyLXRleHQuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9hY2Nlc3Np YmlsaXR5L3JlbmRlci1jb3VudGVyLXRleHQuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2FjY2Vzc2liaWxpdHkvcmVuZGVyLWNvdW50ZXItdGV4dC5odG1sCShyZXZpc2lvbiAwKQpA QCAtMCwwICsxLDQzIEBACis8IURPQ1RZUEUgSFRNTD4KKzxodG1sPgorPGJvZHk+Cis8c2NyaXB0 IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorCis8 c3R5bGU+CitvbCBsaTo6YmVmb3JlIHsgY29udGVudDogY291bnRlcihsMSkgIjoiOyBjb3VudGVy LWluY3JlbWVudDogbDE7fQorb2wgbGkgeyBsaXN0LXN0eWxlLXR5cGU6IGRlY2ltaWFsOyBkaXNw bGF5OiBibG9jazsgfQorPC9zdHlsZT4KKworPGRpdiBzdHlsZT0iY291bnRlci1yZXNldDpsMTsi PgorPG9sIHN0eWxlPSJsaXN0LXN0eWxlLXR5cGU6ZGVjaW1hbCI+Cis8bGkgaWQ9ImxpbmUxIj5s aW5lMQorPGxpIGlkPSJsaW5lMiI+bGluZTIKKzxsaT5saW5lMworPC9vbD4KKzwvZGl2PgorCis8 ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKwor PHNjcmlwdD4KKworZGVzY3JpcHRpb24oIlRoaXMgdGVzdHMgdGhhdCB0aGUgdGV4dCBmb3IgUmVu ZGVyQ291bnRlciBpcyBleHBvc2VkIGNvcnJlY3RseS4iKQorCitpZiAod2luZG93LnRlc3RSdW5u ZXIgJiYgd2luZG93LmFjY2Vzc2liaWxpdHlDb250cm9sbGVyKSB7CisgICAgCisgICAgdmFyIGxp bmUxID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJsaW5l MSIpOworICAgIHNob3VsZEJlKCJsaW5lMS5jaGlsZEF0SW5kZXgoMCkuc3RyaW5nVmFsdWUiLCAi J0FYVmFsdWU6IDEnIik7CisgICAgc2hvdWxkQmUoImxpbmUxLmNoaWxkQXRJbmRleCgxKS5zdHJp bmdWYWx1ZSIsICInQVhWYWx1ZTogOiciKTsKKyAgICBzaG91bGRCZSgibGluZTEuY2hpbGRBdElu ZGV4KDIpLnN0cmluZ1ZhbHVlIiwgIidBWFZhbHVlOiBsaW5lMSciKTsKKworICAgIHZhciBsaW5l MiA9IGFjY2Vzc2liaWxpdHlDb250cm9sbGVyLmFjY2Vzc2libGVFbGVtZW50QnlJZCgibGluZTIi KTsKKyAgICBzaG91bGRCZSgibGluZTIuY2hpbGRBdEluZGV4KDApLnN0cmluZ1ZhbHVlIiwgIidB WFZhbHVlOiAyJyIpOworICAgIHNob3VsZEJlKCJsaW5lMi5jaGlsZEF0SW5kZXgoMSkuc3RyaW5n VmFsdWUiLCAiJ0FYVmFsdWU6IDonIik7CisgICAgc2hvdWxkQmUoImxpbmUyLmNoaWxkQXRJbmRl eCgyKS5zdHJpbmdWYWx1ZSIsICInQVhWYWx1ZTogbGluZTInIik7Cit9CisKKzwvc2NyaXB0Pgor Cis8c2NyaXB0IHNyYz0iLi4vZmFzdC9qcy9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3Nj cmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K