103785 2012-11-30 15:52:16 -0800 [BlackBerry] GeolocationClientBB should show file system path in prompts when host is not avaliable 2012-12-07 12:23:35 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot yong.li.webkit oldest_to_newest 780498 0 otcheung 2012-11-30 15:52:16 -0800 GeolocationClientBlackBerry should show file system path in prompts when host is not avaliable. 785326 1 178090 otcheung 2012-12-06 15:17:11 -0800 Created attachment 178090 Patch 785327 2 178091 otcheung 2012-12-06 15:20:26 -0800 Created attachment 178091 Patch 786045 3 178091 rwlbuis 2012-12-07 12:20:35 -0800 Comment on attachment 178091 Patch LGTM. 786051 4 178091 webkit.review.bot 2012-12-07 12:23:31 -0800 Comment on attachment 178091 Patch Clearing flags on attachment: 178091 Committed r136969: <http://trac.webkit.org/changeset/136969> 786052 5 webkit.review.bot 2012-12-07 12:23:35 -0800 All reviewed patches have been landed. Closing bug. 178090 2012-12-06 15:17:11 -0800 2012-12-06 15:20:23 -0800 Patch bug-103785-20121206181436.patch text/plain 3540 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0MGQwY2U2ZGQwZjZiZTk3OWNkZTc0MWMxMzdmMDBjMmQ0NWUzMDhlLi4xZmU5YTYxMTc1 YTBjYjI1NjVmY2M3NDljMGFjYzQyNGU2NDUwYTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMi0wNiAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBHZW9sb2NhdGlvbkNsaWVu dEJCIHNob3VsZCBzaG93IGZpbGUgc3lzdGVtIHBhdGggaW4gcHJvbXB0cyB3aGVuIGhvc3QgaXMg bm90IGF2YWxpYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAzNzg1CisKKyAgICAgICAgUFIgMjQ3NjU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGEgc3BlY2lhbCBjYXNlIGZvciBvcmln aW5zIHdpdGggcHJvdG9jb2wgImZpbGUiLiBXZSB3aWxsIHVzZSB0aGUgZmlsZXBhdGggYXMKKyAg ICAgICAgYW4gb3JpZ2luIHdoZW4gYXNraW5nIGZvciBnZW9sb2NhdGlvbiBwZXJtaXNzaW9uLgor CisgICAgICAgIElmIHRoZSBvcmlnaW4gaXMgdW5pcXVlIChpZS4gZnJvbSBhIHNhbmRib3hlZCBp ZnJhbWUpLCB3ZSB3aWxsIGZhaWwgdGhlIGxvY2F0aW9uIHJlcXVlc3QKKyAgICAgICAgcmlnaHQg YXdheS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50QmxhY2tC ZXJyeS5jcHA6CisgICAgICAgIChnZXRPcmlnaW4pOgorICAgICAgICAoR2VvbG9jYXRpb25DbGll bnRCbGFja0JlcnJ5OjpyZXF1ZXN0UGVybWlzc2lvbik6CisgICAgICAgIChHZW9sb2NhdGlvbkNs aWVudEJsYWNrQmVycnk6OmNhbmNlbFBlcm1pc3Npb25SZXF1ZXN0KToKKwogMjAxMi0xMi0wNSAg T3R0byBEZXJlayBDaGV1bmcgIDxvdGNoZXVuZ0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XSBHZW9sb2NhdGlvbiBwcm9tcHRzIHdvbid0IHJlc3BvbmQgdG8gdGhlIGNvcnJlY3QgZ2Vv bG9jYXRpb24gb2JqZWN0IGlmIHRoZSB1c2VyIG9wZW5zIHR3byBwYWdlcyBhbmQgcmVzcG9uZCBp biB0aGUgcmV2ZXJzZWQgb3JkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50QmxhY2tC ZXJyeS5jcHAKaW5kZXggNDk5YWU0Yzk1MzRiNTI2MWI0NjQ5ZmMwNTBjMWRkNjg1ZjY3ZTVkNC4u OTA0YmYzZWNhOGE2NDIyNGQ0NmM4NmI4Y2M3Mzc5NmExNTYxN2EyZSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50Qmxh Y2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L0dlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTMwLDYgKzMwLDE4IEBACiAKIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCitzdGF0aWMgU3RyaW5nIGdldE9yaWdpbihGcmFtZSog ZnJhbWUpIAoreworICAgIFNlY3VyaXR5T3JpZ2luKiBzZWN1cml0eU9yaWdpbiA9IGZyYW1lLT5k b2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpOworICAgIFN0cmluZyBvcmlnaW4gPSBzZWN1cml0 eU9yaWdpbi0+dG9TdHJpbmcoKTsKKworICAgIC8vIFNwZWNpYWwgY2FzZSBmb3IgZmlsZS4KKyAg ICBpZiAoc2VjdXJpdHlPcmlnaW4tPnByb3RvY29sKCkgPT0gImZpbGUiKQorICAgICAgICBvcmln aW4gPSBzZWN1cml0eU9yaWdpbi0+ZmlsZVN5c3RlbVBhdGgoKTsKKworICAgIHJldHVybiBvcmln aW47Cit9CisKIEdlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeTo6R2VvbG9jYXRpb25DbGllbnRC bGFja0JlcnJ5KEJsYWNrQmVycnk6OldlYktpdDo6V2ViUGFnZVByaXZhdGUqIHdlYlBhZ2VQcml2 YXRlKQogICAgIDogbV93ZWJQYWdlUHJpdmF0ZSh3ZWJQYWdlUHJpdmF0ZSkKICAgICAsIG1fYWNj dXJhY3koZmFsc2UpCkBAIC02OSwxMyArODEsMTYgQEAgdm9pZCBHZW9sb2NhdGlvbkNsaWVudEJs YWNrQmVycnk6OnJlcXVlc3RQZXJtaXNzaW9uKEdlb2xvY2F0aW9uKiBsb2NhdGlvbikKICAgICBp ZiAoIWZyYW1lKQogICAgICAgICByZXR1cm47CiAKLSAgICAvLyBGSVhNRTogVGhlIGdlb2xvY2F0 aW9uIHNldHRpbmcgZm9yIFdlYlNldHRpbmdzIGlzIGFsd2F5cyB0cnVlLiBOb3RoaW5nIGV2ZXIg dG9nZ2xlcyB0aGF0IHNldHRpbmcuCiAgICAgaWYgKCFtX3dlYlBhZ2VQcml2YXRlLT5tX3dlYlNl dHRpbmdzLT5pc0dlb2xvY2F0aW9uRW5hYmxlZCgpKSB7CiAgICAgICAgIGxvY2F0aW9uLT5zZXRJ c0FsbG93ZWQoZmFsc2UpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgY29uc3QgU3Ry aW5nIG9yaWdpbiA9IGZyYW1lLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpLT50b1N0cmlu ZygpOworICAgIGNvbnN0IFN0cmluZyBvcmlnaW4gPSBnZXRPcmlnaW4oZnJhbWUpOworCisgICAg Ly8gU3BlY2lhbCBjYXNlIGZvciBkb2N1bWVudHMgd2l0aCB0aGUgaXNVbmlxdWUgZmxhZyBvbi4g KGllLiBzYW5kYm94ZWQgaWZyYW1lcykKKyAgICBpZiAob3JpZ2luID09ICJudWxsIikKKyAgICAg ICAgbG9jYXRpb24tPnNldElzQWxsb3dlZChmYWxzZSk7CiAKICAgICAvLyBDaGVjayBnbG9iYWwg bG9jYXRpb24gc2V0dGluZywgaWYgaXQgaXMgb2ZmIHRoZW4gd2UgcmVxdWVzdCBhbiBpbmZvYmFy IHRoYXQgaW52b2tlcyBhIGxvY2F0aW9uIHNldHRpbmdzIGNhcmQuCiAgICAgLy8gSWYgaXQncyBv biwgdGhlbiB3ZSByZXF1ZXN0IGFuIGluZm9iYXIgdGhhdCBhbGxvd3MgdGhlIHNpdGUgdG8gaGF2 ZSBwZXJtaXNzaW9uIHRvIHVzZSBnZW9sb2NhdGlvbi4KQEAgLTEwOSw3ICsxMjQsNyBAQCB2b2lk IEdlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeTo6Y2FuY2VsUGVybWlzc2lvblJlcXVlc3QoR2Vv bG9jYXRpb24qIGxvY2F0aW9uKQogICAgIGlmICghZnJhbWUpCiAgICAgICAgIHJldHVybjsKIAot ICAgIGNvbnN0IFN0cmluZyBvcmlnaW4gPSBmcmFtZS0+ZG9jdW1lbnQoKS0+c2VjdXJpdHlPcmln aW4oKS0+dG9TdHJpbmcoKTsKKyAgICBjb25zdCBTdHJpbmcgb3JpZ2luID0gZ2V0T3JpZ2luKGZy YW1lKTsKIAogICAgIC8vIFJlbW92ZSB0aGUgZ2VvbG9jYXRpb24gZnJvbSB0aGUgcGVuZGluZyBw ZXJtaXNzaW9uIG1hcC4KICAgICBIYXNoTWFwPFN0cmluZywgVmVjdG9yPFJlZlB0cjxHZW9sb2Nh dGlvbj4gPiA+OjppdGVyYXRvciBpdCA9IG1fZ2VvbG9jYXRpb25SZXF1ZXN0TWFwLmZpbmQob3Jp Z2luKTsK 178091 2012-12-06 15:20:26 -0800 2012-12-07 12:23:31 -0800 Patch bug-103785-20121206181751.patch text/plain 3568 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2ODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0MGQwY2U2ZGQwZjZiZTk3OWNkZTc0MWMxMzdmMDBjMmQ0NWUzMDhlLi4xZmU5YTYxMTc1 YTBjYjI1NjVmY2M3NDljMGFjYzQyNGU2NDUwYTY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAxMi0xMi0wNiAgT3R0byBEZXJlayBDaGV1bmcgIDxv dGNoZXVuZ0ByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBHZW9sb2NhdGlvbkNsaWVu dEJCIHNob3VsZCBzaG93IGZpbGUgc3lzdGVtIHBhdGggaW4gcHJvbXB0cyB3aGVuIGhvc3QgaXMg bm90IGF2YWxpYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTAzNzg1CisKKyAgICAgICAgUFIgMjQ3NjU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkaW5nIGEgc3BlY2lhbCBjYXNlIGZvciBvcmln aW5zIHdpdGggcHJvdG9jb2wgImZpbGUiLiBXZSB3aWxsIHVzZSB0aGUgZmlsZXBhdGggYXMKKyAg ICAgICAgYW4gb3JpZ2luIHdoZW4gYXNraW5nIGZvciBnZW9sb2NhdGlvbiBwZXJtaXNzaW9uLgor CisgICAgICAgIElmIHRoZSBvcmlnaW4gaXMgdW5pcXVlIChpZS4gZnJvbSBhIHNhbmRib3hlZCBp ZnJhbWUpLCB3ZSB3aWxsIGZhaWwgdGhlIGxvY2F0aW9uIHJlcXVlc3QKKyAgICAgICAgcmlnaHQg YXdheS4KKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50QmxhY2tC ZXJyeS5jcHA6CisgICAgICAgIChnZXRPcmlnaW4pOgorICAgICAgICAoR2VvbG9jYXRpb25DbGll bnRCbGFja0JlcnJ5OjpyZXF1ZXN0UGVybWlzc2lvbik6CisgICAgICAgIChHZW9sb2NhdGlvbkNs aWVudEJsYWNrQmVycnk6OmNhbmNlbFBlcm1pc3Npb25SZXF1ZXN0KToKKwogMjAxMi0xMi0wNSAg T3R0byBEZXJlayBDaGV1bmcgIDxvdGNoZXVuZ0ByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0Jl cnJ5XSBHZW9sb2NhdGlvbiBwcm9tcHRzIHdvbid0IHJlc3BvbmQgdG8gdGhlIGNvcnJlY3QgZ2Vv bG9jYXRpb24gb2JqZWN0IGlmIHRoZSB1c2VyIG9wZW5zIHR3byBwYWdlcyBhbmQgcmVzcG9uZCBp biB0aGUgcmV2ZXJzZWQgb3JkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJy eS9XZWJDb3JlU3VwcG9ydC9HZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnkuY3BwIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50QmxhY2tC ZXJyeS5jcHAKaW5kZXggNDk5YWU0Yzk1MzRiNTI2MWI0NjQ5ZmMwNTBjMWRkNjg1ZjY3ZTVkNC4u YTkyNzk2N2I2ZGExOTdhYTE5M2IwN2I0YzU0MmVhMDk1Yjc5OGEyNSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0L0dlb2xvY2F0aW9uQ2xpZW50Qmxh Y2tCZXJyeS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYkNvcmVTdXBwb3J0 L0dlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeS5jcHAKQEAgLTMwLDYgKzMwLDIwIEBACiAKIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCitzdGF0aWMgU3RyaW5nIGdldE9yaWdpbihGcmFtZSog ZnJhbWUpIAoreworICAgIFN0cmluZyBvcmlnaW47IAorICAgIFNlY3VyaXR5T3JpZ2luKiBzZWN1 cml0eU9yaWdpbiA9IGZyYW1lLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpOworCisgICAg Ly8gU3BlY2lhbCBjYXNlIGZvciBmaWxlLgorICAgIGlmIChzZWN1cml0eU9yaWdpbi0+cHJvdG9j b2woKSA9PSAiZmlsZSIpCisgICAgICAgIG9yaWdpbiA9IHNlY3VyaXR5T3JpZ2luLT5maWxlU3lz dGVtUGF0aCgpOworICAgIGVsc2UKKyAgICAgICAgb3JpZ2luID0gc2VjdXJpdHlPcmlnaW4tPnRv U3RyaW5nKCk7CisKKyAgICByZXR1cm4gb3JpZ2luOworfQorCiBHZW9sb2NhdGlvbkNsaWVudEJs YWNrQmVycnk6Okdlb2xvY2F0aW9uQ2xpZW50QmxhY2tCZXJyeShCbGFja0JlcnJ5OjpXZWJLaXQ6 OldlYlBhZ2VQcml2YXRlKiB3ZWJQYWdlUHJpdmF0ZSkKICAgICA6IG1fd2ViUGFnZVByaXZhdGUo d2ViUGFnZVByaXZhdGUpCiAgICAgLCBtX2FjY3VyYWN5KGZhbHNlKQpAQCAtNjksMTMgKzgzLDE2 IEBAIHZvaWQgR2VvbG9jYXRpb25DbGllbnRCbGFja0JlcnJ5OjpyZXF1ZXN0UGVybWlzc2lvbihH ZW9sb2NhdGlvbiogbG9jYXRpb24pCiAgICAgaWYgKCFmcmFtZSkKICAgICAgICAgcmV0dXJuOwog Ci0gICAgLy8gRklYTUU6IFRoZSBnZW9sb2NhdGlvbiBzZXR0aW5nIGZvciBXZWJTZXR0aW5ncyBp cyBhbHdheXMgdHJ1ZS4gTm90aGluZyBldmVyIHRvZ2dsZXMgdGhhdCBzZXR0aW5nLgogICAgIGlm ICghbV93ZWJQYWdlUHJpdmF0ZS0+bV93ZWJTZXR0aW5ncy0+aXNHZW9sb2NhdGlvbkVuYWJsZWQo KSkgewogICAgICAgICBsb2NhdGlvbi0+c2V0SXNBbGxvd2VkKGZhbHNlKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIAotICAgIGNvbnN0IFN0cmluZyBvcmlnaW4gPSBmcmFtZS0+ZG9jdW1lbnQo KS0+c2VjdXJpdHlPcmlnaW4oKS0+dG9TdHJpbmcoKTsKKyAgICBjb25zdCBTdHJpbmcgb3JpZ2lu ID0gZ2V0T3JpZ2luKGZyYW1lKTsKKworICAgIC8vIFNwZWNpYWwgY2FzZSBmb3IgZG9jdW1lbnRz IHdpdGggdGhlIGlzVW5pcXVlIGZsYWcgb24uIChpZS4gc2FuZGJveGVkIGlmcmFtZXMpCisgICAg aWYgKG9yaWdpbiA9PSAibnVsbCIpCisgICAgICAgIGxvY2F0aW9uLT5zZXRJc0FsbG93ZWQoZmFs c2UpOwogCiAgICAgLy8gQ2hlY2sgZ2xvYmFsIGxvY2F0aW9uIHNldHRpbmcsIGlmIGl0IGlzIG9m ZiB0aGVuIHdlIHJlcXVlc3QgYW4gaW5mb2JhciB0aGF0IGludm9rZXMgYSBsb2NhdGlvbiBzZXR0 aW5ncyBjYXJkLgogICAgIC8vIElmIGl0J3Mgb24sIHRoZW4gd2UgcmVxdWVzdCBhbiBpbmZvYmFy IHRoYXQgYWxsb3dzIHRoZSBzaXRlIHRvIGhhdmUgcGVybWlzc2lvbiB0byB1c2UgZ2VvbG9jYXRp b24uCkBAIC0xMDksNyArMTI2LDcgQEAgdm9pZCBHZW9sb2NhdGlvbkNsaWVudEJsYWNrQmVycnk6 OmNhbmNlbFBlcm1pc3Npb25SZXF1ZXN0KEdlb2xvY2F0aW9uKiBsb2NhdGlvbikKICAgICBpZiAo IWZyYW1lKQogICAgICAgICByZXR1cm47CiAKLSAgICBjb25zdCBTdHJpbmcgb3JpZ2luID0gZnJh bWUtPmRvY3VtZW50KCktPnNlY3VyaXR5T3JpZ2luKCktPnRvU3RyaW5nKCk7CisgICAgY29uc3Qg U3RyaW5nIG9yaWdpbiA9IGdldE9yaWdpbihmcmFtZSk7CiAKICAgICAvLyBSZW1vdmUgdGhlIGdl b2xvY2F0aW9uIGZyb20gdGhlIHBlbmRpbmcgcGVybWlzc2lvbiBtYXAuCiAgICAgSGFzaE1hcDxT dHJpbmcsIFZlY3RvcjxSZWZQdHI8R2VvbG9jYXRpb24+ID4gPjo6aXRlcmF0b3IgaXQgPSBtX2dl b2xvY2F0aW9uUmVxdWVzdE1hcC5maW5kKG9yaWdpbik7Cg==