103775 2012-11-30 14:17:14 -0800 Remove stale check in check-for-webkit-framework-include-consistency 2012-12-05 12:56:51 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned bdakin ddkilzer joepeck webkit.review.bot oldest_to_newest 780420 0 joepeck 2012-11-30 14:17:14 -0800 The radar claims this was fixed a long time ago with: <http://webkit.org/b/56402> REGRESSION (WebKit2): keygen element doesn't work r81173 - <http://trac.webkit.org/changeset/81173> So we can remove the check in the build phase script. 780421 1 177025 joepeck 2012-11-30 14:19:39 -0800 Created attachment 177025 [PATCH] Proposed Fix 780433 2 177026 joepeck 2012-11-30 14:32:39 -0800 Created attachment 177026 [PATCH] Proposed Fix - Remove some more stale code The "throw" in the unless block is already handled up above via "or throw". So drive-by remove the dead code. 784006 3 177026 ddkilzer 2012-12-05 12:43:39 -0800 Comment on attachment 177026 [PATCH] Proposed Fix - Remove some more stale code r=me 784027 4 177026 webkit.review.bot 2012-12-05 12:56:48 -0800 Comment on attachment 177026 [PATCH] Proposed Fix - Remove some more stale code Clearing flags on attachment: 177026 Committed r136743: <http://trac.webkit.org/changeset/136743> 784028 5 webkit.review.bot 2012-12-05 12:56:51 -0800 All reviewed patches have been landed. Closing bug. 177025 2012-11-30 14:19:39 -0800 2012-11-30 14:32:39 -0800 [PATCH] Proposed Fix fix.patch text/plain 1358 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzBm NjA3Li5jZGRjMTg3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTEtMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc3RhbGUgY2hlY2sgaW4gY2hlY2st Zm9yLXdlYmtpdC1mcmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNzc1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHVuZGVybHlpbmcgaXNzdWUgd2Fz IGZpeGVkIGluIHI4MTE3My4KKworICAgICAgICAqIFNjcmlwdHMvY2hlY2stZm9yLXdlYmtpdC1m cmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeToKKwogMjAxMi0xMS0xNCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFJlbW92ZSB1c2VzIG9mIGRlcHJl Y2F0ZWQgdW5pdHRlc3QuVGVzdENhc2UgYWxpYXNlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9jaGVjay1mb3Itd2Via2l0LWZyYW1ld29yay1pbmNsdWRlLWNvbnNpc3RlbmN5IGIvVG9vbHMv U2NyaXB0cy9jaGVjay1mb3Itd2Via2l0LWZyYW1ld29yay1pbmNsdWRlLWNvbnNpc3RlbmN5Cmlu ZGV4IDMzOWZhN2UuLmJkNWZmYTYgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9y LXdlYmtpdC1mcmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeQorKysgYi9Ub29scy9TY3JpcHRz L2NoZWNrLWZvci13ZWJraXQtZnJhbWV3b3JrLWluY2x1ZGUtY29uc2lzdGVuY3kKQEAgLTczLDkg KzczLDYgQEAgZGVmIHJlc29sdmVfaW5jbHVkZShoZWFkZXIsIGluY2x1ZGVkX2hlYWRlciwgcGVy bWl0dGVkX3R5cGVzKQogCiAgICMgQSBoZWFkZXIgb2YgYW55IHR5cGUgaW5jbHVkaW5nIGEgV2Vi Q29yZSBoZWFkZXIgaXMgYSByZWNpcGUgZm9yIGRpc2FzdGVyLgogICBpZiBmcmFtZXdvcmsgPT0g IldlYkNvcmUiCi0gICAgIyA8cmRhcjovL3Byb2JsZW0vNzcxODgyNj4gV2ViS2V5R2VuZXJhdG9y Lmggc2hvdWxkIG5vdCBpbmNsdWRlIGEgV2ViQ29yZSBoZWFkZXIKLSAgICByZXR1cm4gaWYgaGVh ZGVyID1+IC9cL1dlYktleUdlbmVyYXRvci5oJC8gYW5kIGluY2x1ZGVkX2hlYWRlcl9uYW1lID09 ICJXZWJDb3JlS2V5R2VuZXJhdG9yLmgiCi0KICAgICBwcmludF9lcnJvciAiI3toZWFkZXJ9IGlu Y2x1ZGVkICN7aW5jbHVkZWRfaGVhZGVyfSEiCiAgICAgcmV0dXJuCiAgIGVuZAo= 177026 2012-11-30 14:32:39 -0800 2012-12-05 12:56:48 -0800 [PATCH] Proposed Fix - Remove some more stale code fix-2.patch text/plain 1764 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxYzBm NjA3Li5jZGRjMTg3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMTEtMzAgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgc3RhbGUgY2hlY2sgaW4gY2hlY2st Zm9yLXdlYmtpdC1mcmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAzNzc1CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHVuZGVybHlpbmcgaXNzdWUgd2Fz IGZpeGVkIGluIHI4MTE3My4KKworICAgICAgICAqIFNjcmlwdHMvY2hlY2stZm9yLXdlYmtpdC1m cmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeToKKwogMjAxMi0xMS0xNCAgWmFuIERvYmVyc2Vr ICA8emFuZG9iZXJzZWtAZ21haWwuY29tPgogCiAgICAgICAgIFJlbW92ZSB1c2VzIG9mIGRlcHJl Y2F0ZWQgdW5pdHRlc3QuVGVzdENhc2UgYWxpYXNlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy9jaGVjay1mb3Itd2Via2l0LWZyYW1ld29yay1pbmNsdWRlLWNvbnNpc3RlbmN5IGIvVG9vbHMv U2NyaXB0cy9jaGVjay1mb3Itd2Via2l0LWZyYW1ld29yay1pbmNsdWRlLWNvbnNpc3RlbmN5Cmlu ZGV4IDMzOWZhN2UuLmZhYmM2OTIgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvY2hlY2stZm9y LXdlYmtpdC1mcmFtZXdvcmstaW5jbHVkZS1jb25zaXN0ZW5jeQorKysgYi9Ub29scy9TY3JpcHRz L2NoZWNrLWZvci13ZWJraXQtZnJhbWV3b3JrLWluY2x1ZGUtY29uc2lzdGVuY3kKQEAgLTI3LDEw ICsyNyw2IEBACiBiYXNlX2RpcmVjdG9yeSA9IEVOVlsnVEFSR0VUX0JVSUxEX0RJUiddIG9yIHRo cm93ICJVbmFibGUgdG8gZmluZCBUQVJHRVRfQlVJTERfRElSIGluIHRoZSBlbnZpcm9ubWVudCEi CiBpc19zaGFsbG93X2J1bmRsZSA9IChFTlZbJ1NIQUxMT1dfQlVORExFJ10gfHwgIk5PIikudXBj YXNlID09ICJZRVMiCiAKLXVubGVzcyBiYXNlX2RpcmVjdG9yeQotICB0aHJvdyAiVW5hYmxlIHRv IGZpbmQgVEFSR0VUX0JVSUxEX0RJUiBpbiB0aGUgZW52aXJvbm1lbnQhIgotZW5kCi0KIERpci5j aGRpciBiYXNlX2RpcmVjdG9yeQogCiAkUEVSTUlUVEVEX0lOQ0xVREVfVFlQRVMgPSB7IDpwdWJs aWMgPT4gWyA6cHVibGljIF0sIDpwcml2YXRlID0+IFsgOnB1YmxpYywgOnByaXZhdGUgXSB9CkBA IC03Myw5ICs2OSw2IEBAIGRlZiByZXNvbHZlX2luY2x1ZGUoaGVhZGVyLCBpbmNsdWRlZF9oZWFk ZXIsIHBlcm1pdHRlZF90eXBlcykKIAogICAjIEEgaGVhZGVyIG9mIGFueSB0eXBlIGluY2x1ZGlu ZyBhIFdlYkNvcmUgaGVhZGVyIGlzIGEgcmVjaXBlIGZvciBkaXNhc3Rlci4KICAgaWYgZnJhbWV3 b3JrID09ICJXZWJDb3JlIgotICAgICMgPHJkYXI6Ly9wcm9ibGVtLzc3MTg4MjY+IFdlYktleUdl bmVyYXRvci5oIHNob3VsZCBub3QgaW5jbHVkZSBhIFdlYkNvcmUgaGVhZGVyCi0gICAgcmV0dXJu IGlmIGhlYWRlciA9fiAvXC9XZWJLZXlHZW5lcmF0b3IuaCQvIGFuZCBpbmNsdWRlZF9oZWFkZXJf bmFtZSA9PSAiV2ViQ29yZUtleUdlbmVyYXRvci5oIgotCiAgICAgcHJpbnRfZXJyb3IgIiN7aGVh ZGVyfSBpbmNsdWRlZCAje2luY2x1ZGVkX2hlYWRlcn0hIgogICAgIHJldHVybgogICBlbmQK