103773 2012-11-30 14:04:22 -0800 Late-loading stylesheets can cause composited layers to be blank 2012-11-30 14:49:59 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://philosophically.com/why-were-pivoting-from-mobile-first-to-web-first InRadar P2 Normal --- 1 simon.fraser simon.fraser bdakin eric ojan simon.fraser thorton webkit.review.bot oldest_to_newest 780407 0 simon.fraser 2012-11-30 14:04:22 -0800 Loading http://philosophically.com/why-were-pivoting-from-mobile-first-to-web-first on TOT often shows big blank areas. 780408 1 simon.fraser 2012-11-30 14:04:40 -0800 <rdar://problem/12763281> 780419 2 177024 simon.fraser 2012-11-30 14:16:18 -0800 Created attachment 177024 Patch 780429 3 177024 thorton 2012-11-30 14:26:12 -0800 Comment on attachment 177024 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=177024&action=review > Source/WebCore/ChangeLog:9 > + is pending, which is done to avoid a FOUC. When the stylesheet finally loaded, Probably spell it out? > Source/WebCore/rendering/RenderLayerCompositor.h:148 > + // Repaint parts of all composited layers that intersect the given absolute rectangle (or the entire layer if the pointer is null). > + void repaintCompositedLayers(const IntRect* = 0); This mechanism makes for some slightly unusual looking code elsewhere... > Source/WebCore/rendering/RenderView.h:-84 > - virtual void repaintViewRectangle(const LayoutRect&, bool immediate = false) const; > + void repaintViewRectangle(const LayoutRect&, bool immediate = false) const; > // Repaint the view, and all composited layers that intersect the given absolute rectangle. > // FIXME: ideally we'd never have to do this, if all repaints are container-relative. > - virtual void repaintRectangleInViewAndCompositedLayers(const LayoutRect&, bool immediate = false); These weren't virtual for a reason? 780443 4 simon.fraser 2012-11-30 14:49:59 -0800 http://trac.webkit.org/changeset/136277 177024 2012-11-30 14:16:18 -0800 2012-11-30 14:26:12 -0800 Patch bug-103773-20121130141351.patch text/plain 11931 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MjA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTE3NDZiOGMxMDNhOGJi OGM4ODg2MmE0NWI1MjllOTJiNjg4YzNmYy4uMDE0MWRlYzE4MDhiMDAyNmQxMDlhMjhkNjg1ZTg5 OWQ2NTMzNTM0NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQ0IEBACisyMDEyLTExLTMwICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIExhdGUtbG9hZGlu ZyBzdHlsZXNoZWV0cyBjYW4gY2F1c2UgY29tcG9zaXRlZCBsYXllcnMgdG8gYmUgYmxhbmsKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzc3MworCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVhcmx5IHBhaW50 aW5nIGNhbiBiZSBzaG9ydC1jaXJjdWl0ZWQgaW4gUmVuZGVyQmxvY2s6OnBhaW50Q29udGVudHMo KSBpZiB3ZSBrbm93IGEgc3R5bGVzaGVldAorICAgICAgICBpcyBwZW5kaW5nLCB3aGljaCBpcyBk b25lIHRvIGF2b2lkIGEgRk9VQy4gV2hlbiB0aGUgc3R5bGVzaGVldCBmaW5hbGx5IGxvYWRlZCwK KyAgICAgICAgRG9jdW1lbnQ6OnN0eWxlUmVzb2x2ZXJDaGFuZ2VkKCkgd291bGQgdHJ5IHRvIHJl cGFpbnQgZXZlcnl0aGluZyBieSBjYWxsaW5nIHJlcGFpbnQoKQorICAgICAgICBvbiB0aGUgUmVu ZGVyVmlldygpLiBJbiBhIGNvbXBvc2l0ZWQgd29ybGQsIGhvd2V2ZXIsIHRoaXMgcmVwYWludCgp IGRvZXNuJ3QgcmVwYWludAorICAgICAgICBjb21wb3NpdGVkIGxheWVycy4KKyAgICAgICAgCisg ICAgICAgIFRoaXMgd2FzIHBhcnRpY3VsYXJseSBwcmV2YWxlbnQgb24gdGhpcyBzcGVjaWZpYyBV UkwgYmVjYXVzZSBpdCBmYWlsZWQgdG8gbG9hZAorICAgICAgICBhIENTUyBmaWxlIGZyb20gdHlw ZWtpdC5jb20sIHNvIERvY3VtZW50OjpzdHlsZVJlc29sdmVyQ2hhbmdlZCgpCisgICAgICAgIGp1 c3QgZGlkIHRoZSByZXBhaW50IGFuZCByZXR1cm5lZCAocmF0aGVyIHRoYW4gZG9pbmcgYSByZWNh bGMgc3R5bGUgYXMgd291bGQKKyAgICAgICAgaGFwcGVuIGZvciBjb3JyZWN0bHkgbG9hZGVkIHN0 eWxlc2hlZXRzKS4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSBtYWtpbmcgYSB3YXkgdG8gcmVw YWludCBhbGwgY29tcG9zaXRpbmcgbGF5ZXJzLCBhbmQgY2FsbGluZyBpdAorICAgICAgICBmcm9t IERvY3VtZW50OjpzdHlsZVJlc29sdmVyQ2hhbmdlZCgpLgorCisgICAgICAgIE5vIHRlc3RzIGJl Y2F1c2UgdGhpcyBpcyB0aW1pbmctZGVwZW5kYW50LgorCisgICAgICAgICogZG9tL0RvY3VtZW50 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50OjpzdHlsZVJlc29sdmVyQ2hhbmdlZCk6 IENhbGwgcmVwYWludFZpZXdBbmRDb21wb3NpdGVkTGF5ZXJzKCkuCisgICAgICAgICogcmVuZGVy aW5nL1JlbmRlckJsb2NrLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJsb2NrOjpwYWlu dENvbnRlbnRzKTogRml4IHRoZSBjb21tZW50LgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJM YXllckNvbXBvc2l0b3IuY3BwOiBDb252ZXJ0IHJlcGFpbnRDb21wb3NpdGVkTGF5ZXJzQWJzb2x1 dGVSZWN0KCkKKyAgICAgICAgYW5kIGFzc29jaWF0ZWQgcmVjdXJzaXZlUmVwYWludExheWVyUmVj dCgpIHRvIGFsbG93IHRoZSByZWN0IHRvIGJlIG51bGwsIHdoaWNoIGluZGljYXRlcworICAgICAg ICB0aGF0IHdlIHNob3VsZCBqdXN0IHJlcGFpbnQgdGhlIGVudGlyZSBsYXllciwgYW5kIGltcHJv dmUgdGhlaXIgbmFtZXMuCisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckNvbXBvc2l0b3I6 OnJlcGFpbnRDb21wb3NpdGVkTGF5ZXJzKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVy Q29tcG9zaXRvcjo6cmVjdXJzaXZlUmVwYWludExheWVyKToKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyTGF5ZXJDb21wb3NpdG9yLmg6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclZpZXcu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVmlldzo6cmVwYWludFJlY3RhbmdsZUluVmll d0FuZENvbXBvc2l0ZWRMYXllcnMpOiByZXBhaW50Q29tcG9zaXRlZExheWVyc0Fic29sdXRlUmVj dCgpCisgICAgICAgIHdhcyByZW5hbWVkIHRvIHJlcGFpbnRDb21wb3NpdGVkTGF5ZXJzKCkuCisg ICAgICAgIChXZWJDb3JlOjpSZW5kZXJWaWV3OjpyZXBhaW50Vmlld0FuZENvbXBvc2l0ZWRMYXll cnMpOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJWaWV3Lmg6CisgICAgICAgIChSZW5kZXJW aWV3KTogcmVwYWludFZpZXdSZWN0YW5nbGUoKSBhbmQgcmVwYWludFJlY3RhbmdsZUluVmlld0Fu ZENvbXBvc2l0ZWRMYXllcnMoKSBzaG91bGQgbm90CisgICAgICAgIGJlIHZpcnR1YWwuIEFkZCBy ZXBhaW50Vmlld0FuZENvbXBvc2l0ZWRMYXllcnMoKS4KKwogMjAxMi0xMS0yOSAgTWFydGluIFJv Ymluc29uICA8bXJvYmluc29uQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gW1dlYktpdDJd IFdlYktpdFdlYlZpZXdCYXNlIGNyZWF0ZXMgYSBHTCBjb250ZXh0IGZvciB0aGUgcmVkaXJlY3Rl ZCBYQ29tcG9zaXRlIHdpbmRvdyBjcmFzaGluZyBXZWJLaXQgaW4gWHZmYgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1 bWVudC5jcHAKaW5kZXggZGI3NGQ1NWRlNWMxMGYwNmQ1NTIxNjEzMzBhY2Y2NzI1N2UyMTliMi4u YmM1Yjc0YjY1ZjQ2ZWM4NzA1MDQ3N2NiMWM5NDIyZWI1NjBmMzg0OCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCkBAIC0zMTc5LDcgKzMxNzksNyBAQCB2b2lkIERvY3VtZW50OjpzdHlsZVJlc29s dmVyQ2hhbmdlZChTdHlsZVJlc29sdmVyVXBkYXRlRmxhZyB1cGRhdGVGbGFnKQogICAgIGlmIChk aWRMYXlvdXRXaXRoUGVuZGluZ1N0eWxlc2hlZXRzKCkgJiYgIW1fc3R5bGVTaGVldENvbGxlY3Rp b24tPmhhc1BlbmRpbmdTaGVldHMoKSkgewogICAgICAgICBtX3BlbmRpbmdTaGVldExheW91dCA9 IElnbm9yZUxheW91dFdpdGhQZW5kaW5nU2hlZXRzOwogICAgICAgICBpZiAocmVuZGVyZXIoKSkK LSAgICAgICAgICAgIHJlbmRlcmVyKCktPnJlcGFpbnQoKTsKKyAgICAgICAgICAgIHJlbmRlclZp ZXcoKS0+cmVwYWludFZpZXdBbmRDb21wb3NpdGVkTGF5ZXJzKCk7CiAgICAgfQogCiAgICAgaWYg KCFzdHlsZXNoZWV0Q2hhbmdlUmVxdWlyZXNTdHlsZVJlY2FsYykKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQmxvY2suY3BwCmluZGV4IDhjNjI0OTc2NTllZGY5NWNiY2IzMTE5YTVjOWZj ZTcxYjBkMzA1M2EuLmU3OWNkNmI5ZTk5YWZlMDRiODIzNTE5YzU4MzEzMTNhYjAwMjgwNmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcApAQCAtMjkyOCw4ICsyOTI4 LDggQEAgdm9pZCBSZW5kZXJCbG9jazo6cGFpbnRDb2x1bW5Db250ZW50cyhQYWludEluZm8mIHBh aW50SW5mbywgY29uc3QgTGF5b3V0UG9pbnQmIHAKIHZvaWQgUmVuZGVyQmxvY2s6OnBhaW50Q29u dGVudHMoUGFpbnRJbmZvJiBwYWludEluZm8sIGNvbnN0IExheW91dFBvaW50JiBwYWludE9mZnNl dCkKIHsKICAgICAvLyBBdm9pZCBwYWludGluZyBkZXNjZW5kYW50cyBvZiB0aGUgcm9vdCBlbGVt ZW50IHdoZW4gc3R5bGVzaGVldHMgaGF2ZW4ndCBsb2FkZWQuICBUaGlzIGVsaW1pbmF0ZXMgRk9V Qy4KLSAgICAvLyBJdCdzIG9rIG5vdCB0byBkcmF3LCBiZWNhdXNlIGxhdGVyIG9uLCB3aGVuIGFs bCB0aGUgc3R5bGVzaGVldHMgZG8gbG9hZCwgdXBkYXRlU3R5bGVTZWxlY3RvciBvbiB0aGUgRG9j dW1lbnQKLSAgICAvLyB3aWxsIGRvIGEgZnVsbCByZXBhaW50KCkuCisgICAgLy8gSXQncyBvayBu b3QgdG8gZHJhdywgYmVjYXVzZSBsYXRlciBvbiwgd2hlbiBhbGwgdGhlIHN0eWxlc2hlZXRzIGRv IGxvYWQsIHN0eWxlUmVzb2x2ZXJDaGFuZ2VkKCkgb24gdGhlIERvY3VtZW50CisgICAgLy8gd2ls bCBkbyBhIGZ1bGwgcmVwYWludC4KICAgICBpZiAoZG9jdW1lbnQoKS0+ZGlkTGF5b3V0V2l0aFBl bmRpbmdTdHlsZXNoZWV0cygpICYmICFpc1JlbmRlclZpZXcoKSkKICAgICAgICAgcmV0dXJuOwog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3Np dG9yLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3Iu Y3BwCmluZGV4IDg3MGJmMWRkZmE3Mzk1OWMwZWUwYTJjYzE4ZTllZmE4ODU5Y2YyMWMuLjNkZGZl NDUzODEyNGRhMGMzNThjZDFlYTJlYmE3NDE2Zjc1MGNmYWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuY3BwCkBAIC0xMzQwLDE2ICsx MzQwLDIwIEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjp1cGRhdGVDb21wb3NpdGluZ0Rl c2NlbmRhbnRHZW9tZXRyeShSZW5kZXJMYXllciogY29tCiB9CiAKIAotdm9pZCBSZW5kZXJMYXll ckNvbXBvc2l0b3I6OnJlcGFpbnRDb21wb3NpdGVkTGF5ZXJzQWJzb2x1dGVSZWN0KGNvbnN0IElu dFJlY3QmIGFic1JlY3QpCit2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cmVwYWludENvbXBv c2l0ZWRMYXllcnMoY29uc3QgSW50UmVjdCogYWJzUmVjdCkKIHsKLSAgICByZWN1cnNpdmVSZXBh aW50TGF5ZXJSZWN0KHJvb3RSZW5kZXJMYXllcigpLCBhYnNSZWN0KTsKKyAgICByZWN1cnNpdmVS ZXBhaW50TGF5ZXIocm9vdFJlbmRlckxheWVyKCksIGFic1JlY3QpOwogfQogCi12b2lkIFJlbmRl ckxheWVyQ29tcG9zaXRvcjo6cmVjdXJzaXZlUmVwYWludExheWVyUmVjdChSZW5kZXJMYXllciog bGF5ZXIsIGNvbnN0IEludFJlY3QmIHJlY3QpCit2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6 cmVjdXJzaXZlUmVwYWludExheWVyKFJlbmRlckxheWVyKiBsYXllciwgY29uc3QgSW50UmVjdCog cmVjdCkKIHsKICAgICAvLyBGSVhNRTogVGhpcyBtZXRob2QgZG9lcyBub3Qgd29yayBjb3JyZWN0 bHkgd2l0aCB0cmFuc2Zvcm1zLgotICAgIGlmIChsYXllci0+aXNDb21wb3NpdGVkKCkgJiYgIWxh eWVyLT5iYWNraW5nKCktPnBhaW50c0ludG9Db21wb3NpdGVkQW5jZXN0b3IoKSkKLSAgICAgICAg bGF5ZXItPnNldEJhY2tpbmdOZWVkc1JlcGFpbnRJblJlY3QocmVjdCk7CisgICAgaWYgKGxheWVy LT5pc0NvbXBvc2l0ZWQoKSAmJiAhbGF5ZXItPmJhY2tpbmcoKS0+cGFpbnRzSW50b0NvbXBvc2l0 ZWRBbmNlc3RvcigpKSB7CisgICAgICAgIGlmIChyZWN0KQorICAgICAgICAgICAgbGF5ZXItPnNl dEJhY2tpbmdOZWVkc1JlcGFpbnRJblJlY3QoKnJlY3QpOworICAgICAgICBlbHNlCisgICAgICAg ICAgICBsYXllci0+c2V0QmFja2luZ05lZWRzUmVwYWludCgpOworICAgIH0KIAogI2lmICFBU1NF UlRfRElTQUJMRUQKICAgICBMYXllckxpc3RNdXRhdGlvbkRldGVjdG9yIG11dGF0aW9uQ2hlY2tl cihsYXllcik7CkBAIC0xMzYwLDkgKzEzNjQsMTIgQEAgdm9pZCBSZW5kZXJMYXllckNvbXBvc2l0 b3I6OnJlY3Vyc2l2ZVJlcGFpbnRMYXllclJlY3QoUmVuZGVyTGF5ZXIqIGxheWVyLCBjb25zdAog ICAgICAgICAgICAgc2l6ZV90IGxpc3RTaXplID0gbmVnWk9yZGVyTGlzdC0+c2l6ZSgpOwogICAg ICAgICAgICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBsaXN0U2l6ZTsgKytpKSB7CiAgICAgICAg ICAgICAgICAgUmVuZGVyTGF5ZXIqIGN1ckxheWVyID0gbmVnWk9yZGVyTGlzdC0+YXQoaSk7Ci0g ICAgICAgICAgICAgICAgSW50UmVjdCBjaGlsZFJlY3QocmVjdCk7Ci0gICAgICAgICAgICAgICAg Y3VyTGF5ZXItPmNvbnZlcnRUb1BpeGVsU25hcHBlZExheWVyQ29vcmRzKGxheWVyLCBjaGlsZFJl Y3QpOwotICAgICAgICAgICAgICAgIHJlY3Vyc2l2ZVJlcGFpbnRMYXllclJlY3QoY3VyTGF5ZXIs IGNoaWxkUmVjdCk7CisgICAgICAgICAgICAgICAgaWYgKHJlY3QpIHsKKyAgICAgICAgICAgICAg ICAgICAgSW50UmVjdCBjaGlsZFJlY3QoKnJlY3QpOworICAgICAgICAgICAgICAgICAgICBjdXJM YXllci0+Y29udmVydFRvUGl4ZWxTbmFwcGVkTGF5ZXJDb29yZHMobGF5ZXIsIGNoaWxkUmVjdCk7 CisgICAgICAgICAgICAgICAgICAgIHJlY3Vyc2l2ZVJlcGFpbnRMYXllcihjdXJMYXllciwgJmNo aWxkUmVjdCk7CisgICAgICAgICAgICAgICAgfSBlbHNlCisgICAgICAgICAgICAgICAgICAgIHJl Y3Vyc2l2ZVJlcGFpbnRMYXllcihjdXJMYXllcik7CiAgICAgICAgICAgICB9CiAgICAgICAgIH0K IApAQCAtMTM3MCw5ICsxMzc3LDEyIEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZWN1 cnNpdmVSZXBhaW50TGF5ZXJSZWN0KFJlbmRlckxheWVyKiBsYXllciwgY29uc3QKICAgICAgICAg ICAgIHNpemVfdCBsaXN0U2l6ZSA9IHBvc1pPcmRlckxpc3QtPnNpemUoKTsKICAgICAgICAgICAg IGZvciAoc2l6ZV90IGkgPSAwOyBpIDwgbGlzdFNpemU7ICsraSkgewogICAgICAgICAgICAgICAg IFJlbmRlckxheWVyKiBjdXJMYXllciA9IHBvc1pPcmRlckxpc3QtPmF0KGkpOwotICAgICAgICAg ICAgICAgIEludFJlY3QgY2hpbGRSZWN0KHJlY3QpOwotICAgICAgICAgICAgICAgIGN1ckxheWVy LT5jb252ZXJ0VG9QaXhlbFNuYXBwZWRMYXllckNvb3JkcyhsYXllciwgY2hpbGRSZWN0KTsKLSAg ICAgICAgICAgICAgICByZWN1cnNpdmVSZXBhaW50TGF5ZXJSZWN0KGN1ckxheWVyLCBjaGlsZFJl Y3QpOworICAgICAgICAgICAgICAgIGlmIChyZWN0KSB7CisgICAgICAgICAgICAgICAgICAgIElu dFJlY3QgY2hpbGRSZWN0KCpyZWN0KTsKKyAgICAgICAgICAgICAgICAgICAgY3VyTGF5ZXItPmNv bnZlcnRUb1BpeGVsU25hcHBlZExheWVyQ29vcmRzKGxheWVyLCBjaGlsZFJlY3QpOworICAgICAg ICAgICAgICAgICAgICByZWN1cnNpdmVSZXBhaW50TGF5ZXIoY3VyTGF5ZXIsICZjaGlsZFJlY3Qp OworICAgICAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgICAgICByZWN1cnNpdmVS ZXBhaW50TGF5ZXIoY3VyTGF5ZXIpOwogICAgICAgICAgICAgfQogICAgICAgICB9CiAgICAgfQpA QCAtMTM4MCw5ICsxMzkwLDEyIEBAIHZvaWQgUmVuZGVyTGF5ZXJDb21wb3NpdG9yOjpyZWN1cnNp dmVSZXBhaW50TGF5ZXJSZWN0KFJlbmRlckxheWVyKiBsYXllciwgY29uc3QKICAgICAgICAgc2l6 ZV90IGxpc3RTaXplID0gbm9ybWFsRmxvd0xpc3QtPnNpemUoKTsKICAgICAgICAgZm9yIChzaXpl X3QgaSA9IDA7IGkgPCBsaXN0U2l6ZTsgKytpKSB7CiAgICAgICAgICAgICBSZW5kZXJMYXllciog Y3VyTGF5ZXIgPSBub3JtYWxGbG93TGlzdC0+YXQoaSk7Ci0gICAgICAgICAgICBJbnRSZWN0IGNo aWxkUmVjdChyZWN0KTsKLSAgICAgICAgICAgIGN1ckxheWVyLT5jb252ZXJ0VG9QaXhlbFNuYXBw ZWRMYXllckNvb3JkcyhsYXllciwgY2hpbGRSZWN0KTsKLSAgICAgICAgICAgIHJlY3Vyc2l2ZVJl cGFpbnRMYXllclJlY3QoY3VyTGF5ZXIsIGNoaWxkUmVjdCk7CisgICAgICAgICAgICBpZiAocmVj dCkgeworICAgICAgICAgICAgICAgIEludFJlY3QgY2hpbGRSZWN0KCpyZWN0KTsKKyAgICAgICAg ICAgICAgICBjdXJMYXllci0+Y29udmVydFRvUGl4ZWxTbmFwcGVkTGF5ZXJDb29yZHMobGF5ZXIs IGNoaWxkUmVjdCk7CisgICAgICAgICAgICAgICAgcmVjdXJzaXZlUmVwYWludExheWVyKGN1ckxh eWVyLCAmY2hpbGRSZWN0KTsKKyAgICAgICAgICAgIH0gZWxzZQorICAgICAgICAgICAgICAgIHJl Y3Vyc2l2ZVJlcGFpbnRMYXllcihjdXJMYXllcik7CiAgICAgICAgIH0KICAgICB9CiB9CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgg Yi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmgKaW5kZXgg NGQ4MjhmMWE1ZjFmMTAwYmYyNDBiYzMxNGIwMzczYWRhYmJiNTZmNy4uNTE5MzQxMWEyZDcxMGU3 OWUyMzhmNTEwYmY3NGFlMGU2YTFmZGNhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckNvbXBvc2l0b3IuaApAQCAtMTQ0LDggKzE0NCw4IEBAIHB1YmxpYzoK ICAgICAvLyBHZXQgdGhlIG5lYXJlc3QgYW5jZXN0b3IgbGF5ZXIgdGhhdCBoYXMgb3ZlcmZsb3cg b3IgY2xpcCwgYnV0IGlzIG5vdCBhIHN0YWNraW5nIGNvbnRleHQKICAgICBSZW5kZXJMYXllciog ZW5jbG9zaW5nTm9uU3RhY2tpbmdDbGlwcGluZ0xheWVyKGNvbnN0IFJlbmRlckxheWVyKiBsYXll cikgY29uc3Q7CiAKLSAgICAvLyBSZXBhaW50IHBhcnRzIG9mIGFsbCBjb21wb3NpdGVkIGxheWVy cyB0aGF0IGludGVyc2VjdCB0aGUgZ2l2ZW4gYWJzb2x1dGUgcmVjdGFuZ2xlLgotICAgIHZvaWQg cmVwYWludENvbXBvc2l0ZWRMYXllcnNBYnNvbHV0ZVJlY3QoY29uc3QgSW50UmVjdCYpOworICAg IC8vIFJlcGFpbnQgcGFydHMgb2YgYWxsIGNvbXBvc2l0ZWQgbGF5ZXJzIHRoYXQgaW50ZXJzZWN0 IHRoZSBnaXZlbiBhYnNvbHV0ZSByZWN0YW5nbGUgKG9yIHRoZSBlbnRpcmUgbGF5ZXIgaWYgdGhl IHBvaW50ZXIgaXMgbnVsbCkuCisgICAgdm9pZCByZXBhaW50Q29tcG9zaXRlZExheWVycyhjb25z dCBJbnRSZWN0KiA9IDApOwogCiAgICAgLy8gUmV0dXJucyB0cnVlIGlmIHRoZSBnaXZlbiBsYXll ciBuZWVkcyBpdCBvd24gYmFja2luZyBzdG9yZS4KICAgICBib29sIHJlcXVpcmVzT3duQmFja2lu Z1N0b3JlKGNvbnN0IFJlbmRlckxheWVyKiwgY29uc3QgUmVuZGVyTGF5ZXIqIGNvbXBvc2l0aW5n QW5jZXN0b3JMYXllcikgY29uc3Q7CkBAIC0yNTcsNyArMjU3LDcgQEAgcHJpdmF0ZToKICAgICB2 b2lkIGNsZWFyQmFja2luZ0ZvckxheWVySW5jbHVkaW5nRGVzY2VuZGFudHMoUmVuZGVyTGF5ZXIq KTsKIAogICAgIC8vIFJlcGFpbnQgdGhlIGdpdmVuIHJlY3QgKHdoaWNoIGlzIGxheWVyJ3MgY29v cmRzKSwgYW5kIHJlZ2lvbnMgb2YgY2hpbGQgbGF5ZXJzIHRoYXQgaW50ZXJzZWN0IHRoYXQgcmVj dC4KLSAgICB2b2lkIHJlY3Vyc2l2ZVJlcGFpbnRMYXllclJlY3QoUmVuZGVyTGF5ZXIqLCBjb25z dCBJbnRSZWN0Jik7CisgICAgdm9pZCByZWN1cnNpdmVSZXBhaW50TGF5ZXIoUmVuZGVyTGF5ZXIq LCBjb25zdCBJbnRSZWN0KiA9IDApOwogCiAgICAgdm9pZCBhZGRUb092ZXJsYXBNYXAoT3Zlcmxh cE1hcCYsIFJlbmRlckxheWVyKiwgSW50UmVjdCYgbGF5ZXJCb3VuZHMsIGJvb2wmIGJvdW5kc0Nv bXB1dGVkKTsKICAgICB2b2lkIGFkZFRvT3ZlcmxhcE1hcFJlY3Vyc2l2ZShPdmVybGFwTWFwJiwg UmVuZGVyTGF5ZXIqLCBSZW5kZXJMYXllciogYW5jZXN0b3JMYXllciA9IDApOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwIGIvU291cmNlL1dlYkNv cmUvcmVuZGVyaW5nL1JlbmRlclZpZXcuY3BwCmluZGV4IDE0NTdiNmJlMmE0N2Y5ZmI2M2JkYWQy NjFmMDIwNWE4ZjEwMzEzYTYuLmJkYjljODA2OTQ1Y2I3OTk2YjcxODllMmE0MGNkZDkwNzQ4NmNk ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJWaWV3LmNwcAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5jcHAKQEAgLTQzNSw4ICs0 MzUsMjAgQEAgdm9pZCBSZW5kZXJWaWV3OjpyZXBhaW50UmVjdGFuZ2xlSW5WaWV3QW5kQ29tcG9z aXRlZExheWVycyhjb25zdCBMYXlvdXRSZWN0JiB1ciwKICAgICByZXBhaW50Vmlld1JlY3Rhbmds ZSh1ciwgaW1tZWRpYXRlKTsKICAgICAKICNpZiBVU0UoQUNDRUxFUkFURURfQ09NUE9TSVRJTkcp CisgICAgaWYgKGNvbXBvc2l0b3IoKS0+aW5Db21wb3NpdGluZ01vZGUoKSkgeworICAgICAgICBJ bnRSZWN0IHJlcGFpbnRSZWN0ID0gcGl4ZWxTbmFwcGVkSW50UmVjdCh1cik7CisgICAgICAgIGNv bXBvc2l0b3IoKS0+cmVwYWludENvbXBvc2l0ZWRMYXllcnMoJnJlcGFpbnRSZWN0KTsKKyAgICB9 CisjZW5kaWYKK30KKwordm9pZCBSZW5kZXJWaWV3OjpyZXBhaW50Vmlld0FuZENvbXBvc2l0ZWRM YXllcnMoKQoreworICAgIHJlcGFpbnQoKTsKKyAgICAKKyNpZiBVU0UoQUNDRUxFUkFURURfQ09N UE9TSVRJTkcpCiAgICAgaWYgKGNvbXBvc2l0b3IoKS0+aW5Db21wb3NpdGluZ01vZGUoKSkKLSAg ICAgICAgY29tcG9zaXRvcigpLT5yZXBhaW50Q29tcG9zaXRlZExheWVyc0Fic29sdXRlUmVjdChw aXhlbFNuYXBwZWRJbnRSZWN0KHVyKSk7CisgICAgICAgIGNvbXBvc2l0b3IoKS0+cmVwYWludENv bXBvc2l0ZWRMYXllcnMoKTsKICNlbmRpZgogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clZpZXcuaAppbmRleCBkNjNmOGRmODY4NjEzNzE1OGI5YWI5ODRlYTFlYzM1NDI0NzZlOTdlLi45 OWFiMWMxYTNiYmUwNjY1YWY2MTJjNjQwOTBkMWNhOWE0OGM3OTgyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVmlldy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJWaWV3LmgKQEAgLTc4LDEwICs3OCwxMSBAQCBwdWJsaWM6CiAgICAgRnJh bWVWaWV3KiBmcmFtZVZpZXcoKSBjb25zdCB7IHJldHVybiBtX2ZyYW1lVmlldzsgfQogCiAgICAg dmlydHVhbCB2b2lkIGNvbXB1dGVSZWN0Rm9yUmVwYWludChjb25zdCBSZW5kZXJMYXllck1vZGVs T2JqZWN0KiByZXBhaW50Q29udGFpbmVyLCBMYXlvdXRSZWN0JiwgYm9vbCBmaXhlZCA9IGZhbHNl KSBjb25zdCBPVkVSUklERTsKLSAgICB2aXJ0dWFsIHZvaWQgcmVwYWludFZpZXdSZWN0YW5nbGUo Y29uc3QgTGF5b3V0UmVjdCYsIGJvb2wgaW1tZWRpYXRlID0gZmFsc2UpIGNvbnN0OworICAgIHZv aWQgcmVwYWludFZpZXdSZWN0YW5nbGUoY29uc3QgTGF5b3V0UmVjdCYsIGJvb2wgaW1tZWRpYXRl ID0gZmFsc2UpIGNvbnN0OwogICAgIC8vIFJlcGFpbnQgdGhlIHZpZXcsIGFuZCBhbGwgY29tcG9z aXRlZCBsYXllcnMgdGhhdCBpbnRlcnNlY3QgdGhlIGdpdmVuIGFic29sdXRlIHJlY3RhbmdsZS4K ICAgICAvLyBGSVhNRTogaWRlYWxseSB3ZSdkIG5ldmVyIGhhdmUgdG8gZG8gdGhpcywgaWYgYWxs IHJlcGFpbnRzIGFyZSBjb250YWluZXItcmVsYXRpdmUuCi0gICAgdmlydHVhbCB2b2lkIHJlcGFp bnRSZWN0YW5nbGVJblZpZXdBbmRDb21wb3NpdGVkTGF5ZXJzKGNvbnN0IExheW91dFJlY3QmLCBi b29sIGltbWVkaWF0ZSA9IGZhbHNlKTsKKyAgICB2b2lkIHJlcGFpbnRSZWN0YW5nbGVJblZpZXdB bmRDb21wb3NpdGVkTGF5ZXJzKGNvbnN0IExheW91dFJlY3QmLCBib29sIGltbWVkaWF0ZSA9IGZh bHNlKTsKKyAgICB2b2lkIHJlcGFpbnRWaWV3QW5kQ29tcG9zaXRlZExheWVycygpOwogCiAgICAg dmlydHVhbCB2b2lkIHBhaW50KFBhaW50SW5mbyYsIGNvbnN0IExheW91dFBvaW50Jik7CiAgICAg dmlydHVhbCB2b2lkIHBhaW50Qm94RGVjb3JhdGlvbnMoUGFpbnRJbmZvJiwgY29uc3QgTGF5b3V0 UG9pbnQmKSBPVkVSUklERTsK