103749 2012-11-30 07:54:12 -0800 ENABLE(IMAGE_DECODER_DOWN_SAMPLING): Should use TURBO_JPEG_RGB_SWIZZLE fast path for non-scaled images 2012-12-03 07:48:57 -0800 1 1 1 Unclassified WebKit Images 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 98878 1 yong.li.webkit webkit-unassigned bfulgham kbr laszlo.gombos noel.gordon tonikitoo webkit.review.bot oldest_to_newest 780119 0 yong.li.webkit 2012-11-30 07:54:12 -0800 There is currently following line #if !ENABLE(IMAGE_DECODER_DOWN_SAMPLING) && defined(TURBO_JPEG_RGB_SWIZZLE) in JPEGImaggeDecoder.cpp. The reason of this !ENABLE(IMAGE_DECODER_DOWN_SAMPLING) check is we cannot do swizzling when the buffer wants a down-sampled image. However this doesn't work. As there is no such check when it sets the colorspace. If you enable both IMAGE_DECODER_DOWN_SAMPLING and TURBO_JPEG_RGB_SWIZZLE, it will crash for sure. ENABLE(IMAGE_DECODER_DOWN_SAMPLING) is probably not widely used, and could be improved. However, I found it super easy to make TURBO_JPEG_RGB_SWIZZLE work with it, so why not? 780207 1 yong.li.webkit 2012-11-30 10:30:25 -0800 seems the crash has been fixed. 780223 2 176995 yong.li.webkit 2012-11-30 10:45:47 -0800 Created attachment 176995 the patch 780296 3 yong.li.webkit 2012-11-30 12:18:57 -0800 +Recent JPEGImageDecoder reviewers and Antonio 780300 4 yong.li.webkit 2012-11-30 12:20:19 -0800 This is safe since http://trac.webkit.org/changeset/131075. (See bug 98878) 780375 5 kbr 2012-11-30 13:37:21 -0800 Noel: could you unofficially review this? 780673 6 noel.gordon 2012-11-30 23:15:48 -0800 Thank you Yong Li. Looks good to me. 780674 7 noel.gordon 2012-11-30 23:18:36 -0800 (In reply to comment #1) > seems the crash has been fixed. Yes. Fixed on bug 98878. 781443 8 176995 rwlbuis 2012-12-03 07:43:34 -0800 Comment on attachment 176995 the patch LGTM. 781450 9 176995 webkit.review.bot 2012-12-03 07:48:54 -0800 Comment on attachment 176995 the patch Clearing flags on attachment: 176995 Committed r136401: <http://trac.webkit.org/changeset/136401> 781451 10 webkit.review.bot 2012-12-03 07:48:57 -0800 All reviewed patches have been landed. Closing bug. 176995 2012-11-30 10:45:47 -0800 2012-12-03 07:48:53 -0800 the patch 103749.patch text/plain 1776 yong.li.webkit ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZTQ5Mzc2Li4xNTU5ZTI2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMTEtMzAgIFlvbmcgTGkgIDx5b2xpQHJpbS5jb20+CisKKyAgICAgICAgRU5BQkxF KElNQUdFX0RFQ09ERVJfRE9XTl9TQU1QTElORyk6IFNob3VsZCB1c2UgVFVSQk9fSlBFR19SR0Jf U1dJWlpMRSBmYXN0IHBhdGggZm9yIG5vbi1zY2FsZWQgaW1hZ2VzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM3NDkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlICFFTkFCTEUoSU1BR0VfREVD T0RFUl9ET1dOX1NBTVBMSU5HKSB3aXRoICFtX3NjYWxlZC4KKworICAgICAgICBObyBuZXcgdGVz dHMgYXMgZXhpc3RpbmcganBlZ3MgYXJlIGdvb2Qgd2l0aCBJTUFHRV9ERUNPREVSX0RPV05fU0FN UExJTkcgc2V0IHVwLgorCisgICAgICAgICogcGxhdGZvcm0vaW1hZ2UtZGVjb2RlcnMvanBlZy9K UEVHSW1hZ2VEZWNvZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkpQRUdJbWFnZURlY29kZXI6 Om91dHB1dFNjYW5saW5lcyk6CisKIDIwMTItMTEtMjkgIFRvbW15IFdpZGVuZmx5Y2h0ICA8dG9t bXl3QGdvb2dsZS5jb20+CiAKICAgICAgICAgU3BlZWNoIFJlY29nbml0aW9uIEFQSTogVXBkYXRl IFNwZWVjaFJlY29nbml0aW9uRXZlbnQvUmVzdWx0IHRvIG1hdGNoIHRoZSBzcGVjaWZpY2F0aW9u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVn L0pQRUdJbWFnZURlY29kZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW1hZ2UtZGVj b2RlcnMvanBlZy9KUEVHSW1hZ2VEZWNvZGVyLmNwcAppbmRleCBlMTUyYTJlLi5hZDQ4MWMxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pbWFnZS1kZWNvZGVycy9qcGVnL0pQ RUdJbWFnZURlY29kZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2ltYWdlLWRl Y29kZXJzL2pwZWcvSlBFR0ltYWdlRGVjb2Rlci5jcHAKQEAgLTc0MCw5ICs3NDAsOCBAQCBib29s IEpQRUdJbWFnZURlY29kZXI6Om91dHB1dFNjYW5saW5lcygpCiAKICAgICBqcGVnX2RlY29tcHJl c3Nfc3RydWN0KiBpbmZvID0gbV9yZWFkZXItPmluZm8oKTsKIAotI2lmICFFTkFCTEUoSU1BR0Vf REVDT0RFUl9ET1dOX1NBTVBMSU5HKSAmJiBkZWZpbmVkKFRVUkJPX0pQRUdfUkdCX1NXSVpaTEUp Ci0gICAgaWYgKHR1cmJvU3dpenpsZWQoaW5mby0+b3V0X2NvbG9yX3NwYWNlKSkgewotICAgICAg ICBBU1NFUlQoIW1fc2NhbGVkKTsKKyNpZiBkZWZpbmVkKFRVUkJPX0pQRUdfUkdCX1NXSVpaTEUp CisgICAgaWYgKCFtX3NjYWxlZCAmJiB0dXJib1N3aXp6bGVkKGluZm8tPm91dF9jb2xvcl9zcGFj ZSkpIHsKICAgICAgICAgd2hpbGUgKGluZm8tPm91dHB1dF9zY2FubGluZSA8IGluZm8tPm91dHB1 dF9oZWlnaHQpIHsKICAgICAgICAgICAgIHVuc2lnbmVkIGNoYXIqIHJvdyA9IHJlaW50ZXJwcmV0 X2Nhc3Q8dW5zaWduZWQgY2hhcio+KGJ1ZmZlci5nZXRBZGRyKDAsIGluZm8tPm91dHB1dF9zY2Fu bGluZSkpOwogICAgICAgICAgICAgaWYgKGpwZWdfcmVhZF9zY2FubGluZXMoaW5mbywgJnJvdywg MSkgIT0gMSkK