103745 2012-11-30 07:26:59 -0800 [EFL][AC] MiniBrowser starts with a black empty view before painting a web page 2013-04-17 14:05:58 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103105 111543 1 joone joone benjamin commit-queue gyuyoung.kim kenneth lucas.de.marchi mikhail.pozdnyakov ostap73 rakuco webkit.review.bot oldest_to_newest 780101 0 joone 2012-11-30 07:26:59 -0800 Launch MiniBrowser, you will see the black view before loading google.com. 862030 1 194668 joone 2013-03-22 17:40:05 -0700 Created attachment 194668 Patch 862557 2 194668 mikhail.pozdnyakov 2013-03-25 01:43:12 -0700 Comment on attachment 194668 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194668&action=review > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:554 > + evas_object_show(sd->image); think this snippet could be a static function accepting 'sd' > Source/WebKit2/UIProcess/API/efl/EwkView.h:165 > + bool isAccelerated() { return m_isAccelerated; } We actually do not need this getter, m_isAccelerated is still accessed within the class only 863129 3 194668 joone 2013-03-25 16:01:28 -0700 Comment on attachment 194668 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=194668&action=review >> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:554 >> + evas_object_show(sd->image); > > think this snippet could be a static function accepting 'sd' Do you mean the above 3 lines of code could be a staic function? If so, it could be only used 2 times. >> Source/WebKit2/UIProcess/API/efl/EwkView.h:165 >> + bool isAccelerated() { return m_isAccelerated; } > > We actually do not need this getter, m_isAccelerated is still accessed within the class only Okay, I will fix this. 863418 4 mikhail.pozdnyakov 2013-03-26 00:25:10 -0700 (In reply to comment #3) > (From update of attachment 194668 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=194668&action=review > > >> Source/WebKit2/UIProcess/API/efl/EwkView.cpp:554 > >> + evas_object_show(sd->image); > > > > think this snippet could be a static function accepting 'sd' > > Do you mean the above 3 lines of code could be a staic function? If so, it could be only used 2 times. yeah, I mean those 3 lines. Think it will improve code-readability. 864604 5 195338 joone 2013-03-27 09:14:10 -0700 Created attachment 195338 Patch 864615 6 195338 kenneth 2013-03-27 09:26:24 -0700 Comment on attachment 195338 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195338&action=review > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:561 > + // Make Evas objects visible here in order not to paint empty Evas objects with black color. > + showEvasObjects(sd); Isn't it more a showEvasObjectsIfNeeded(), I suppose those methods does nothing if already visible... 864675 7 joone 2013-03-27 10:44:18 -0700 (In reply to comment #6) > (From update of attachment 195338 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=195338&action=review > > > Source/WebKit2/UIProcess/API/efl/EwkView.cpp:561 > > + // Make Evas objects visible here in order not to paint empty Evas objects with black color. > > + showEvasObjects(sd); > > Isn't it more a showEvasObjectsIfNeeded(), I suppose those methods does nothing if already visible... showEvasObjectsIfNeeded makes more sense. I will update the patch soon. 864757 8 195372 joone 2013-03-27 11:56:26 -0700 Created attachment 195372 Patch 864811 9 kenneth 2013-03-27 13:20:54 -0700 You need an owner to sign this one off 876886 10 195372 benjamin 2013-04-16 15:02:47 -0700 Comment on attachment 195372 Patch I sign off on this for WebKit2. 876936 11 195372 commit-queue 2013-04-16 16:02:01 -0700 Comment on attachment 195372 Patch Rejecting attachment 195372 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 195372, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ource/WebKit2/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKit2/UIProcess/API/efl/EwkView.cpp Hunk #1 succeeded at 130 (offset 2 lines). Hunk #2 FAILED at 559. Hunk #3 succeeded at 1133 (offset -14 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebKit2/UIProcess/API/efl/EwkView.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Kenneth Rohde Christiansen']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/32149 877455 12 198601 joone 2013-04-17 13:20:31 -0700 Created attachment 198601 Patch 877471 13 joone 2013-04-17 13:49:41 -0700 (In reply to comment #12) > Created an attachment (id=198601) [details] > Patch Patch rebased on master 877472 14 198601 commit-queue 2013-04-17 13:50:13 -0700 Comment on attachment 198601 Patch Clearing flags on attachment: 198601 Committed r148633: <http://trac.webkit.org/changeset/148633> 194668 2013-03-22 17:40:05 -0700 2013-03-27 09:13:59 -0700 Patch bug-103745-20130322173332.patch text/plain 2792 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2NjI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTE5NGJlZmM0MTQ4YTcy MTBmNzcxMjM3YmRjYzQ0ZGRlYjkwZWM2NS4uNjYwM2FhYzFkMTJiYTUxYmVmNjcwYjRkODEwOTcx M2U0NmRmYTJhZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDEzLTAzLTIyICBKb29u ZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0FDXSBNaW5pQnJv d3NlciBzdGFydHMgd2l0aCBhIGJsYWNrIGVtcHR5IHZpZXcgYmVmb3JlIHBhaW50aW5nIGEgd2Vi IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw Mzc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV2 YXMgcGFpbnRzIGVtcHR5IGV2YXMgb2JqZWN0cyBiZWZvcmUgcmVuZGVyaW5nIGEgd2ViIHBhZ2Us IHNvIGl0IHNob3dzIAorICAgICAgICBhIGJsYWNrIGVtcHR5IHZpZXcgZm9yIGEgbW9tZW50LiBU aGlzIHBhdGNoIHByZXZlbnRzIGZyb20gcGFpbnRpbmcgdGhlIGVtcHR5IAorICAgICAgICBldmFz IG9iamVjdHMgdW50aWwgYSBHTCBzdXJmYWNlIGlzIHJlYWR5IGZvciByZW5kZXJpbmcuICAKKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgorICAgICAgICAoRXdrVmll dzo6ZGlzcGxheVRpbWVyRmlyZWQpOgorICAgICAgICAoRXdrVmlldzo6aGFuZGxlRXZhc09iamVj dFNob3cpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuaDoKKyAgICAgICAg KEV3a1ZpZXc6OmlzQWNjZWxlcmF0ZWQpOgorCiAyMDEzLTAzLTIyICBUaW1vdGh5IEhhdGNoZXIg IDx0aW1vdGh5QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggYW4gYXNzZXJ0IHdoZW4gb3Blbmlu ZyB0aGUgV2ViIEluc3BlY3RvciB3aW5kb3cgZm9yIHRoZSBmaXJzdCB0aW1lLgpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAppbmRleCAwNjJhMzkyY2YyNzRl YWZkMDUxNjBkYjc1M2UyNmIyNzAwNmZjN2E4Li4zODZkZmM2OWI0M2RmZTA1YjcwNjdmYjFjMDM0 NTU1YWQxYTk0ZjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2Vm bC9Fd2tWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tW aWV3LmNwcApAQCAtNTQ4LDYgKzU0OCwxMSBAQCB2b2lkIEV3a1ZpZXc6OmRpc3BsYXlUaW1lckZp cmVkKFRpbWVyPEV3a1ZpZXc+KikKICAgICAgICAgaWYgKCFjcmVhdGVHTFN1cmZhY2UoKSkKICAg ICAgICAgICAgIHJldHVybjsKIAorICAgICAgICAvLyBNYWtlIGV2YXMgb2JqZWN0cyB2aXNpYmxl IGhlcmUgaW4gb3JkZXIgbm90IHRvIHBhaW50IGVtcHR5IGV2YXMgb2JqZWN0cyB3aXRoIGJsYWNr IGNvbG9yLgorICAgICAgICBpZiAoZXZhc19vYmplY3RfY2xpcGVlc19nZXQoc2QtPmJhc2UuY2xp cHBlcikpCisgICAgICAgICAgICBldmFzX29iamVjdF9zaG93KHNkLT5iYXNlLmNsaXBwZXIpOwor ICAgICAgICBldmFzX29iamVjdF9zaG93KHNkLT5pbWFnZSk7CisKICAgICAgICAgbV9wZW5kaW5n U3VyZmFjZVJlc2l6ZSA9IGZhbHNlOwogICAgIH0KIApAQCAtMTEzNSw2ICsxMTQwLDkgQEAgdm9p ZCBFd2tWaWV3OjpoYW5kbGVFdmFzT2JqZWN0U2hvdyhFdmFzX09iamVjdCogZXZhc09iamVjdCkK ICAgICBFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEgPSB0b1NtYXJ0RGF0YShldmFzT2Jq ZWN0KTsKICAgICBBU1NFUlQoc21hcnREYXRhKTsKIAorICAgIGlmICh0b0V3a1ZpZXcoc21hcnRE YXRhKS0+aXNBY2NlbGVyYXRlZCgpKQorICAgICAgICByZXR1cm47CisKICAgICBpZiAoZXZhc19v YmplY3RfY2xpcGVlc19nZXQoc21hcnREYXRhLT5iYXNlLmNsaXBwZXIpKQogICAgICAgICBldmFz X29iamVjdF9zaG93KHNtYXJ0RGF0YS0+YmFzZS5jbGlwcGVyKTsKICAgICBldmFzX29iamVjdF9z aG93KHNtYXJ0RGF0YS0+aW1hZ2UpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvRXdrVmlldy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv RXdrVmlldy5oCmluZGV4IDAxZWM1NDhiMWJlNTc0NmUwOWZlMzQ3YWE4ODM3ODBiN2I4MTk1ZWYu LmI4OWI0YjUzZGQ0ZmVhMzczYmJlZDFlZGFiN2IzNDUwYmExMDhhNjMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuaAorKysgYi9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmgKQEAgLTE2Miw2ICsxNjIsNyBAQCBwdWJs aWM6CiAKICAgICBib29sIGNyZWF0ZUdMU3VyZmFjZSgpOwogICAgIHZvaWQgc2V0TmVlZHNTdXJm YWNlUmVzaXplKCkgeyBtX3BlbmRpbmdTdXJmYWNlUmVzaXplID0gdHJ1ZTsgfQorICAgIGJvb2wg aXNBY2NlbGVyYXRlZCgpIHsgcmV0dXJuIG1faXNBY2NlbGVyYXRlZDsgfQogCiAjaWYgRU5BQkxF KElOUFVUX1RZUEVfQ09MT1IpCiAgICAgdm9pZCByZXF1ZXN0Q29sb3JQaWNrZXIoV0tDb2xvclBp Y2tlclJlc3VsdExpc3RlbmVyUmVmIGxpc3RlbmVyLCBjb25zdCBXZWJDb3JlOjpDb2xvciYpOwo= 195338 2013-03-27 09:14:10 -0700 2013-03-27 11:56:15 -0700 Patch bug-103745-20130327091146.patch text/plain 2585 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjZhZGNlMDk1Y2FkZTU3 NjJhZDIxZGE2OTJmY2QwZmQzZGY4YzdhMy4uYmI3YjY5NmZlZDIxNzI1Y2NmMzJkZGQ2ZjUyM2Fm YThlMDU0ZGQzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTI2ICBKb29u ZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0FDXSBNaW5pQnJv d3NlciBzdGFydHMgd2l0aCBhIGJsYWNrIGVtcHR5IHZpZXcgYmVmb3JlIHBhaW50aW5nIGEgd2Vi IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw Mzc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV2 YXMgcGFpbnRzIGVtcHR5IGV2YXMgb2JqZWN0cyBiZWZvcmUgcmVuZGVyaW5nIGEgd2ViIHBhZ2Us IHNvIGl0IHNob3dzIAorICAgICAgICBhIGJsYWNrIGVtcHR5IHZpZXcgZm9yIGEgbW9tZW50LiBU aGlzIHBhdGNoIHByZXZlbnRzIGZyb20gcGFpbnRpbmcgdGhlIGVtcHR5IAorICAgICAgICBldmFz IG9iamVjdHMgdW50aWwgYSBHTCBzdXJmYWNlIGlzIHJlYWR5IGZvciByZW5kZXJpbmcuICAKKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgorICAgICAgICAoc2hvd0V2 YXNPYmplY3RzKToKKyAgICAgICAgKEV3a1ZpZXc6OmRpc3BsYXlUaW1lckZpcmVkKToKKyAgICAg ICAgKEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RTaG93KToKKwogMjAxMy0wMy0yNyAgS29uZGFw YWxseSBLYWx5YW4gIDxrYWx5YW4ua29uZGFwYWxseUBpbnRlbC5jb20+CiAKICAgICAgICAgW0Nv b3JkR2Z4XSBTdXBwb3J0IHRvIHNoYXJlIEdyYXBoaWNzU3VyZmFjZSBmbGFncyB3aXRoIGNsaWVu dC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcu Y3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKaW5kZXgg MDYyYTM5MmNmMjc0ZWFmZDA1MTYwZGI3NTNlMjZiMjcwMDZmYzdhOC4uMjY4NWZiZTA5NjI3OTBi OWYzYWQ0MzAxYzczNGVlMjc1ZWEyOTFlNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FQSS9lZmwvRXdrVmlldy5jcHAKQEAgLTEyOCw2ICsxMjgsMTUgQEAgc3RhdGljIGlubGluZSBF d2tWaWV3KiB0b0V3a1ZpZXcoY29uc3QgRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhKQog ICAgIHJldHVybiBzbWFydERhdGEtPnByaXY7CiB9CiAKK3N0YXRpYyBpbmxpbmUgdm9pZCBzaG93 RXZhc09iamVjdHMoY29uc3QgRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnREYXRhKQoreworICAg IEFTU0VSVChzbWFydERhdGEpOworCisgICAgaWYgKGV2YXNfb2JqZWN0X2NsaXBlZXNfZ2V0KHNt YXJ0RGF0YS0+YmFzZS5jbGlwcGVyKSkKKyAgICAgICAgZXZhc19vYmplY3Rfc2hvdyhzbWFydERh dGEtPmJhc2UuY2xpcHBlcik7CisgICAgZXZhc19vYmplY3Rfc2hvdyhzbWFydERhdGEtPmltYWdl KTsKK30KKwogLy8gRXdrVmlld0V2ZW50SGFuZGxlciBpbXBsZW1lbnRhdGlvbi4KIAogdGVtcGxh dGUgPEV2YXNfQ2FsbGJhY2tfVHlwZSBFdmVudFR5cGU+CkBAIC01NDgsNiArNTU3LDkgQEAgdm9p ZCBFd2tWaWV3OjpkaXNwbGF5VGltZXJGaXJlZChUaW1lcjxFd2tWaWV3PiopCiAgICAgICAgIGlm ICghY3JlYXRlR0xTdXJmYWNlKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKKyAgICAgICAgLy8g TWFrZSBFdmFzIG9iamVjdHMgdmlzaWJsZSBoZXJlIGluIG9yZGVyIG5vdCB0byBwYWludCBlbXB0 eSBFdmFzIG9iamVjdHMgd2l0aCBibGFjayBjb2xvci4KKyAgICAgICAgc2hvd0V2YXNPYmplY3Rz KHNkKTsKKwogICAgICAgICBtX3BlbmRpbmdTdXJmYWNlUmVzaXplID0gZmFsc2U7CiAgICAgfQog CkBAIC0xMTM1LDkgKzExNDcsOCBAQCB2b2lkIEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RTaG93 KEV2YXNfT2JqZWN0KiBldmFzT2JqZWN0KQogICAgIEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0 RGF0YSA9IHRvU21hcnREYXRhKGV2YXNPYmplY3QpOwogICAgIEFTU0VSVChzbWFydERhdGEpOwog Ci0gICAgaWYgKGV2YXNfb2JqZWN0X2NsaXBlZXNfZ2V0KHNtYXJ0RGF0YS0+YmFzZS5jbGlwcGVy KSkKLSAgICAgICAgZXZhc19vYmplY3Rfc2hvdyhzbWFydERhdGEtPmJhc2UuY2xpcHBlcik7Ci0g ICAgZXZhc19vYmplY3Rfc2hvdyhzbWFydERhdGEtPmltYWdlKTsKKyAgICBpZiAoIXRvRXdrVmll dyhzbWFydERhdGEpLT5tX2lzQWNjZWxlcmF0ZWQpCisgICAgICAgIHNob3dFdmFzT2JqZWN0cyhz bWFydERhdGEpOwogfQogCiB2b2lkIEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RIaWRlKEV2YXNf T2JqZWN0KiBldmFzT2JqZWN0KQo= 195372 2013-03-27 11:56:26 -0700 2013-04-16 16:02:01 -0700 Patch bug-103745-20130327115402.patch text/plain 2617 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ2OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZjZhZGNlMDk1Y2FkZTU3 NjJhZDIxZGE2OTJmY2QwZmQzZGY4YzdhMy4uNTZjZThkY2I0NWQ0NTNkYTZjYWU0MzEzNWExZWNm ZTkwYTE1MTY2NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTAzLTI3ICBKb29u ZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0FDXSBNaW5pQnJv d3NlciBzdGFydHMgd2l0aCBhIGJsYWNrIGVtcHR5IHZpZXcgYmVmb3JlIHBhaW50aW5nIGEgd2Vi IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw Mzc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEV2 YXMgcGFpbnRzIGVtcHR5IGV2YXMgb2JqZWN0cyBiZWZvcmUgcmVuZGVyaW5nIGEgd2ViIHBhZ2Us IHNvIGl0IHNob3dzIAorICAgICAgICBhIGJsYWNrIGVtcHR5IHZpZXcgZm9yIGEgbW9tZW50LiBU aGlzIHBhdGNoIHByZXZlbnRzIGZyb20gcGFpbnRpbmcgdGhlIGVtcHR5IAorICAgICAgICBldmFz IG9iamVjdHMgdW50aWwgYSBHTCBzdXJmYWNlIGlzIHJlYWR5IGZvciByZW5kZXJpbmcuICAKKwor ICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgorICAgICAgICAoc2hvd0V2 YXNPYmplY3RzSWZOZWVkZWQpOgorICAgICAgICAoRXdrVmlldzo6ZGlzcGxheVRpbWVyRmlyZWQp OgorICAgICAgICAoRXdrVmlldzo6aGFuZGxlRXZhc09iamVjdFNob3cpOgorCiAyMDEzLTAzLTI3 ICBLb25kYXBhbGx5IEthbHlhbiAgPGthbHlhbi5rb25kYXBhbGx5QGludGVsLmNvbT4KIAogICAg ICAgICBbQ29vcmRHZnhdIFN1cHBvcnQgdG8gc2hhcmUgR3JhcGhpY3NTdXJmYWNlIGZsYWdzIHdp dGggY2xpZW50LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwv RXdrVmlldy5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNw cAppbmRleCAwNjJhMzkyY2YyNzRlYWZkMDUxNjBkYjc1M2UyNmIyNzAwNmZjN2E4Li44MTEwNDA5 YzIwMTQ0ODAwYjJmMzYwZjdiMGU0MjRjZWJkM2NjZjRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQVBJL2VmbC9Fd2tWaWV3LmNwcApAQCAtMTI4LDYgKzEyOCwxNSBAQCBzdGF0aWMg aW5saW5lIEV3a1ZpZXcqIHRvRXdrVmlldyhjb25zdCBFd2tfVmlld19TbWFydF9EYXRhKiBzbWFy dERhdGEpCiAgICAgcmV0dXJuIHNtYXJ0RGF0YS0+cHJpdjsKIH0KIAorc3RhdGljIGlubGluZSB2 b2lkIHNob3dFdmFzT2JqZWN0c0lmTmVlZGVkKGNvbnN0IEV3a19WaWV3X1NtYXJ0X0RhdGEqIHNt YXJ0RGF0YSkKK3sKKyAgICBBU1NFUlQoc21hcnREYXRhKTsKKworICAgIGlmIChldmFzX29iamVj dF9jbGlwZWVzX2dldChzbWFydERhdGEtPmJhc2UuY2xpcHBlcikpCisgICAgICAgIGV2YXNfb2Jq ZWN0X3Nob3coc21hcnREYXRhLT5iYXNlLmNsaXBwZXIpOworICAgIGV2YXNfb2JqZWN0X3Nob3co c21hcnREYXRhLT5pbWFnZSk7Cit9CisKIC8vIEV3a1ZpZXdFdmVudEhhbmRsZXIgaW1wbGVtZW50 YXRpb24uCiAKIHRlbXBsYXRlIDxFdmFzX0NhbGxiYWNrX1R5cGUgRXZlbnRUeXBlPgpAQCAtNTQ4 LDYgKzU1Nyw5IEBAIHZvaWQgRXdrVmlldzo6ZGlzcGxheVRpbWVyRmlyZWQoVGltZXI8RXdrVmll dz4qKQogICAgICAgICBpZiAoIWNyZWF0ZUdMU3VyZmFjZSgpKQogICAgICAgICAgICAgcmV0dXJu OwogCisgICAgICAgIC8vIE1ha2UgRXZhcyBvYmplY3RzIHZpc2libGUgaGVyZSBpbiBvcmRlciBu b3QgdG8gcGFpbnQgZW1wdHkgRXZhcyBvYmplY3RzIHdpdGggYmxhY2sgY29sb3IuCisgICAgICAg IHNob3dFdmFzT2JqZWN0c0lmTmVlZGVkKHNkKTsKKwogICAgICAgICBtX3BlbmRpbmdTdXJmYWNl UmVzaXplID0gZmFsc2U7CiAgICAgfQogCkBAIC0xMTM1LDkgKzExNDcsOCBAQCB2b2lkIEV3a1Zp ZXc6OmhhbmRsZUV2YXNPYmplY3RTaG93KEV2YXNfT2JqZWN0KiBldmFzT2JqZWN0KQogICAgIEV3 a19WaWV3X1NtYXJ0X0RhdGEqIHNtYXJ0RGF0YSA9IHRvU21hcnREYXRhKGV2YXNPYmplY3QpOwog ICAgIEFTU0VSVChzbWFydERhdGEpOwogCi0gICAgaWYgKGV2YXNfb2JqZWN0X2NsaXBlZXNfZ2V0 KHNtYXJ0RGF0YS0+YmFzZS5jbGlwcGVyKSkKLSAgICAgICAgZXZhc19vYmplY3Rfc2hvdyhzbWFy dERhdGEtPmJhc2UuY2xpcHBlcik7Ci0gICAgZXZhc19vYmplY3Rfc2hvdyhzbWFydERhdGEtPmlt YWdlKTsKKyAgICBpZiAoIXRvRXdrVmlldyhzbWFydERhdGEpLT5tX2lzQWNjZWxlcmF0ZWQpCisg ICAgICAgIHNob3dFdmFzT2JqZWN0c0lmTmVlZGVkKHNtYXJ0RGF0YSk7CiB9CiAKIHZvaWQgRXdr Vmlldzo6aGFuZGxlRXZhc09iamVjdEhpZGUoRXZhc19PYmplY3QqIGV2YXNPYmplY3QpCg== 198601 2013-04-17 13:20:31 -0700 2013-04-17 13:50:13 -0700 Patch bug-103745-20130417131733.patch text/plain 2621 joone U3VidmVyc2lvbiBSZXZpc2lvbjogMTQ4NjE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOWI2MmQ5ODc4OTdmMzdh YjE0NmM3NGQzNDJlYjdjMzEzYzE2NGYxZC4uYmQ3MjJlZDMyMThjMDJiM2EyODk1ODM2MTYwYWJk OThiMjlhYmFmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEzLTA0LTE3ICBKb29u ZSBIdXIgIDxqb29uZS5odXJAaW50ZWwuY29tPgorCisgICAgICAgIFtFRkxdW0FDXSBNaW5pQnJv d3NlciBzdGFydHMgd2l0aCBhIGJsYWNrIGVtcHR5IHZpZXcgYmVmb3JlIHBhaW50aW5nIGEgd2Vi IHBhZ2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEw Mzc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgor CisgICAgICAgIEV2YXMgcGFpbnRzIGVtcHR5IGV2YXMgb2JqZWN0cyBiZWZvcmUgcmVuZGVyaW5n IGEgd2ViIHBhZ2UsIHNvIGl0IHNob3dzIAorICAgICAgICBhIGJsYWNrIGVtcHR5IHZpZXcgZm9y IGEgbW9tZW50LiBUaGlzIHBhdGNoIHByZXZlbnRzIGZyb20gcGFpbnRpbmcgdGhlIGVtcHR5IAor ICAgICAgICBldmFzIG9iamVjdHMgdW50aWwgYSBHTCBzdXJmYWNlIGlzIHJlYWR5IGZvciByZW5k ZXJpbmcuICAKKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL0V3a1ZpZXcuY3BwOgorICAg ICAgICAoc2hvd0V2YXNPYmplY3RzSWZOZWVkZWQpOgorICAgICAgICAoRXdrVmlldzo6ZGlzcGxh eVRpbWVyRmlyZWQpOgorICAgICAgICAoRXdrVmlldzo6aGFuZGxlRXZhc09iamVjdFNob3cpOgor CiAyMDEzLTA0LTE2ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBbR1RLXSBBZGQgd2Via2l0X3dlYl9wYWdlX2dldF9pZCgpIHRvIFdlYktpdDIg R1RLKyBBUEkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL0V3 a1ZpZXcuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAK aW5kZXggZTkxNzE4MWFlYjg0YWVlYjQzNzgyNzdjYzZlNGRmMTgxNmIzNzVhZS4uN2NiMmRlNmQ0 YjJmZTAxYjFlNWY4YTY5MDY5M2E4MzQyNmViNTQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9lZmwvRXdrVmlldy5jcHAKQEAgLTEzMCw2ICsxMzAsMTUgQEAgc3RhdGljIGlu bGluZSBFd2tWaWV3KiB0b0V3a1ZpZXcoY29uc3QgRXdrX1ZpZXdfU21hcnRfRGF0YSogc21hcnRE YXRhKQogICAgIHJldHVybiBzbWFydERhdGEtPnByaXY7CiB9CiAKK3N0YXRpYyBpbmxpbmUgdm9p ZCBzaG93RXZhc09iamVjdHNJZk5lZWRlZChjb25zdCBFd2tfVmlld19TbWFydF9EYXRhKiBzbWFy dERhdGEpCit7CisgICAgQVNTRVJUKHNtYXJ0RGF0YSk7CisKKyAgICBpZiAoZXZhc19vYmplY3Rf Y2xpcGVlc19nZXQoc21hcnREYXRhLT5iYXNlLmNsaXBwZXIpKQorICAgICAgICBldmFzX29iamVj dF9zaG93KHNtYXJ0RGF0YS0+YmFzZS5jbGlwcGVyKTsKKyAgICBldmFzX29iamVjdF9zaG93KHNt YXJ0RGF0YS0+aW1hZ2UpOworfQorCiAvLyBFd2tWaWV3RXZlbnRIYW5kbGVyIGltcGxlbWVudGF0 aW9uLgogCiB0ZW1wbGF0ZSA8RXZhc19DYWxsYmFja19UeXBlIEV2ZW50VHlwZT4KQEAgLTUzOSw2 ICs1NDgsOSBAQCB2b2lkIEV3a1ZpZXc6OmRpc3BsYXlUaW1lckZpcmVkKFRpbWVyPEV3a1ZpZXc+ KikKICAgICAgICAgaWYgKCFjcmVhdGVHTFN1cmZhY2UoKSkKICAgICAgICAgICAgIHJldHVybjsK ICNlbmRpZgorICAgICAgICAvLyBNYWtlIEV2YXMgb2JqZWN0cyB2aXNpYmxlIGhlcmUgaW4gb3Jk ZXIgbm90IHRvIHBhaW50IGVtcHR5IEV2YXMgb2JqZWN0cyB3aXRoIGJsYWNrIGNvbG9yLgorICAg ICAgICBzaG93RXZhc09iamVjdHNJZk5lZWRlZChzZCk7CisKICAgICAgICAgbV9wZW5kaW5nU3Vy ZmFjZVJlc2l6ZSA9IGZhbHNlOwogICAgIH0KIApAQCAtMTEyMSw5ICsxMTMzLDggQEAgdm9pZCBF d2tWaWV3OjpoYW5kbGVFdmFzT2JqZWN0U2hvdyhFdmFzX09iamVjdCogZXZhc09iamVjdCkKICAg ICBFd2tfVmlld19TbWFydF9EYXRhKiBzbWFydERhdGEgPSB0b1NtYXJ0RGF0YShldmFzT2JqZWN0 KTsKICAgICBBU1NFUlQoc21hcnREYXRhKTsKIAotICAgIGlmIChldmFzX29iamVjdF9jbGlwZWVz X2dldChzbWFydERhdGEtPmJhc2UuY2xpcHBlcikpCi0gICAgICAgIGV2YXNfb2JqZWN0X3Nob3co c21hcnREYXRhLT5iYXNlLmNsaXBwZXIpOwotICAgIGV2YXNfb2JqZWN0X3Nob3coc21hcnREYXRh LT5pbWFnZSk7CisgICAgaWYgKCF0b0V3a1ZpZXcoc21hcnREYXRhKS0+bV9pc0FjY2VsZXJhdGVk KQorICAgICAgICBzaG93RXZhc09iamVjdHNJZk5lZWRlZChzbWFydERhdGEpOwogfQogCiB2b2lk IEV3a1ZpZXc6OmhhbmRsZUV2YXNPYmplY3RIaWRlKEV2YXNfT2JqZWN0KiBldmFzT2JqZWN0KQo=