103701 2012-11-29 18:24:06 -0800 REGRESSION(r136167): Win debug build failure (Requested by zhenyao on #webkit). 2012-11-30 20:06:48 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103555 1 webkit.review.bot webkit.review.bot hclam qinmin senorblanco oldest_to_newest 779715 0 webkit.review.bot 2012-11-29 18:24:06 -0800 http://trac.webkit.org/changeset/136167 broke the build: Win debug build failure (Requested by zhenyao on #webkit). This is an automatic bug report generated by the sheriff-bot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests case pain. "Only you can prevent forest fires." -- Smokey the Bear 779718 1 176880 webkit.review.bot 2012-11-29 18:24:46 -0800 Created attachment 176880 ROLLOUT of r136167 Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment. 779723 2 176880 webkit.review.bot 2012-11-29 18:29:26 -0800 Comment on attachment 176880 ROLLOUT of r136167 Clearing flags on attachment: 176880 Committed r136196: <http://trac.webkit.org/changeset/136196> 779724 3 webkit.review.bot 2012-11-29 18:29:29 -0800 All reviewed patches have been landed. Closing bug. 780601 4 hclam 2012-11-30 18:09:44 -0800 Is there any log of the build failure? 780606 5 qinmin 2012-11-30 18:23:41 -0800 sth like this: 169> GraphicsContext3DPrivate.cpp 169>Link: 169> Creating library ..\..\..\..\..\build\Debug\lib\webkit.lib and object ..\..\..\..\..\build\Debug\lib\webkit.exp 169>webcore_platform.lib(LazyDecodingPixelRef.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: virtual __thiscall skia::LazyPixelRef::~LazyPixelRef(void)" (__imp_??1LazyPixelRef@skia@@UAE@XZ) referenced in function __unwindfunclet$??0LazyDecodingPixelRef@WebCore@@QAE@V?$PassRefPtr@VImageFrameGenerator@WebCore@@@WTF@@ABU?$SkTSize@H@@ABUSkIRect@@@Z$0 169>webcore_platform.lib(LazyDecodingPixelRef.obj) : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __thiscall skia::LazyPixelRef::LazyPixelRef(void)" (__imp_??0LazyPixelRef@skia@@QAE@XZ) referenced in function "public:__thiscall WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef(class WTF::PassRefPtr<class WebCore::ImageFrameGenerator>,struct SkTSize<int> const &,struct SkIRect const &)" (??0LazyDecodingPixelRef@WebCore@@QAE@V?$PassRefPtr@VImageFrameGenerator@WebCore@@@WTF@@ABU?$SkTSize@H@@ABUSkIRect@@@Z) 169>..\..\..\..\..\build\Debug\webkit.dll : fatal error LNK1120: 2 unresolved externals 169> 169>Build FAILED. I submitted https://codereview.chromium.org/11299277/ to add ctor and dtor to lazy_pixel_ref.h, hope it solves the problem (In reply to comment #4) > Is there any log of the build failure? 780624 6 hclam 2012-11-30 20:06:48 -0800 Cool alright. 176880 2012-11-29 18:24:46 -0800 2012-11-29 18:29:26 -0800 ROLLOUT of r136167 bug-103701-20121130023100.patch text/plain 3603 webkit.review.bot U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2U3NGE3OGUzYTU4NjRh NmNhNmEyMjRlMDE2YjVmYWRmMGE2ZDk0Yi4uMWE2NmU0NDViZGIzYWUxMDEyNDNmZDU0YWQ1OGMy ZDk5NmFkZDY5MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI5ICBTaGVy aWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KKworICAgICAgICBVbnJldmll d2VkLCByb2xsaW5nIG91dCByMTM2MTY3LgorICAgICAgICBodHRwOi8vdHJhYy53ZWJraXQub3Jn L2NoYW5nZXNldC8xMzYxNjcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTEwMzcwMQorCisgICAgICAgIFdpbiBkZWJ1ZyBidWlsZCBmYWlsdXJlIChSZXF1 ZXN0ZWQgYnkgemhlbnlhbyBvbiAjd2Via2l0KS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBo aWNzL2Nocm9taXVtL0xhenlEZWNvZGluZ1BpeGVsUmVmLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkxhenlEZWNvZGluZ1BpeGVsUmVmOjpMYXp5RGVjb2RpbmdQaXhlbFJlZik6CisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF6eURlY29kaW5nUGl4ZWxSZWYuaDoKKyAgICAg ICAgKExhenlEZWNvZGluZ1BpeGVsUmVmKToKKwogMjAxMi0xMS0yOSAgRGF2aWQgR3JvZ2FuICA8 ZGdyb2dhbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgSW5kZXhlZERCOiBQcm9wYWdhdGUgbW9y ZSBsZXZlbGRiIGVycm9ycyB0byBzY3JpcHQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xhenlEZWNvZGluZ1BpeGVsUmVmLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xhenlEZWNvZGluZ1BpeGVsUmVm LmNwcAppbmRleCBmMzEyMGU3OWQ4MGVkNWFiNDQwMzI3NDVlYjE2MWRmYzQwOGQ4OTNlLi41NTUy NjYzNjJhNjUyOGNkNGM1MzM4MjJmMWY2NTg2YmJmZDg0MzUzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXp5RGVjb2RpbmdQaXhlbFJlZi5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF6eURl Y29kaW5nUGl4ZWxSZWYuY3BwCkBAIC0zNCw3ICszNCw4IEBACiBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIExhenlEZWNvZGluZ1BpeGVsUmVmOjpMYXp5RGVjb2RpbmdQaXhlbFJlZihQYXNzUmVmUHRy PEltYWdlRnJhbWVHZW5lcmF0b3I+IGZyYW1lR2VuZXJhdG9yLCBjb25zdCBTa0lTaXplJiBzY2Fs ZWRTaXplLCBjb25zdCBTa0lSZWN0JiBzY2FsZWRTdWJzZXQpCi0gICAgOiBtX2ZyYW1lR2VuZXJh dG9yKGZyYW1lR2VuZXJhdG9yKQorICAgIDogU2tQaXhlbFJlZigwKQorICAgICwgbV9mcmFtZUdl bmVyYXRvcihmcmFtZUdlbmVyYXRvcikKICAgICAsIG1fc2NhbGVkU2l6ZShzY2FsZWRTaXplKQog ICAgICwgbV9zY2FsZWRTdWJzZXQoc2NhbGVkU3Vic2V0KQogICAgICwgbV9sb2NrZWRDYWNoZWRJ bWFnZSgwKQpAQCAtODksMTkgKzkwLDQgQEAgYm9vbCBMYXp5RGVjb2RpbmdQaXhlbFJlZjo6b25M b2NrUGl4ZWxzQXJlV3JpdGFibGUoKSBjb25zdAogICAgIHJldHVybiBmYWxzZTsKIH0KIAotYm9v bCBMYXp5RGVjb2RpbmdQaXhlbFJlZjo6UHJlcGFyZVRvRGVjb2RlKGNvbnN0IExhenlQaXhlbFJl Zjo6UHJlcGFyZVBhcmFtcyYgcGFyYW1zKQotewotICAgIE11dGV4TG9ja2VyIGxvY2sobV9tdXRl eCk7Ci0gICAgLy8gVE9ETzogY2hlY2sgaWYgb25seSBhIHBhcnRpY3VsYXIgcmVjdCBpcyBhdmFp bGFibGUgaW4gaW1hZ2UgY2FjaGUuCi0gICAgVU5VU0VEX1BBUkFNKHBhcmFtcyk7Ci0gICAgcmV0 dXJuIEltYWdlRGVjb2RpbmdTdG9yZTo6aW5zdGFuY2UoKS0+bG9ja0NvbXBsZXRlQ2FjaGUobV9m cmFtZUdlbmVyYXRvci5nZXQoKSwgbV9zY2FsZWRTaXplKTsKLX0KLQotdm9pZCBMYXp5RGVjb2Rp bmdQaXhlbFJlZjo6RGVjb2RlKCkKLXsKLSAgICBsb2NrUGl4ZWxzKCk7Ci0gICAgdW5sb2NrUGl4 ZWxzKCk7Ci19Ci0KLQogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXp5RGVjb2RpbmdQaXhlbFJlZi5o IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF6eURlY29kaW5n UGl4ZWxSZWYuaAppbmRleCAwOWU2ZjhkMDM4NDFhOGFiMTU2NjBhYWQ2M2I1ZjE4ZDA3OGM0ZDI4 Li45YjJhNDZkNGU1ZDliNDVmNGUwNzJlNzMyODBjMTRiMDJhYjJhMGI3IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXp5RGVjb2RpbmdQaXhl bFJlZi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xh enlEZWNvZGluZ1BpeGVsUmVmLmgKQEAgLTI2LDI0ICsyNiwyMSBAQAogI2lmbmRlZiBMYXp5RGVj b2RpbmdQaXhlbFJlZl9oCiAjZGVmaW5lIExhenlEZWNvZGluZ1BpeGVsUmVmX2gKIAorI2luY2x1 ZGUgIlNrVHlwZXMuaCIKICNpbmNsdWRlICJTa0ZsYXR0ZW5hYmxlQnVmZmVycy5oIgogI2luY2x1 ZGUgIlNrUGl4ZWxSZWYuaCIKICNpbmNsdWRlICJTa1JlY3QuaCIKICNpbmNsdWRlICJTa1NpemUu aCIKLSNpbmNsdWRlICJTa1R5cGVzLmgiCi0jaW5jbHVkZSAic2tpYS9leHQvbGF6eV9waXhlbF9y ZWYuaCIKIAogI2luY2x1ZGUgPHd0Zi9SZWZQdHIuaD4KICNpbmNsdWRlIDx3dGYvVGhyZWFkaW5n UHJpbWl0aXZlcy5oPgogCi11c2luZyBza2lhOjpMYXp5UGl4ZWxSZWY7Ci0KIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogY2xhc3MgSW1hZ2VGcmFtZUdlbmVyYXRvcjsKIGNsYXNzIFNjYWxlZEltYWdl RnJhZ21lbnQ7CiAKLWNsYXNzIExhenlEZWNvZGluZ1BpeGVsUmVmIDogcHVibGljIExhenlQaXhl bFJlZiB7CitjbGFzcyBMYXp5RGVjb2RpbmdQaXhlbFJlZiA6IHB1YmxpYyBTa1BpeGVsUmVmIHsK IHB1YmxpYzoKICAgICBMYXp5RGVjb2RpbmdQaXhlbFJlZihQYXNzUmVmUHRyPEltYWdlRnJhbWVH ZW5lcmF0b3I+LCBjb25zdCBTa0lTaXplJiBzY2FsZWRTaXplLCBjb25zdCBTa0lSZWN0JiBzY2Fs ZWRTdWJzZXQpOwogICAgIHZpcnR1YWwgfkxhenlEZWNvZGluZ1BpeGVsUmVmKCk7CkBAIC01NCw5 ICs1MSw2IEBAIHB1YmxpYzoKICAgICBib29sIGlzU2NhbGVkKGNvbnN0IFNrSVNpemUmIGZ1bGxT aXplKSBjb25zdDsKICAgICBib29sIGlzQ2xpcHBlZCgpIGNvbnN0OwogCi0gICAgdmlydHVhbCBi b29sIFByZXBhcmVUb0RlY29kZShjb25zdCBMYXp5UGl4ZWxSZWY6OlByZXBhcmVQYXJhbXMmKTsK LSAgICB2aXJ0dWFsIHZvaWQgRGVjb2RlKCk7Ci0KIHByb3RlY3RlZDoKICAgICAvLyBTa1BpeGVs UmVmIGltcGxlbWVudGF0aW9uLgogICAgIHZpcnR1YWwgdm9pZCogb25Mb2NrUGl4ZWxzKFNrQ29s b3JUYWJsZSoqKTsK