103676 2012-11-29 15:18:35 -0800 Unused parameters on plugins/npapi.cpp 2012-11-29 16:49:51 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ktf.kim ktf.kim haraken webkit.review.bot oldest_to_newest 779498 0 ktf.kim 2012-11-29 15:18:35 -0800 Because the 'instance' and 'menu' parameter are not used in NPN_PopUpContextMenu when !PLATFORM(QT) || !defined(XP_MACOSX), use UNUSED_PARAM macro to fix build warning -Wunused-parameter Source/WebCore/plugins/npapi.cpp:203:9: warning: unused parameter 'instance' [-Wunused-parameter] Source/WebCore/plugins/npapi.cpp:203:9: warning: unused parameter 'menu' [-Wunused-parameter] 779500 1 176832 ktf.kim 2012-11-29 15:21:35 -0800 Created attachment 176832 Patch 779547 2 176832 haraken 2012-11-29 15:49:19 -0800 Comment on attachment 176832 Patch OK 779594 3 176832 webkit.review.bot 2012-11-29 16:49:48 -0800 Comment on attachment 176832 Patch Clearing flags on attachment: 176832 Committed r136185: <http://trac.webkit.org/changeset/136185> 779595 4 webkit.review.bot 2012-11-29 16:49:51 -0800 All reviewed patches have been landed. Closing bug. 176832 2012-11-29 15:21:35 -0800 2012-11-29 16:49:48 -0800 Patch bug-103676-20121130081908.patch text/plain 1389 ktf.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTM2MTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGFlYzVjZGUyOGNjYzcw ZWNlNjZmNGYyMGIxNDZkYzZjMzI2ZjRhMy4uNTQ2ZDZhOTBhNTk1ZTllNmJkMTA2NzUwNjg4MDMz OWQwMzJjMmJkOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTExLTI5ICBLeXVu Z1RhZSBLaW0gIDxrdGYua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFVudXNlZCBwYXJhbWV0 ZXJzIG9uIHBsdWdpbnMvbnBhcGkuY3BwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMDM2NzYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBCZWNhdXNlICdpbnN0YW5jZScgYW5kICdtZW51JyBhcmUgbm90IHVz ZWQgd2hlbiAhUExBVEZPUk0oUVQpIHx8ICFkZWZpbmVkKFhQX01BQ09TWCksCisgICAgICAgIHVz ZSBVTlVTRURfUEFSQU0gbWFjcm8gdG8gZml4IGJ1aWxkIHdhcm5pbmcgLVd1bnVzZWQtcGFyYW1l dGVyCisKKyAgICAgICAgKiBwbHVnaW5zL25wYXBpLmNwcDoKKyAgICAgICAgKE5QTl9Qb3BVcENv bnRleHRNZW51KToKKwogMjAxMi0xMS0yOSAgRXVnZW5lIEtseXVjaG5pa292ICA8ZXVzdGFzQGNo cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBXZWIgSW5zcGVjdG9yOiBNYWtl IG1haW4tdGhyZWFkIG1vbml0b3JpbmcgZ28gdGhyb3VnaCBJbnNwZWN0b3JDb250cm9sbGVyLgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGx1Z2lucy9ucGFwaS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbHVnaW5zL25wYXBpLmNwcAppbmRleCA1NWQzNDVjODAyMmI0ZjViZmY2OTM5YjNjN2Q0 OTgwYzMxOGRmYjdhLi42NjIzNTcxNDNkMzA2OTcyZmU2M2YxODE1NzdlNDM3OTBjMTliYzIxIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbHVnaW5zL25wYXBpLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbHVnaW5zL25wYXBpLmNwcApAQCAtMjA3LDYgKzIwNyw4IEBAIE5QRXJyb3IgTlBO X1BvcFVwQ29udGV4dE1lbnUoTlBQIGluc3RhbmNlLCBOUE1lbnUqIG1lbnUpCiAgICAgcGx1Z2lu LT5wb3BVcENvbnRleHRNZW51KG1lbnUpOwogICAgIHJldHVybiBOUEVSUl9OT19FUlJPUjsKICNl bHNlCisgICAgVU5VU0VEX1BBUkFNKGluc3RhbmNlKTsKKyAgICBVTlVTRURfUEFSQU0obWVudSk7 CiAgICAgcmV0dXJuIE5QRVJSX05PX0VSUk9SOwogI2VuZGlmIC8vIFBMQVRGT1JNKFFUKSAmJiBk ZWZpbmVkKFhQX01BQ09TWCkKIH0K