103673 2012-11-29 15:01:24 -0800 Avoid painting lots of small rects in WebLayer painting 2012-11-29 15:22:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser dino mitz simon.fraser thorton oldest_to_newest 779474 0 simon.fraser 2012-11-29 15:01:24 -0800 Avoid painting lots of small rects in WebLayer painting 779480 1 176826 simon.fraser 2012-11-29 15:07:35 -0800 Created attachment 176826 Patch 779485 2 176826 thorton 2012-11-29 15:11:02 -0800 Comment on attachment 176826 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176826&action=review > Source/WebCore/platform/graphics/mac/WebLayer.mm:106 > + const FloatRect& currRect = dirtyRects[i]; curr? :\ > Source/WebCore/platform/graphics/mac/WebLayer.mm:114 > + layerContents->platformCALayerPaintContents(graphicsContext, enclosingIntRect(clipBounds)); Shouldn't this be the union of the rects instead? 779486 3 simon.fraser 2012-11-29 15:11:25 -0800 <rdar://problem/12773043> 779501 4 simon.fraser 2012-11-29 15:22:42 -0800 http://trac.webkit.org/changeset/136174 176826 2012-11-29 15:07:35 -0800 2012-11-29 15:11:02 -0800 Patch bug-103673-20121129150509.patch text/plain 3712 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1NzQ2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjgwMzQ5YmRmMGUxOThi YjY2YTJmYWI1NTgyMzU4ZmE0NTRjMGE1OC4uZjcxZDliMGY5ZjJjMGJhZWY3Y2E5ODk1NzI0MmM0 YWQ2NmZmOTFlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDEyLTExLTI5ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEF2b2lkIHBhaW50 aW5nIGxvdHMgb2Ygc21hbGwgcmVjdHMgaW4gV2ViTGF5ZXIgcGFpbnRpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEwMzY3MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHIxMDkxODYgYWRkZWQgY29kZSBp biBkcmF3TGF5ZXJDb250ZW50cygpIHRvIGVudW1lcmF0ZSBvdmVyIHRoZSByZWN0cyBpbgorICAg ICAgICB0aGUgQ0FMYXllcidzIGRpcnR5IHJlZ2lvbiwgYW5kIHBhaW50IHRoZW0gaW5kaXZpZHVh bGx5LiBUaGlzIHdhcyBkb25lCisgICAgICAgIHRvIGhlbHAgcGVyZm9ybWFuY2Ugb24gdGhlIElF IE1hemUgU29sdmVyIHRlc3QuCisgICAgICAgIAorICAgICAgICBPbiBsYXJnZSwgY29tcGxleCBw YWdlcyBsaWtlIEZhY2Vib29rLCB0aGUgb3ZlcmhlYWQgb2YgdHJhdmVyc2luZyB0aGUKKyAgICAg ICAgUmVuZGVyTGF5ZXIgdHJlZSBmb3IgcGFpbnRpbmcgaXMgc3VjaCB0aGF0IGl0J3MgYmV0dGVy IHRvIHBhaW50IGEgc2luZ2xlLAorICAgICAgICBvciBmZXdlciByZWN0cyByYXRoZXIgdGhhbiBs b3RzIG9mIGxpdHRsZSBvbmVzLgorICAgICAgICAKKyAgICAgICAgU28gYWRvcHQgYSBoZXVyaXN0 aWMgc2ltaWxhciB0byB0aGF0IGluIERyYXdpbmdBcmVhLCB3aGVyZSBpZiB0aGUKKyAgICAgICAg Y29tYmluZWQgYXJlYSBvZiB0aGUgc21hbGwgcmVjdHMgaXMgNzUlIG9yIG1vcmUgb2YgdGhlIGNv bWJpbmVkIHJlY3QsCisgICAgICAgIGp1c3QgcGFpbnQgdGhlIGNvbWJpbmVkIHJlY3QuIEFsc28g cGFpbnQgdGhlIGNvbWJpbmVkIHJlY3QgaWYgdGhlcmUKKyAgICAgICAgYXJlIG1vcmUgdGhhbiA1 IGluZGl2aWR1YWwgcmVjdHMuCisgICAgICAgIAorICAgICAgICBJIHZlcmlmaWVkIHRoYXQgdGhp cyBwcmVzZXJ2ZXMgdGhlIG9wdGltaXphdGlvbiBmb3IgSUUgTWF6ZSBTb2x2ZXIuCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvV2ViTGF5ZXIubW06CisgICAgICAgIChkcmF3TGF5 ZXJDb250ZW50cyk6CisKIDIwMTItMTEtMjYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBh cHBsZS5jb20+CiAKICAgICAgICAgT3B0aW1pemUgbGF5ZXIgdXBkYXRlcyBhZnRlciBzY3JvbGxp bmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9XZWJM YXllci5tbSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9XZWJMYXllci5t bQppbmRleCBjYTQzOTNkODU1ZTUzYWYyYWJjOTg1MzYzODEyNjJkOGUxNjcyMmMzLi4xNzE4YmU4 MDI2M2M2ZTRhZTllYjA4ODYxNDc2ODI1ZmYzMTZjMjY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvV2ViTGF5ZXIubW0KKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL1dlYkxheWVyLm1tCkBAIC04NSwxOCArODUsMzQgQEAg dm9pZCBkcmF3TGF5ZXJDb250ZW50cyhDR0NvbnRleHRSZWYgY29udGV4dCwgQ0FMYXllciAqbGF5 ZXIsIFdlYkNvcmU6OlBsYXRmb3JtQ0EKICAgICBUaGVtZU1hYzo6c2V0Rm9jdXNSaW5nQ2xpcFJl Y3QodHJhbnNmb3JtLm1hcFJlY3QoY2xpcEJvdW5kcykpOwogCiAjaWYgUExBVEZPUk0oSU9TKSB8 fCBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwNzAKLSAgICBfX2Jsb2NrIEdy YXBoaWNzQ29udGV4dCogY3R4ID0gJmdyYXBoaWNzQ29udGV4dDsKKyAgICBjb25zdCBmbG9hdCB3 YXN0ZWRTcGFjZVRocmVzaG9sZCA9IDAuNzVmOworICAgIGNvbnN0IHVuc2lnbmVkIG1heFJlY3Rz VG9QYWludCA9IDU7CiAKLSAgICB3a0NBTGF5ZXJFbnVtZXJhdGVSZWN0c0JlaW5nRHJhd25XaXRo QmxvY2sobGF5ZXIsIGNvbnRleHQsIF4oQ0dSZWN0IHJlY3QpewotICAgICAgICBGbG9hdFJlY3Qg cmVjdEJlaW5nRHJhd24ocmVjdCk7Ci0gICAgICAgIHJlY3RCZWluZ0RyYXduLmludGVyc2VjdChj bGlwQm91bmRzKTsKLSAgICAgICAgCi0gICAgICAgIEdyYXBoaWNzQ29udGV4dFN0YXRlU2F2ZXIg c3RhdGVTYXZlcigqY3R4KTsKLSAgICAgICAgY3R4LT5jbGlwKHJlY3RCZWluZ0RyYXduKTsKLSAg ICAgICAgCi0gICAgICAgIGxheWVyQ29udGVudHMtPnBsYXRmb3JtQ0FMYXllclBhaW50Q29udGVu dHMoKmN0eCwgZW5jbG9zaW5nSW50UmVjdChyZWN0QmVpbmdEcmF3bikpOworICAgIGRvdWJsZSBj bGlwQXJlYSA9IGNsaXBCb3VuZHMud2lkdGgoKSAqIGNsaXBCb3VuZHMuaGVpZ2h0KCk7CisgICAg X19ibG9jayBkb3VibGUgdG90YWxSZWN0QXJlYSA9IDA7CisgICAgX19ibG9jayB1bnNpZ25lZCBy ZWN0Q291bnQgPSAwOworICAgIF9fYmxvY2sgVmVjdG9yPEZsb2F0UmVjdCwgbWF4UmVjdHNUb1Bh aW50PiBkaXJ0eVJlY3RzOworICAgIAorICAgIHdrQ0FMYXllckVudW1lcmF0ZVJlY3RzQmVpbmdE cmF3bldpdGhCbG9jayhsYXllciwgY29udGV4dCwgXihDR1JlY3QgcmVjdCkgeworICAgICAgICBp ZiAoKytyZWN0Q291bnQgPiBtYXhSZWN0c1RvUGFpbnQpCisgICAgICAgICAgICByZXR1cm47CisK KyAgICAgICAgdG90YWxSZWN0QXJlYSArPSByZWN0LnNpemUud2lkdGggKiByZWN0LnNpemUuaGVp Z2h0OworICAgICAgICBkaXJ0eVJlY3RzLmFwcGVuZChyZWN0KTsKICAgICB9KTsKIAorICAgIGlm IChyZWN0Q291bnQgPCBtYXhSZWN0c1RvUGFpbnQgJiYgdG90YWxSZWN0QXJlYSA8IGNsaXBBcmVh ICogd2FzdGVkU3BhY2VUaHJlc2hvbGQpIHsKKyAgICAgICAgZm9yICh1bnNpZ25lZCBpID0gMDsg aSA8IHJlY3RDb3VudDsgKytpKSB7CisgICAgICAgICAgICBjb25zdCBGbG9hdFJlY3QmIGN1cnJS ZWN0ID0gZGlydHlSZWN0c1tpXTsKKyAgICAgICAgICAgIAorICAgICAgICAgICAgR3JhcGhpY3ND b250ZXh0U3RhdGVTYXZlciBzdGF0ZVNhdmVyKGdyYXBoaWNzQ29udGV4dCk7CisgICAgICAgICAg ICBncmFwaGljc0NvbnRleHQuY2xpcChjdXJyUmVjdCk7CisgICAgICAgICAgICAKKyAgICAgICAg ICAgIGxheWVyQ29udGVudHMtPnBsYXRmb3JtQ0FMYXllclBhaW50Q29udGVudHMoZ3JhcGhpY3ND b250ZXh0LCBlbmNsb3NpbmdJbnRSZWN0KGN1cnJSZWN0KSk7CisgICAgICAgIH0KKyAgICB9IGVs c2UKKyAgICAgICAgbGF5ZXJDb250ZW50cy0+cGxhdGZvcm1DQUxheWVyUGFpbnRDb250ZW50cyhn cmFwaGljc0NvbnRleHQsIGVuY2xvc2luZ0ludFJlY3QoY2xpcEJvdW5kcykpOworCiAjZWxzZQog ICAgIEludFJlY3QgY2xpcChlbmNsb3NpbmdJbnRSZWN0KGNsaXBCb3VuZHMpKTsKICAgICBsYXll ckNvbnRlbnRzLT5wbGF0Zm9ybUNBTGF5ZXJQYWludENvbnRlbnRzKGdyYXBoaWNzQ29udGV4dCwg Y2xpcCk7Cg==