103659 2012-11-29 12:23:24 -0800 [BlackBerry] Do not adjust scroll position on viewport resizes that are not orientation change related 2012-11-29 13:26:19 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anlo anlo mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 779310 0 anlo 2012-11-29 12:23:24 -0800 For viewport resizes that are not due to orientation changes, do not adjust scroll position. 779318 1 176786 anlo 2012-11-29 12:27:47 -0800 Created attachment 176786 Patch 779321 2 176786 rwlbuis 2012-11-29 12:29:39 -0800 Comment on attachment 176786 Patch LGTM. 779323 3 webkit.review.bot 2012-11-29 12:30:30 -0800 Attachment 176786 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/Api/WebPage.cpp:3641: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 779330 4 176790 anlo 2012-11-29 12:35:32 -0800 Created attachment 176790 Patch 779338 5 176790 rwlbuis 2012-11-29 12:39:03 -0800 Comment on attachment 176790 Patch Retry. 779340 6 webkit.review.bot 2012-11-29 12:40:06 -0800 Attachment 176790 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/WebPage.cpp',..." exit_code: 1 Source/WebKit/blackberry/Api/WebPage.cpp:3641: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 779347 7 176794 anlo 2012-11-29 12:46:18 -0800 Created attachment 176794 Patch 779350 8 176794 rwlbuis 2012-11-29 12:47:29 -0800 Comment on attachment 176794 Patch These rules are silly IMHO. 779386 9 176794 webkit.review.bot 2012-11-29 13:26:15 -0800 Comment on attachment 176794 Patch Clearing flags on attachment: 176794 Committed r136157: <http://trac.webkit.org/changeset/136157> 779387 10 webkit.review.bot 2012-11-29 13:26:19 -0800 All reviewed patches have been landed. Closing bug. 176786 2012-11-29 12:27:47 -0800 2012-11-29 12:35:28 -0800 Patch bug-103659-20121129152540.patch text/plain 2117 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4Y2M5OGRjMzcyYzcyMmU3NTE5NGJhMTUwNjg3MWNlODRjOTUyMTk1Li44NzFiNmU0Mzg4 ODNhN2I0OGU5NGI4ZGVjNmY2ZjJhZWMyOWU1ZGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yOSAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBub3QgYWRqdXN0IHNjcm9sbCBwb3NpdGlv biBvbiB2aWV3cG9ydCByZXNpemVzIHRoYXQgYXJlIG5vdCBvcmllbnRhdGlvbiBjaGFuZ2UgcmVs YXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz NjU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIEludGVy bmFsbHkgcmV2aWV3ZWQgYnkgR2VuIE1hay4KKworICAgICAgICBJbnRlcm5hbCBQUjI1Mzg5My4K KyAgICAgICAgT25seSBhZGp1c3Qgc2Nyb2xsIHBvc2l0aW9uIGR1cmluZyBhbiBvcmllbnRhdGlv biBjaGFuZ2UKKyAgICAgICAgd2hlbiBzZXR0aW5nIHZpZXdwb3J0IHNpemUuCisgICAgICAgIFdl IGRvbid0IHdhbnQgdGhlIHNjcm9sbCBwb3NpdGlvbiBqdW1waW5nIGFyb3VuZCB3aGVuIG9wZW5p bmcKKyAgICAgICAgJiBjbG9zaW5nIHRoZSBWS0IuCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpzZXRWaWV3 cG9ydFNpemUpOgorCiAyMDEyLTExLTI3ICBBbmRyZXcgTG8gIDxhbmxvQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSB1bm5lY2Vzc2FyeSBiYWNraW5nIHN0b3JlIHN1c3Bl bnNpb24gaW4gSW5wdXRIYW5kbGVyOjplbnN1cmVGb2N1c1RleHRFbGVtZW50VmlzaWJsZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggNGI0OGRiN2JlZjU2YTk3 NmJkM2JjYTRjZmIxMjA0OTg2MzFiZWZlMy4uMjE5ZjliNDJhYTIzMWQ2ZmVhZWQ1YWZlN2YwNjg2 YTJkODU4NjJhNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBA IC0zNjY2LDkgKzM2NjYsMTEgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6c2V0Vmlld3BvcnRTaXpl KGNvbnN0IEludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNpemUKIAogICAgIEludFNp emUgdmlld3BvcnRTaXplQWZ0ZXIgPSBhY3R1YWxWaXNpYmxlU2l6ZSgpOwogCi0gICAgSW50U2l6 ZSBvZmZzZXQoCi0gICAgICAgIHJvdW5kZigodmlld3BvcnRTaXplQmVmb3JlLndpZHRoKCkgLSB2 aWV3cG9ydFNpemVBZnRlci53aWR0aCgpKSAvIDIuMCksCi0gICAgICAgIHJvdW5kZigodmlld3Bv cnRTaXplQmVmb3JlLmhlaWdodCgpIC0gdmlld3BvcnRTaXplQWZ0ZXIuaGVpZ2h0KCkpIC8gMi4w KSk7CisgICAgSW50U2l6ZSBvZmZzZXQ7CisgICAgaWYgKGhhc1BlbmRpbmdPcmllbnRhdGlvbikg eworICAgICAgICBvZmZzZXQgPSBJbnRTaXplKHJvdW5kZigodmlld3BvcnRTaXplQmVmb3JlLndp ZHRoKCkgLSB2aWV3cG9ydFNpemVBZnRlci53aWR0aCgpKSAvIDIuMCksCisgICAgICAgICAgICAg ICAgICAgICAgICAgcm91bmRmKCh2aWV3cG9ydFNpemVCZWZvcmUuaGVpZ2h0KCkgLSB2aWV3cG9y dFNpemVBZnRlci5oZWlnaHQoKSkgLyAyLjApKTsKKyAgICB9CiAKICAgICAvLyBBcyBhIHNwZWNp YWwgY2FzZSwgaWYgd2Ugd2VyZSBhbmNob3JlZCB0byB0aGUgdG9wIGxlZnQgcG9zaXRpb24gYXQK ICAgICAvLyB0aGUgYmVnaW5uaW5nIG9mIHRoZSByb3RhdGlvbiB0aGVuIHByZXNlcnZlIHRoYXQg YW5jaG9yLgo= 176790 2012-11-29 12:35:32 -0800 2012-11-29 12:46:15 -0800 Patch bug-103659-20121129153326.patch text/plain 2120 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4Y2M5OGRjMzcyYzcyMmU3NTE5NGJhMTUwNjg3MWNlODRjOTUyMTk1Li44NzFiNmU0Mzg4 ODNhN2I0OGU5NGI4ZGVjNmY2ZjJhZWMyOWU1ZGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yOSAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBub3QgYWRqdXN0IHNjcm9sbCBwb3NpdGlv biBvbiB2aWV3cG9ydCByZXNpemVzIHRoYXQgYXJlIG5vdCBvcmllbnRhdGlvbiBjaGFuZ2UgcmVs YXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz NjU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIEludGVy bmFsbHkgcmV2aWV3ZWQgYnkgR2VuIE1hay4KKworICAgICAgICBJbnRlcm5hbCBQUjI1Mzg5My4K KyAgICAgICAgT25seSBhZGp1c3Qgc2Nyb2xsIHBvc2l0aW9uIGR1cmluZyBhbiBvcmllbnRhdGlv biBjaGFuZ2UKKyAgICAgICAgd2hlbiBzZXR0aW5nIHZpZXdwb3J0IHNpemUuCisgICAgICAgIFdl IGRvbid0IHdhbnQgdGhlIHNjcm9sbCBwb3NpdGlvbiBqdW1waW5nIGFyb3VuZCB3aGVuIG9wZW5p bmcKKyAgICAgICAgJiBjbG9zaW5nIHRoZSBWS0IuCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpzZXRWaWV3 cG9ydFNpemUpOgorCiAyMDEyLTExLTI3ICBBbmRyZXcgTG8gIDxhbmxvQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSB1bm5lY2Vzc2FyeSBiYWNraW5nIHN0b3JlIHN1c3Bl bnNpb24gaW4gSW5wdXRIYW5kbGVyOjplbnN1cmVGb2N1c1RleHRFbGVtZW50VmlzaWJsZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggNGI0OGRiN2JlZjU2YTk3 NmJkM2JjYTRjZmIxMjA0OTg2MzFiZWZlMy4uNjM1YzczZWE2NzIzNDkyMmJlOGJjZjY2ZTJhMzU2 Nzk0Y2U5YWExZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBA IC0zNjY2LDkgKzM2NjYsMTEgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6c2V0Vmlld3BvcnRTaXpl KGNvbnN0IEludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNpemUKIAogICAgIEludFNp emUgdmlld3BvcnRTaXplQWZ0ZXIgPSBhY3R1YWxWaXNpYmxlU2l6ZSgpOwogCi0gICAgSW50U2l6 ZSBvZmZzZXQoCi0gICAgICAgIHJvdW5kZigodmlld3BvcnRTaXplQmVmb3JlLndpZHRoKCkgLSB2 aWV3cG9ydFNpemVBZnRlci53aWR0aCgpKSAvIDIuMCksCi0gICAgICAgIHJvdW5kZigodmlld3Bv cnRTaXplQmVmb3JlLmhlaWdodCgpIC0gdmlld3BvcnRTaXplQWZ0ZXIuaGVpZ2h0KCkpIC8gMi4w KSk7CisgICAgSW50U2l6ZSBvZmZzZXQ7CisgICAgaWYgKGhhc1BlbmRpbmdPcmllbnRhdGlvbikg eworICAgICAgICBvZmZzZXQgPSBJbnRTaXplKHJvdW5kZigodmlld3BvcnRTaXplQmVmb3JlLndp ZHRoKCkgLSB2aWV3cG9ydFNpemVBZnRlci53aWR0aCgpKSAvIDIuMCksCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgcm91bmRmKCh2aWV3cG9ydFNpemVCZWZvcmUuaGVpZ2h0KCkgLSB2aWV3 cG9ydFNpemVBZnRlci5oZWlnaHQoKSkgLyAyLjApKTsKKyAgICB9CiAKICAgICAvLyBBcyBhIHNw ZWNpYWwgY2FzZSwgaWYgd2Ugd2VyZSBhbmNob3JlZCB0byB0aGUgdG9wIGxlZnQgcG9zaXRpb24g YXQKICAgICAvLyB0aGUgYmVnaW5uaW5nIG9mIHRoZSByb3RhdGlvbiB0aGVuIHByZXNlcnZlIHRo YXQgYW5jaG9yLgo= 176794 2012-11-29 12:46:18 -0800 2012-11-29 13:26:15 -0800 Patch bug-103659-20121129154411.patch text/plain 2104 anlo U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1ODk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA4Y2M5OGRjMzcyYzcyMmU3NTE5NGJhMTUwNjg3MWNlODRjOTUyMTk1Li44NzFiNmU0Mzg4 ODNhN2I0OGU5NGI4ZGVjNmY2ZjJhZWMyOWU1ZGQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxMi0xMS0yOSAgQW5kcmV3IExvICA8YW5sb0ByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBEbyBub3QgYWRqdXN0IHNjcm9sbCBwb3NpdGlv biBvbiB2aWV3cG9ydCByZXNpemVzIHRoYXQgYXJlIG5vdCBvcmllbnRhdGlvbiBjaGFuZ2UgcmVs YXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTAz NjU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIEludGVy bmFsbHkgcmV2aWV3ZWQgYnkgR2VuIE1hay4KKworICAgICAgICBJbnRlcm5hbCBQUjI1Mzg5My4K KyAgICAgICAgT25seSBhZGp1c3Qgc2Nyb2xsIHBvc2l0aW9uIGR1cmluZyBhbiBvcmllbnRhdGlv biBjaGFuZ2UKKyAgICAgICAgd2hlbiBzZXR0aW5nIHZpZXdwb3J0IHNpemUuCisgICAgICAgIFdl IGRvbid0IHdhbnQgdGhlIHNjcm9sbCBwb3NpdGlvbiBqdW1waW5nIGFyb3VuZCB3aGVuIG9wZW5p bmcKKyAgICAgICAgJiBjbG9zaW5nIHRoZSBWS0IuCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5j cHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpzZXRWaWV3 cG9ydFNpemUpOgorCiAyMDEyLTExLTI3ICBBbmRyZXcgTG8gIDxhbmxvQHJpbS5jb20+CiAKICAg ICAgICAgW0JsYWNrQmVycnldIFJlbW92ZSB1bm5lY2Vzc2FyeSBiYWNraW5nIHN0b3JlIHN1c3Bl bnNpb24gaW4gSW5wdXRIYW5kbGVyOjplbnN1cmVGb2N1c1RleHRFbGVtZW50VmlzaWJsZQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcCBiL1NvdXJj ZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5kZXggNGI0OGRiN2JlZjU2YTk3 NmJkM2JjYTRjZmIxMjA0OTg2MzFiZWZlMy4uMmYwYjQ4YmVhZmY4Mzk2M2UwNTAyZjdiNTdlODJm NmUxYjA2NmFiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9XZWJQ YWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQXBpL1dlYlBhZ2UuY3BwCkBA IC0zNjY2LDkgKzM2NjYsMTEgQEAgdm9pZCBXZWJQYWdlUHJpdmF0ZTo6c2V0Vmlld3BvcnRTaXpl KGNvbnN0IEludFNpemUmIHRyYW5zZm9ybWVkQWN0dWFsVmlzaWJsZVNpemUKIAogICAgIEludFNp emUgdmlld3BvcnRTaXplQWZ0ZXIgPSBhY3R1YWxWaXNpYmxlU2l6ZSgpOwogCi0gICAgSW50U2l6 ZSBvZmZzZXQoCi0gICAgICAgIHJvdW5kZigodmlld3BvcnRTaXplQmVmb3JlLndpZHRoKCkgLSB2 aWV3cG9ydFNpemVBZnRlci53aWR0aCgpKSAvIDIuMCksCi0gICAgICAgIHJvdW5kZigodmlld3Bv cnRTaXplQmVmb3JlLmhlaWdodCgpIC0gdmlld3BvcnRTaXplQWZ0ZXIuaGVpZ2h0KCkpIC8gMi4w KSk7CisgICAgSW50U2l6ZSBvZmZzZXQ7CisgICAgaWYgKGhhc1BlbmRpbmdPcmllbnRhdGlvbikg eworICAgICAgICBvZmZzZXQgPSBJbnRTaXplKHJvdW5kZigodmlld3BvcnRTaXplQmVmb3JlLndp ZHRoKCkgLSB2aWV3cG9ydFNpemVBZnRlci53aWR0aCgpKSAvIDIuMCksCisgICAgICAgICAgICBy b3VuZGYoKHZpZXdwb3J0U2l6ZUJlZm9yZS5oZWlnaHQoKSAtIHZpZXdwb3J0U2l6ZUFmdGVyLmhl aWdodCgpKSAvIDIuMCkpOworICAgIH0KIAogICAgIC8vIEFzIGEgc3BlY2lhbCBjYXNlLCBpZiB3 ZSB3ZXJlIGFuY2hvcmVkIHRvIHRoZSB0b3AgbGVmdCBwb3NpdGlvbiBhdAogICAgIC8vIHRoZSBi ZWdpbm5pbmcgb2YgdGhlIHJvdGF0aW9uIHRoZW4gcHJlc2VydmUgdGhhdCBhbmNob3IuCg==