103649 2012-11-29 10:16:52 -0800 [BlackBerry] Cookies in private mode should not have access to public cookies 2012-11-29 12:16:21 -0800 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 0 otcheung webkit-unassigned mifenton rwlbuis tonikitoo webkit.review.bot oldest_to_newest 779133 0 otcheung 2012-11-29 10:16:52 -0800 We are changing the cookie private mode behaviour so it will not have access to public cookies 779140 1 176755 otcheung 2012-11-29 10:20:19 -0800 Created attachment 176755 Patch 779166 2 176755 rwlbuis 2012-11-29 10:32:32 -0800 Comment on attachment 176755 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176755&action=review Otto agreed to clean it up some more. > Source/WebCore/platform/blackberry/CookieManager.cpp:512 > if (!mode) { It would be more readable to have it called privateMode instead of mode, but your patch is not related to that. > Source/WebCore/platform/blackberry/CookieManager.cpp:516 > + removeAllCookies(DoNotRemoveFromBackingStore); We always do this... 779169 3 176758 otcheung 2012-11-29 10:37:15 -0800 Created attachment 176758 Patch 779176 4 176760 otcheung 2012-11-29 10:46:43 -0800 Created attachment 176760 Patch 779177 5 176760 rwlbuis 2012-11-29 10:47:28 -0800 Comment on attachment 176760 Patch LGTM. 779299 6 176760 webkit.review.bot 2012-11-29 12:16:18 -0800 Comment on attachment 176760 Patch Clearing flags on attachment: 176760 Committed r136148: <http://trac.webkit.org/changeset/136148> 779300 7 webkit.review.bot 2012-11-29 12:16:21 -0800 All reviewed patches have been landed. Closing bug. 176755 2012-11-29 10:20:19 -0800 2012-11-29 10:37:11 -0800 Patch bug-103649-20121129131752.patch text/plain 1752 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA5NjUzNDk4ZGJkZDcw YTgxODFjYWNhNThhZDZmOWFjNTE4MDA3OS4uZTZjMDMwMGM2OGYyMmM3M2NmNzM3ZjJiMzlmNDNh ZTVlOTlhNGRjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTI5ICBPdHRv IERlcmVrIENoZXVuZyAgPG90Y2hldW5nQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IENvb2tpZXMgaW4gcHJpdmF0ZSBtb2RlIHNob3VsZCBub3QgaGF2ZSBhY2Nlc3MgdG8gcHVibGlj IGNvb2tpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMzY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFBSIDI1Mzk4MworCisgICAgICAgIFdoZW4gQ29va2llTWFuYWdlciBzd2l0Y2hlcyBiYWNrIGZy b20gcHVibGljIHRvIHByaXZhdGUgbW9kZSwKKyAgICAgICAgd2Ugd2lsbCBjbGVhciB0aGUgY29v a2llIHRyZWUgc28gdGhlIGJyb3dzZXIgd29uJ3QgaGF2ZSBhY2Nlc3MKKyAgICAgICAgdG8gdGhl IHB1YmxpYyBjb29raWVzLgorCisgICAgICAgIFRlc3RlZCB1c2luZyBicm93c2VyLnN3bGFiLnJp bS5uZXQgY29va2llIHRlc3RzIGFuZCB0aGUgc3RlcHMgaW4KKyAgICAgICAgdGhlIFBSLgorCisg ICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9Db29raWVNYW5hZ2VyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNvb2tpZU1hbmFnZXI6OnNldFByaXZhdGVNb2RlKToKKwogMjAxMi0xMS0yNyAg QWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gSW1w bGVtZW50IGZ1bGwtZmVhdHVyZWQgaW1hZ2UgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvQ29va2llTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZU1hbmFnZXIuY3BwCmluZGV4IDEzNzc2NThhZDkz ZWY4YWJiMTIzZjljZGQ4YTFmY2Y2ZjRkODRkNzAuLmJiMjQyYWU0YTNhYTQ0MWU3ZGViNDA2ZGFl OGY3NzUyZTkyYjYxYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNr YmVycnkvQ29va2llTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxh Y2tiZXJyeS9Db29raWVNYW5hZ2VyLmNwcApAQCAtNTA4LDEwICs1MDgsMTIgQEAgdm9pZCBDb29r aWVNYW5hZ2VyOjpzZXRQcml2YXRlTW9kZShib29sIG1vZGUpCiAgICAgICAgIHJldHVybjsKIAog ICAgIG1fcHJpdmF0ZU1vZGUgPSBtb2RlOworCiAgICAgaWYgKCFtb2RlKSB7CiAgICAgICAgIHJl bW92ZUFsbENvb2tpZXMoRG9Ob3RSZW1vdmVGcm9tQmFja2luZ1N0b3JlKTsKICAgICAgICAgZ2V0 QmFja2luZ1N0b3JlQ29va2llcygpOwotICAgIH0KKyAgICB9IGVsc2UKKyAgICAgICAgcmVtb3Zl QWxsQ29va2llcyhEb05vdFJlbW92ZUZyb21CYWNraW5nU3RvcmUpOwogfQogCiBDb29raWVNYXAq IENvb2tpZU1hbmFnZXI6OmZpbmRPckNyZWF0ZUNvb2tpZU1hcChDb29raWVNYXAqIHByb3RvY29s TWFwLCBjb25zdCBQYXJzZWRDb29raWUmIGNhbmRpZGF0ZUNvb2tpZSkK 176758 2012-11-29 10:37:15 -0800 2012-11-29 10:46:38 -0800 Patch bug-103649-20121129133448.patch text/plain 2077 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA5NjUzNDk4ZGJkZDcw YTgxODFjYWNhNThhZDZmOWFjNTE4MDA3OS4uZTZjMDMwMGM2OGYyMmM3M2NmNzM3ZjJiMzlmNDNh ZTVlOTlhNGRjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTI5ICBPdHRv IERlcmVrIENoZXVuZyAgPG90Y2hldW5nQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IENvb2tpZXMgaW4gcHJpdmF0ZSBtb2RlIHNob3VsZCBub3QgaGF2ZSBhY2Nlc3MgdG8gcHVibGlj IGNvb2tpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMzY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFBSIDI1Mzk4MworCisgICAgICAgIFdoZW4gQ29va2llTWFuYWdlciBzd2l0Y2hlcyBiYWNrIGZy b20gcHVibGljIHRvIHByaXZhdGUgbW9kZSwKKyAgICAgICAgd2Ugd2lsbCBjbGVhciB0aGUgY29v a2llIHRyZWUgc28gdGhlIGJyb3dzZXIgd29uJ3QgaGF2ZSBhY2Nlc3MKKyAgICAgICAgdG8gdGhl IHB1YmxpYyBjb29raWVzLgorCisgICAgICAgIFRlc3RlZCB1c2luZyBicm93c2VyLnN3bGFiLnJp bS5uZXQgY29va2llIHRlc3RzIGFuZCB0aGUgc3RlcHMgaW4KKyAgICAgICAgdGhlIFBSLgorCisg ICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9Db29raWVNYW5hZ2VyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNvb2tpZU1hbmFnZXI6OnNldFByaXZhdGVNb2RlKToKKwogMjAxMi0xMS0yNyAg QWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gSW1w bGVtZW50IGZ1bGwtZmVhdHVyZWQgaW1hZ2UgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvQ29va2llTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZU1hbmFnZXIuY3BwCmluZGV4IDEzNzc2NThhZDkz ZWY4YWJiMTIzZjljZGQ4YTFmY2Y2ZjRkODRkNzAuLmJiN2M1ZjgwY2RlZjgyNzg0YTc0MDk5Njk2 MDkzZDRjNzQ1NGE4NWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNr YmVycnkvQ29va2llTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxh Y2tiZXJyeS9Db29raWVNYW5hZ2VyLmNwcApAQCAtNTAyLDE2ICs1MDIsMTkgQEAgdm9pZCBDb29r aWVNYW5hZ2VyOjpnZXRCYWNraW5nU3RvcmVDb29raWVzKCkKICAgICB9CiB9CiAKLXZvaWQgQ29v a2llTWFuYWdlcjo6c2V0UHJpdmF0ZU1vZGUoYm9vbCBtb2RlKQordm9pZCBDb29raWVNYW5hZ2Vy OjpzZXRQcml2YXRlTW9kZShib29sIHByaXZhdGVTdGF0dXMpCiB7Ci0gICAgaWYgKG1fcHJpdmF0 ZU1vZGUgPT0gbW9kZSkKKyAgICBpZiAobV9wcml2YXRlTW9kZSA9PSBwcml2YXRlU3RhdHVzKQog ICAgICAgICByZXR1cm47CiAKLSAgICBtX3ByaXZhdGVNb2RlID0gbW9kZTsKLSAgICBpZiAoIW1v ZGUpIHsKLSAgICAgICAgcmVtb3ZlQWxsQ29va2llcyhEb05vdFJlbW92ZUZyb21CYWNraW5nU3Rv cmUpOworICAgIG1fcHJpdmF0ZU1vZGUgPSBwcml2YXRlU3RhdHVzOworCisgICAgcmVtb3ZlQWxs Q29va2llcyhEb05vdFJlbW92ZUZyb21CYWNraW5nU3RvcmUpOworCisgICAgLy8gSWYgd2UgYXJl IHN3aXRjaGluZyBiYWNrIHRvIHB1YmxpYyBtb2RlLCByZWxvYWQgdGhlCisgICAgLy8gZGF0YWJh c2UgdG8gbWVtb3J5LgorICAgIGlmICghbV9wcml2YXRlTW9kZSkKICAgICAgICAgZ2V0QmFja2lu Z1N0b3JlQ29va2llcygpOwotICAgIH0KIH0KIAogQ29va2llTWFwKiBDb29raWVNYW5hZ2VyOjpm aW5kT3JDcmVhdGVDb29raWVNYXAoQ29va2llTWFwKiBwcm90b2NvbE1hcCwgY29uc3QgUGFyc2Vk Q29va2llJiBjYW5kaWRhdGVDb29raWUpCg== 176760 2012-11-29 10:46:43 -0800 2012-11-29 12:16:17 -0800 Patch bug-103649-20121129134416.patch text/plain 2063 otcheung U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjA5NjUzNDk4ZGJkZDcw YTgxODFjYWNhNThhZDZmOWFjNTE4MDA3OS4uZTZjMDMwMGM2OGYyMmM3M2NmNzM3ZjJiMzlmNDNh ZTVlOTlhNGRjMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDEyLTExLTI5ICBPdHRv IERlcmVrIENoZXVuZyAgPG90Y2hldW5nQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnld IENvb2tpZXMgaW4gcHJpdmF0ZSBtb2RlIHNob3VsZCBub3QgaGF2ZSBhY2Nlc3MgdG8gcHVibGlj IGNvb2tpZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEwMzY0OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFBSIDI1Mzk4MworCisgICAgICAgIFdoZW4gQ29va2llTWFuYWdlciBzd2l0Y2hlcyBiYWNrIGZy b20gcHVibGljIHRvIHByaXZhdGUgbW9kZSwKKyAgICAgICAgd2Ugd2lsbCBjbGVhciB0aGUgY29v a2llIHRyZWUgc28gdGhlIGJyb3dzZXIgd29uJ3QgaGF2ZSBhY2Nlc3MKKyAgICAgICAgdG8gdGhl IHB1YmxpYyBjb29raWVzLgorCisgICAgICAgIFRlc3RlZCB1c2luZyBicm93c2VyLnN3bGFiLnJp bS5uZXQgY29va2llIHRlc3RzIGFuZCB0aGUgc3RlcHMgaW4KKyAgICAgICAgdGhlIFBSLgorCisg ICAgICAgICogcGxhdGZvcm0vYmxhY2tiZXJyeS9Db29raWVNYW5hZ2VyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkNvb2tpZU1hbmFnZXI6OnNldFByaXZhdGVNb2RlKToKKwogMjAxMi0xMS0yNyAg QWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1bV0gSW1w bGVtZW50IGZ1bGwtZmVhdHVyZWQgaW1hZ2UgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2JsYWNrYmVycnkvQ29va2llTWFuYWdlci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ibGFja2JlcnJ5L0Nvb2tpZU1hbmFnZXIuY3BwCmluZGV4IDEzNzc2NThhZDkz ZWY4YWJiMTIzZjljZGQ4YTFmY2Y2ZjRkODRkNzAuLmI0ZGQwZWY2YzE4ZTMwZWFlNjM4MDQ3NDky OGFiZGNlNDM4YTQ4MjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2JsYWNr YmVycnkvQ29va2llTWFuYWdlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYmxh Y2tiZXJyeS9Db29raWVNYW5hZ2VyLmNwcApAQCAtNTAyLDE2ICs1MDIsMTggQEAgdm9pZCBDb29r aWVNYW5hZ2VyOjpnZXRCYWNraW5nU3RvcmVDb29raWVzKCkKICAgICB9CiB9CiAKLXZvaWQgQ29v a2llTWFuYWdlcjo6c2V0UHJpdmF0ZU1vZGUoYm9vbCBtb2RlKQordm9pZCBDb29raWVNYW5hZ2Vy OjpzZXRQcml2YXRlTW9kZShib29sIHByaXZhdGVNb2RlKQogewotICAgIGlmIChtX3ByaXZhdGVN b2RlID09IG1vZGUpCisgICAgaWYgKG1fcHJpdmF0ZU1vZGUgPT0gcHJpdmF0ZU1vZGUpCiAgICAg ICAgIHJldHVybjsKIAotICAgIG1fcHJpdmF0ZU1vZGUgPSBtb2RlOwotICAgIGlmICghbW9kZSkg ewotICAgICAgICByZW1vdmVBbGxDb29raWVzKERvTm90UmVtb3ZlRnJvbUJhY2tpbmdTdG9yZSk7 CisgICAgbV9wcml2YXRlTW9kZSA9IHByaXZhdGVNb2RlOworCisgICAgcmVtb3ZlQWxsQ29va2ll cyhEb05vdFJlbW92ZUZyb21CYWNraW5nU3RvcmUpOworCisgICAgLy8gSWYgd2UgYXJlIHN3aXRj aGluZyBiYWNrIHRvIHB1YmxpYyBtb2RlLCByZWxvYWQgdGhlIGRhdGFiYXNlIHRvIG1lbW9yeS4K KyAgICBpZiAoIW1fcHJpdmF0ZU1vZGUpCiAgICAgICAgIGdldEJhY2tpbmdTdG9yZUNvb2tpZXMo KTsKLSAgICB9CiB9CiAKIENvb2tpZU1hcCogQ29va2llTWFuYWdlcjo6ZmluZE9yQ3JlYXRlQ29v a2llTWFwKENvb2tpZU1hcCogcHJvdG9jb2xNYXAsIGNvbnN0IFBhcnNlZENvb2tpZSYgY2FuZGlk YXRlQ29va2llKQo=