103647 2012-11-29 09:34:04 -0800 [chromium] Mark last input event for current vsync interval 2012-12-03 04:40:43 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 103648 1 skyostil skyostil abarth brianderson dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 779101 0 skyostil 2012-11-29 09:34:04 -0800 [chromium] Mark last input event for current vsync interval 779105 1 176749 skyostil 2012-11-29 09:37:12 -0800 Created attachment 176749 Patch 779112 2 webkit.review.bot 2012-11-29 09:40:45 -0800 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 779704 3 176749 jamesr 2012-11-29 18:19:05 -0800 Comment on attachment 176749 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176749&action=review > Source/WebKit/chromium/public/WebInputEvent.h:169 > + bool endOfInput; // Last input event for the current vsync interval. I think this name needs to be a bit more descriptive. The comment is good > Source/WebKit/chromium/src/WebInputEvent.cpp:47 > + int inputData[6]; that's sad - can we fit this in somewhere else? modifiers seems to have plenty of bits available 780081 4 176961 skyostil 2012-11-30 06:56:20 -0800 Created attachment 176961 Patch How's this? 780265 5 176961 jamesr 2012-11-30 11:45:12 -0800 Comment on attachment 176961 Patch I think it's pretty good! Darin/Adam - does this make enough sense for folks who aren't living in compositor land all day, or do you think we should segregate this out some more? 780390 6 176961 abarth 2012-11-30 13:51:17 -0800 Comment on attachment 176961 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=176961&action=review > Source/WebKit/chromium/public/WebInputEvent.h:162 > + // Last input event to be sent for the current vsync interval. > + IsLastInputEventForCurrentVSync = 1 << 13, Seems fine to me. Will this bit be set accurately on every OS? If not, it might be worth explaining in the comment that this is OS(ANDROID) specific. 780488 7 jamesr 2012-11-30 15:42:56 -0800 I think it'll be false by default, which is a fine value to set since that means the sender of the input events can't promise that this is the last input of a vsync. It's only set when the embedder has knowledge. 780489 8 176961 jamesr 2012-11-30 15:43:17 -0800 Comment on attachment 176961 Patch R=me but documenting what it means for the flag to be false would help. 781308 9 177224 skyostil 2012-12-03 03:41:16 -0800 Created attachment 177224 Patch Patch for landing. 781337 10 177224 webkit.review.bot 2012-12-03 04:40:39 -0800 Comment on attachment 177224 Patch Clearing flags on attachment: 177224 Committed r136383: <http://trac.webkit.org/changeset/136383> 781338 11 webkit.review.bot 2012-12-03 04:40:43 -0800 All reviewed patches have been landed. Closing bug. 176749 2012-11-29 09:37:12 -0800 2012-11-30 06:56:15 -0800 Patch bug-103647-20121129173445.patch text/plain 2635 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY2ZGFhNjM5ZDljMzUxOWE5OThlMjNkZTQwNGMxOTE2OTU3MGY0OTUuLjc1Y2QzNDhjNzVlMTg4 OWFiZmZkNDdkNzE4NzQ4OTJkMjFmYWIxZGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjEgQEAKKzIwMTItMTEtMjkgIFNhbWkgS3lvc3RpbGEgIDxza3lvc3RpbEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBNYXJrIGxhc3QgaW5wdXQgZXZlbnQgZm9y IGN1cnJlbnQgdnN5bmMgaW50ZXJ2YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzY0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE9uIEFuZHJvaWQgYWxsIGlucHV0IGV2ZW50cyBhcmUgdHJpZ2dlcmVk IGF0IHRoZSBzdGFydCBvZiBhIHZzeW5jIHRvIG1heGltaXplCisgICAgICAgIHRoZSBhbW91bnQg b2YgdGltZSBhbiBhcHBsaWNhdGlvbiBoYXMgZm9yIHBhaW50aW5nLiBBZGQgYSBmaWVsZCB0bwor ICAgICAgICBXZWJJbnB1dEV2ZW50IHRvIGluZGljYXRlIHdoZW4gdGhlIGlucHV0IGV2ZW50IGlz IHRoZSBmaW5hbCBvbmUgZm9yIHRoZQorICAgICAgICBjdXJyZW50IHZzeW5jIGludGVydmFsLiBU aGlzIGluZm9ybWF0aW9uIHdpbGwgYmUgdXNlZCBmb3IgbW9yZSBlZmZpY2llbnQKKyAgICAgICAg cmVuZGVyIHNjaGVkdWxpbmcuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSW5wdXRFdmVudC5oOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEV2ZW50OjpXZWJJbnB1dEV2ZW50KToKKyAgICAgICAg KiBzcmMvV2ViSW5wdXRFdmVudC5jcHA6CisgICAgICAgIChTYW1lU2l6ZUFzV2ViSW5wdXRFdmVu dCk6CisKIDIwMTItMTEtMjcgIEFscGhhIExhbSAgPGhjbGFtQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBbY2hyb21pdW1dIEltcGxlbWVudCBmdWxsLWZlYXR1cmVkIGltYWdlIGNhY2hlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmggYi9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1dEV2ZW50LmgKaW5kZXggM2M5Zjc3 MDkwMzI4MzQ1ZTVjNzE2MTVmMWIxMjBhYWU0ZTQ2YmIxNi4uODJhMzEwMWQwNDE3ZjRjMGU2ZGIy YjliYjEzMmE1ZDE5M2RkOTk0OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9w dWJsaWMvV2ViSW5wdXRFdmVudC5oCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGlj L1dlYklucHV0RXZlbnQuaApAQCAtNjIsNyArNjIsOCBAQCBwdWJsaWM6CiAgICAgICAgIDogdGlt ZVN0YW1wU2Vjb25kcygwLjApCiAgICAgICAgICwgc2l6ZShzaXplUGFyYW0pCiAgICAgICAgICwg dHlwZShVbmRlZmluZWQpCi0gICAgICAgICwgbW9kaWZpZXJzKDApIHsgfQorICAgICAgICAsIG1v ZGlmaWVycygwKQorICAgICAgICAsIGVuZE9mSW5wdXQoZmFsc2UpIHsgfQogCiAgICAgLy8gV2hl biB3ZSB1c2UgYW4gaW5wdXQgbWV0aG9kIChvciBhbiBpbnB1dCBtZXRob2QgZWRpdG9yKSwgd2Ug cmVjZWl2ZQogICAgIC8vIHR3byBldmVudHMgZm9yIGEga2V5cHJlc3MuIFRoZSBmb3JtZXIgZXZl bnQgaXMgYSBrZXlkb3duLCB3aGljaApAQCAtMTY1LDYgKzE2Niw3IEBAIHB1YmxpYzoKICAgICB1 bnNpZ25lZCBzaXplOyAvLyBUaGUgc2l6ZSBvZiB0aGlzIHN0cnVjdHVyZSwgZm9yIHNlcmlhbGl6 YXRpb24uCiAgICAgVHlwZSB0eXBlOwogICAgIGludCBtb2RpZmllcnM7CisgICAgYm9vbCBlbmRP ZklucHV0OyAvLyBMYXN0IGlucHV0IGV2ZW50IGZvciB0aGUgY3VycmVudCB2c3luYyBpbnRlcnZh bC4KIAogICAgIC8vIFJldHVybnMgdHJ1ZSBpZiB0aGUgV2ViSW5wdXRFdmVudCB8dHlwZXwgaXMg YSBtb3VzZSBldmVudC4KICAgICBzdGF0aWMgYm9vbCBpc01vdXNlRXZlbnRUeXBlKGludCB0eXBl KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSW5wdXRFdmVudC5j cHAgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcAppbmRleCAx MGQxZjIxMDdhODA5ZjExM2ZhN2Q4MzZhMzYwODU1NjdhNjkxZDE2Li40MDAwNjZkN2Y3YzNhOTU4 MjNkMjE2ZTNiMjQ3MDNkN2QyMDBlYzJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJJbnB1dEV2ZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Ny Yy9XZWJJbnB1dEV2ZW50LmNwcApAQCAtNDQsNyArNDQsNyBAQCB1c2luZyBuYW1lc3BhY2UgV2Vi Q29yZTsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBzdHJ1Y3QgU2FtZVNpemVBc1dlYklucHV0RXZl bnQgewotICAgIGludCBpbnB1dERhdGFbNV07CisgICAgaW50IGlucHV0RGF0YVs2XTsKIH07CiAK IHN0cnVjdCBTYW1lU2l6ZUFzV2ViS2V5Ym9hcmRFdmVudCA6IHB1YmxpYyBTYW1lU2l6ZUFzV2Vi SW5wdXRFdmVudCB7Cg== 176961 2012-11-30 06:56:20 -0800 2012-12-03 03:41:12 -0800 Patch bug-103647-20121130145351.patch text/plain 1745 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY2ZGFhNjM5ZDljMzUxOWE5OThlMjNkZTQwNGMxOTE2OTU3MGY0OTUuLjNmNjlhODQ0ZGJhYTkw YTdkZDBlNDZmMGE3NTIyNWUzYmIxYzNjMGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTEtMjkgIFNhbWkgS3lvc3RpbGEgIDxza3lvc3RpbEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBNYXJrIGxhc3QgaW5wdXQgZXZlbnQgZm9y IGN1cnJlbnQgdnN5bmMgaW50ZXJ2YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzY0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE9uIEFuZHJvaWQgYWxsIGlucHV0IGV2ZW50cyBhcmUgdHJpZ2dlcmVk IGF0IHRoZSBzdGFydCBvZiBhIHZzeW5jIHRvIG1heGltaXplCisgICAgICAgIHRoZSBhbW91bnQg b2YgdGltZSBhbiBhcHBsaWNhdGlvbiBoYXMgZm9yIHBhaW50aW5nLiBBZGQgYSBmaWVsZCB0bwor ICAgICAgICBXZWJJbnB1dEV2ZW50IHRvIGluZGljYXRlIHdoZW4gdGhlIGlucHV0IGV2ZW50IGlz IHRoZSBmaW5hbCBvbmUgZm9yIHRoZQorICAgICAgICBjdXJyZW50IHZzeW5jIGludGVydmFsLiBU aGlzIGluZm9ybWF0aW9uIHdpbGwgYmUgdXNlZCBmb3IgbW9yZSBlZmZpY2llbnQKKyAgICAgICAg cmVuZGVyIHNjaGVkdWxpbmcuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSW5wdXRFdmVudC5oOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEV2ZW50OjpXZWJJbnB1dEV2ZW50KToKKwogMjAxMi0x MS0yNyAgQWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1 bV0gSW1wbGVtZW50IGZ1bGwtZmVhdHVyZWQgaW1hZ2UgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaAppbmRleCAzYzlmNzcwOTAzMjgzNDVlNWM3 MTYxNWYxYjEyMGFhZTRlNDZiYjE2Li5iZjdkNTYzMzNmYmNjZTM2OTMwMzg4MGIyY2ZkMmM4MmJk MTU3ODY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1 dEV2ZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVu dC5oCkBAIC0xNTcsNiArMTU3LDkgQEAgcHVibGljOgogICAgICAgICAvLyBMZWZ0L3JpZ2h0IG1v ZGlmaWVycyBmb3Iga2V5Ym9hcmQgZXZlbnRzLgogICAgICAgICBJc0xlZnQgICAgICAgICAgID0g MSA8PCAxMSwKICAgICAgICAgSXNSaWdodCAgICAgICAgICA9IDEgPDwgMTIsCisKKyAgICAgICAg Ly8gTGFzdCBpbnB1dCBldmVudCB0byBiZSBzZW50IGZvciB0aGUgY3VycmVudCB2c3luYyBpbnRl cnZhbC4KKyAgICAgICAgSXNMYXN0SW5wdXRFdmVudEZvckN1cnJlbnRWU3luYyA9IDEgPDwgMTMs CiAgICAgfTsKIAogICAgIHN0YXRpYyBjb25zdCBpbnQgSW5wdXRNb2RpZmllcnMgPSBTaGlmdEtl eSB8IENvbnRyb2xLZXkgfCBBbHRLZXkgfCBNZXRhS2V5Owo= 177224 2012-12-03 03:41:16 -0800 2012-12-03 04:40:39 -0800 Patch bug-103647-20121203113843.patch text/plain 2091 skyostil U3VidmVyc2lvbiBSZXZpc2lvbjogMTM1OTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY2ZGFhNjM5ZDljMzUxOWE5OThlMjNkZTQwNGMxOTE2OTU3MGY0OTUuLjBmODczMDE3NjJkN2Yx NGE5YjlkMDQ3MDVmMTc0YjBkNWQzYTg1NTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTItMTEtMjkgIFNhbWkgS3lvc3RpbGEgIDxza3lvc3RpbEBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBNYXJrIGxhc3QgaW5wdXQgZXZlbnQgZm9y IGN1cnJlbnQgdnN5bmMgaW50ZXJ2YWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEwMzY0NworCisgICAgICAgIFJldmlld2VkIGJ5IEphbWVzIFJvYmlu c29uLgorCisgICAgICAgIE9uIEFuZHJvaWQgYWxsIGlucHV0IGV2ZW50cyBhcmUgdHJpZ2dlcmVk IGF0IHRoZSBzdGFydCBvZiBhIHZzeW5jIHRvIG1heGltaXplCisgICAgICAgIHRoZSBhbW91bnQg b2YgdGltZSBhbiBhcHBsaWNhdGlvbiBoYXMgZm9yIHBhaW50aW5nLiBBZGQgYSBmaWVsZCB0bwor ICAgICAgICBXZWJJbnB1dEV2ZW50IHRvIGluZGljYXRlIHdoZW4gdGhlIGlucHV0IGV2ZW50IGlz IHRoZSBmaW5hbCBvbmUgZm9yIHRoZQorICAgICAgICBjdXJyZW50IHZzeW5jIGludGVydmFsLiBU aGlzIGluZm9ybWF0aW9uIHdpbGwgYmUgdXNlZCBmb3IgbW9yZSBlZmZpY2llbnQKKyAgICAgICAg cmVuZGVyIHNjaGVkdWxpbmcuCisKKyAgICAgICAgKiBwdWJsaWMvV2ViSW5wdXRFdmVudC5oOgor ICAgICAgICAoV2ViS2l0OjpXZWJJbnB1dEV2ZW50OjpXZWJJbnB1dEV2ZW50KToKKwogMjAxMi0x MS0yNyAgQWxwaGEgTGFtICA8aGNsYW1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJvbWl1 bV0gSW1wbGVtZW50IGZ1bGwtZmVhdHVyZWQgaW1hZ2UgY2FjaGUKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaCBiL1NvdXJjZS9XZWJLaXQv Y2hyb21pdW0vcHVibGljL1dlYklucHV0RXZlbnQuaAppbmRleCAzYzlmNzcwOTAzMjgzNDVlNWM3 MTYxNWYxYjEyMGFhZTRlNDZiYjE2Li41ZjYyMjc2MGQxNDU5ZmRmZGUzYzg2N2EzZjA2YWY3YWNj NGNhZDY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJJbnB1 dEV2ZW50LmgKKysrIGIvU291cmNlL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViSW5wdXRFdmVu dC5oCkBAIC0xNTcsNiArMTU3LDE0IEBAIHB1YmxpYzoKICAgICAgICAgLy8gTGVmdC9yaWdodCBt b2RpZmllcnMgZm9yIGtleWJvYXJkIGV2ZW50cy4KICAgICAgICAgSXNMZWZ0ICAgICAgICAgICA9 IDEgPDwgMTEsCiAgICAgICAgIElzUmlnaHQgICAgICAgICAgPSAxIDw8IDEyLAorCisgICAgICAg IC8vIExhc3QgaW5wdXQgZXZlbnQgdG8gYmUgc2VudCBmb3IgdGhlIGN1cnJlbnQgdnN5bmMgaW50 ZXJ2YWwuIElmIHRoaXMKKyAgICAgICAgLy8gZmxhZyBpcyBzZXQsIHRoZSBzZW5kZXIgZ3VhcmFu dGVlcyB0aGF0IG5vIG1vcmUgaW5wdXQgZXZlbnRzIHdpbGwgYmUKKyAgICAgICAgLy8gZGVsaXZl cmVkIHVudGlsIHRoZSBuZXh0IHZzeW5jIGFuZCB0aGUgcmVjZWl2ZXIgY2FuIHNjaGVkdWxlCisg ICAgICAgIC8vIHJlbmRlcmluZyBhY2NvcmRpbmdseS4gSWYgaXQgaXNuJ3Qgc2V0LCB0aGUgcmVj ZWl2ZXIgc2hvdWxkIG5vdCBtYWtlCisgICAgICAgIC8vIGFueSBhc3N1bXB0aW9ucyBhYm91dCB0 aGUgZGVsaXZlcnkgdGltZXMgb2YgZnV0dXJlIGlucHV0IGV2ZW50cworICAgICAgICAvLyB3LnIu dC4gdnN5bmMuCisgICAgICAgIElzTGFzdElucHV0RXZlbnRGb3JDdXJyZW50VlN5bmMgPSAxIDw8 IDEzLAogICAgIH07CiAKICAgICBzdGF0aWMgY29uc3QgaW50IElucHV0TW9kaWZpZXJzID0gU2hp ZnRLZXkgfCBDb250cm9sS2V5IHwgQWx0S2V5IHwgTWV0YUtleTsK