103645 2012-11-29 09:15:41 -0800 [CoordinatedGraphics] Have LayerTreeRenderer::ensureLayer() return the layer 2012-11-29 10:18:46 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez jturcotte kenneth noam webkit.review.bot zeno oldest_to_newest 779069 0 cdumez 2012-11-29 09:15:41 -0800 The current LayerTreeRenderer code keep calling ensureLayer() and then LayerMap::find() to retrieve the layer. Since ensureLayer() already has a pointer to the layer, we can simply have the function return it. This is slightly more efficient and it makes the code a bit simpler. 779075 1 176747 cdumez 2012-11-29 09:19:07 -0800 Created attachment 176747 Patch 779137 2 176747 webkit.review.bot 2012-11-29 10:18:41 -0800 Comment on attachment 176747 Patch Clearing flags on attachment: 176747 Committed r136139: <http://trac.webkit.org/changeset/136139> 779138 3 webkit.review.bot 2012-11-29 10:18:46 -0800 All reviewed patches have been landed. Closing bug. 176747 2012-11-29 09:19:07 -0800 2012-11-29 10:18:41 -0800 Patch 103645_LayerTreeRenderer_ensureLayer.patch text/plain 4334 cdumez ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkNDFkY2VlLi45NDZlNjU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIg QEAKKzIwMTItMTEtMjkgIENocmlzdG9waGUgRHVtZXogIDxjaHJpc3RvcGhlLmR1bWV6QGludGVs LmNvbT4KKworICAgICAgICBbQ29vcmRpbmF0ZWRHcmFwaGljc10gSGF2ZSBMYXllclRyZWVSZW5k ZXJlcjo6ZW5zdXJlTGF5ZXIoKSByZXR1cm4gdGhlIGxheWVyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMDM2NDUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgY3VycmVudCBMYXllclRyZWVSZW5kZXJl ciBjb2RlIGtlZXAgY2FsbGluZyBlbnN1cmVMYXllcigpIGFuZCB0aGVuCisgICAgICAgIExheWVy TWFwOjpmaW5kKCkgdG8gcmV0cmlldmUgdGhlIGxheWVyLiBTaW5jZSBlbnN1cmVMYXllcigpIGFs cmVhZHkgaGFzCisgICAgICAgIGEgcG9pbnRlciB0byB0aGUgbGF5ZXIsIHdlIGNhbiBzaW1wbHkg aGF2ZSB0aGUgZnVuY3Rpb24gcmV0dXJuIGl0LgorICAgICAgICBUaGlzIGlzIHNsaWdodGx5IG1v cmUgZWZmaWNpZW50IGFuZCBpdCBtYWtlcyB0aGUgY29kZSBhIGJpdCBzaW1wbGVyLgorCisgICAg ICAgICogVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3Bw OgorICAgICAgICAoV2ViS2l0OjpMYXllclRyZWVSZW5kZXJlcjo6c2V0TGF5ZXJDaGlsZHJlbik6 CisgICAgICAgIChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjpzZXRMYXllckZpbHRlcnMpOgor ICAgICAgICAoV2ViS2l0OjpMYXllclRyZWVSZW5kZXJlcjo6c2V0TGF5ZXJTdGF0ZSk6CisgICAg ICAgIChXZWJLaXQ6OkxheWVyVHJlZVJlbmRlcmVyOjplbnN1cmVMYXllcik6CisgICAgICAgICog VUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuaDoKKwogMjAx Mi0xMS0yOSAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQGRpZ2lhLmNvbT4K IAogICAgICAgICBQb3NzaWJsZSB0byByZXNpemUgb3V0IG9mIGJvdW5kcyAKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJl bmRlcmVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29yZGluYXRlZEdyYXBoaWNz L0xheWVyVHJlZVJlbmRlcmVyLmNwcAppbmRleCA3ZmFlOWEwLi4yMjc2NTczIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVS ZW5kZXJlci5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3Jh cGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuY3BwCkBAIC0yNjYsOSArMjY2LDcgQEAgdm9pZCBMYXll clRyZWVSZW5kZXJlcjo6ZGVzdHJveUNhbnZhcyhXZWJMYXllcklEIGlkKQogCiB2b2lkIExheWVy VHJlZVJlbmRlcmVyOjpzZXRMYXllckNoaWxkcmVuKFdlYkxheWVySUQgaWQsIGNvbnN0IFZlY3Rv cjxXZWJMYXllcklEPiYgY2hpbGRJRHMpCiB7Ci0gICAgZW5zdXJlTGF5ZXIoaWQpOwotICAgIExh eWVyTWFwOjppdGVyYXRvciBpdCA9IG1fbGF5ZXJzLmZpbmQoaWQpOwotICAgIEdyYXBoaWNzTGF5 ZXIqIGxheWVyID0gaXQtPnZhbHVlOworICAgIEdyYXBoaWNzTGF5ZXIqIGxheWVyID0gZW5zdXJl TGF5ZXIoaWQpOwogICAgIFZlY3RvcjxHcmFwaGljc0xheWVyKj4gY2hpbGRyZW47CiAKICAgICBm b3IgKHNpemVfdCBpID0gMDsgaSA8IGNoaWxkSURzLnNpemUoKTsgKytpKSB7CkBAIC0yODYsMTEg KzI4NCw4IEBAIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OnNldExheWVyQ2hpbGRyZW4oV2ViTGF5 ZXJJRCBpZCwgY29uc3QgVmVjdG9yPFdlYkxheWVySUQ+CiAjaWYgRU5BQkxFKENTU19GSUxURVJT KQogdm9pZCBMYXllclRyZWVSZW5kZXJlcjo6c2V0TGF5ZXJGaWx0ZXJzKFdlYkxheWVySUQgaWQs IGNvbnN0IEZpbHRlck9wZXJhdGlvbnMmIGZpbHRlcnMpCiB7Ci0gICAgZW5zdXJlTGF5ZXIoaWQp OwotICAgIExheWVyTWFwOjppdGVyYXRvciBpdCA9IG1fbGF5ZXJzLmZpbmQoaWQpOwotICAgIEFT U0VSVChpdCAhPSBtX2xheWVycy5lbmQoKSk7CisgICAgR3JhcGhpY3NMYXllciogbGF5ZXIgPSBl bnN1cmVMYXllcihpZCk7CiAKLSAgICBHcmFwaGljc0xheWVyKiBsYXllciA9IGl0LT52YWx1ZTsK ICNpZiBFTkFCTEUoQ1NTX1NIQURFUlMpCiAgICAgaW5qZWN0Q2FjaGVkQ3VzdG9tRmlsdGVyUHJv Z3JhbXMoZmlsdGVycyk7CiAjZW5kaWYKQEAgLTMzMiwxMSArMzI3LDcgQEAgdm9pZCBMYXllclRy ZWVSZW5kZXJlcjo6cmVtb3ZlQ3VzdG9tRmlsdGVyUHJvZ3JhbShpbnQgaWQpCiAKIHZvaWQgTGF5 ZXJUcmVlUmVuZGVyZXI6OnNldExheWVyU3RhdGUoV2ViTGF5ZXJJRCBpZCwgY29uc3QgV2ViTGF5 ZXJJbmZvJiBsYXllckluZm8pCiB7Ci0gICAgZW5zdXJlTGF5ZXIoaWQpOwotICAgIExheWVyTWFw OjppdGVyYXRvciBpdCA9IG1fbGF5ZXJzLmZpbmQoaWQpOwotICAgIEFTU0VSVChpdCAhPSBtX2xh eWVycy5lbmQoKSk7Ci0KLSAgICBHcmFwaGljc0xheWVyKiBsYXllciA9IGl0LT52YWx1ZTsKKyAg ICBHcmFwaGljc0xheWVyKiBsYXllciA9IGVuc3VyZUxheWVyKGlkKTsKIAogICAgIGxheWVyLT5z ZXRSZXBsaWNhdGVkQnlMYXllcihsYXllckJ5SUQobGF5ZXJJbmZvLnJlcGxpY2EpKTsKICAgICBs YXllci0+c2V0TWFza0xheWVyKGxheWVyQnlJRChsYXllckluZm8ubWFzaykpOwpAQCAtMzg1LDEy ICszNzYsMTggQEAgdm9pZCBMYXllclRyZWVSZW5kZXJlcjo6ZGVsZXRlTGF5ZXIoV2ViTGF5ZXJJ RCBsYXllcklEKQogfQogCiAKLXZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OmVuc3VyZUxheWVyKFdl YkxheWVySUQgaWQpCitXZWJDb3JlOjpHcmFwaGljc0xheWVyKiBMYXllclRyZWVSZW5kZXJlcjo6 ZW5zdXJlTGF5ZXIoV2ViTGF5ZXJJRCBpZCkKIHsKKyAgICBMYXllck1hcDo6aXRlcmF0b3IgaXQg PSBtX2xheWVycy5maW5kKGlkKTsKKyAgICBpZiAoaXQgIT0gbV9sYXllcnMuZW5kKCkpCisgICAg ICAgIHJldHVybiBpdC0+dmFsdWU7CisKICAgICAvLyBXZSBoYXZlIHRvIGxlYWsgdGhlIG5ldyBs YXllcidzIHBvaW50ZXIgYW5kIG1hbmFnZSBpdCBvdXJzZWx2ZXMsCiAgICAgLy8gYmVjYXVzZSBP d25QdHIgaXMgbm90IGNvcHlhYmxlLgotICAgIGlmIChtX2xheWVycy5maW5kKGlkKSA9PSBtX2xh eWVycy5lbmQoKSkKLSAgICAgICAgbV9sYXllcnMuYWRkKGlkLCBjcmVhdGVMYXllcihpZCkubGVh a1B0cigpKTsKKyAgICBXZWJDb3JlOjpHcmFwaGljc0xheWVyKiBsYXllciA9IGNyZWF0ZUxheWVy KGlkKS5sZWFrUHRyKCk7CisgICAgbV9sYXllcnMuYWRkKGlkLCBsYXllcik7CisKKyAgICByZXR1 cm4gbGF5ZXI7CiB9CiAKIHZvaWQgTGF5ZXJUcmVlUmVuZGVyZXI6OnNldFJvb3RMYXllcklEKFdl YkxheWVySUQgbGF5ZXJJRCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9D b29yZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvQ29vcmRpbmF0ZWRHcmFwaGljcy9MYXllclRyZWVSZW5kZXJlci5oCmluZGV4IDZm MTA1NmEuLjhlYzQ5NjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9Db29y ZGluYXRlZEdyYXBoaWNzL0xheWVyVHJlZVJlbmRlcmVyLmgKKysrIGIvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL0Nvb3JkaW5hdGVkR3JhcGhpY3MvTGF5ZXJUcmVlUmVuZGVyZXIuaApAQCAtMTQy LDcgKzE0Miw3IEBAIHByaXZhdGU6CiAgICAgdm9pZCBhc3NpZ25JbWFnZUJhY2tpbmdUb0xheWVy KFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqLCBDb29yZGluYXRlZEltYWdlQmFja2luZ0lEKTsKICAg ICB2b2lkIHJlbW92ZVJlbGVhc2VkSW1hZ2VCYWNraW5nc0lmTmVlZGVkKCk7CiAgICAgdm9pZCBl bnN1cmVSb290TGF5ZXIoKTsKLSAgICB2b2lkIGVuc3VyZUxheWVyKFdlYkxheWVySUQpOworICAg IFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXIqIGVuc3VyZUxheWVyKFdlYkxheWVySUQpOwogICAgIHZv aWQgY29tbWl0UGVuZGluZ0JhY2tpbmdTdG9yZU9wZXJhdGlvbnMoKTsKIAogICAgIENvb3JkaW5h dGVkQmFja2luZ1N0b3JlKiBnZXRCYWNraW5nU3RvcmUoV2ViQ29yZTo6R3JhcGhpY3NMYXllciop Owo=